Hand-stroked dividers and edges use the rule painter

The split button's divider, the timeline track header's divider and the table
outline and grid header edges paint through Draw::rule and Draw::rule_with, the
one pixel-snapped line, instead of their own strokes.
This commit is contained in:
aiongg
2026-11-12 14:32:41 +00:00
parent a53d901967
commit 5d8b0a94de
7 changed files with 27 additions and 41 deletions
+2 -2
View File
@@ -2,7 +2,7 @@
use crate::contract::{Access, Common, Component, Cx, MeasureCx, PaintUi, Pointer as _, Role, Styled as _};
use crate::primitives::{StrokeWidth, TextLayout, TextRun, Wrap};
use crate::style::{ComponentStyle, FocusLook, Stateful, StyleCx, TextLook, TypeRole};
use crate::style::{ComponentStyle, FocusLook, RuleLook, RuleWidth, Stateful, StyleCx, TextLook, TypeRole};
use craft_behavior::{Flow, Metrics, PointerButton, PressPhase, Sense};
use craft_theme::variant::Tone;
use craft_theme::{Contrast, States};
@@ -120,7 +120,7 @@ impl Component for Link {
draw.galley(Pos2::new(line.left(), top), &layout);
// The stroke's top edge sits on the line box's bottom, so the whole stroke lies below every descender.
let y = top + line_bottom(&layout).unwrap_or(layout.size().y) + underline / 2.0;
draw.line_snapped(cx.style.underline, color.egui(), Pos2::new(line.left(), y), Pos2::new(line.right(), y));
draw.rule_with(&RuleLook { color: color.egui(), width: RuleWidth::Points(underline) }, Pos2::new(line.left(), y), Pos2::new(line.right(), y));
}
fn finish(self, cx: Cx<'_, Self>) -> Response {
@@ -6,9 +6,9 @@ use crate::contract::{
ShowContainer as _, Styled as _, WordSetCx as _,
};
use crate::menu::{self, Menu};
use crate::primitives::{IconSpec, PaintShape, StrokeWidth};
use crate::primitives::{IconSpec, PaintShape};
use crate::runtime::env::Label;
use crate::style::{ComponentStyle, Corners, FocusLook, IconLook, Stateful, StyleColor, StyleCx, SurfaceLook, TextLook};
use crate::style::{ComponentStyle, Corners, FocusLook, IconLook, RuleLook, RuleWidth, Stateful, StyleColor, StyleCx, SurfaceLook, TextLook};
use craft_behavior::{Flow, HitLevel, HitPriority, Metrics, NavMove, PartKey, Sense, Value};
use craft_theme::{
States, Variant,
@@ -43,6 +43,7 @@ pub struct SplitButtonStyle {
chevron: Stateful<StyleColor>,
/// The line between the parts, in the variant's edge colour.
divider: Stateful<StyleColor>,
divider_width: RuleWidth,
/// The divider's gap from the top and bottom edges.
divider_inset: f32,
radius: CornerRadius,
@@ -121,6 +122,7 @@ impl<T: Value + 'static> Component for SplitButton<'_, T> {
part_fill: Stateful::new(clear).off(States::new(clear, fill.hover, fill.pressed, clear)),
chevron,
divider,
divider_width: RuleWidth::Points(cx.tokens.stroke.thin),
divider_inset: cx.tokens.space.gap.inline,
radius: parts.radius,
}
@@ -201,13 +203,9 @@ impl<T: Value + 'static> Component for SplitButton<'_, T> {
let chevron = Rect::from_center_size(arrow.center(), Vec2::splat(side));
draw.icon(chevron, &crate::controls::disclosure::DisclosureGlyph::menu_button().color(cx.resolve(&cx.style.chevron)));
let x = if rtl { arrow.right() } else { arrow.left() };
let x = draw.pixel_centre(x);
let inset = cx.style.divider_inset;
draw.stroke(
&PaintShape::Path(vec![Pos2::new(x, cx.rect.top() + inset), Pos2::new(x, cx.rect.bottom() - inset)]),
StrokeWidth::Thin,
cx.resolve(&cx.style.divider),
);
let divider = RuleLook { color: cx.resolve(&cx.style.divider).egui(), width: cx.style.divider_width };
draw.rule_with(&divider, Pos2::new(x, cx.rect.top() + inset), Pos2::new(x, cx.rect.bottom() - inset));
}
fn finish(self, cx: Cx<'_, Self>) -> SplitOutput<T> {