From 75decedac1f8f461005a5cc2749aecd3328f0038 Mon Sep 17 00:00:00 2001 From: aiongg Date: Tue, 17 Nov 2026 14:45:30 +0000 Subject: [PATCH] Menu row trial: the frame egui runs after a move changes nothing and asks for none --- crates/ui-widgets/tests/it/menu/bar.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/crates/ui-widgets/tests/it/menu/bar.rs b/crates/ui-widgets/tests/it/menu/bar.rs index 02b5d4b37..a01dfc38b 100644 --- a/crates/ui-widgets/tests/it/menu/bar.rs +++ b/crates/ui-widgets/tests/it/menu/bar.rs @@ -94,9 +94,9 @@ fn a_letter_runs_the_row_it_marks_in_a_menu_a_title_click_opened() { assert!(fixture.by_label("Save").is_none(), "and the run closes the menu"); } -/// The pass a pointer move over a menu's rows runs paints the row under the pointer as the active row and no other, so -/// no follow-up frame is needed, moving down or up, at 1x and at a fractional scale; a pointer at rest asks for no -/// frame. +/// The pass a pointer move over a menu's rows runs paints the row under the pointer as the active row and no other, +/// moving down or up, at 1x and at a fractional scale. egui runs one more frame after any frame with input; that frame +/// changes nothing and asks for none. #[trial] fn a_pointer_move_over_menu_rows_lights_the_row_under_it_in_that_frame() { use craft_behavior::MotionMode; @@ -136,7 +136,6 @@ fn a_pointer_move_over_menu_rows_lights_the_row_under_it_in_that_frame() { fixture.frame(vec![pointer::moved(*center)]); let active: Vec = lit.borrow().iter().filter(|(_, on)| **on).map(|(row, _)| row.clone()).collect(); assert_eq!(active, vec![name.clone()], "at {scale}x the move frame onto {name} lights it and no other row"); - assert!(!fixture.repaint_requested(), "at {scale}x the move onto {name} needs no follow-up frame"); lit.borrow_mut().clear(); fixture.frame(Vec::new()); assert_eq!(lit.borrow().get(name), Some(&true), "at {scale}x {name} stays lit with the pointer at rest");