Merge pull request #2009 from storytold/feat/lottie-raw-gradient

feat(lottie): expose raw gradient values for animated fitting
This commit is contained in:
Dylan M. Taylor
2026-11-17 04:32:57 -05:00
committed by GitHub
3 changed files with 49 additions and 1 deletions
+3
View File
@@ -119,6 +119,9 @@ The XML reader in `crates/plist/src/xml.rs` and its base64 compatibility helper
`crates/palette` extracts the GPL text parser from AniCraft `crates/doc/src/swatch.rs` at `d875a7feb250e6ab06aa28a37fb78a0699e88330` (MIT OR Apache-2.0), introduced by Tanish Manku in `a64130a9da9bdde545463b852d95d6a6774b1dfd` (AniCraft #270). The import preserves Tanish as primary author. Neutral RGB/name adaptation separates application display-name sanitization and the `Untitled` policy; validation tests and integration are subsequent Dylan M. Taylor changes. `crates/palette` extracts the GPL text parser from AniCraft `crates/doc/src/swatch.rs` at `d875a7feb250e6ab06aa28a37fb78a0699e88330` (MIT OR Apache-2.0), introduced by Tanish Manku in `a64130a9da9bdde545463b852d95d6a6774b1dfd` (AniCraft #270). The import preserves Tanish as primary author. Neutral RGB/name adaptation separates application display-name sanitization and the `Untitled` policy; validation tests and integration are subsequent Dylan M. Taylor changes.
The raw gradient wire ordering in `craft-lottie::Gradient::flat_values` follows
AniCraft's Lottie exporter by Tanish Manku (`63b39355`, `b9258b7b`), MIT OR Apache-2.0.
Sanitization, animation fitting and numeric output policy remain caller-owned.
## Screen Video key frames ## Screen Video key frames
`crates/video/src/screen_video.rs` extracts AniCraft `crates/xfl/src/video.rs` codec-3 decoding and its synthetic partial-block fixture, introduced by Tanish Manku in `1f3e603b7ff53a3da364e41ec4da8d43dc83aab0` with pixel-loop cleanup `2b7571363b4b647266df758f95b6e397021cfd4d` (MIT OR Apache-2.0). Import commits preserve Tanish as primary author. Caller-owned bounds and neutral RGBA output separate codec work from the consuming app's FLV first-frame/report policy. Boundary tests and integration are subsequent Dylan M. Taylor changes. `crates/video/src/screen_video.rs` extracts AniCraft `crates/xfl/src/video.rs` codec-3 decoding and its synthetic partial-block fixture, introduced by Tanish Manku in `1f3e603b7ff53a3da364e41ec4da8d43dc83aab0` with pixel-loop cleanup `2b7571363b4b647266df758f95b6e397021cfd4d` (MIT OR Apache-2.0). Import commits preserve Tanish as primary author. Caller-owned bounds and neutral RGBA output separate codec work from the consuming app's FLV first-frame/report policy. Boundary tests and integration are subsequent Dylan M. Taylor changes.
+45
View File
@@ -4,6 +4,18 @@ use serde_json::json;
use crate::{Json, nums, round6}; use crate::{Json, nums, round6};
/// Raw gradient wire values from borrowed or mapped stops, without intermediate allocation.
///
/// Yields color groups (`position, r, g, b`) then every opacity pair (`position, alpha`).
/// Input order and all values, including non-finite values and opaque alpha, are preserved.
/// Sanitization, rounding, and input/output size budgets remain the caller's responsibility.
pub fn flat_gradient_values(
colors: impl IntoIterator<Item = (f64, [f64; 3])>,
opacities: impl IntoIterator<Item = (f64, f64)>,
) -> impl Iterator<Item = f64> {
colors.into_iter().flat_map(|(p, [r, g, b])| [p, r, g, b]).chain(opacities.into_iter().flat_map(|(p, a)| [p, a]))
}
/// A gradient: colour stops and opacity stops, each at a position in 0..=1. /// A gradient: colour stops and opacity stops, each at a position in 0..=1.
#[derive(Debug, Clone, Default, PartialEq)] #[derive(Debug, Clone, Default, PartialEq)]
pub struct Gradient { pub struct Gradient {
@@ -29,6 +41,17 @@ impl Gradient {
Some(Self { colors, opacities }) Some(Self { colors, opacities })
} }
/// Raw color groups (`position, r, g, b`), followed by all opacity pairs
/// (`position, alpha`), in input order. No rounding, clamping, or opacity elision.
///
/// This allocation-free view lets callers fit or interpolate equal-sized animated
/// values before applying their own numeric policy. In particular, opaque alpha
/// stops remain present so an opaque frame can interpolate to a translucent one.
/// Non-finite values are preserved; callers must sanitize them before JSON output.
pub fn flat_values(&self) -> impl Iterator<Item = f64> + '_ {
flat_gradient_values(self.colors.iter().copied(), self.opacities.iter().copied())
}
/// The flat list, rounded to six decimals. The alpha pairs are left out when every stop is /// The flat list, rounded to six decimals. The alpha pairs are left out when every stop is
/// opaque. /// opaque.
pub fn to_flat(&self) -> Json { pub fn to_flat(&self) -> Json {
@@ -44,3 +67,25 @@ impl Gradient {
json!(out) json!(out)
} }
} }
#[cfg(test)]
mod raw_tests {
use super::*;
#[test]
fn raw_values_keep_order_precision_and_opaque_alpha() {
let g = Gradient { colors: vec![(0.123456789, [0.2, 0.3, 0.4]), (1.0, [0.5, 0.6, 0.7])], opacities: vec![(0.0, 1.0), (1.0, 1.0)] };
assert_eq!(g.flat_values().collect::<Vec<_>>(), vec![0.123456789, 0.2, 0.3, 0.4, 1.0, 0.5, 0.6, 0.7, 0.0, 1.0, 1.0, 1.0]);
assert_eq!(g.to_flat(), json!([0.123457, 0.2, 0.3, 0.4, 1.0, 0.5, 0.6, 0.7]));
}
#[test]
fn raw_values_keep_nonfinite_signed_zero_and_unpaired_lists() {
let g = Gradient { colors: vec![], opacities: vec![(-0.0, f64::NAN), (f64::INFINITY, f64::NEG_INFINITY)] };
let bits: Vec<_> = g.flat_values().map(f64::to_bits).collect();
assert_eq!(bits, [-0.0, f64::NAN, f64::INFINITY, f64::NEG_INFINITY].map(f64::to_bits));
assert_eq!(Gradient::default().flat_values().count(), 0);
let g = Gradient { colors: vec![(1e303, [1.0, 0.0, 0.0])], opacities: vec![] };
assert_eq!(g.flat_values().collect::<Vec<_>>(), [1e303, 1.0, 0.0, 0.0]);
}
}
+1 -1
View File
@@ -30,7 +30,7 @@ mod prop;
mod value; mod value;
pub mod zip; pub mod zip;
pub use gradient::Gradient; pub use gradient::{Gradient, flat_gradient_values};
pub use model::{Animated, Animation, Layer, LayerContent, Limits, Shape, ShapeKind}; pub use model::{Animated, Animation, Layer, LayerContent, Limits, Shape, ShapeKind};
pub use path::Bezier; pub use path::Bezier;
pub use prop::{Ease, Key, KeyOut, Prop, PropValue, Tangents, is_animated, read_prop, tangent, write_keys, write_prop}; pub use prop::{Ease, Key, KeyOut, Prop, PropValue, Tangents, is_animated, read_prop, tangent, write_keys, write_prop};