From 988aea1845c03b669493ea161ff0c1ede540ed5e Mon Sep 17 00:00:00 2001 From: aiongg Date: Wed, 18 Nov 2026 00:28:14 +0000 Subject: [PATCH] timeline: the row-menu test presses the Menu key on a PC shell A Mac keyboard has no Menu key and the shell reads it only off the Mac, so the test failed on macOS runners. --- crates/timeline/tests/it/timecode.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/crates/timeline/tests/it/timecode.rs b/crates/timeline/tests/it/timecode.rs index 729ed64d2..6dbacd630 100644 --- a/crates/timeline/tests/it/timecode.rs +++ b/crates/timeline/tests/it/timecode.rs @@ -1,6 +1,7 @@ //! The timecode field: a drag scrubs a field that is not in edit, and the arrows on the selected text start from its //! end. The Timecode panel: each row's menu opens from that row and acts on it. +use craft_keymap::Platform; use craft_timeline::ui::{TimecodeField, TimecodePanel, TimecodePanelSettings, TimecodeRow, TimecodeRowKind, TimecodeSource, TimecodeText}; use craft_timeline::{FrameRate, Tick, TimeFormat}; use craft_ui::contract::{Bind, Role, Show as _}; @@ -78,6 +79,8 @@ fn open_menu_by_key(fixture: &mut Fixture, readout: &str, key: Key, modifiers: M fn a_rows_menu_opens_from_a_secondary_click_or_the_menu_keys_and_acts_on_that_row() { use TimecodeRowKind::{CurrentTime, Duration, MediaTime, Remaining}; let mut fixture = Fixture::story(&Story::new("timecode panel", panel)); + // The Menu key is a PC key: a Mac keyboard has none, and the shell does not read it there. + fixture.os(Platform::Linux); fixture.settle(); let second = "Duration \u{b7} Program: Duration"; let target = fixture.by_label(second).expect("the second readout");