From c365d75c48b0e47f4b43cdb6592d0cdc39d2d52e Mon Sep 17 00:00:00 2001 From: dotCooCoo Date: Sun, 8 Nov 2026 14:22:08 -0800 Subject: [PATCH] craft-update: the restart-helper test's comment matches spawn_detached spawn_detached now starts the process on its waiting thread, and the test starts the helper on the calling thread. The comment names only what the two share, standard streams set to null. --- crates/update/src/self_update.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/crates/update/src/self_update.rs b/crates/update/src/self_update.rs index 66bfbae4f..01ec41dae 100644 --- a/crates/update/src/self_update.rs +++ b/crates/update/src/self_update.rs @@ -2012,8 +2012,9 @@ mod tests { /// The restart helper starts only when the restart is started, at the app's exit: a close the /// user cancels leaves no helper counting down its one-minute wait. The test starts the helper - /// the way `spawn_detached` does and keeps it, and a thread that waits for the helper to exit - /// writes `exited`, so a helper that exits without writing `started` fails the test. + /// with its standard streams set to null, as `spawn_detached` does, and a thread that waits + /// for the helper to exit writes `exited`, so a helper that exits without writing `started` + /// fails the test. #[cfg(unix)] #[test] fn the_restart_helper_starts_only_when_the_restart_is_started() {