From ed0307bc1ed3e1daf223fa34fddd0e7a1442c7dd Mon Sep 17 00:00:00 2001 From: aiongg Date: Wed, 11 Nov 2026 21:23:30 +0000 Subject: [PATCH] Trial: a settled dock runs no closed menu and the same runs per group --- crates/ui-patterns/tests/it/docking/mod.rs | 2 + crates/ui-patterns/tests/it/docking/runs.rs | 54 +++++++++++++++++++++ 2 files changed, 56 insertions(+) create mode 100644 crates/ui-patterns/tests/it/docking/runs.rs diff --git a/crates/ui-patterns/tests/it/docking/mod.rs b/crates/ui-patterns/tests/it/docking/mod.rs index d5364aecf..b9422aa8d 100644 --- a/crates/ui-patterns/tests/it/docking/mod.rs +++ b/crates/ui-patterns/tests/it/docking/mod.rs @@ -6,6 +6,8 @@ use craft_ui::testing::style::{tokens, with_cx}; mod render; +mod runs; + mod split; mod drop; diff --git a/crates/ui-patterns/tests/it/docking/runs.rs b/crates/ui-patterns/tests/it/docking/runs.rs new file mode 100644 index 000000000..ec60e3237 --- /dev/null +++ b/crates/ui-patterns/tests/it/docking/runs.rs @@ -0,0 +1,54 @@ +//! The runs of a settled docked layout: each group adds the same runs, and a closed menu adds none. + +use craft_behavior::Axis; +use craft_behavior::dock::{Layout, Node, SplitSize, Workspace}; +use craft_ui::contract::{Bind, BodyCx}; +use craft_ui::docking::{DockConfig, DockPanels, PanelSpec}; +use craft_ui::menu::PanelRow; +use craft_ui::patterns::dock::DockArea; +use craft_ui::testing::{Fixture, last_pass_runs, trial}; +use egui::{Ui, Vec2}; + +struct Panels; + +impl DockPanels for Panels { + fn spec(&self, panel: &usize) -> PanelSpec { + PanelSpec::new(format!("Panel {panel}")) + } + + fn body(&mut self, _: &usize, _: &mut Ui, _: &mut BodyCx<'_>) {} + + /// A host row, so each group shows its panel menu button and its menu. + fn panel_rows(&mut self, _: &usize) -> Vec { + vec![PanelRow::Separator] + } +} + +/// The runs by type of a settled pass of a dock of `groups` groups side by side, two panels each. +fn settled_runs(groups: usize) -> Vec<(&'static str, u32)> { + let group = |at: usize| Node::tabs(vec![2 * at, 2 * at + 1], 0); + let root = (1..groups).fold(group(0), |left, at| Node::split(Axis::X, SplitSize::Ratio(0.5), left, group(at))); + let mut workspace = Workspace::new(Layout::new(Some(root), Vec::new())); + let mut fixture = Fixture::new(move |ui| { + DockArea::new("Dock", Bind::bound(&mut workspace), &mut Panels, DockConfig::default()).show(ui); + }); + fixture.room(Vec2::new(1200.0, 600.0)).settle().idle(1); + last_pass_runs(fixture.ctx()) +} + +fn total(runs: &[(&'static str, u32)]) -> u32 { + runs.iter().map(|(_, runs)| runs).sum() +} + +/// A settled dock runs no closed menu (the panel menus and the tabs' context menus), and each group it shows adds +/// the same runs. +#[trial] +fn a_settled_dock_runs_no_closed_menu_and_the_same_runs_per_group() { + let runs: Vec<_> = (1..=3).map(settled_runs).collect(); + for shown in &runs { + let menus: Vec<_> = shown.iter().filter(|(ty, _)| ty.split('<').next().is_some_and(|name| name.ends_with("::Menu"))).collect(); + assert!(menus.is_empty(), "a settled dock ran closed menus: {menus:?}"); + } + let (one, two, three) = (total(&runs[0]), total(&runs[1]), total(&runs[2])); + assert_eq!(three - two, two - one, "the runs per group grow: {one}, {two}, {three} runs for 1, 2 and 3 groups"); +}