From f2c8c2ae16adc4bd914cc2199291025b2ac80cf4 Mon Sep 17 00:00:00 2001 From: aiongg Date: Tue, 17 Nov 2026 13:37:15 +0000 Subject: [PATCH] An offer being inspected leaves no earlier release for request_install to reopen The newer offer closes the earlier release's prompt; request_install reopened it from known, so known is cleared until the offer's inspection answers. --- crates/update/src/updater.rs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/crates/update/src/updater.rs b/crates/update/src/updater.rs index bc87d5755..19cb40371 100644 --- a/crates/update/src/updater.rs +++ b/crates/update/src/updater.rs @@ -231,7 +231,8 @@ pub struct Updater { /// A prompt the updater dropped is still on the host; it is withdrawn when it shows. stale: bool, /// The newest release a check found or the app offered, with whether this copy can install it - /// itself; [`Updater::request_install`] works from it after the prompt closed. + /// itself; [`Updater::request_install`] works from it after the prompt closed. `None` while an + /// offered release is being inspected. known: Option<(Release, bool)>, /// A finished installation waiting for the app to exit: what still has to start then, and /// the release it installs. @@ -447,8 +448,10 @@ impl Updater { } self.status = Status::Idle; // The prompt for an earlier release closes while this one is inspected: nothing installs - // the earlier release from it, and a save it asked for installs nothing. + // the earlier release from it, and a save it asked for installs nothing. Nor does + // `request_install`, which would reopen it from `known`. self.drop_prompt(); + self.known = None; if self.offered.is_some() { self.next_offer = Some(release); return;