202 upstream commits since 6cb00467a. Resolutions:
- craft-window, craft-platform: ours. Upstream's frame policy v2, restore
store and GNOME light/wait_first are the versions carried on 28 Oct;
ours moved place() to craft-behavior and kept LayoutWatch and the
appearance/portal.rs split.
- craft-timeline: ours. craft-time (crates/time) lands as upstream wrote
it and is not yet used by craft-timeline.
- Old crates/ui modules stay removed. Upstream's frosted backdrops, shape
gallery, dialog tabs and the iconic flyout top-edge rendering are not
carried. The #1094 model half is in craft-behavior's dock:
Group::flyout_offset and Action::MoveFlyoutTop.
- craft-update: #586 Save and Update, the install probe on the check
thread and quiet per-user MSI self-updates, carried into updater.rs,
stack_dialogs.rs, install/windows.rs and self_update/helper.rs.
- craft-jpeg: progressive Huffman decoding, carried into huffman.rs,
parse.rs and scan.rs.
- craft-print: the driver settings dialog's new tests and the bounded
XML parse's tests, as trials.
- Test-only conflicts: upstream tests from before the base that our side
cut stay cut; tests new upstream are kept.
The HarfBuzz subsetter bindings live in storytold/harfbuzz, branch
rust-subset-15.0.0 (HarfBuzz 15.0.0 plus rust/harfbuzz-subset-sys, which
compiles the fork's own src/). The workspace pins that package by commit
and no longer carries a copy of the HarfBuzz sources, the crate, or the
update script. design-lint's unsafe allow list, the facade's crate list,
ATTRIBUTION and the framework doc follow.
EditorState.composing replaces EditorState.revision (and TextEditorHost::revision): an editor that reported
composing and now does not ended the composition itself (a press in its text, a selection, an app edit over the
marked text), and the engine interrupts the OS composition and drops its late events. TextEditor and the sheet
grid report their marked text; editors that show none report false throughout.
The reset fence ends only with the completion of the engine's latest request (ImeResetId); an earlier request's
completion is stale. A request the integration can no longer answer (a pass with no IME output, an unfocused
window) is retired and asked again when an owner returns.
Trials: preedit and a click during composition for a canvas TextEditor, with one press per pass holding the late
commit for the next pass (craft-text); reset requests and stale completions (craft-ui-contract).
Each opens on a DialogHost as a StackDialog that owns what its dialog edits
and binds the dialog's open state to its own field, so it opens again after
closing. HostedCanvasSize and HostedImageSize share SizingOutput::hosted.
HostedExportAs keeps its preview and save requests for the app as
HostedSaveForWeb does; HostedAbout keeps the activated link. HostedAlert
holds an Alert's content. HostedLayerStyle frames the Layer Style body in a
form dialog with side buttons and the Preview box, and queues the page's asks
as LayerStyleAsk. HostedAdjustDialog<V, E> frames any adjustment editor the
same way, resizable and remembered for Curves, with the editor's asks as E.
Stories open the hosted dialogs through a story host bound to the card's
open value (dialog::stories::hosted), so the card holds them behind its
button and story-render shows them open. Trials open each on a DialogHost
and check Escape, OK and the asks.
StandardPrompt and UnsavedChangesDialog build their buttons, their choice
check and their programmatic OK from one offered list; a choice without an
enabled button is refused. HostedParamDialog opens its values once (remembered
values, defaults) before its first show, OK or set, through the helper the
first pass uses; OK builds its result through one helper; set refuses rows
that are hidden or disabled and reads the value as its row's kind.
set_json_field takes the Context. Automation lists dialog ids as decimal
strings, takes a string or a number, and names only the host's dialogs.
StackDialog gains json_fields and set_json_field; DialogHost lists its open
dialogs with their fields, sets one by id, and confirms or cancels by id
whatever the type. HostedParamDialog (values by parameter row, with a
programmatic OK), StandardPrompt and UnsavedChangesDialog (their choice)
implement them. craft_automation::dialogs runs ui.dialog.set/confirm/cancel
on a host and lists its dialogs for ui.inspect.
* docs: add the Windows installation policy; models are persistent asse…
…ts, not caches
A companion policy to settings-storage.md: dual-scope per-user-default MSIs,
the ArtCraft suite folder, what an update must preserve (folder, context, no
duplicates), standalone installability, and the platform-native boundary on
macOS, Linux and FreeBSD. Splits models out of the disposable-caches row:
downloaded models are persistent user assets that cache cleanup and app
uninstallers must never delete.
* docs: describe suite Windows installation policy
* docs: record the wizard scope and folder rules and the real-install c…
…hecks
The scope page leaves ALLUSERS unset for Only for me, and the wizard sets the new-install folder itself after the choice, because Windows Installer resolves Program Files once for the context it started in. Notes the 32-bit Program Files (x86) folder and updates the adoption table to say real per-user and all-users msiexec runs were done. Clean-machine and second-account checks are still pending.
* docs: new installs default to per-machine; only the old default folde…
…r moves
* docs: say plainly that released packages still default to per-user
The policy says new installs are per-machine, but every released package is
dual-scope with a per-user authored default, and the inventory still listed
"Per-user default". The policy now separates the two: what the policy is, what
the packages do today, who picks per-machine (the launcher, or "Everyone" in the
wizard), and the follow-up that closes the gap.
Also: Update all's one-prompt route was reverted after the antivirus incident,
so the policy no longer says it asks once; the Linux model folder names its
ArtCraft/models subfolder; repair is listed where the 26/10 payload runs
covered it; the inventory no longer says nothing was released.
* docs: the launcher and a direct MSI run match only for the same scope…
… and folder
CodeRabbit pointed out that 'produce the same result' contradicted the
documented new-install difference: the launcher sets ALLUSERS=1, while a
direct run keeps the package's per-user default.
* docs: make the legacy-folder migration exception explicit
State that exact former-default paths can migrate even when manually
chosen, subject to maintainer acceptance of the proposed policy. Preserve
other chosen folders and document the effect on custom shortcuts.
---------
Co-authored-by: Jeremy <jeremy8776@googlemail.com>
The samples beside the thumbnail size choices of a panel's options dialog (Layers, Channels, Paths) are larger than the
panel's own thumbnails, so the three choices read apart. They take `size.thumb.sample.{sm,md,lg}`: 36, 48 and 96 in
Compact, 36, 68 and 96 in Comfortable (twice the row thumbnails, as the old dialog drew them; PhotoCraft draws 38, 68
and 96). A Picture shows one through `PictureSize::Sample`, and the Layers options dialog's samples use it.
The digits take the mono type role, as the timecode field does. The unit is a
smaller faint caption pinned at the end of the value area with the inline gap,
so the number centres in the room before it and stacked fields line their
units up. Units::suffix goes; callers pass the unit's symbol.
A reveal (requested, key move, page switch, type-ahead, rename) scrolled by the item layout's
extents, in which rows no pass built yet have the estimate. The rows the pass then built took
their measured heights and pushed an auto row taller than the estimate out of view. The List
now aims the reveal in the content step, before it builds the rows: it builds and measures the
auto rows that will share the view with the revealed row, up to it, that have no kept height,
and aims again until the row is placed by measured heights. The build takes those measures and
does not measure the rows again, and the frame runs once. The per-row measure is shared with the
widest-row measure.
LayersPanel no longer compares the active layer with the last pass's (Session.seen_active and
the auto-reveal go): the app calls reveal(layer) in the pass its active layer changes.
LayersPanel::document(key) keys the rows List per document, so each document keeps its scroll
position and lead.
Trials: ui-widgets List reveal past unbuilt taller rows (one pass, no row measured twice);
craft-layers panel_reveal (reveal with Open, row in view, per-document scroll, counts).
DataMode holds the one mapping of a data colour (DataMode::color) and maps
every colour of a shape with it (DataMode::shape). ContentPainterCx gets
data_shapes for shapes whose colours are data, and its data methods
(picture, checker, checker_with, ramp) paint through the mode, sharing
data_picture and data_checker with Draw::texture and Draw::checker. A
States component's ramps, pictures and checkers in a content painter dim
while it paints its Disabled state, as its Draw's data colours do.
The histogram's bins and outlines and the notes editor's document text
paint through data_shapes.