Commit Graph
63 Commits
Author SHA1 Message Date
aiongg 14d5ec609a cargo fmt 2026-11-15 10:23:21 +00:00
aiongg a303fcbd62 tools-w5: net change of 3 commits
- tools-w5: written from its sheet
- tools-w5: repair 1
- tools-w5: review fixes (review-1)
2026-11-15 04:46:08 +00:00
aiongg f0aaef0ca0 tools-w4: net change of 2 commits
- tools-w4: written from its sheet
- tools-w4: review fixes (review-1.md)
2026-11-15 04:46:08 +00:00
aiongg 280aa468e7 tools-w6: net change of 3 commits
- tools-w6: written by an agent
- tools-w6: review fixes (review-1)
- Integration: synthetic input trials keep canvas-widgets-w13's queued-pass trial beside tools-w6's
2026-11-15 04:46:08 +00:00
aiongg 941cccf829 panels-w13: net change of 1 commits
- panels-w13: the bare-caret warning answers every attempt to apply a character style, a click on the selected row and Enter included (tools run round)
2026-11-15 04:46:05 +00:00
aiongg 2be14c1ac5 panels-w13: compile fix (include row field is FnMut: the grid body runs per pass) 2026-11-14 17:56:01 +00:00
aiongg 552da163a2 panels-w13: review fixes (review-1) 2026-11-14 17:56:01 +00:00
aiongg 2fa69d40d8 panels-w13: repair 1 2026-11-14 17:56:01 +00:00
aiongg 6c3fe5e209 panels-w13: written from its sheet 2026-11-14 17:56:01 +00:00
aiongg 0e216b6257 Contract stubs: decision pass 2026-11-14 16:07:24 +00:00
aiongg e9e3a961f4 Merge next (CI lint fixes) into phase2/stubs
# Conflicts:
#	crates/color/src/ui/swatches/menu.rs
2026-11-14 03:13:33 +00:00
aiongg 3329f24220 Contract stubs: craft-text, story-render, craft-fonts-build (stage 8) 2026-11-14 02:55:10 +00:00
aiongg deeb91802f Lints: doc links, test lint allowances, struct update in tests, wildcard imports, dead code 2026-11-14 02:35:35 +00:00
aiongg 7808f7f6d2 Lints: fix clippy, rustdoc and test findings (shadowed f32 module, unused import, private doc link, struct-update defaults, test attributes lost in the 13 Nov sync) 2026-11-14 00:15:29 +00:00
aiongg a17171af48 Lints: drop the workspace missing_docs lint and warn on it in the framework crates that document every public item 2026-11-14 00:15:29 +00:00
aiongg 73030467ae IME engine fix round 1: only the IME owner's report counts; retired resets come from the integration
- note_editor ignores every editor but the IME owner, so a second editor shown after it leaves the owner's
  composing report standing; editor_history answers non-owners (false, false).
- egui repinned to the fork's craft/ime-reset-retired (9b1f60c60): Event::ImeResetRetired reports a reset request
  egui-winit or PlatformOutput::append dropped without a completion. The engine asks again on the retirement of
  its own request; the focus check and the no-output retire in end_pass are gone. The test fixture reports
  retirements where egui-winit does (focus loss, no IME output, another IME context, a newer request, egui's
  dropped requests).
- The sheet grid's point mode ends a composition in the draft, its marked text kept as typed.
- TextEditor applies a pass's input before its press (the press is the pass's last pointer event, H0), so a
  preedit and a press in one raw frame change the marked text once and the press interrupts.

Trials: a reset the integration retires is asked again (craft-ui-contract); the click trial gains a second
editor shown after the composing one and a preedit-then-press frame (craft-text).
2026-11-13 16:15:16 +00:00
aiongg f910b4fe3c IME engine: an editor's own end of composition interrupts the OS composition; resets end only with their own completion
EditorState.composing replaces EditorState.revision (and TextEditorHost::revision): an editor that reported
composing and now does not ended the composition itself (a press in its text, a selection, an app edit over the
marked text), and the engine interrupts the OS composition and drops its late events. TextEditor and the sheet
grid report their marked text; editors that show none report false throughout.

The reset fence ends only with the completion of the engine's latest request (ImeResetId); an earlier request's
completion is stale. A request the integration can no longer answer (a pass with no IME output, an unfocused
window) is retired and asked again when an owner returns.

Trials: preedit and a click during composition for a canvas TextEditor, with one press per pass holding the late
commit for the next pass (craft-text); reset requests and stale completions (craft-ui-contract).
2026-11-13 16:15:16 +00:00
aiongg 74a1426e57 F-5 review: the host reports the autoscroll step from the pass clock; the hover band is size.hit.edge inside the view's rect; a secondary background press leaves a text session open 2026-11-13 01:08:19 +00:00
aiongg 47a49e542d TextEditor: a press on the canvas background commits the session 2026-11-13 01:08:19 +00:00
aiongg f7f75c178f Sizing::FillWidth makes a leaf fill its row's leftover room
Component::fills defaults to the width when the caller set Sizing::FillWidth,
and the sizing stays on the component after step 1 so the layout hooks read
it. Button, TextField and Slider lose their fill_width props and Swatch and
GradientSwatch their fill flags; callers set Sizing::FillWidth. The blend
select in BlendRows takes the room before Opacity, as in PhotoCraft.

A contract trial checks that a FillWidth leaf takes the row's room and a
Content leaf does not.
2026-11-12 15:12:10 +00:00
aiongg a3434176e4 Dialog bodies: the content sits directly in the dialog body, which is already a stack, so fill-width children take the dialog's width; the Tabs dialog's Position column is as wide as its field and Alignment and Leader share the rest 2026-11-12 14:32:57 +00:00
aiongg b19f52dde8 Content painters paint data colours in the component's data mode
DataMode holds the one mapping of a data colour (DataMode::color) and maps
every colour of a shape with it (DataMode::shape). ContentPainterCx gets
data_shapes for shapes whose colours are data, and its data methods
(picture, checker, checker_with, ramp) paint through the mode, sharing
data_picture and data_checker with Draw::texture and Draw::checker. A
States component's ramps, pictures and checkers in a content painter dim
while it paints its Disabled state, as its Draw's data colours do.

The histogram's bins and outlines and the notes editor's document text
paint through data_shapes.
2026-11-12 14:32:51 +00:00
aiongg 935613c4f7 Columns place their text as their spec says: rows take each column's alignment and tabular figures from the collection, and an end-aligned column's header ends at its cell's end; ListRow::columns goes 2026-11-12 14:32:49 +00:00
aiongg 0a724a2342 FindReplaceDialog stories: built in the gallery (craft-text find feature), open bool, dialog kept while open 2026-11-12 14:32:49 +00:00
aiongg 24ea1e849e NotesEditor stories: the old five-paragraph speaker notes as Default 2026-11-12 14:32:49 +00:00
aiongg cba374046d TextRuler: the decimal stop's dot at the size WordCraft draws it
Its radius was the thick stroke, about twice WordCraft's 1.1 pt, so the dots crowded the ruler.
2026-11-12 14:32:48 +00:00
aiongg 13221fd697 Collections take their width from content where their column gives none, and honour their pad
A collection that fills the width (Fill or FillWidth) follows the rule a
container does: where the enclosing body does not give its width (sized
from content, or a content column), a measuring run takes the width from
its content (header least width, else its largest row, at least its
ideal_width) and the column holds it across the width it settles on. A
FillWidth TabStrip or list in a dialog's column no longer sets the
column to the screen's width. Env::gives_width names the rule for both.

Collections honour ContainerProps::pad as containers do: the items hook
reports it (ShapeHooks::pad), the pass carries it in Resolved::pad, and
step 5, the measure view's room and step 7's content rect read the
padding through steps::padding. The header, rows, scroll bar and empty
text sit inside it; the surface covers the whole rect. #[container]
forwards pad, so Panel's own copy goes.

The spelling, file list and glyph wells are a List or TileGrid with
surface(Sunken).pad(Control); RelinkDialog's table is FillWidth.
2026-11-12 14:32:48 +00:00
aiongg 8703a667ba FooterBar: lay panel actions out from the reading end
The first action given sits at the end edge, as the old PanelFooter and
Photoshop's panel footers place them; a start group keeps its order.
Callers give their actions from the end edge: Layers, Channels,
Actions, Pages, the styles panel, the preset footer and MediaBin.
The filter gallery keeps Move Up and Move Down at the start edge.
LinkList's actions read as in the old: the menu at the start edge,
Relink at the end edge.
2026-11-12 14:32:48 +00:00
aiongg 9b22aa4e0f Fill propagates down a column whose width is given
A content-sized inline container shown in a `Stack` body given its width
passes that width on to its own body: its children measure and show as in
a given column, so a child that fills (a fill-width row, a list, a divider,
a picture, a side-labelled control) takes the width, and the container
takes what its content took. A content-sized mount (dialog, popover, menu),
a row, a grid or a held container stops it, so their bodies stay content
columns and measure as before.

The env carries the fact as `given_column`, set by a `Stack` body that is
not a content column and listed in the measure key's env facts. No pass,
record or measuring run is added.

Panel roots that set `fill_width()` only to span their pane now take the
default: CharacterControls, ParagraphControls, TimecodePanel,
ReorderableSections and BlendIfBar each hold a fill child, and where they
sit in a content column (BlendIfBar in the Layer Style page) the column
around them hugs them either way.

The fill_column trial shows the given column, nesting, a row stopping it,
the hug kept in a popover, and the measuring-run count against a
fill-width column.
2026-11-12 14:32:47 +00:00
aiongg e5188dd2bf NotesEditor: one paragraph layout for measure, hit testing and paint; the first line's text starts after a marker wider than its hanging indent 2026-11-12 14:32:47 +00:00
aiongg 280f5cbdf7 Wells: the spelling suggestions, the file list and the recently used glyphs in a sunken well, and the notes editor in the text well 2026-11-12 14:32:47 +00:00
aiongg 79c7732c40 NumberField: the unit follows the shown number, spaced as the language's unit template 2026-11-12 14:32:47 +00:00
aiongg d1afe97dc8 Select closed face: Entry::closed_label is the face's text while the list, type-ahead and accessible value keep the label; Select::picture draws an entry's thumbnail in its row and on the face, alone with picture_only; ConnectorBar and the stroke editor use it, TabStopsDialog shows the leader fill alone in the box and the Leader cell 2026-11-12 14:32:46 +00:00
aiongg 72561b52e2 Panel: no header unless titled, as a docked panel is named by its tab 2026-11-12 14:32:46 +00:00
aiongg 66b9f69fdb Build fixes: toggle_row takes the toggles by slice; drop TextColumns' unused length_row, the editor's unused Focus import and a trial's unused Show import 2026-11-12 14:32:45 +00:00
aiongg a706a9ddb6 TabStopsDialog: each row edits its stop in place (position field, alignment and leader Selects through ListRow::cell_field), as the old; the detail row under the table goes, and Set moves into the new row's position field 2026-11-12 14:32:45 +00:00
aiongg b537a04cc0 Validity::Error: a checked value that stands, read invalid with its message in the bad tone; TextColumns marks an out-of-range Number or Spacing field so, in place of the notices after it; the New Document preset name refusal uses it 2026-11-12 14:32:45 +00:00
aiongg e0d4068761 TextStylesPanel footer: Clear Override and Redefine at the start edge, the other actions at the end edge, through FooterBar::at_start 2026-11-12 14:32:45 +00:00
aiongg b48592be02 TextRuler: while Alt is held in a column border drag, each column's width shows between its borders, as the old 2026-11-12 14:32:45 +00:00
aiongg cef7d51cb6 TextEditor: the caret blinks for the whole session; in vertical text the formatting keys follow the flow; a formatting key the host does not take moves the caret as its arrow does 2026-11-12 14:32:45 +00:00
aiongg 65568b98e0 ParagraphControls: alignment and direction are rows of icon toggle buttons, each a Tab stop, as the old; a justify button on point text is disabled with its reason in the tooltip 2026-11-12 14:32:45 +00:00
aiongg 21051f8d27 Kerning field: the doc says what it shows for Metrics and Optical; a trial holds a named number value to its row label and the typed name 2026-11-12 14:32:45 +00:00
aiongg 3203b19882 FindBar: the count and the search progress write their numbers in the user's digits and groups 2026-11-12 14:32:45 +00:00
aiongg 26cfefbc0c HyperlinkDialog: each Link to option shows its icon between the radio and the label (globe, mail, bookmark), as the old 2026-11-12 14:32:45 +00:00
aiongg 0c31ce2889 Captions as the old dialogs showed them: Text Columns rows show Width and Spacing before their fields and Preview above the page preview; the toolbar drawer keeps a placed tool's shortcut and reports In toolbar as its description 2026-11-12 14:32:45 +00:00
aiongg 8fc8f79834 A glyph label can sit inside its control: FieldLayout::Inside puts it in the number field's leading slot as a scrub handle, every measure of the control sees it, and LinkedFields rows, the character panel's fields and the transform angle use it 2026-11-12 14:32:44 +00:00
aiongg f85dd3717c Status reporters report StatusMessage
The Vanishing Point editor's refused Stamp press, the text styles panel's caret hint, the screen picker's
capture failure and the swatches panel and menu report a StatusMessage for the host's status bar in place
of a String, a Label or a Toast.
2026-11-12 14:32:44 +00:00
aiongg fd2e9d2abb Footer buttons and media controls are Tab stops of their own; the text ruler is one Tab stop
FooterBar no longer makes its members one roving group, so each dialog or panel footer button is a Tab stop in
display order, as the old PanelFooter. Bar::tab_stops drops a bar's roving group; MediaControls uses it. The
TextRuler's markers, stops and column borders are one roving group whose Page keys move between them, as the
canvas guides; the arrows reach the ruler as nudges, and its own Page pick goes.
2026-11-12 14:32:42 +00:00
aiongg ac563d9eb3 Collections take a row range: min_rows and max_rows bound their height, and a capped one scrolls its rows; MissingFonts, TabStops, TextStyles and FieldList set theirs 2026-11-12 14:32:42 +00:00
aiongg 6a3cc54ed4 Rows drag only in their mode: TextStylesPanel rows drag while highlighting, and the toolbar drawer's tools already on the toolbar do not drag 2026-11-12 14:32:41 +00:00