Commit Graph
56 Commits
Author SHA1 Message Date
aiongg b6088dbdcf Merge branch 'fw/speed1' into fw/mac1
# Conflicts:
#	crates/ui-patterns/src/patterns/dock/area.rs
#	crates/ui-shell/src/shell/app_shell.rs
2026-11-16 19:05:56 +00:00
aiongg 9d61d87e46 cargo fmt 2026-11-16 18:29:58 +00:00
aiongg b54fe562bc The canvas panel's rail is one rail column wide at the panel's end edge, so the document area runs up to it 2026-11-16 17:49:05 +00:00
aiongg 9b8dbfb332 Shell slots and dock panel bodies settle when they give a content version
Slot::content and AppShell::content give a slot the version of the app data it shows; DockPanels::content
gives one per panel body. With one, the slot or body runs in a settling Lazy. Trials: a versioned slot and a
versioned panel body run only when their version changes; a stroke whose tool asks for repaints runs no
versioned panel beside the canvas and one pass per move frame.
2026-11-16 17:42:23 +00:00
aiongg 1d8c7d13a2 Merge branch 'fw/mac1-bars' into fw/mac1
# Conflicts:
#	crates/ui-contract/src/contract/body/hooks.rs
#	crates/ui-shell/src/shell/app_shell.rs
#	crates/ui-shell/tests/it/shell/app_shell.rs
2026-11-16 16:25:37 +00:00
aiongg dc41b3dbe3 Shell slots choose their region before naming it; exhaustive pad edges 2026-11-16 16:13:37 +00:00
aiongg 718d054ecf A title bar end with no captions keeps its content the regular pad off the window's edge 2026-11-16 16:09:19 +00:00
aiongg 60bdf15129 ToolRail fits its slot: block padding, a rail-width column per column with the buttons centred, toggles on one line
ContainerProps gains pad_edges (PadEdges::Block pads top and bottom only) and LeastWidth::Rail
(size.rail.width per column). ToolRail pads only above and below, is at least its columns'
rail width wide, and centres its grid of buttons, so no button or corner mark reaches past the
slot. The column and side toggles share one header line as small control-glyph buttons that
touch, which fits two in one rail column. A container's child_size and child_glyphs reach its
header and footer as well as its body, so a rail's footer buttons show the rail's glyphs.
AppShell::tools takes the rail's column count, so a two-column rail gets a two-column slot.
2026-11-16 16:05:13 +00:00
aiongg 81078945af A row given its height centres its line; a fill-width row on that line fills it; top and bottom shell panes lay their bar on one line
A container given its height whose body is an unwrapped row sets the row's line at the middle of its band and
pads only along the line. A fill-width container with a row body on such a line is given the line's height, so a
bar in a top or bottom slot fills the slot. A container whose first line is its own row's line sits on an outer
row's line by it even with a child of two lines. The shell's top and bottom panes lay their content out as a row;
the egui centring wrapper and the slot's surface under the bar are gone.
2026-11-16 15:59:53 +00:00
aiongg 4816295631 Shell edge panes paint chrome and the rule toward the body; the window paints the background
Every shell slot but the title is a chrome pane: its surface covers the whole pane, so a rail
shorter than the window leaves no band of the clear colour, and a divider runs along its edge
toward the body (rails, options bar, status bar, the canvas panel rail). The edge rule is drawn
by the pane itself; PanelRail's own rule and the env's enclosing pane edge go. The window root
paints the background surface and the document tabs pane sits on it.
2026-11-16 15:55:32 +00:00
aiongg f647f41e82 Merge branch 'dl/api' into dl/all 2026-11-16 13:39:11 +00:00
aiongg fbe5a16ffe design-lint: api/non-exhaustive: #[non_exhaustive] on public types and variants, constructors where other crates build them 2026-11-16 13:31:29 +00:00
aiongg 404e03bc63 design-lint: contract/platform, contract/memory: the freedesktop icon lookup lives in craft-window (theme_svgs), so caption icons need no target cfg; desktop icons kept in a session slot; the memory rule's scope_builder test reads the builder argument, not the closure body 2026-11-16 13:22:31 +00:00
aiongg 014ead170f merge-fwd: item 4: FW9: ui-contract and ui-shell parse and draw icons through craft-svg (features tree-core, tree, draw, tree-render; Limits.allow_dtd); resvg 0.45 goes; trials 2026-11-16 12:40:51 +00:00
aiongg 7ca2ec0a0e Move items to the layer that owns them: pointer art and surround painting up to primitives, member_gesture_running next to the arena members, gesture_key down to runtime::edit; the font defaults test no longer needs a system emoji font 2026-11-16 04:56:54 +00:00
aiongg cc00dbd368 Clippy and test-target lints: redundant must_use, type aliases for complex types, boxed large variants, argument structs, struct-update initialisers, deprecated egui calls, unused imports and dead code; the swatch library's reorder test runs as a trial 2026-11-16 02:30:55 +00:00
aiongg f1f0333a5b Merge storytold next into the framework branch 2026-11-16 01:01:38 +00:00
aiongg 19cd2e1762 commands: a story's command set (#[command(story)]) loads only in an install that shows stories (the gallery, the story fixtures), so its keys never take an app's 2026-11-15 18:28:52 +00:00
aiongg 14d5ec609a cargo fmt 2026-11-15 10:23:21 +00:00
aiongg 5ae2808984 fwb1 review: Show in Folder follows CAN_REVEAL as a command state 2026-11-15 10:01:34 +00:00
aiongg 38a5547d45 hub-w1: net change of 1 commits
- hub-w1: review fixes (review-1)
2026-11-15 09:18:08 +00:00
aiongg 0b46a6d24d canvas-widgets-w29: net change of 2 commits
- canvas-widgets-w29: written by an agent
- canvas-widgets-w29: review fixes (review-1)
2026-11-15 09:18:07 +00:00
aiongg e1b4567e59 top-w5: net change of 4 commits
- top-w5: written by an agent
- top-w5: review fixes (review-1.md)
- top-w5: read_last_update doc follows the updater arm (review-1 item 2)
- top-w5: the opening card's progress bar is named by the card's title (top run round)
2026-11-15 04:46:09 +00:00
aiongg b7ee7384fc canvas-widgets-w9: net change of 3 commits
- canvas-widgets-w9: written by an agent
- canvas-widgets-w9: review fixes (review-1)
- canvas-widgets-w9: the typed-zoom press trial reads the row's commit (a plain typed number proposes as typed) and shows the canvas tall enough for its pasteboard press (fwcw round 3)
2026-11-15 04:46:06 +00:00
aiongg d2d7d870c9 canvas-widgets-w12: net change of 7 commits
- canvas-widgets-w12: written by an agent
- canvas-widgets-w12: review fixes (review-1)
- canvas-widgets-w12: the pass's elapsed time (top round, review-top-1)
- canvas-widgets-w12: the strip trial reads rows wholly in view, not the first row's clipped rect (top run round)
- canvas-widgets-w12: the walk out of the menus is focus's (out_of_menus), with the menu-level container and the running menu; a body group names its container (top run round)
- canvas-widgets-w12: the walk out of the menus stops at the first return stop that is no menu row, and a menu pick returns focus by the same walk (top run round)
- canvas-widgets-w12: the walk out of a layer returns the menus it crosses; a pick walks from the menu its row runs in, and an activation closes the layer it ran in and the menus that walk crosses (top run round)
2026-11-15 04:46:06 +00:00
aiongg 1951630307 canvas-widgets-w10: net change of 5 commits
- canvas-widgets-w10: partly written (run interrupted)
- canvas-widgets-w10: partly written (run interrupted)
- canvas-widgets-w10: partly written (run interrupted)
- canvas-widgets-w10: finished by an agent
- canvas-widgets-w10: review fixes (review-1)
2026-11-15 04:46:05 +00:00
aiongg 38d3342ad0 framework-01-w9: net change of 8 commits
- framework-01-w9: written by an agent
- framework-01-w9: finished by an agent
- Integration: desktop.rs icon_theme module lines owed by top-w2
- framework-01-w9: review fixes (review-1)
- framework-01-w9: layer containers map placement once (review-1 item 6)
- framework-01-w9: the flyout trials read the open panel's flyout, not one fading out (fw01 round 2)
- framework-01-w9: Flyout is IconicColumn's unregistered face (fw01 round 2)
- framework-01-w9: review fixes (review-tl-1.md)
2026-11-15 04:46:05 +00:00
aiongg eadac57bb8 panels-w2: net change of 1 commits
- panels-w2: a screen-mode change is a change from the mode the last pass applied, whoever wrote the binding; the reveal trial drives Tab through a root that toggles the chrome and a document canvas, and a body-only reveal shows every revealing slot (top run round)
2026-11-15 04:46:04 +00:00
aiongg 80f8719cd4 panels-w2: review fixes (review-2) 2026-11-14 17:56:00 +00:00
aiongg d7ed431c5c panels-w2: review fixes (review-2) 2026-11-14 17:56:00 +00:00
aiongg db29b49895 panels-w2: written from its sheet 2026-11-14 17:56:00 +00:00
aiongg 2b5de84828 Design lint: layer the env values, route egui access through the adapter, derive setters, token and relation checks in tests
The gate's design-lint test finds nothing. Env value types (pane edge, column align, row pressed, in-bar), band fill and span live in the layer that uses them; the cursor image and inside label are read back by the higher layer. Hand setters become derived props, tests assert relations, and the remaining sites are listed exceptions with reasons. The shortcut chord chip's sample is built only for screen tests.
2026-11-14 05:05:04 +00:00
aiongg 2c8a2affd8 Contract stubs: pn.C10 and pn.C16 markers name their writer set panels-w2 2026-11-14 03:36:11 +00:00
aiongg 870c17ba97 Contract stubs: craft-ui-patterns (06.md items), cw.C46 senses_surface 2026-11-14 02:11:11 +00:00
aiongg 38ce55467c Contract stubs: craft-ui-canvas, craft-ui-shell (plus stage-4 carry) 2026-11-14 01:59:24 +00:00
aiongg d325856d4f Lints: ui-shell, ui-canvas and ui-patterns findings 2026-11-14 00:39:12 +00:00
aiongg a17171af48 Lints: drop the workspace missing_docs lint and warn on it in the framework crates that document every public item 2026-11-14 00:15:29 +00:00
aiongg 304030b65b runtime: the root's System choices resolve from the host's SystemReader
InstallSpec::system takes the reader (ui-shell's create starts it with a
repaint wake); the input hook feeds egui's Event::SystemTheme into it, and
system_appearance(ctx) gives the reading and its generation, the one source
RootEnv::resolved uses. egui's system_theme is no longer read. The root token
cache counts its misses for tests (root_token_resolves replaces
root_token_entries).
2026-11-13 17:44:39 +00:00
aiongg 6924d6a1bf Rules are 1 pt wide and take a band of their own
Divider and edge rules take the thin stroke (1 pt, whole physical
pixels) instead of one physical pixel; grid rules over the document stay
one physical pixel.

The rules between a container's regions (above and under the header,
beside a ruled footer, before a ruled end region) each get a band in the
region layout, so no rule lies over a region's content at any scale.
Rules drawn along a rect's edge (footer bar, tile grid tail, timeline
graph bar, docked scroll bar, layer row toggle cells) are edge rules on
the side the rule belongs to, so the second pixel at 2x stays off the
neighbour. The split button's divider reads the divider rule's width.
2026-11-12 15:23:58 +00:00
aiongg a3434176e4 Dialog bodies: the content sits directly in the dialog body, which is already a stack, so fill-width children take the dialog's width; the Tabs dialog's Position column is as wide as its field and Alignment and Leader share the rest 2026-11-12 14:32:57 +00:00
aiongg 4188d4f356 TitleBar stories keep their text placeholders: a MenuBar in the bar's leading slot shows no titles and fails the right-to-left rule, a follow-up of its own 2026-11-12 14:32:50 +00:00
aiongg 8de5a82799 TitleBar stories show the app's menu bar at the leading end and icon buttons at the trailing end 2026-11-12 14:32:50 +00:00
aiongg 0fc7bc0355 Edge rules sit on the pixels just inside their rect
Rule::edge and Draw::edge_rule draw a rule along one side of a rect, moved in by half its width, so a row's bottom rule, a cell's gridline or a strip's edge is no longer drawn on the first pixel outside, where the next row's clip or the next cell's fill hides it. List rows (layer dividers, rule), CellGrid gridlines and header edges, tab dividers, the tile grid's pinned band, font cards and ruler strips use it, as do the pane, end-region, title bar, timeline header and outline band rules that offset by hand. CellGrid draws the old's header edges toward the cells, its gridlines in the divider colour, and the selected header's accent bar inside the header.
2026-11-12 14:32:47 +00:00
aiongg 47508315ef craft-ui-shell: public embed hooks for apps with their own eframe App
shell::embed holds install (runtime plus fonts), before_input, logic and
before_ui, and CloseDecision. app::run's Driver calls the same hooks.
runtime::keys::with_window_intents is public: the host's read of the
window-level keys no component took. docs/craft-framework.md 2.2
describes the recipe and what install takes over. A trial drives its
own frame loop through the hooks alone.
2026-11-12 14:32:46 +00:00
aiongg 9c78e36602 TitleBar draws its bottom hairline only with separator, as the old bar did
The old app's own bar drew none; the stories set it, as the old stories did.
2026-11-12 14:32:45 +00:00
aiongg 5e11bad614 A container in an embedded shell acts on no OS window; its title bar is a picture of a window
os_window reads the embedded-shell signal (ShellCx::region): inline, pane and window
mounts inside an embedded shell stand for no OS window, so they get no move band or
grips and report nothing to the window. TitleBar reads the same signal: its captions
report their clicks but send no window command, a double click acts on nothing, and
it reads no window state.
2026-11-12 14:32:44 +00:00
aiongg eef17642ba Toasts: one queue per window; each AppShell, embedded ones included, shows its own window's toasts at the end-bottom corner of its body (Anchor::Corner replaces Anchor::Viewport), so nested shells no longer each draw every card at the viewport corner; NoticeCenter posts to its window, and the NoticeCenter and ToastStack stories show three notices in their own area, as the old ones did 2026-11-12 14:32:44 +00:00
aiongg be6d1a3332 Rules draw one physical pixel at every scale
Dividers, edges and grid lines are hairlines, as the old Divider was; the drop
mark keeps its medium width. RuleLook carries a RuleWidth that the rule painter
resolves to whole physical pixels.
2026-11-12 14:32:41 +00:00
aiongg 81c22f3469 Old modality: Tour and ViewportWindow block nothing, Preferences is app-modal, a tool window ignores Escape (K17, D10)
The tour card is a popup that blocks and dims nothing and stays on an outside press; Backdrop::ScrimWithHole and the
cover layer's hole go with it. ViewportWindow blocks nothing until app_modal(backdrop). A modeless Dialog without a
footer ignores Escape; a modal one or one with a footer closes on it. PreferencesWindow drops modeless and takes the
shared app-modal path (blocked cursor, refused close).
2026-11-12 14:32:41 +00:00
aiongg 476602d4a3 A filling story's card is as tall as its content, and content taller than the room shares it
Along a height its parent sizes from its content, a container that fills takes its content height, at most the
room it is offered. When the content is taller, the measuring run is taken back and the container is laid out as
given the room, so its list and the bar under it share it; a record of the content height lets later runs and kept
transcripts lay it out the same. room_height only offers a finite room inside a scroll: a gallery card is as tall as
its story's content, at most the view, as the old gallery's tiles were.

layout_memory::draft runs a measuring run whose hand-forwards can be taken back once its result is seen: records,
kept transcripts, the open transcript's items, leaves and inputs, and each contribution (Contribution::undo for
column widths, label control minimums and reads). steps::id::draft takes the Auto id ordinals back with it. The
shrinking row's least probe is a draft taken back that reads nothing from outside.

A scrolling collection that fills keeps to its measured height in the real run under a body sized from its content,
so a footer under it stays below its rows. The PlacesTree story keeps the old 380 pt box.
2026-11-12 14:32:40 +00:00