Commit Graph
115 Commits
Author SHA1 Message Date
aiongg ac5fc71ed0 panels-w1: review fixes (racheck-fix) 2026-11-14 17:56:00 +00:00
aiongg be96f04af2 panels-w1: review fixes (review-1) 2026-11-14 17:56:00 +00:00
aiongg ee5be1ccdd panels-w1: written from its sheet 2026-11-14 17:55:58 +00:00
aiongg 0e216b6257 Contract stubs: decision pass 2026-11-14 16:07:24 +00:00
aiongg e9e3a961f4 Merge next (CI lint fixes) into phase2/stubs
# Conflicts:
#	crates/color/src/ui/swatches/menu.rs
2026-11-14 03:13:33 +00:00
aiongg deeb91802f Lints: doc links, test lint allowances, struct update in tests, wildcard imports, dead code 2026-11-14 02:35:35 +00:00
aiongg 870c17ba97 Contract stubs: craft-ui-patterns (06.md items), cw.C46 senses_surface 2026-11-14 02:11:11 +00:00
aiongg 52a2595a60 Lints: document craft-aaf, fix its doc links, keep canvas size builder closure 2026-11-14 01:47:15 +00:00
aiongg bcd543e017 Lints: ui-patterns tests, gallery, docx docs link 2026-11-14 01:36:21 +00:00
aiongg 36a1900fca Lints: cargo fmt 2026-11-14 00:41:05 +00:00
aiongg 469e3cbc62 Lints: keep the sizing story closures 2026-11-14 00:39:29 +00:00
aiongg d325856d4f Lints: ui-shell, ui-canvas and ui-patterns findings 2026-11-14 00:39:12 +00:00
aiongg a17171af48 Lints: drop the workspace missing_docs lint and warn on it in the framework crates that document every public item 2026-11-14 00:15:29 +00:00
aiongg 5c890a33ae Manifests: crates that turn off a dependency's default features name it by path (cargo 1.95 refuses the override on a workspace dependency) 2026-11-13 23:36:41 +00:00
aiongg 3944c303e3 Popovers size from their content, at least their anchor's width below or above it, capped by the window; a collection measured from its content lays its rows out at the width it asks for; PresetPicker and PresetBrowser columns (default 6) give the grid's ideal width 2026-11-13 18:40:30 +00:00
aiongg a555f84b71 PresetPicker as a pattern over a Popover container: open at a point without the field (open_at), resizable with a remembered size; PopoverOutput reports its open state from its binding (ColorPopover and PresetPicker read it, not the exit fade); no hover proposals 2026-11-13 18:40:30 +00:00
aiongg 172e753d87 Multi-line text parts declare that they act on Enter, so the one Submit take in the text step keeps it from the default button; ParamRows' full-width choice is one Line method 2026-11-13 18:32:12 +00:00
aiongg 02e1c47112 Param list additions and the preview click point: Param::multiline, Param::read_only_text, PreviewOutput::clicked through ParamDialog and HostedParamDialog 2026-11-13 18:32:12 +00:00
aiongg 53ff1a9cc7 cargo fmt 2026-11-13 17:44:43 +00:00
aiongg c895a8a45b PresetPanelMenu trial: view checks and Save… gating agree between states and the per-command answers 2026-11-13 17:44:42 +00:00
aiongg bc95df75c0 PresetPanelMenu: checked and enabled per command, for a host that draws the panel menu itself 2026-11-13 17:44:42 +00:00
aiongg e8329e5d52 FooterBar leading controls: units of the bar's row, narrowing to leave the actions their width 2026-11-13 17:44:41 +00:00
aiongg 25bc6bda1c PresetBrowser footer: stays in the room under a long library, spans the footer under one rule, count on one line; room_height sizes a browser to its presets 2026-11-13 17:44:41 +00:00
aiongg 4e542896f7 PresetEvent: constructors for the struct variants, so hosts can table-test their event mapping 2026-11-13 17:44:40 +00:00
aiongg d76615b3d4 PresetBrowser drop zone: a preset released over the host's zone reports DropAt, on the drag runtime's targets
DropZone names a rect on an egui layer; drag::zone_target registers a target over it with the
layer order, operation and mark of a component's own target, which now goes through the same
function. Trials: the zone drop (and the covered, outside and group cases), and a PresetPicker
inside a Popover keeping the popover open through open and pick.
2026-11-13 17:44:40 +00:00
aiongg 3314ffeb28 F-16 fix round 1: one canvas zoom field with the percent unit, NavigateBar::zoom over the canvas's ViewTarget, Fit Artboard margins 30 by 40 2026-11-13 13:17:30 +00:00
aiongg 1e5782dfd4 Dialogs: StackDialog::story_facts; hosted forms keep their last pass's facts and hosted stories report them 2026-11-13 02:26:58 +00:00
aiongg af8855c139 Dialogs: FormDialog::preview takes an optional owner, every owner-less open starts with Preview on; Guide Layout's Preview box is FormDialog's; the story host is a story note 2026-11-13 02:26:58 +00:00
aiongg 7f34140aa6 Dialogs: FormDialog::preview is the one Preview box; hosted stories reopen their dialog when a knob changes
FormDialog::preview(Bind<bool>) adds the Preview check box under the side buttons, with one
word (formDialog.preview) and hold-to-compare in FormOutput::comparing. ParamDialog,
HostedAdjustDialog and HostedLayerStyle use it; their own boxes and the paramDialog.preview,
adjust.preview and layerStyle.preview words are gone.

The hosted story helpers take the knob values the dialog is built from and replace the open
dialog when they change. The Export As story asks for a preview only while preview_ready is on.
2026-11-13 02:26:58 +00:00
aiongg be927e9393 Dialogs: hosted forms for Canvas Size, About, format options, Export As, Alert, Layer Style and the adjustment dialogs
Each opens on a DialogHost as a StackDialog that owns what its dialog edits
and binds the dialog's open state to its own field, so it opens again after
closing. HostedCanvasSize and HostedImageSize share SizingOutput::hosted.
HostedExportAs keeps its preview and save requests for the app as
HostedSaveForWeb does; HostedAbout keeps the activated link. HostedAlert
holds an Alert's content. HostedLayerStyle frames the Layer Style body in a
form dialog with side buttons and the Preview box, and queues the page's asks
as LayerStyleAsk. HostedAdjustDialog<V, E> frames any adjustment editor the
same way, resizable and remembered for Curves, with the editor's asks as E.

Stories open the hosted dialogs through a story host bound to the card's
open value (dialog::stories::hosted), so the card holds them behind its
button and story-render shows them open. Trials open each on a DialogHost
and check Escape, OK and the asks.
2026-11-13 02:26:58 +00:00
aiongg 908da71beb New Workspace's Capture boxes sit in a titled group box; contract API lists the workspace captures 2026-11-13 01:22:55 +00:00
aiongg a2e346e414 Trials: dock side width, workspace captures, bottom pane on switch, workspace dialogs 2026-11-13 01:22:55 +00:00
aiongg 741be65f20 New Workspace and Delete Workspace dialogs for WorkspaceAsk 2026-11-13 01:22:55 +00:00
aiongg 41c16c7b6e Commands: a key command keeps open the popup whose content declares its scope; instances record the layer they run in 2026-11-12 22:54:16 +00:00
aiongg 7fd2b260db ui-contract: the host's tool gesture holds only beside a modal body that keeps the canvas
The registry keeps the dialog's part and the host's part apart: the
host's gestures join the reach only while a modal body keeps the same
canvas, whatever order the two are made in, so a modal that keeps
nothing (an alert) leaves the canvas blocked. Trials: the host's gesture
lapses when the dialog stops keeping the canvas; under a dialog that
keeps nothing it passes no press and no wheel.

Also: the BlockingOverlay story's drive opens it; rows.rs doc wrapped;
api-map TonePickerRow note names pass_canvas_gesture.
2026-11-12 22:38:11 +00:00
aiongg 5f279e9a00 ui-contract: a modal's canvas reach names the gestures it passes
The canvas a modal dialog keeps open (runtime::sampler) passes the view
navigation and, beside it, only the presses the dialog names: a
CanvasGesture is a button with the modifiers it needs held, its drag
included. Sampler::pass_canvas_gesture replaces arm_sampler; the
eyedropper rows, the Color Picker and the tone pickers name a primary
press, Curves names its Cmd-click, and every other press stays blocked.

Trials: the kept view passes the wheel (scroll and zoom) and the middle
pan and blocks the primary press; a modifier gesture passes only with
its modifier. Story: Canvas "under a dialog", a live region under an
open modal.
2026-11-12 22:38:11 +00:00
aiongg 01f146b931 Dialogs: automation answers only what a user can press
StandardPrompt and UnsavedChangesDialog build their buttons, their choice
check and their programmatic OK from one offered list; a choice without an
enabled button is refused. HostedParamDialog opens its values once (remembered
values, defaults) before its first show, OK or set, through the helper the
first pass uses; OK builds its result through one helper; set refuses rows
that are hidden or disabled and reads the value as its row's kind.
set_json_field takes the Context. Automation lists dialog ids as decimal
strings, takes a string or a number, and names only the host's dialogs.
2026-11-12 22:27:40 +00:00
aiongg e51e929e48 Dialogs: automation surface for every StackDialog
StackDialog gains json_fields and set_json_field; DialogHost lists its open
dialogs with their fields, sets one by id, and confirms or cancels by id
whatever the type. HostedParamDialog (values by parameter row, with a
programmatic OK), StandardPrompt and UnsavedChangesDialog (their choice)
implement them. craft_automation::dialogs runs ui.dialog.set/confirm/cancel
on a host and lists its dialogs for ui.inspect.
2026-11-12 22:27:40 +00:00
aiongg fc7d05a5fc NumberField: monospace digits, the unit apart at the end of the value area
The digits take the mono type role, as the timecode field does. The unit is a
smaller faint caption pinned at the end of the value area with the inline gap,
so the number centres in the room before it and stacked fields line their
units up. Units::suffix goes; callers pass the unit's symbol.
2026-11-12 15:12:11 +00:00
aiongg f7f75c178f Sizing::FillWidth makes a leaf fill its row's leftover room
Component::fills defaults to the width when the caller set Sizing::FillWidth,
and the sizing stays on the component after step 1 so the layout hooks read
it. Button, TextField and Slider lose their fill_width props and Swatch and
GradientSwatch their fill flags; callers set Sizing::FillWidth. The blend
select in BlendRows takes the room before Opacity, as in PhotoCraft.

A contract trial checks that a FillWidth leaf takes the row's room and a
Content leaf does not.
2026-11-12 15:12:10 +00:00
aiongg 7a02997ac1 CommandPalette: the lead row is the command highlight
ListRow's command flag puts an option that runs a command in the menu row
form: the lead row in accent.solid with text.on_accent, with no lead or
chosen edge. The palette's rows take it; other option lists keep the
option form.
2026-11-12 14:32:51 +00:00
aiongg cef153147a PdfExportDialog: the shown page's title heads the page, as Preferences titles its page 2026-11-12 14:32:51 +00:00
aiongg e8e7142df9 Preferences groups have no column modes: the label step places each check box row 2026-11-12 14:32:51 +00:00
aiongg 41ded35010 ParamRows: group headings (sections and radio rows) are quiet captions with no rule, as the old dialogs drew them 2026-11-12 14:32:51 +00:00
aiongg 4a6d07a02e Save for Web's Image Size and the PDF export headings are quiet section labels, as they were 2026-11-12 14:32:50 +00:00
aiongg a4316d6d6a Export As story: a 4000 x 3000 document of a landscape, opened on JPG as the old story was, so its pair shows the Quality rows 2026-11-12 14:32:50 +00:00
aiongg f204291477 PreviewPane: an aspect sets the well's height from its width; Export As shows a square preview beside its settings 2026-11-12 14:32:50 +00:00
aiongg b127a87dc8 Export As: the format is a select, Constrain Proportions a check box under Height, Image Size a quiet heading, and every settings row shares one label column 2026-11-12 14:32:50 +00:00
aiongg 477b080845 Title rows: a note runs on after the title in muted body text, and the subtitle sits at the band's end in muted caption text; the gallery card shows its story name as the note, the Inspector its target's kind as the subtitle 2026-11-12 14:32:50 +00:00
aiongg b54195e805 One path row: PathRow, a path field and a Browse button that reports the press; ParamRows and Watermark ask with a PathRequest, PathField picks through the file service 2026-11-12 14:32:50 +00:00