Commit Graph
39 Commits
Author SHA1 Message Date
aiongg 2b66d91e8b IME engine: the input method's byte-counted delete-surrounding deletes the characters those bytes cover, converted at the editor against its text around the caret 2026-11-16 21:20:27 +00:00
aiongg deeb91802f Lints: doc links, test lint allowances, struct update in tests, wildcard imports, dead code 2026-11-14 02:35:35 +00:00
aiongg 80ea3f6670 Lints: ui-widgets trials, table, prepress, media, raw and update doc links 2026-11-14 00:55:22 +00:00
aiongg a17171af48 Lints: drop the workspace missing_docs lint and warn on it in the framework crates that document every public item 2026-11-14 00:15:29 +00:00
aiongg 73030467ae IME engine fix round 1: only the IME owner's report counts; retired resets come from the integration
- note_editor ignores every editor but the IME owner, so a second editor shown after it leaves the owner's
  composing report standing; editor_history answers non-owners (false, false).
- egui repinned to the fork's craft/ime-reset-retired (9b1f60c60): Event::ImeResetRetired reports a reset request
  egui-winit or PlatformOutput::append dropped without a completion. The engine asks again on the retirement of
  its own request; the focus check and the no-output retire in end_pass are gone. The test fixture reports
  retirements where egui-winit does (focus loss, no IME output, another IME context, a newer request, egui's
  dropped requests).
- The sheet grid's point mode ends a composition in the draft, its marked text kept as typed.
- TextEditor applies a pass's input before its press (the press is the pass's last pointer event, H0), so a
  preedit and a press in one raw frame change the marked text once and the press interrupts.

Trials: a reset the integration retires is asked again (craft-ui-contract); the click trial gains a second
editor shown after the composing one and a preedit-then-press frame (craft-text).
2026-11-13 16:15:16 +00:00
aiongg f910b4fe3c IME engine: an editor's own end of composition interrupts the OS composition; resets end only with their own completion
EditorState.composing replaces EditorState.revision (and TextEditorHost::revision): an editor that reported
composing and now does not ended the composition itself (a press in its text, a selection, an app edit over the
marked text), and the engine interrupts the OS composition and drops its late events. TextEditor and the sheet
grid report their marked text; editors that show none report false throughout.

The reset fence ends only with the completion of the engine's latest request (ImeResetId); an earlier request's
completion is stale. A request the integration can no longer answer (a pass with no IME output, an unfocused
window) is retired and asked again when an owner returns.

Trials: preedit and a click during composition for a canvas TextEditor, with one press per pass holding the late
commit for the next pass (craft-text); reset requests and stale completions (craft-ui-contract).
2026-11-13 16:15:16 +00:00
aiongg ac9dd13cdc Toggle columns: one width from the toggle-column mechanism, a control and the inline gap (ColumnWidth::Toggle, ColumnSpec::toggle) 2026-11-12 15:42:15 +00:00
aiongg 5570e075ec ConditionBuilder: the match, field, operator, unit and choice selects fit their widest entry 2026-11-12 15:23:58 +00:00
aiongg 004ab39f41 CellGrid: cell buttons are small boxes with a control's corners; story rows a text line high
The filter button and the error tag share one cell button look (table ui/cell_button.rs): a raised box with
shape.radius.control corners and a size.icon.sm glyph, so a filter button fits inside its header cell instead of
a pill that covers the heading. The sheet stories' rows are a line of body text high, as a spreadsheet's default
row, under the 20 pt headers.
2026-11-12 14:52:13 +00:00
aiongg 2e64f951b8 Slicer: accent header band and control-radius tiles
HeaderRegion's band takes a BandFill: a surface or a tone's tinted fill
(HeaderRegion::tint). Tone::soft_fill and Tone::on_soft give a tone's fill
and the ink on it from one token table; StyleCx::tone_fill and the new
tone_on_fill read them. TitleRow::tone sets a header title in that ink.

The slicer's header is an accent band, inset like the body, with its
caption a section-strength TitleRow in accent.on_soft on the funnel's
centre line; its tiles take radius.control instead of the button radius.
2026-11-12 14:32:51 +00:00
aiongg dab44be31a CellGrid: row headers hold the digits of the last row the view shows (Component::padding from the rect; digits leave the style key) 2026-11-12 14:32:50 +00:00
aiongg 99f603de6c CellGrid: the chrome over the cells stays in the rows' view, clear of the scroll bar (PartsCx::rows_view; one scroll track helper) 2026-11-12 14:32:50 +00:00
aiongg 77ebd4b848 CellGrid: filter buttons sit in the table's header cells at their own size, as a spreadsheet's filter arrows do 2026-11-12 14:32:50 +00:00
aiongg 6cfa0101c8 One fill for a closed polygon
PaintShape::Polygon is any closed polygon whose edges don't cross.
kit::fill_polygon fills it as one mesh: egui's edge fade around the outline
and an ear-clipped inside, so the parts of one shape meet without a seam.
Draw fills every polygon with it.

Chart wedges and area polygons fill as one polygon each, and the eyedropper
ring band as one polygon, in place of runs of convex pieces whose faded
edges left seams between them.
2026-11-12 14:32:50 +00:00
aiongg eb08ed121e Chart text takes a type role
ChartPrimitive::Text carries its TypeRole in place of a bold flag. The chart
story sets titles in BodyStrong and axis labels in Caption, as the old
gallery did, so the region labels no longer touch.
2026-11-12 14:32:50 +00:00
aiongg 73814336a4 Charts paint lines and outlines
ChartPrimitive lines paint solid or dashed in the theme's dash pattern, and
every stroke (rect, polygon, wedge, circle) paints. Widths are a named theme
width or a document width that scales with the chart's zoom. Draw::dashes
gives the theme's dash pattern. The chart story draws its axes, gridlines
and wedge gaps hairline, as the old gallery did.
2026-11-12 14:32:50 +00:00
aiongg 7fcd160eca Field and number widths per control size: size.length.field and size.length.number hold sm and md, and controls read them through ControlMetrics, so a field in a small options bar is narrower than one in a dialog 2026-11-12 14:32:49 +00:00
aiongg 1daf4d94fb CellGrid story: the range holding the active cell comes last, so the two-range selection shows 2026-11-12 14:32:49 +00:00
aiongg f0e47b655e CellGrid: a column header cut narrower than its letters leaves them unpainted, as a cut row header does 2026-11-12 14:32:49 +00:00
aiongg 31574e0bd4 SlicerCard stories: the region tiles inside the card, sized like the Slicer story 2026-11-12 14:32:49 +00:00
aiongg fca6431051 CellGrid stories: the sales sheet as Default (filters, error tag, two ranges, token line sizes); hidden column and merge in their own story 2026-11-12 14:32:49 +00:00
aiongg 864c93bacd ChartSheet story: the old Primitives card, a column chart and a doughnut in theme colours at the room's width 2026-11-12 14:32:49 +00:00
aiongg 243b86c23e CellGrid: headers a small control high, and the select-all mark in the corner
The column headers take the small control height at every density, as the old grid's did (size.control.sm). The corner between the headers shows the old's select-all triangle in its end-bottom, in the header text colour.
2026-11-12 14:32:47 +00:00
aiongg 260822bacf CellGrid: merged cells paint at sheet level, whole over the rows they span
A merged cell was painted by its first row inside that row's clip, so its text was cut and the rows below showed the grid's surface. The grid paints each merged cell in view over its whole rect, cut to each pane it shows in, with the same cell paint as a row's cells (CellPaint: background, the tint of its flags, gridlines, the app's paint). Its flags come from the grid's selection as the item step sets a row's cells'. Rows skip every cell inside a merge. PaintUi::clipped cuts a PaintUi to a rect, as Draw::clipped cuts a Draw.
2026-11-12 14:32:47 +00:00
aiongg 0fc7bc0355 Edge rules sit on the pixels just inside their rect
Rule::edge and Draw::edge_rule draw a rule along one side of a rect, moved in by half its width, so a row's bottom rule, a cell's gridline or a strip's edge is no longer drawn on the first pixel outside, where the next row's clip or the next cell's fill hides it. List rows (layer dividers, rule), CellGrid gridlines and header edges, tab dividers, the tile grid's pinned band, font cards and ruler strips use it, as do the pane, end-region, title bar, timeline header and outline band rules that offset by hand. CellGrid draws the old's header edges toward the cells, its gridlines in the divider colour, and the selected header's accent bar inside the header.
2026-11-12 14:32:47 +00:00
aiongg 7df7b0579c Slicer: the card pads its header and tiles 2026-11-12 14:32:47 +00:00
aiongg a2ce6e6881 FieldListPane: title and hint over the checklist, the areas as sunken tiles two by two 2026-11-12 14:32:47 +00:00
aiongg f06b238b7b ConditionBuilder: a nested group sits in a frame with its remove button 2026-11-12 14:32:47 +00:00
aiongg a1e11bbedc Slicer: height_for measures the card at a width; the story reserves that room 2026-11-12 14:32:47 +00:00
aiongg 4f37e8a432 ConditionBuilder rule rows and the FieldListPane footer wrap where the room is short, so selects and buttons keep their labels whole; a range's two ends and its "and" wrap as one 2026-11-12 14:32:47 +00:00
aiongg 210bea1bdf CellGrid: a pinch or Cmd/Ctrl+wheel zooms about the pointer; the zoom and the scroll live in GridState 2026-11-12 14:32:46 +00:00
aiongg 5e7d2c9943 CellGrid header press: Shift extends the current range from the anchor's line, Cmd/Ctrl adds the whole line as a range 2026-11-12 14:32:46 +00:00
aiongg 49455a3aa8 CellGrid: Alt+Enter and Ctrl+Enter open the active cell's editor, as F2 does 2026-11-12 14:32:46 +00:00
aiongg d33c7b23f9 Entry headings and the empty swatch: Entry::heading shows as a caption row in Select lists (ListRow::heading) and menus (MenuItem::heading) that keys, clicks and type-ahead pass over; Draw::swatch_well paints every swatch well, the empty one for a colour the theme decides; ConditionBuilder and ColorChoice use them 2026-11-12 14:32:46 +00:00
aiongg 316ac6fa21 Collections take drops through drop kinds: a payload of any type, between items or onto an item, reported as one Dropped event with its place and payload; accept_from and the same-key foreign drop go 2026-11-12 14:32:43 +00:00
aiongg ac563d9eb3 Collections take a row range: min_rows and max_rows bound their height, and a capped one scrolls its rows; MissingFonts, TabStops, TextStyles and FieldList set theirs 2026-11-12 14:32:42 +00:00
aiongg 5d8b0a94de Hand-stroked dividers and edges use the rule painter
The split button's divider, the timeline track header's divider and the table
outline and grid header edges paint through Draw::rule and Draw::rule_with, the
one pixel-snapped line, instead of their own strokes.
2026-11-12 14:32:41 +00:00
aiongg f74d963e8f Collection keys: Cmd+] and Cmd+[ move the selected items, Shift to the ends
The stacking keys replace Alt+Up and Alt+Down as the reorder keys of every reorderable
collection and section stack, from one table in the key table. ] moves toward the front:
the start of a vertical order, later in a horizontal strip. The keys move the selection
as a block (the lead alone when it is not selected), with the tree rule for into_groups;
the single-row nudge helpers go. Alt+Down is Open everywhere.
2026-11-12 14:32:39 +00:00
aiongg 8735a8b1c5 Document and app crates on the framework: text, pages, table, review, timeline, menu, browse, dialogs, print, font manager, theme store, update, automation 2026-11-12 14:32:38 +00:00