Commit Graph
39 Commits
Author SHA1 Message Date
aiongg af40a12e48 Font picker: a preview the pointer proposed ends when the pointer leaves the rows 2026-11-16 21:21:57 +00:00
aiongg ddb920e3f2 Font picker trial: the hovered row is proposed as the preview; closing the list cancels it 2026-11-16 21:12:23 +00:00
aiongg 259fc8e0bc merge-fwb: FW13: param rows report range alerts; Global Light angle range and whole degrees; SliderField reports its field's range alert 2026-11-16 12:48:38 +00:00
aiongg b171283050 fmt 2026-11-16 01:01:56 +00:00
aiongg 0b823cd7b0 tfix4-f6: value controls that step by the wheel declare it, so a Free scope frees them 2026-11-15 21:30:32 +00:00
aiongg ac07821a8d Font sample: measure and paint share one row layout, cut with an ellipsis where the room does not fit it 2026-11-15 14:04:22 +00:00
aiongg c01f1ed6b0 fwb2-fix: R108 read_axes and read_named_instances without the ui feature 2026-11-15 12:26:55 +00:00
aiongg 84580bba7b fwb2-fix: R108 FontAxis and NamedInstance without the ui feature 2026-11-15 12:26:55 +00:00
aiongg add947785c fwb2-fix: FontAxis and NamedInstance constructors
(cherry picked from commit c5d7f5e08eaeece50ca0f48d98b1a893e4c4c121)
2026-11-15 12:06:39 +00:00
aiongg 14d5ec609a cargo fmt 2026-11-15 10:23:21 +00:00
aiongg 8e6b23810a tools-w7: net change of 7 commits
- tools-w7: written from its sheet
- tools-w7: repair 1
- tools-w7: review fixes (review-1.md)
- tools-w7: Picture takes a content painter (T-ruling, item 1)
- tools-w7: banner paints through Picture::painter (review-1.md item 1)
- tools-w7: Picture painter is Fn (runs twice per pass)
- tools-w7: family rows show the list's tree disclosure; the style trial and story open a family by its expand request (tools run round)
2026-11-15 04:46:09 +00:00
aiongg 2151ca4cd4 canvas-widgets-w11: net change of 12 commits
- canvas-widgets-w11: partly written (run interrupted)
- canvas-widgets-w11: partly written (run interrupted)
- canvas-widgets-w11: partly written (run interrupted)
- canvas-widgets-w11: written by an agent
- canvas-widgets-w11: review fixes (review-1)
- canvas-widgets-w11: a root's response reports the presses on every part of its own, whatever egui widget took them; the part results say which part (fwcw round 3)
- canvas-widgets-w11: a press keeps focus only on the framework's focused stop, so a press on the canvas background focuses the canvas while a body member holds the stop (fwcw round 3)
- Integration: ui-widgets exports TextWords for Alert::range (dialogs-w4, cw.N6)
- canvas-widgets-w11: the held edit-menu selection drives the text part's keys and survives the pass focus takes to come back (top run round)
- canvas-widgets-w11: a root's own background is a hover candidate below its parts, and the root's response hovers by the framework's resolve wherever its arena is under the pointer; the press fallback to the background folds into the same shape (top run round)
- canvas-widgets-w11: an activation closes only the layers its walk out of the layer it ran in crosses, so a pick in a field's edit menu inside Help leaves Help open (top run round)
- Integration: overlay pass keeps framework-01-w9's layer spaces beside the activation's closed layers
2026-11-15 04:46:05 +00:00
aiongg 84ad88d5c8 panels-w11: review fixes (review-1) 2026-11-14 17:56:00 +00:00
aiongg 424cf7fd98 panels-w11: written by an agent 2026-11-14 17:56:00 +00:00
aiongg b12d6387c5 Contract stubs: craft-automation, craft-layers, craft-font-manager, craft-timeline, craft-print 2026-11-14 02:34:37 +00:00
aiongg 5202f8c11d Lints: drop the Styled import the card module now carries 2026-11-14 00:19:14 +00:00
aiongg acdacefe1a Lints: import the names the split-out modules use from where they are defined 2026-11-14 00:18:37 +00:00
aiongg e8663f6c72 Lints: replace wildcard imports of split-out modules with explicit imports 2026-11-14 00:15:29 +00:00
aiongg a17171af48 Lints: drop the workspace missing_docs lint and warn on it in the framework crates that document every public item 2026-11-14 00:15:29 +00:00
aiongg 522e71a4f0 Components that show data paint their enabled look faded when disabled
Picture, ColorWheel, ColorDisc, ColorRamp, TrackRamp, GradientSwatch,
BrushStrokeStrip, Histogram, GraphEditor, FontSample, CurveGraph,
ToneRamp, CurvePreview, VectorscopePlot and FramePreview declare
DisabledLook::Faded: their content is data painted with the content
painter, and their chrome has no Disabled look of its own. GradientSwatch
goes the way of Swatch: its edge loses its Disabled entry.
2026-11-12 14:32:51 +00:00
aiongg efc398a2f4 Timeline panel: headers sized by content, ruler on the lanes' origin, whole timecode
- HeaderColumns: one set of header columns per pass, worked out from the model before the view shows. The switch
  columns are the ones some track has; the name column is the widest track name with its pads and indent, or the
  width the user dragged; the headers are at least as wide as the timecode and toolbar block over them. Every pane's
  TrackStack, the top strip's head column and the TimelineView's inset (header_extent) take the same extent.
- The top strip's head column is the header extent and its columns touch; the marker strip and the ruler sit in a
  fill-width stack, so they span the time area from where the lanes start.
- BodyLayout::grid takes owned or borrowed columns.
- TimecodeField::large keeps the timecode face (equal-width digits), so its widest sample is its widest text.
- MeasureCx::field_text: an editable text's room with the caret past its last letter. TextField, NumberField,
  TimecodeField, DateField, ComboBox and the font picker size by it.
- Trial: the ruler starts where the lanes do, and no header has a column no track has.
2026-11-12 14:32:49 +00:00
aiongg d27244eac7 GlyphsPanel stories: the editing panel is Default; the non-editing panel its own story 2026-11-12 14:32:49 +00:00
aiongg a96e58b6bd MissingFontsDialog: the Replace With caption over the missing fonts
The field group named its rows for AccessKit only. A fixed section in the caption strength shows the old grey caption over them, with no rule.
2026-11-12 14:32:48 +00:00
aiongg 13221fd697 Collections take their width from content where their column gives none, and honour their pad
A collection that fills the width (Fill or FillWidth) follows the rule a
container does: where the enclosing body does not give its width (sized
from content, or a content column), a measuring run takes the width from
its content (header least width, else its largest row, at least its
ideal_width) and the column holds it across the width it settles on. A
FillWidth TabStrip or list in a dialog's column no longer sets the
column to the screen's width. Env::gives_width names the rule for both.

Collections honour ContainerProps::pad as containers do: the items hook
reports it (ShapeHooks::pad), the pass carries it in Resolved::pad, and
step 5, the measure view's room and step 7's content rect read the
padding through steps::padding. The header, rows, scroll bar and empty
text sit inside it; the surface covers the whole rect. #[container]
forwards pad, so Panel's own copy goes.

The spelling, file list and glyph wells are a List or TileGrid with
surface(Sunken).pad(Control); RelinkDialog's table is FillWidth.
2026-11-12 14:32:48 +00:00
aiongg 37b6bb87c5 Bare tiles pack tight
A tile without a caption keeps only gap.tight around its picture, the room its selection ring draws in, and a grid of such tiles puts no gap between them. GlyphsPanel's zoom takes the old cell range, 24 to 64 pt, with a default near the old 32 pt.
2026-11-12 14:32:48 +00:00
aiongg 0fc7bc0355 Edge rules sit on the pixels just inside their rect
Rule::edge and Draw::edge_rule draw a rule along one side of a rect, moved in by half its width, so a row's bottom rule, a cell's gridline or a strip's edge is no longer drawn on the first pixel outside, where the next row's clip or the next cell's fill hides it. List rows (layer dividers, rule), CellGrid gridlines and header edges, tab dividers, the tile grid's pinned band, font cards and ruler strips use it, as do the pane, end-region, title bar, timeline header and outline band rules that offset by hand. CellGrid draws the old's header edges toward the cells, its gridlines in the divider colour, and the selected header's accent bar inside the header.
2026-11-12 14:32:47 +00:00
aiongg 280f5cbdf7 Wells: the spelling suggestions, the file list and the recently used glyphs in a sunken well, and the notes editor in the text well 2026-11-12 14:32:47 +00:00
aiongg e4a8dfc2f8 FontsPanel details sheet: a press outside closes it and reaches nothing below 2026-11-12 14:32:46 +00:00
aiongg 8f1a136e42 FontsPanel trial: with the keyboard on a card, Cmd/Ctrl+F puts it in the search field 2026-11-12 14:32:46 +00:00
aiongg 0897874266 Every component takes one sizing setter: a leaf with Sizing::Content is as wide as its content, without its style's ideal width, and the selects the old gallery fitted to their entries are content-sized 2026-11-12 14:32:44 +00:00
aiongg a8cc821ff9 Dropdowns close when the focus leaves their anchor, and Tab in an open Select chooses the row the keys reached
Overlay::dropdown dismisses on focus left (the tree picker and font rows keep it with their own Dismiss). CloseReason::FocusLeft carries what moved the focus (FocusMove: keyboard navigation, or a press or code), recorded where the focus service applies Tab, Shift+Tab and F6. OverlayUi::closing tells the opener why its popup closes this pass: Select commits its proposal on a keyboard focus move, cancels on Escape and on any other focus move. A dropdown's content is no Tab entry, and Tab from inside it goes on from its anchor.
2026-11-12 14:32:43 +00:00
aiongg ac563d9eb3 Collections take a row range: min_rows and max_rows bound their height, and a capped one scrolls its rows; MissingFonts, TabStops, TextStyles and FieldList set theirs 2026-11-12 14:32:42 +00:00
aiongg d1a90a2447 Toggles open on the press by default: menu and dropdown openers (split button arrow, breadcrumb ellipsis, number field chevrons, bar overflow, panel menu) let press, drag, release pick a row; on_click keeps the release for the iconic flyout and the date calendar 2026-11-12 14:32:41 +00:00
aiongg e64dd901d9 Tooltips: a control that paints no label shows its own label, and the hints and names the old controls showed
A control whose own label is not painted (an icon, a glyph label, a caption-less tile, a chip, the stroke button) shows that label as its tooltip inside a field too; one named only by its field label shows none. Restores the old tooltips of the ReferencePoint points, the list disclosure, the PeopleBar avatars, the recent files, Distribute Rows Evenly, a page that failed to render, the font class mark (ListRow::trailing_named) and the Character hints (SideLabel::tooltip).
2026-11-12 14:32:39 +00:00
aiongg e9c1a3a776 Popup lists: one popup padding and the listbox option rows
Every popup pads its content by POPUP_PAD (space.pad.control, the old menu
margin): OverlayUi::show insets its body, and PopupList, Popover and Menu
take it as their pad; Menu::inline has no pad of its own. Option rows of a
listbox have their own form: rounded, the chosen row in state.selected with
an accent.text outline, the lead row in state.hover with a line.control_edge
outline. ListRow::check gives a value list's rows a mark column with the
check glyph on the chosen one; Select, ComboBox, the number presets, the
tree picker and the font picker set it.
2026-11-12 14:32:39 +00:00
aiongg 8735a8b1c5 Document and app crates on the framework: text, pages, table, review, timeline, menu, browse, dialogs, print, font manager, theme store, update, automation 2026-11-12 14:32:38 +00:00
aiongg 92d392cff1 craft-ui: ComboBox, egui's combo box with a menu that grows back (#387)
* craft-ui: combo boxes whose menu grows back with its contents

egui's ComboBox lays its menu out in the height it had on the previous pass,
and its scroll area takes no more than that. A filtered list that shrinks (a
search with no matches) never grows back when the search is cleared
(emilk/egui#5225, #5138). craft_ui::combo::menu offers its contents the full
height on every pass; craft_ui::combo::combo draws the combo box button
around it. The Font Manager's Language, Script and Sample menus use it.

* craft-ui: combo and menu take the close behaviour

A menu with a search field that closes itself on a pick (DesignCraft's font
menu) closes on a click outside only.

* craft-ui: ComboBox, a drop-in for egui's combo box, with header menus

craft_ui::ComboBox has egui 0.37's ComboBox builder and button (same
atoms, style classes and icon, pixel-identical in a test) with a menu that
grows back. show_ui_with_header and show_rows_with_header keep a search
field in place and scroll only the list; combo::Menu is the same menu under
a field an app draws itself. clippy.toml disallows egui::ComboBox.

The Font Manager's Language menu, the keymap dialog's combo boxes and the
print dialog's printer and duplex choices use it.

* craft-ui: combo menus keep to the room on their side, and footers

A menu is never taller than the room on the side of its field it opens on,
so an unbounded height fits on screen and scrolls. The side is settled once
the menu is measured and kept while it is open, so a menu that shrinks or
grows while typing doesn't jump to the other side of its field.

Footer forms keep a row under the scrolling list. Menu::new takes the
field's Ui for its default height and frame, and Menu::open shows the menu
under a text field that keeps the focus while typing.

* craft-ui: combo menus open by the app keep their side, and take picks

Menu::open takes &mut bool: the menu clears it when it closes (close
behavior, Escape, ui.close(), the field losing the focus to anything but
the menu), so a click on a row under a focused text field is picked.

The side settles only once the menu was shown and measured, also for
menus the app opens (Popup::open_id). A footer that changes height
remeasures the menu before it is shown. The popup frame's margins come
from the popup style; only above/below alignments are tried.

* craft-ui: a resting pointer over a combo menu doesn't keep it open

The menu counts the pointer as having moved into it only on a press or
click. A footer height change also requests a repaint, in case the
discard is denied.

* craft-ui: a footer menu opens without a second sizing pass

A footer height change no longer discards the pass or forces another
sizing pass: the menu measures again on the next pass and settles its
side then. A forced sizing pass ran a search field's focus request in a
pass where the field can't take the focus, so a footer menu opened with
the search unfocused.

* craft-ui: tests use Ui::scope_id

* craft-ui: hide the measuring pass of a footer menu, cap remeasures

The pass that measures a menu before its side is settled is laid out but
drawn fully transparent, so no frame shows a side or height the menu then
leaves. A footer that changes height on every pass remeasures twice per
open, then settles.

* craft-ui: tests satisfy clippy
2026-10-27 09:21:01 -04:00
aiongg 5120c0ce2d Font store and Font Manager: review fixes
- FontStore::remove_files only touches names the family's manifest entry
  lists and that are safe file names.
- A user source's folder carries a hash of its full ID, so sources whose
  IDs slug alike don't share a folder.
- The download dialog and the sidebar note name the family's own source,
  and the server for a source the user added.
- The face cache takes out only faces the last frame didn't draw.
- The catalog test lists missing translations instead of failing.
- ATTRIBUTION lists the three bundled craft-font-index files.
2026-10-25 19:41:46 +00:00
aiongg 06a4ec194a craft-font-catalog, craft-font-store and craft-font-manager: installed fonts, the font store and the Font Manager panel 2026-10-25 19:09:33 +00:00