Commit Graph
54 Commits
Author SHA1 Message Date
aiongg ebf36dc279 A Single Row or Column Marquee click inside the selection selects the line at the press snapped as a point, leaving out the selection's own edges 2026-11-16 21:21:53 +00:00
aiongg 2103be6de1 Fix clippy and rustdoc errors in automation, draw, imaging, svg, ui-patterns and ui-widgets 2026-11-16 15:40:46 +00:00
aiongg f647f41e82 Merge branch 'dl/api' into dl/all 2026-11-16 13:39:11 +00:00
aiongg b39d967677 Merge branch 'dl/contract' into dl/all 2026-11-16 13:39:10 +00:00
aiongg fbe5a16ffe design-lint: api/non-exhaustive: #[non_exhaustive] on public types and variants, constructors where other crates build them 2026-11-16 13:31:29 +00:00
aiongg 3be93ea350 design-lint: contract/keys, contract/egui-import, contract/pointer, test/harness: imaging's raw story presses through testing::input, SelectMask::start_pass, CylinderValues::moved, the magnetic width trial in the select trials 2026-11-16 13:29:30 +00:00
aiongg 839b67b628 Merge branch 'fw/merge-fb' into area/fwb2 2026-11-16 13:20:06 +00:00
aiongg c321c26d35 merge-fwf: StyledPreview: one composite store per filter in a context, keyed by the preview's name, so closed previews' composites are evicted; trial 2026-11-16 13:13:18 +00:00
aiongg cb0b9afa4a merge-fwf: F7 settled regions: a Loading answer of the texture loader notes the asking code as still moving, so a settled region showing a stand-in reruns when the job lands; trial: the mip trial in a settling region 2026-11-16 13:13:18 +00:00
aiongg f77d72c556 merge-f: F7: PreviewTextures builds mip levels on the shared TextureLoader, the closest finer level standing in (#13382); one store per context keyed by name and level, revisioned per preview; the loader drops finished results of keys nobody asked for 2026-11-16 13:00:43 +00:00
aiongg 70fda8a853 merge-c3: Magnetic Lasso cursor reads the canvas's precise cursor (cx.precise()); MagneticLassoTool::precise_cursor removed 2026-11-16 12:55:44 +00:00
aiongg f009a2065d merge-c4: 3.1: the lasso click trial names its rigs apart from the rig helper 2026-11-16 12:43:03 +00:00
aiongg dd1dbea3d4 merge-c4: 5.1: LassoTool::outline_operation, the operation the open outline latched at its press 2026-11-16 12:34:31 +00:00
aiongg 8f78c213de merge-c4: 3.1: a Lasso click deselects only when its operation is New (#13612) 2026-11-16 12:34:06 +00:00
aiongg cc00dbd368 Clippy and test-target lints: redundant must_use, type aliases for complex types, boxed large variants, argument structs, struct-update initialisers, deprecated egui calls, unused imports and dead code; the swatch library's reorder test runs as a trial 2026-11-16 02:30:55 +00:00
aiongg b171283050 fmt 2026-11-16 01:01:56 +00:00
aiongg 6dabf1503d tfix5-f8: content moves take every move from the press; MoveGesture::left_press is their only click rule; a selection drag that ends where it began cancels 2026-11-15 23:33:58 +00:00
aiongg 01199ba26e tfix4-f6d: format the fill trial 2026-11-15 22:04:53 +00:00
aiongg 5cabd08694 tfix4-f6d: FormDialog::opening is the host's Reset baseline in every pass; HostedAdjustDialog::seed moves it, so Reset returns to the last seed 2026-11-15 22:04:30 +00:00
aiongg 245f0dba01 tfix4-f6d: FullWindowWorkspace::closed runs on every close of a hosted workspace; Content-Aware Fill stores its settings there only 2026-11-15 22:03:17 +00:00
aiongg eb1aa98b2b tfix4-f6: HostedAdjustDialog::json_form lists the value's automation fields in the app's form (the command's params), with the edited signal 2026-11-15 21:43:01 +00:00
aiongg ebe44b9779 tfix4-f6: HostedAdjustDialog::edited is the dialog's edit signal (editor, Reset, field sets, value_mut); seed replaces the value without one 2026-11-15 21:40:51 +00:00
aiongg 4f7cf0bbfb Merge branch 'area/fwb2-f3' into area/fwb2 2026-11-15 17:02:15 +00:00
aiongg 55fd41e76c tfix3-f3: one held OK (HeldAnswer) for every hosted family: HostedParamDialog and HostedWorkspace use it, HostedAdjustDialog gains held_ok/take_ok/answer_ok 2026-11-15 17:01:32 +00:00
aiongg 80e47af962 tfix3-f4: hit reach read, snap kinds, warp frame, fill expand/contract, finite pointer requests, pen host end, exact right-angle cap, empty tone channels 2026-11-15 16:58:16 +00:00
aiongg 189783bde2 imaging, draw: Wide Angle undo/redo methods, lasso replaces_selection, Delete Anchor segment drag, vanishing point writes queue Planes/Stamp Set 2026-11-15 14:37:28 +00:00
aiongg f696f22deb fwb2-fix: remember for Content-Aware Fill and Liquify, Liquify redo depth
(cherry picked from commit 4848ca7f70f9455979824b47876adbaa3696f0bb)
2026-11-15 12:06:39 +00:00
aiongg 1b18c0b443 imaging select trials: injected input passes through the press arena as a hand's does
- marquee drag: the first move goes past the slop before the sub-pixel moves; the release elsewhere is a move there first
- lasso Alt clicks: Alt stays down across presses and releases, so the trial uses the hand's pointer and keyboard
- magnetic jump: the canvas is wide enough that the jump ends over it
- magnetic close on the start: the pointer reaches the start along the edge
2026-11-15 10:46:10 +00:00
aiongg 83b8649a7d R76: tool-host injection rides the window host's injected lanes
ToolHost::inject hands each ToolInput to the window host's injected lane of the
canvas's viewport, one step per pass: presses, moves and releases as egui
pointer events (InjectedPointer), carrying the pen's reading, which the step's
pass reads in place of the tablet's; Hold/LetGo as steps with no event that the
lane holds (WindowHost::inject_hold, inject_let_go, injected_holds). The tool
reads its input from the canvas's press and the pass pointer as for a hand's,
so the Color HUD, hover and egui's button state see injected moves.

Held keys end where the lane drops input (withdrawal, focus loss, cancel, end
of the session). A held key's momentary command applies to the whole pass, as
the real key's does.

Removed: HostState.queued and injected_held, WindowHost::inject_pass and its
trial, the injected gesture path in the host (Active.injected, Run::injected,
pick_momentary), Momentary::press, ToolInput.clicks.

Trials: the injection trials run until injected_idle; new trials for a held
Space ended by a cancel, an injected pen reading, and the Color HUD picking at
an injected move.
2026-11-15 10:32:47 +00:00
aiongg 14d5ec609a cargo fmt 2026-11-15 10:23:21 +00:00
aiongg 3238d9187e batch 1: ToolHost::cancel callers use a host value (R59) 2026-11-15 09:21:30 +00:00
aiongg c43ad9b0b2 tools-w3: net change of 5 commits
- tools-w3: written by an agent
- tools-w3: review fixes (review-1)
- tools-w3: canvas_space reads the env's view, the cylinder body copies its result before the cursor call, the upload trial reads the first delta of a texture (combine)
- tools-w3: the ants trial compares a reduced copy's band ends with the full-size selection's on a canvas the room holds; the monitor trial clears the deltas it reads; the stretch trial counts the narrow column's samples on a low layer (tools run round)
- tools-w3: the cylinder story names its drive, a drag of the Wrap handle, as the perspective and pin stories do (top run round)
2026-11-15 04:46:08 +00:00
aiongg 4ff83a83e2 dialogs-w9: net change of 5 commits
- dialogs-w9: written from its sheet
- dialogs-w9: repair 1
- Integration: imaging's trial list keeps dialogs-w17's raw_develop beside color_range
- dialogs-w9: review fixes (review-1)
- dialogs-w9: the color range trial's proxy is large enough that the preview fits it to the well inside the zoom range (top run round)
2026-11-15 04:46:08 +00:00
aiongg 74322a79a9 dialogs-w6: net change of 4 commits
- dialogs-w6: written by an agent
- dialogs-w6: tone panels import the command traits (combine)
- dialogs-w6: review fixes (review-1)
- dialogs-w6: the compare swatch's current half sets the opening colour with its model values (dialogs run round)
2026-11-15 04:46:07 +00:00
aiongg 5a6839a3b3 dialogs-w18: net change of 9 commits
- dialogs-w18: written from its sheet
- dialogs-w18: repair 1
- dialogs-w18: the grading tail reads dialogs-w17's blending and balance words; zone memory arms are statements (combine)
- dialogs-w18: review fixes (review-1)
- Integration: a kept binding with nothing stored reads its reset value
- dialogs-w18: review fixes (review-1): the mixer tab is a kept binding
- Integration: a component reads its running gesture's start value
- dialogs-w18: tone-zone drag reports absolute values (item 2)
- dialogs-w18: a mixed tone-zone value steps and drags from the zones' reset values (dialogs run round)
2026-11-15 04:46:07 +00:00
aiongg 6487acdbf4 dialogs-w17: net change of 11 commits
- dialogs-w17: written by an agent
- dialogs-w17: mod line for its raw_develop trials (combine)
- Integration: the Camera Raw workspace calls dialogs-w18's preview helpers as written (lab readouts, held clipping mask) and the sampler marks' carried prop; step events taken before queueing (combine)
- dialogs-w17: the curve splits' word, named after its settings field as the naming rule gives (combine)
- dialogs-w17: the settings side clones the reset value per pass (combine)
- dialogs-w17: review fixes (review-1)
- dialogs-w17: review fixes (review-1): the edited mark uses the catalog's filled circle
- dialogs-w17: Before is a momentary command, so its release shows the developed picture again; the trial's pictures report their changes (dialogs run round)
- Integration: a layer opened inside a modal family shows in the family's tier
- Integration: windows.rs keeps dialogs-w11's trials beside the full-window layer trial
- Integration: note_activated keeps canvas-widgets-w11's closed-layer walk over the tiered drawing stack
2026-11-15 04:46:07 +00:00
aiongg 66eb6af5e7 dialogs-w12: net change of 2 commits
- dialogs-w12: written by an agent
- dialogs-w12: review fixes (review-1)
2026-11-15 04:46:07 +00:00
aiongg b0fc3a6521 dialogs-w10: net change of 5 commits
- dialogs-w10: written by an agent
- dialogs-w10: fill issues resolve their label through the env's view (combine)
- dialogs-w10: review fixes (review-1)
- dialogs-w10: review fixes (review-1): Props import
- dialogs-w10: liquify's command loop borrows the view per call, so the Preview command can toggle through set_preview (combine)
2026-11-15 04:46:07 +00:00
aiongg b8cbaab7fa dialogs-w11: net change of 7 commits
- dialogs-w11: written by an agent
- dialogs-w11: finished by an agent
- dialogs-w11: measure_layer takes Overlay::full_window (combine)
- dialogs-w11: BrushWorkspace's queue is visible to its trials (combine)
- dialogs-w11: review fixes (review-1)
- dialogs-w11: the held-OK trial reads one tree for the shown and disabled checks (dialogs run round)
- dialogs-w11: a resizable window takes its default or content size only to open (dialogs run round)
2026-11-15 04:46:06 +00:00
aiongg f83986ad4b canvas-widgets-w3: net change of 9 commits
- canvas-widgets-w3: partly written (run interrupted)
- canvas-widgets-w3: partly written (run interrupted)
- canvas-widgets-w3: partly written (run interrupted)
- canvas-widgets-w3: written by an agent
- canvas-widgets-w3: review fixes (review-1)
- Integration: canvas trials keep canvas-widgets-w10's split module
- canvas-widgets-w3: the drag's snap reads the press bounds alone, so the release can take the gesture (combine)
- canvas-widgets-w3: the ruled guides trial shows its canvas in a room that holds the bounds, so its releases land on the canvas (fwcw round 3)
- canvas-widgets-w3: review fixes (review-tl-1)
2026-11-15 04:46:06 +00:00
aiongg 0e216b6257 Contract stubs: decision pass 2026-11-14 16:07:24 +00:00
aiongg 117cdbd9ca Contract stubs: craft-update, craft-menu, craft-imaging, craft-color 2026-11-14 02:28:16 +00:00
aiongg 5f7fd84ac8 wip 2026-11-14 02:21:14 +00:00
aiongg 23c4885d2a wip 2026-11-14 02:17:33 +00:00
aiongg be927e9393 Dialogs: hosted forms for Canvas Size, About, format options, Export As, Alert, Layer Style and the adjustment dialogs
Each opens on a DialogHost as a StackDialog that owns what its dialog edits
and binds the dialog's open state to its own field, so it opens again after
closing. HostedCanvasSize and HostedImageSize share SizingOutput::hosted.
HostedExportAs keeps its preview and save requests for the app as
HostedSaveForWeb does; HostedAbout keeps the activated link. HostedAlert
holds an Alert's content. HostedLayerStyle frames the Layer Style body in a
form dialog with side buttons and the Preview box, and queues the page's asks
as LayerStyleAsk. HostedAdjustDialog<V, E> frames any adjustment editor the
same way, resizable and remembered for Curves, with the editor's asks as E.

Stories open the hosted dialogs through a story host bound to the card's
open value (dialog::stories::hosted), so the card holds them behind its
button and story-render shows them open. Trials open each on a DialogHost
and check Escape, OK and the asks.
2026-11-13 02:26:58 +00:00
aiongg ac54d1bf29 CurveEditor trial: the fields and the hint show under the graph inside the editor's area 2026-11-12 14:32:47 +00:00
aiongg 364271a8db Trial: ThresholdEditor in a disabled scope takes no edit from its slider 2026-11-12 14:32:44 +00:00
aiongg 9a2b60fd7f ContourField: the thumbnail asks for the Contour Editor, the arrow opens the presets
PresetPicker's edit_face replaces the Edit Contour... button.
2026-11-12 14:32:44 +00:00
aiongg 2519fe36ee A canvas with a view is its body's scroll owner: the page keys a focused control in it leaves scroll the view as its own do, with their modifiers, and focus arriving at a control or part off a scroll owner's view brings it into view by the smallest move, every owner passing on the part it shows
ContainerProps::scroll_owner declares an owner without a scroll region; Canvas::view sets it. ScrollMoves keeps the move's modifiers, Intents::take_move_where is the one move taker (take_scroll_move goes; BezierOverlay leaves lead Page moves untaken through it), Focus::take_scroll_moves and Focus::take_reveal serve a declared owner, and settle reveals a focused part's rect. The reveal fallback goes to scroll regions only, so a layer over a canvas reveals nothing into it.
2026-11-12 14:32:43 +00:00
aiongg 8331defed5 Blur Gallery pins leave a Cmd press to the host and report it as ignored_press
The pins are a canvas control (a component with parts in the canvas body), not a CanvasTool: their presses never pass through the ToolHost, so ToolAction::Ignored can't carry this one. The output reports the press with the same ToolPointer that ToolHostResponse::ignored_press uses, for the app's tool.
2026-11-12 14:32:42 +00:00