Commit Graph
78 Commits
Author SHA1 Message Date
aiongg f647f41e82 Merge branch 'dl/api' into dl/all 2026-11-16 13:39:11 +00:00
aiongg fbe5a16ffe design-lint: api/non-exhaustive: #[non_exhaustive] on public types and variants, constructors where other crates build them 2026-11-16 13:31:29 +00:00
aiongg af3758b54e design-lint: contract/egui-widget: the comp comment tip is a Text 2026-11-16 13:23:38 +00:00
aiongg 2b3056407b merge-fwd: item 5: FW15 trial: wheel to the list's end in steps as its extent grows; the selected filter, the list's lead, is out of view after scrolling up 2026-11-16 12:57:21 +00:00
aiongg 54f9aa1b0d merge-fwd: item 5: FW15: the mock counts sub_rows calls; trial: a long layer list asks only for the rows in view 2026-11-16 12:43:51 +00:00
aiongg f1f0333a5b Merge storytold next into the framework branch 2026-11-16 01:01:38 +00:00
aiongg 6d3560a158 panels-w25: net change of 3 commits
- panels-w25: written by an agent
- panels-w25: the drag payload copies the document id into its closure (the payload map is 'static + Sync)
- panels-w25: review fixes (review-1)
2026-11-15 09:18:08 +00:00
aiongg 6e122e4c38 dialogs-w3: net change of 1 commits
- dialogs-w3: written from its sheet
2026-11-15 04:46:07 +00:00
aiongg e89d434cc1 framework-01-w2: net change of 7 commits
- framework-01-w2: repair 1
- framework-01-w2: RowStyle and ShapeTokens::rows go (size.rs, lib.rs rows of the sheet)
- framework-01-w2: list rows: option rows rounded, others square; layer rules in every theme (show.rs row of the sheet)
- framework-01-w2: review fixes (review-1)
- framework-01-w2: review fixes (review-1, files the rulings name)
- framework-01-w2: the escaped-sweep trial follows the sweep rule: only the eyes it switched are restored (fw01 round 2)
- framework-01-w2: a drop past the last item in reading order lands at the end, in every layout (fwcw round 3)
2026-11-15 04:46:05 +00:00
aiongg ac056667b1 panels-w10: review fixes (review-2) 2026-11-14 17:56:01 +00:00
aiongg 429fe0321a panels-w10: review fixes (review-1) 2026-11-14 17:56:01 +00:00
aiongg 0780608ff2 panels-w10: written from its sheet 2026-11-14 17:56:01 +00:00
aiongg a6dc55e4ed Gallery overview tests: classify the OS appearance source for the measuring-run guard, list the Layers panel's own stories before its filter stories, open a hosted dialog story in the dialog trial 2026-11-14 16:22:31 +00:00
aiongg 0e216b6257 Contract stubs: decision pass 2026-11-14 16:07:24 +00:00
aiongg 2b5de84828 Design lint: layer the env values, route egui access through the adapter, derive setters, token and relation checks in tests
The gate's design-lint test finds nothing. Env value types (pane edge, column align, row pressed, in-bar), band fill and span live in the layer that uses them; the cursor image and inside label are read back by the higher layer. Hand setters become derived props, tests assert relations, and the remaining sites are listed exceptions with reasons. The shortcut chord chip's sample is built only for screen tests.
2026-11-14 05:05:04 +00:00
aiongg b12d6387c5 Contract stubs: craft-automation, craft-layers, craft-font-manager, craft-timeline, craft-print 2026-11-14 02:34:37 +00:00
aiongg a17171af48 Lints: drop the workspace missing_docs lint and warn on it in the framework crates that document every public item 2026-11-14 00:15:29 +00:00
aiongg 0748cf6634 FW-263 review: a list trial for the multi-click selection rule; a triple thumbnail click that selected acts once; the hold comment names keeps_pick 2026-11-13 01:30:21 +00:00
aiongg 4b607c829d Lists: a later click of a multi-click on a selected row keeps the selection the first click left; Layers: a double click's selection names its thumbnail part
A double click on a Smart Filter row reported its Activate on the second press and narrowed the selection on its
release, after the app had opened the filter's editor. A double click on a fill thumbnail reselected the row with no
part, which targets a fill layer's mask.
2026-11-13 01:30:21 +00:00
aiongg ff3638f870 Lists: stacking keys move the rows a drag takes; a held release asks for its pass
key_reorder takes the rows acted_on names, so a stacking key on a selected sub-row moves that sub-row and not its
row. While a press holds a release for a later pass, sensing asks for a repaint, so the release goes out in the next
frame without new input.
2026-11-12 22:02:35 +00:00
aiongg 70dfca7f24 Lists: a drag or Delete of a selected sub-row takes the selected sub-rows only
A sub-row belongs to the row above it, so a gesture on one acts on the selected rows of its own kind. The Layers
panel keeps a Smart Filter row selected beside its layer; a drag of that row carried the layer too, and the drop
rule refused the mixed set.
2026-11-12 22:02:35 +00:00
aiongg bbd51b2db0 Press machine: a press reports its phases in order, one per pass
A release in a pass that still owes the press's Down or DragStart is held for the next pass, with its click
state taken when the button went up. Two clicks in one frame, which the one-press rule splits into
[P1], [R1, P2], [R2], report Down and Activate for both clicks.
2026-11-12 22:02:35 +00:00
aiongg 2f7593cbbb layers: a double click on a thumbnail activates it once 2026-11-12 20:37:37 +00:00
aiongg fd03f1725f Layers: an adjustment layer's row icon is the adjustment_layer glyph, as in the footer and the filter 2026-11-12 17:33:40 +00:00
aiongg 73e652fd7f Layers: small touching lock buttons, small filter toggles, typed thumbnail badges
The Lock row's five buttons are small (ControlSize::Sm) and touch, as Photoshop's, so Fill and its
field stay on the row at a panel's width instead of wrapping below it. The Kind filter toggles are
small too.

LayerInfo::thumb_badge is a ThumbBadge (SmartObject, Shape) that craft-layers paints: a window glyph,
or a path with an anchor on each corner. Kind and mask badges share one badge box, a field well at
the small icon size in the thumbnail's corner.
2026-11-12 17:18:25 +00:00
aiongg ca5cc4ff06 Layer content runs outside its opener's label scopes
A tooltip shown from a field's control recorded its text line in the
field's label scope, so the side label lined up with the tooltip and
dropped under the next row. The overlay host now runs a layer's body
outside the open label and merge scopes.
2026-11-12 16:45:18 +00:00
aiongg bf99b186ec Rows: no divider under a collection's last row; the Effects header shows no icon
Dividers fall between rows (RowState::last), so a list's last row no longer
draws a rule beside the footer bar's. Photoshop's Effects header shows only its
eye and label; the mock sets no icon and SubRow::icon no longer names one.
2026-11-12 15:59:54 +00:00
aiongg cf928885f8 Layers: the row's effects badge is the fx icon
A list row paints a trailing drag handle's icon face as a mark, not an icon
button: a handle has no node of its own (the row's description names it), and a
button face would add an unnamed button.
2026-11-12 15:59:54 +00:00
aiongg d6ef780c79 Layers: a story with the effects and Smart Filters open 2026-11-12 15:59:54 +00:00
aiongg 5334392883 Layers: effect and Smart Filter sub-rows as Photoshop shows them
A source marks a sub-row with its indent steps (ItemSource::sub_row). The row is
compact, its eye column empty, and its toggle cells sit in its content at that
indent (sub_row_cells): one step past the layer for the header, two for an item.
Presses flip them there and a sweep down the eye column passes them by. No divider
falls between a row and the sub-rows that continue it (RowState::continued).
The mock's Effects header carries the sparkles icon.
2026-11-12 15:59:54 +00:00
aiongg 18262420d5 Lists keep a hidden document's scroll position: the read step no longer clamps the kept offset against the evicted last extent
A collection kept its offset in session memory but the last pass's extent in
shown memory. While another document showed, the hidden list's shown memory was
evicted, the extent read back as 0, and the read step clamped the offset to 0.
Every later step already clamps against this pass's content, so the read-step
clamp and View.extent go.
2026-11-12 15:48:42 +00:00
aiongg ac9dd13cdc Toggle columns: one width from the toggle-column mechanism, a control and the inline gap (ColumnWidth::Toggle, ColumnSpec::toggle) 2026-11-12 15:42:15 +00:00
aiongg 93651d8505 Icon catalogue: adjustment layer as a half-filled ring, a filled layer-mask dot, an italic fx, a plain folder for new_folder, and link_layers as the horizontal chain the Layers panel uses 2026-11-12 15:23:58 +00:00
aiongg 51efda762e Panel options: thumbnail size samples take their own size role
The samples beside the thumbnail size choices of a panel's options dialog (Layers, Channels, Paths) are larger than the
panel's own thumbnails, so the three choices read apart. They take `size.thumb.sample.{sm,md,lg}`: 36, 48 and 96 in
Compact, 36, 68 and 96 in Comfortable (twice the row thumbnails, as the old dialog drew them; PhotoCraft draws 38, 68
and 96). A Picture shows one through `PictureSize::Sample`, and the Layers options dialog's samples use it.
2026-11-12 15:12:11 +00:00
aiongg f7f75c178f Sizing::FillWidth makes a leaf fill its row's leftover room
Component::fills defaults to the width when the caller set Sizing::FillWidth,
and the sizing stays on the component after step 1 so the layout hooks read
it. Button, TextField and Slider lose their fill_width props and Swatch and
GradientSwatch their fill flags; callers set Sizing::FillWidth. The blend
select in BlendRows takes the room before Opacity, as in PhotoCraft.

A contract trial checks that a FillWidth leaf takes the row's room and a
Content leaf does not.
2026-11-12 15:12:10 +00:00
aiongg 5468aa82ac Layers header and panel controls take the scope's control size
BlendRows, LayerFilterBar, the scopes refresh button and the wide-angle Add
constraint button no longer fix the small size, so they show at the size
their scope gives (Md in a panel), as PhotoCraft's header controls do.
2026-11-12 15:12:10 +00:00
aiongg 009eafedae LayersPanel::reveal takes the app's rule for closed groups: Groups::Open or Groups::Keep
Groups::Open opens the layer's closed groups and scrolls its row into view; Groups::Keep opens
nothing and scrolls to the row of its outermost closed group, the row that stands for the layer
(PhotoCraft's Move tool pick with "expand group on click" off).
2026-11-12 15:12:10 +00:00
aiongg 74e6a26b18 A List reveal places the row by measured heights; the Layers panel reveals what the app names, per document
A reveal (requested, key move, page switch, type-ahead, rename) scrolled by the item layout's
extents, in which rows no pass built yet have the estimate. The rows the pass then built took
their measured heights and pushed an auto row taller than the estimate out of view. The List
now aims the reveal in the content step, before it builds the rows: it builds and measures the
auto rows that will share the view with the revealed row, up to it, that have no kept height,
and aims again until the row is placed by measured heights. The build takes those measures and
does not measure the rows again, and the frame runs once. The per-row measure is shared with the
widest-row measure.

LayersPanel no longer compares the active layer with the last pass's (Session.seen_active and
the auto-reveal go): the app calls reveal(layer) in the pass its active layer changes.
LayersPanel::document(key) keys the rows List per document, so each document keeps its scroll
position and lead.

Trials: ui-widgets List reveal past unbuilt taller rows (one pass, no row measured twice);
craft-layers panel_reveal (reveal with Open, row in view, per-document scroll, counts).
2026-11-12 15:12:09 +00:00
aiongg 46b0240050 Host tests find a list row's pointer-only parts from the row's node
craft-ui testing part_rect_of_node reads a part's rect from the shape record by the owner's
AccessKit node, the lookup Fixture::part_rect makes by id. ThumbTarget::part and TrailingPart::part
name a row's thumbnail and trailing parts; the row declares its parts through them.
LayerInfo::thumb maps a layer part to the thumbnail that shows it, over the order the panel
reads thumbnail clicks by, and craft-layers testing thumb_rect and fx_badge_rect give a host test
the rect of a layer row's thumbnail or fx badge. The drag, menu and frame trials find thumbnails
and the badge this way.
2026-11-12 14:52:31 +00:00
aiongg f3d0a4e2a1 Lists keep the host's selection when the lead's row leaves; a new Layers filter deselects what it hides
follow_lead_source moves the lead to the row now in its place and no longer
selects that row: a row that was deleted or filtered out is not replaced by its
neighbour. LayerFilter::deselect_hidden is the one rule for a newly applied
filter (Photoshop #10879); the panel reports it as a Select on its filter bar's
edit, and an app that sets the filter itself calls it there.
2026-11-12 14:52:13 +00:00
aiongg a3434176e4 Dialog bodies: the content sits directly in the dialog body, which is already a stack, so fill-width children take the dialog's width; the Tabs dialog's Position column is as wide as its field and Alignment and Leader share the rest 2026-11-12 14:32:57 +00:00
aiongg a5c5d1e497 A select in a bar fits its widest entry, up to a field length
A content-sized select, and any select in a bar, fits its faces: as wide as its widest entry and the chevron need,
with no field floor, and at most a field length, where a longer entry elides. Options bars sized every select to the
field length or kept a 96 pt floor, so the whole-or-nothing rule hid later members the bar had room for. The bar
selects that asked for content sizing themselves no longer need to; LayerFilterBar's type select, in a row of its own,
asks for it.
2026-11-12 14:32:52 +00:00
aiongg 3ffaa00ea5 craft-layers: the app chooses the filter types the Layers panel offers 2026-11-12 14:32:51 +00:00
aiongg 77a855fbcc craft-layers: a frame's mask thumbnail, after its content thumbnail, drags the mask (trial) 2026-11-12 14:32:51 +00:00
aiongg 8955294c83 Collections take an opt-in edge press; the Layers panel's Alt-click on the line between two layers clips
- List::edge_press(mods, test): while the modifiers are held, the band of the line between two adjacent rows the
  test gives a cursor for shows that cursor and takes the click (CollectionEvent::EdgePressed), picking neither
  row. The band reaches LINE_REACH from the line; a toggle cell keeps its press. Collections without it are
  unchanged.
- craft-layers: LayersEvent::ClipLine { upper, release } for an Alt-click on the line between two sibling layers,
  with the clip-below or clip-release cursor.
2026-11-12 14:32:51 +00:00
aiongg 0d82cf70b4 Row drags from any part, a text face for trailing parts, thumbnail cursors and the empty space's menu
- ListRow::part_drag(RowDragSpot, payload) replaces thumb_drag: a thumbnail or a trailing part drags instead of
  the row (RowEvent::PartDrag). A trailing part that drags is a handle: its click is the row's.
- TrailingFace::Strong: a text face for a trailing part.
- ListRow::thumb_cursor: the cursor over a thumbnail.
- CollectionEvent::EmptyContextMenu: a secondary click on a collection's empty space.
- craft-layers: the fx badge drags every effect of its layer onto another layer (a transfer, Alt copies) and a
  click on it selects the row; MenuTarget.row is None for the empty space's menu; the load-selection cursor over
  thumbnails while Cmd/Ctrl is held; LayerTree::label_colors_in_menu decides per target whether the row menu
  gets the Label Color submenu.
2026-11-12 14:32:51 +00:00
aiongg 1d2e5ae5bb craft-layers: the row menu of a layer row ends with the Label Color submenu, sharing the eye menu's colours
LayersPanel::row_label_colors turns it off. A thumbnail's menu and the effects and Smart Filter rows' menus have
none.
2026-11-12 14:32:51 +00:00
aiongg b4d2f8cdce craft-layers: a mask thumbnail dropped on another layer's row moves the mask there, Alt copies (LayerDrop::Mask)
The rows take the mask through the list's drop kind for the panel's drag payload. LayerTree::accepts_mask_drop
decides which layers take it; by default a layer takes a mask of a kind it does not have.
2026-11-12 14:32:51 +00:00
aiongg 9ba22550f8 craft-layers: LayersDrag is public, so an app's drop target (a document tab) reads the dragged layers 2026-11-12 14:32:51 +00:00
aiongg dfd1d30270 Layers panel: thumbnail badges at the small icon size
The mask badges and the app's thumbnail badge fill the theme's small icon size (size.icon.sm) within the thumbnail,
and the app's icon draws at the small glyph size (size.icon.glyph_sm), instead of a share of the thumbnail.
2026-11-12 14:32:51 +00:00