Commit Graph
59 Commits
Author SHA1 Message Date
aiongg 1d8c7d13a2 Merge branch 'fw/mac1-bars' into fw/mac1
# Conflicts:
#	crates/ui-contract/src/contract/body/hooks.rs
#	crates/ui-shell/src/shell/app_shell.rs
#	crates/ui-shell/tests/it/shell/app_shell.rs
2026-11-16 16:25:37 +00:00
aiongg 1cf223ebbc Merge branch 'fw/mac1-edges' into fw/mac1 2026-11-16 16:20:25 +00:00
aiongg b3124fb9f2 Gallery: docked bodies leave their padding to the dock group 2026-11-16 16:12:04 +00:00
aiongg 60bdf15129 ToolRail fits its slot: block padding, a rail-width column per column with the buttons centred, toggles on one line
ContainerProps gains pad_edges (PadEdges::Block pads top and bottom only) and LeastWidth::Rail
(size.rail.width per column). ToolRail pads only above and below, is at least its columns'
rail width wide, and centres its grid of buttons, so no button or corner mark reaches past the
slot. The column and side toggles share one header line as small control-glyph buttons that
touch, which fits two in one rail column. A container's child_size and child_glyphs reach its
header and footer as well as its body, so a rail's footer buttons show the rail's glyphs.
AppShell::tools takes the rail's column count, so a two-column rail gets a two-column slot.
2026-11-16 16:05:13 +00:00
aiongg cc00dbd368 Clippy and test-target lints: redundant must_use, type aliases for complex types, boxed large variants, argument structs, struct-update initialisers, deprecated egui calls, unused imports and dead code; the swatch library's reorder test runs as a trial 2026-11-16 02:30:55 +00:00
aiongg f1f0333a5b Merge storytold next into the framework branch 2026-11-16 01:01:38 +00:00
aiongg c8713d756a tfix3-f5: a tool command's key release fires it in the release phase (spring-loaded tools); framework tool pickers act on the press only 2026-11-15 18:58:20 +00:00
aiongg 19cd2e1762 commands: a story's command set (#[command(story)]) loads only in an install that shows stories (the gallery, the story fixtures), so its keys never take an app's 2026-11-15 18:28:52 +00:00
aiongg ef51284928 tfix3-f3: a hosted param dialog is instanced by its command key; take_keyed takes results of any instance (take keeps to uninstanced ones) 2026-11-15 16:56:45 +00:00
aiongg 617cc04932 Merge branch 'area/fwb2-f2' into area/fwb2 2026-11-15 16:34:59 +00:00
aiongg 450eba6c2d ui-patterns: hosted parameter dialogs open their values at open; custom rows declare companions and an opening value 2026-11-15 15:36:34 +00:00
aiongg 7fa10c107a craft-settings: reset and repair one value at a time, remove map entries the value drops, merge a missing section against its defaults 2026-11-15 15:21:21 +00:00
aiongg 14d5ec609a cargo fmt 2026-11-15 10:23:21 +00:00
aiongg 38a5547d45 hub-w1: net change of 1 commits
- hub-w1: review fixes (review-1)
2026-11-15 09:18:08 +00:00
aiongg b119a18735 canvas-widgets-w19: net change of 2 commits
- canvas-widgets-w19: written by an agent
- canvas-widgets-w19: review fixes (review-1)
2026-11-15 09:18:07 +00:00
aiongg db4828eaca framework-01-w1: net change of 4 commits
- framework-01-w1: written from its sheet
- framework-01-w1: review fixes (review-1)
- framework-01-w1: review fixes (review-1, files the rulings name)
- Integration: Cargo.lock line for w1's craft-settings dependency
2026-11-15 04:46:05 +00:00
aiongg a6dc55e4ed Gallery overview tests: classify the OS appearance source for the measuring-run guard, list the Layers panel's own stories before its filter stories, open a hosted dialog story in the dialog trial 2026-11-14 16:22:31 +00:00
aiongg 2b5de84828 Design lint: layer the env values, route egui access through the adapter, derive setters, token and relation checks in tests
The gate's design-lint test finds nothing. Env value types (pane edge, column align, row pressed, in-bar), band fill and span live in the layer that uses them; the cursor image and inside label are read back by the higher layer. Hand setters become derived props, tests assert relations, and the remaining sites are listed exceptions with reasons. The shortcut chord chip's sample is built only for screen tests.
2026-11-14 05:05:04 +00:00
aiongg eb01f1f302 Lints: slice iteration in gallery test, private token doc link 2026-11-14 02:08:38 +00:00
aiongg bcd543e017 Lints: ui-patterns tests, gallery, docx docs link 2026-11-14 01:36:21 +00:00
aiongg 7808f7f6d2 Lints: fix clippy, rustdoc and test findings (shadowed f32 module, unused import, private doc link, struct-update defaults, test attributes lost in the 13 Nov sync) 2026-11-14 00:15:29 +00:00
aiongg a17171af48 Lints: drop the workspace missing_docs lint and warn on it in the framework crates that document every public item 2026-11-14 00:15:29 +00:00
aiongg 27608b1da3 RootEnv: the theme is private with its definition; theme_id reads it, set_theme sets it in place 2026-11-13 18:36:52 +00:00
aiongg 477b080845 Title rows: a note runs on after the title in muted body text, and the subtitle sits at the band's end in muted caption text; the gallery card shows its story name as the note, the Inspector its target's kind as the subtitle 2026-11-12 14:32:50 +00:00
aiongg 2774b6010e Form-rows cards: the stories' column is as wide as its widest story and the values follow it, so each slider's value sits beside its track 2026-11-12 14:32:50 +00:00
aiongg 0a724a2342 FindReplaceDialog stories: built in the gallery (craft-text find feature), open bool, dialog kept while open 2026-11-12 14:32:49 +00:00
aiongg 47508315ef craft-ui-shell: public embed hooks for apps with their own eframe App
shell::embed holds install (runtime plus fonts), before_input, logic and
before_ui, and CloseDecision. app::run's Driver calls the same hooks.
runtime::keys::with_window_intents is public: the host's read of the
window-level keys no component took. docs/craft-framework.md 2.2
describes the recipe and what install takes over. A trial drives its
own frame loop through the hooks alone.
2026-11-12 14:32:46 +00:00
aiongg efc09443fa TransportBar centres its buttons and keeps the button editor at the end edge
Bar::align sets the body row's alignment; Bar::trailing gets the bar's body
context so an end-region group can read and write the state the body reads.
A centred or end-aligned row in a body that scrolls along x measures its band
from the view, as the shrink step does.
2026-11-12 14:32:46 +00:00
aiongg ee9aaf11eb EditorMock: show_at, and its stories fill a stage as tall as the room offered
A card sizes a filling story from its content, and the window's canvas has none.
EditorMock::show_at shows the window at a rect through AppShell::show_at; both
stories pass a stage of testing::room_height. The gallery's dock preview keeps show.
2026-11-12 14:32:45 +00:00
aiongg c8a092d0b5 EditorMock: the status bar as the old preview had it
The zoom and the chosen readout item, the colour mode, the layer count and the
mock's status message, and the CPU Rendering warning at the end. The message says
which tool was chosen and the size Image Size set, as the old mock's did. Uses
L04's StatusMessage.
2026-11-12 14:32:45 +00:00
aiongg 982734d240 EditorMock: a screen-mode binding and the Full screen story
The old gallery showed the mock app in the Canvas shell in Standard, Full screen,
Revealed and Right to left. Full screen is an EditorMock story over the shell's
screen_mode binding; right to left is the gallery's own direction switch.
2026-11-12 14:32:45 +00:00
aiongg 1e3d9345a0 EditorMock: the title bar as the old preview drew it
An integrated frame of the generic family with every caption at the end, the
hairline under it, and Search in the trailing group.
2026-11-12 14:32:45 +00:00
aiongg eef17642ba Toasts: one queue per window; each AppShell, embedded ones included, shows its own window's toasts at the end-bottom corner of its body (Anchor::Corner replaces Anchor::Viewport), so nested shells no longer each draw every card at the viewport corner; NoticeCenter posts to its window, and the NoticeCenter and ToastStack stories show three notices in their own area, as the old ones did 2026-11-12 14:32:44 +00:00
aiongg 0897874266 Every component takes one sizing setter: a leaf with Sizing::Content is as wide as its content, without its style's ideal width, and the selects the old gallery fitted to their entries are content-sized 2026-11-12 14:32:44 +00:00
aiongg 9777ba9c83 Rows, notices and gallery story columns derive their sizes from role tokens
A list row with a thumbnail is at least a standard control and the panel padding tall (the old
thumb_row_min), a centred notice reads about 38 body sizes wide, and the stage tokens become the story
stage (size.story), whose least width also sets the gallery's story columns. A gallery card is at
least a story and its padding wide, and its height guesses come from type and control roles.
size.thumb_row goes.
2026-11-12 14:32:43 +00:00
aiongg 03d2526deb Slider thumbs take the knob shape role and the control glyph size; component tokens removed
The slider thumb lengths were the only component tokens. A round knob is the control's glyph across
(StyleCx::glyph, shared with the icon-only button glyph); a tab knob is the control's icon side tall.
Themes choose the shape with shape.knob; Classic sets the tab, its old 10 x 16 thumb. TokenRef
collapses into ColorToken, and the theme file's components maps go.
2026-11-12 14:32:43 +00:00
aiongg 64d03f8ef9 Live tool stories: tool_story keeps the tool and the document it edits across passes and runs the tool on a canvas over the story picture; the selection tool stories run on it with a selection of combined shapes that starts round the house, the marquee kind and style and the magnetic options as story values, and a status line; the mock Move tool moves the current layer with MoveGesture 2026-11-12 14:32:42 +00:00
aiongg 476602d4a3 A filling story's card is as tall as its content, and content taller than the room shares it
Along a height its parent sizes from its content, a container that fills takes its content height, at most the
room it is offered. When the content is taller, the measuring run is taken back and the container is laid out as
given the room, so its list and the bar under it share it; a record of the content height lets later runs and kept
transcripts lay it out the same. room_height only offers a finite room inside a scroll: a gallery card is as tall as
its story's content, at most the view, as the old gallery's tiles were.

layout_memory::draft runs a measuring run whose hand-forwards can be taken back once its result is seen: records,
kept transcripts, the open transcript's items, leaves and inputs, and each contribution (Contribution::undo for
column widths, label control minimums and reads). steps::id::draft takes the Auto id ordinals back with it. The
shrinking row's least probe is a draft taken back that reads nothing from outside.

A scrolling collection that fills keeps to its measured height in the real run under a body sized from its content,
so a footer under it stays below its rows. The PlacesTree story keeps the old 380 pt box.
2026-11-12 14:32:40 +00:00
aiongg b3bd1897a4 Overview: a settled card repaints its last run
Each card sits in a settling Lazy inside its row: a settled frame of the
Overview runs no card. Lazy::settles notes that a settled reader needs a
binding that stays in place between frames.
2026-11-12 14:32:40 +00:00
aiongg af4791df71 Overview: a row out of view does not run
Each row of the Overview's grid is a Lazy child of the scroll body, keyed by
its cards and the column count, so only the rows in view run their Grid and
cards. The per-card Lazy goes. A card's Panel takes its id from the card's
key, so a change of the column count keeps each card's state.

Trial: a settled pass of a short view runs as many Grids for the whole
Controls level as for a filter that lists the same cards in view.
2026-11-12 14:32:40 +00:00
aiongg 0e9ca32073 Story readouts: a line under the story in the old stories' words
StoryOutput::readout is a line a story words about what it shows or what last happened in it;
the gallery card shows it, muted, under the story in every layout. StoryData::note keeps what a
readout needs (last event, click count) outside the story's values, so drives and Reset compare
values only. The old readout lines come back for ColorWheel, ColorPicker, SwatchPalette and
SwatchTable, GradientPalette, TipEllipse, the symmetry canvas stories, LutPicker, ColorChoice,
Swatch, LayersPanel, MediaBin, ChannelsPanel, ToolRail, StrokeEditor and StrokeButton.
2026-11-12 14:32:40 +00:00
aiongg eb850635e7 Gallery card: the start Reset compares with is noted after the story's first real run
A pass that took a kept measurement, ran only the measuring run or held the story back
noted an empty start, so every value the story made counted as a change and Reset showed
at rest on most cards of a level (ToggleButton, TipEllipse, CompareTile, CurvesPanel, ...).
2026-11-12 14:32:40 +00:00
aiongg 0bb46ce6e8 Gallery card: CardEvents carries the card's rect again, which story-render --card crops to 2026-11-12 14:32:40 +00:00
aiongg c427e539c3 Bars: rules between groups, faint hints and the options bar's Home and tool icon
A Divider::vertical() is the bar's one section break: the connector,
shape and eyedropper bars, the about dialog's controls and the status
story place it where the old bars did. Hints use the faint shade.
BarHome and BarTool are the parts an options bar starts with. A
captioned control in a bar is a Field; BarCell goes.
2026-11-12 14:32:40 +00:00
aiongg 037df036e0 Gallery inspector: inspected regions, the Inspect panel and the overlay over the selected card
inspect::record shows a region and records, in real runs, every component shown in it (box, box inside its padding,
depth, and the access facts step 16 wrote, named by their labels as a screen reader reads them), the sensing core's
hit areas of those components at their least size in tree order, and the focus stops numbered in Tab order: every
member of a roving group, whatever the platform's Tab setting. Inside a region nodes are reported whether or not
AccessKit runs. The record is kept as a value: a reader shown earlier in the pass (inspect::recorded,
inspect::pointed) reruns the pass when the record changes. Recording is on in fixture frames and inside an open
region; FrameInput.inspect and the focus state's all_controls go.

InspectOverlay (display) draws a record as the old gallery inspector did, cut to the region: padding bands, hit
areas with small ones flagged, numbered focus badges, and a marquee on the element the list points at.

Row, Stack and Grid take indent(levels), a start padding of space.pad.regular per level, and hover(), which gives
the root Sense::HOVER so its response reports the pointer. Text takes italic().

While the Inspect panel is in front of the components workspace and no Variants view is open, the selected card of
the Overview or of the selected component's tab shows each story as an inspected region with the overlay over it.
The Inspect panel lists the Padding, Hit areas and Focus order switches, the flag note, one section per story with a
row per element (number, role, name, value, actions, state, "no label"), indented by depth, whose hover marks the
element on the card, and the declared facts as the last section.
2026-11-12 14:32:40 +00:00
aiongg 939a80c85a Collection keys: type-ahead is a collection setting, off for lists
CollectionProps::type_ahead decides whether typed letters move the lead; the key role
reads it instead of turning type-ahead on for every collection, so a focused list leaves
single-letter tool keys to the app. Popup option lists, the hyperlink place list and the
gallery's component and token lists turn it on. The suite's type-ahead case runs where
the focused stop takes type-ahead.
2026-11-12 14:32:39 +00:00
aiongg 306fef9a38 Value controls take the wheel only while focused or armed
A value control takes the wheel only while focused or armed, on the axes
it senses. WheelScope replaces the wheel_gated scope: Free lets the
sliders of an adjustment dialog take the wheel without focus, and Gated
(the Overview card) gates every taker and wins over a Free inside it.
Slider senses the vertical wheel only; RangeSlider and ThumbRow sense no
wheel bits; PointPicker and AngleDial sense both scroll axes.
2026-11-12 14:32:39 +00:00
aiongg 72a8204117 Gallery: the Foundations level with Colours and EditPolicy
Colours shows every semantic colour role of the card's theme by group, as a
swatch, its path and its hex value. EditPolicy binds a slider and a text
field to one of two documents under a write-through or on-commit policy,
logs their edit events, and its Undo and Switch document buttons cancel a
running gesture through cancel_all. Types of the gallery's foundations
module are Foundations, the first level listed.
2026-11-12 14:32:39 +00:00
aiongg 543ab4236e Overview: selecting a component glides its card to the top
Lazy::reveal asks its scroll body to glide until the child starts at the
view's start, run or not; the body follows the child's place on the motion
service's follow curve and a move of its own ends the glide. It replaces
Lazy::keep. The gallery's Overview passes the selected card's reveal in the
pass its cards follow the selection, in place of egui's scroll_to_rect,
which no scroll body reads.
2026-11-12 14:32:39 +00:00
aiongg f494e40237 story-render --card: render whole Overview cards through the gallery's own card code
overview_card builds an Overview card's Spec from the catalog alone and Spec::card turns it into the Card the
Overview shows; the Overview uses both. story-render --card renders one selected card per story group, the given
width wide, in a one-column grid row in a vertical scroll as the Overview holds its cards, inside the one shell the
bin runs everything in, with its dialogs open. --scale sets the images' pixels per point (1 matches the old gallery's
shots) and stories.tsv lists it. cl render passes both through.
2026-11-12 14:32:39 +00:00