Commit Graph
55 Commits
Author SHA1 Message Date
aiongg b1766bb698 Merge remote-tracking branch 'upstream/next' into fw/mac1 2026-11-16 19:42:31 +00:00
aiongg 3829737b47 Trial: the stacked parameter layout stacks sliders and puts the buttons across the foot; Below keeps the button column 2026-11-16 16:42:19 +00:00
aiongg 2103be6de1 Fix clippy and rustdoc errors in automation, draw, imaging, svg, ui-patterns and ui-widgets 2026-11-16 15:40:46 +00:00
aiongg 63a4811416 cargo fmt 2026-11-16 14:34:57 +00:00
aiongg fbe5a16ffe design-lint: api/non-exhaustive: #[non_exhaustive] on public types and variants, constructors where other crates build them 2026-11-16 13:31:29 +00:00
aiongg 4119da5b95 Merge branch 'fw/merge-d' into area/fwb2 2026-11-16 12:57:54 +00:00
aiongg 259fc8e0bc merge-fwb: FW13: param rows report range alerts; Global Light angle range and whole degrees; SliderField reports its field's range alert 2026-11-16 12:48:38 +00:00
aiongg 1b67b7c8b2 merge-fwb: FW7: format 2026-11-16 12:48:38 +00:00
aiongg c081a17fed merge-fwd: item 6: Export As suggests names with their boundary spaces and dots; ExportAsDialog/HostedExportAs files(count) asks for a folder for several files; trials 2026-11-16 12:42:49 +00:00
aiongg a635457fa0 merge-fwb: A13: blend row keys step past greyed modes, a greyed mode's letter picks nothing (#13852) 2026-11-16 12:39:46 +00:00
aiongg ab7c3c712c merge-fwb: FW7: a claimed key press takes its text; Image Size Alt+1..8 pick Resample (#15054) 2026-11-16 12:39:46 +00:00
aiongg 862486453d merge-fwa: FW7: Image Size readout counts whole-byte rows of the flat image and says (was …) only after a size change 2026-11-16 12:31:40 +00:00
aiongg e5e4c1cd2e merge-fwa: FW6: Export As Scale All rows (one file per size, folder for several), Enter does not export, Convert to sRGB on by default as a Color Space check box 2026-11-16 12:31:40 +00:00
aiongg 9befcd2612 merge-fwa: FW5: New Document Bitmap (1 bit, no Transparent), Pixel Aspect Ratio row, Web/Mobile cards turn Artboards on, Save Document Preset icon and pane 2026-11-16 12:31:40 +00:00
aiongg cc00dbd368 Clippy and test-target lints: redundant must_use, type aliases for complex types, boxed large variants, argument structs, struct-update initialisers, deprecated egui calls, unused imports and dead code; the swatch library's reorder test runs as a trial 2026-11-16 02:30:55 +00:00
aiongg b171283050 fmt 2026-11-16 01:01:56 +00:00
aiongg 9b93aacce2 tfix5-f11: number rows follow a shared Units choice (Param::number_in_units); HostedPrint::json_form; the preview is named Print preview image 2026-11-16 00:44:29 +00:00
aiongg 009c18cece tfix5-f9: Reset restores the opening values with reset_to's over them; keys added since the open go 2026-11-16 00:16:34 +00:00
aiongg 1b13399c08 tfix5-f9: a ParamDialog whose preview pane centres on clicks passes a primary press on its canvas: the image is the pane's locator 2026-11-16 00:16:33 +00:00
aiongg e49acf5414 tfix5-f9: Param::resets: changing a row's value through the row, automation or a host answer removes the keys of the rows that depend on it 2026-11-16 00:15:54 +00:00
aiongg 20e969d9f6 tfix4-f6d: ParamDialog::previews declares the Preview box; HostedParamDialog keeps its value, so is_previewing holds from construction 2026-11-15 22:02:17 +00:00
aiongg b5448ade93 tfix4-f6: trial: a hosted param dialog lists its opening fields and takes a set before its first pass 2026-11-15 21:53:46 +00:00
aiongg a4176ef04e tfix4-f6: HostedNewDocument opens its settings at construction (ctx in new); a host-opened dialog's first pass keeps them 2026-11-15 21:32:41 +00:00
aiongg 84bb213705 tfix4-f6: HostedFormatOptions opens its fields at construction (ctx in new), so they list and take sets before the first pass 2026-11-15 21:32:41 +00:00
aiongg e390c0dba2 tfix3-f3: rustfmt 2026-11-15 17:01:49 +00:00
aiongg ef51284928 tfix3-f3: a hosted param dialog is instanced by its command key; take_keyed takes results of any instance (take keeps to uninstanced ones) 2026-11-15 16:56:45 +00:00
aiongg 0bf5367096 ui-patterns: trials for the JPEG quality row and New Guide's unparsed OK 2026-11-15 15:36:35 +00:00
aiongg 450eba6c2d ui-patterns: hosted parameter dialogs open their values at open; custom rows declare companions and an opening value 2026-11-15 15:36:34 +00:00
aiongg 2bc5fd1782 tfix-dialog: a held OK is a state the host reports (HeldOk), and confirm finishes an accepted one
StackDialog::held_state / DialogHost::held_state tell a filed OK (Waiting), an accepted one and a refused one
apart from a refused confirm. HostedParamDialog and HostedWorkspace answer confirm with the accepted held answer;
Export As and Save for Web confirm without a path ask for the save dialog as their buttons do. ui.dialog.confirm
does not report a filed held OK as a refusal.
2026-11-15 14:26:31 +00:00
aiongg 28b664b417 fwb2-fix: Export As resample list and title
(cherry picked from commit a36669c7d77d92ef4421306081582fbc56c3c522)
2026-11-15 12:06:39 +00:00
aiongg 14d5ec609a cargo fmt 2026-11-15 10:23:21 +00:00
aiongg 20e0bcf93b dialogs-w2: net change of 3 commits
- dialogs-w2: written by an agent
- Integration: ParamRows keeps dialogs-w1's preview_colors beside the patterns rows (dialogs-w1 7a195af4a)
- dialogs-w2: review fixes (review-1)
2026-11-15 04:46:07 +00:00
aiongg d3257f265a dialogs-w15: net change of 7 commits
- dialogs-w15: written from its sheet
- dialogs-w15: repair 1
- dialogs-w15: trials build the non-exhaustive SaveForWebOptions from its default (combine)
- Integration: craft-color's re-export and panels trials take SwatchTable from craft_ui::choice (panels-w7 and panels-w6 requests, done here so the area compiles)
- dialogs-w15: review fixes (review-1)
- dialogs-w15: review fixes (item 3)
- dialogs-w15: the palette trial selects the Optimized pane, whose palette the Color Table shows (dialogs run round)
2026-11-15 04:46:07 +00:00
aiongg e6e7d2183c dialogs-w14: net change of 3 commits
- dialogs-w14: written by an agent
- dialogs-w14: trials build the non-exhaustive ExportOptions from its default (combine)
- dialogs-w14: review fixes (review-1)
2026-11-15 04:46:07 +00:00
aiongg 51b41ec6df dialogs-w4: net change of 7 commits
- dialogs-w4: written by an agent
- dialogs-w4: finished by an agent
- dialogs-w4: drop the PLAN note on TextWords' export (combine)
- dialogs-w4: review fixes (review-1)
- dialogs-w4: the About tab strip takes its tabs' height in the stack header (dialogs run round)
- dialogs-w4: Integration: the dialog host ends the shown life of a dialog it removes (dialogs run round)
- dialogs-w4: ui.dialog.cancel on a prompt with Cancel answers that Cancel in the typed-dialogs trial, as dl.N2 rules (top run round)
2026-11-15 04:46:07 +00:00
aiongg 2b38e14dee dialogs-w13: net change of 5 commits
- dialogs-w13: written by an agent
- dialogs-w13: finished by an agent
- dialogs-w13: review fixes (review-1)
- Integration: draw's screen tests keep framework-01-w11's presets module beside pattern_fill
- dialogs-w13: guides trials say why a reopen is a first pass (dialogs run round)
2026-11-15 04:46:06 +00:00
aiongg 66a61366fa dialogs-w1: net change of 2 commits
- dialogs-w1: written by an agent
- dialogs-w1: review fixes (review-1)
2026-11-15 04:46:06 +00:00
aiongg e9e3a961f4 Merge next (CI lint fixes) into phase2/stubs
# Conflicts:
#	crates/color/src/ui/swatches/menu.rs
2026-11-14 03:13:33 +00:00
aiongg 870c17ba97 Contract stubs: craft-ui-patterns (06.md items), cw.C46 senses_surface 2026-11-14 02:11:11 +00:00
aiongg 52a2595a60 Lints: document craft-aaf, fix its doc links, keep canvas size builder closure 2026-11-14 01:47:15 +00:00
aiongg bcd543e017 Lints: ui-patterns tests, gallery, docx docs link 2026-11-14 01:36:21 +00:00
aiongg 02e1c47112 Param list additions and the preview click point: Param::multiline, Param::read_only_text, PreviewOutput::clicked through ParamDialog and HostedParamDialog 2026-11-13 18:32:12 +00:00
aiongg be927e9393 Dialogs: hosted forms for Canvas Size, About, format options, Export As, Alert, Layer Style and the adjustment dialogs
Each opens on a DialogHost as a StackDialog that owns what its dialog edits
and binds the dialog's open state to its own field, so it opens again after
closing. HostedCanvasSize and HostedImageSize share SizingOutput::hosted.
HostedExportAs keeps its preview and save requests for the app as
HostedSaveForWeb does; HostedAbout keeps the activated link. HostedAlert
holds an Alert's content. HostedLayerStyle frames the Layer Style body in a
form dialog with side buttons and the Preview box, and queues the page's asks
as LayerStyleAsk. HostedAdjustDialog<V, E> frames any adjustment editor the
same way, resizable and remembered for Curves, with the editor's asks as E.

Stories open the hosted dialogs through a story host bound to the card's
open value (dialog::stories::hosted), so the card holds them behind its
button and story-render shows them open. Trials open each on a DialogHost
and check Escape, OK and the asks.
2026-11-13 02:26:58 +00:00
aiongg b127a87dc8 Export As: the format is a select, Constrain Proportions a check box under Height, Image Size a quiet heading, and every settings row shares one label column 2026-11-12 14:32:50 +00:00
aiongg 6d9381f411 A parameter radio row is its own section titled by the parameter, so its name shows once; Targa drops the section that repeated it 2026-11-12 14:32:45 +00:00
aiongg e97d392892 OutputPathRow: the file name is a link; a click asks for the file dialog, Alt-click edits the template in place (comp2:64)
ButtonOutput carries the modifiers held at the activation (Activation::mods), and Link reports a ButtonOutput, so a
caller reads a modified click from the framework's signal.
2026-11-12 14:32:44 +00:00
aiongg 6901310103 AboutDialog: Contributors has a View control, Grab bag by default, whose names are links to the profiles (pat2:31, 32) 2026-11-12 14:32:44 +00:00
aiongg b7a9d56b49 NewDocumentDialog: each saved preset row has a Delete button (pat2:18) 2026-11-12 14:32:44 +00:00
aiongg 269d59a358 JPEG options: the quality field and preset list on one line with the slider under them, the encoding as a radio group (pat2:54, 55)
The quality row is a full-width custom row, so the slider starts at the form's start edge as the old one did. A
dialog confirmed without a quality edit answers the quality it opened with.
2026-11-12 14:32:44 +00:00
aiongg bd6fbd2b54 A picture in a column sized from its content measures at its least width
picture_width took the column's room where the measure offered none. A measuring run in a content column offers no
room so that nothing there fills it; the picture took the room anyway, and a dialog sized from its content with a
preview (Export As, a parameter dialog) took its whole share of the window, or more. The picture now takes the room it
is offered and its least width where it is offered none; the real run shows it across the width the column settles on.
2026-11-12 14:32:42 +00:00