Commit Graph
36 Commits
Author SHA1 Message Date
aiongg b6088dbdcf Merge branch 'fw/speed1' into fw/mac1
# Conflicts:
#	crates/ui-patterns/src/patterns/dock/area.rs
#	crates/ui-shell/src/shell/app_shell.rs
2026-11-16 19:05:56 +00:00
aiongg b54fe562bc The canvas panel's rail is one rail column wide at the panel's end edge, so the document area runs up to it 2026-11-16 17:49:05 +00:00
aiongg 9b8dbfb332 Shell slots and dock panel bodies settle when they give a content version
Slot::content and AppShell::content give a slot the version of the app data it shows; DockPanels::content
gives one per panel body. With one, the slot or body runs in a settling Lazy. Trials: a versioned slot and a
versioned panel body run only when their version changes; a stroke whose tool asks for repaints runs no
versioned panel beside the canvas and one pass per move frame.
2026-11-16 17:42:23 +00:00
aiongg e0ebaf4634 A row's line record holds the line it shared: a row centred in another height measures its line afresh, so a title bar in its slot sits in the slot; the Swatches panel fills its room and scrolls its own swatches 2026-11-16 17:25:09 +00:00
aiongg 1d8c7d13a2 Merge branch 'fw/mac1-bars' into fw/mac1
# Conflicts:
#	crates/ui-contract/src/contract/body/hooks.rs
#	crates/ui-shell/src/shell/app_shell.rs
#	crates/ui-shell/tests/it/shell/app_shell.rs
2026-11-16 16:25:37 +00:00
aiongg 60bdf15129 ToolRail fits its slot: block padding, a rail-width column per column with the buttons centred, toggles on one line
ContainerProps gains pad_edges (PadEdges::Block pads top and bottom only) and LeastWidth::Rail
(size.rail.width per column). ToolRail pads only above and below, is at least its columns'
rail width wide, and centres its grid of buttons, so no button or corner mark reaches past the
slot. The column and side toggles share one header line as small control-glyph buttons that
touch, which fits two in one rail column. A container's child_size and child_glyphs reach its
header and footer as well as its body, so a rail's footer buttons show the rail's glyphs.
AppShell::tools takes the rail's column count, so a two-column rail gets a two-column slot.
2026-11-16 16:05:13 +00:00
aiongg 81078945af A row given its height centres its line; a fill-width row on that line fills it; top and bottom shell panes lay their bar on one line
A container given its height whose body is an unwrapped row sets the row's line at the middle of its band and
pads only along the line. A fill-width container with a row body on such a line is given the line's height, so a
bar in a top or bottom slot fills the slot. A container whose first line is its own row's line sits on an outer
row's line by it even with a child of two lines. The shell's top and bottom panes lay their content out as a row;
the egui centring wrapper and the slot's surface under the bar are gone.
2026-11-16 15:59:53 +00:00
aiongg 63a4811416 cargo fmt 2026-11-16 14:34:57 +00:00
aiongg 014ead170f merge-fwd: item 4: FW9: ui-contract and ui-shell parse and draw icons through craft-svg (features tree-core, tree, draw, tree-render; Limits.allow_dtd); resvg 0.45 goes; trials 2026-11-16 12:40:51 +00:00
aiongg c8713d756a tfix3-f5: a tool command's key release fires it in the release phase (spring-loaded tools); framework tool pickers act on the press only 2026-11-15 18:58:20 +00:00
aiongg 19cd2e1762 commands: a story's command set (#[command(story)]) loads only in an install that shows stories (the gallery, the story fixtures), so its keys never take an app's 2026-11-15 18:28:52 +00:00
aiongg 5ca05d0f44 tfix3-f3: trials: a press without a physical key fires its command once (separate passes and one pass); an app catalog's alternate key for a registry command runs it 2026-11-15 16:54:50 +00:00
aiongg 14d5ec609a cargo fmt 2026-11-15 10:23:21 +00:00
aiongg 38a5547d45 hub-w1: net change of 1 commits
- hub-w1: review fixes (review-1)
2026-11-15 09:18:08 +00:00
aiongg 0b46a6d24d canvas-widgets-w29: net change of 2 commits
- canvas-widgets-w29: written by an agent
- canvas-widgets-w29: review fixes (review-1)
2026-11-15 09:18:07 +00:00
aiongg b9d2a9b266 top-w7: net change of 6 commits
- top-w7: written by an agent
- top-w7: review fixes (review-1.md)
- top-w7: menu redirect keeps the return stop's chain, with its trial (review-1.md, lead ruling on the gap)
- top-w7: a component inside a menu resolves its bound command from where focus goes once the menus close, through focus's walk (top run round)
- Integration: pick_focus trials keep top-w2's Help search-field Cut trial after this set's shortcut trial
- top-w7: a menu row's command takes its instance from the row's own chain, judged from the stop focus returns to, which gives the instance when the chain holds none (top run round)
2026-11-15 04:46:09 +00:00
aiongg e1b4567e59 top-w5: net change of 4 commits
- top-w5: written by an agent
- top-w5: review fixes (review-1.md)
- top-w5: read_last_update doc follows the updater arm (review-1 item 2)
- top-w5: the opening card's progress bar is named by the card's title (top run round)
2026-11-15 04:46:09 +00:00
aiongg c77e6d6ead top-w4: net change of 3 commits
- top-w4: written by an agent
- top-w4: review fixes (review-1)
- top-w4: edge scroll caps its step like the strips (top round)
2026-11-15 04:46:09 +00:00
aiongg b7ee7384fc canvas-widgets-w9: net change of 3 commits
- canvas-widgets-w9: written by an agent
- canvas-widgets-w9: review fixes (review-1)
- canvas-widgets-w9: the typed-zoom press trial reads the row's commit (a plain typed number proposes as typed) and shows the canvas tall enough for its pasteboard press (fwcw round 3)
2026-11-15 04:46:06 +00:00
aiongg 1951630307 canvas-widgets-w10: net change of 5 commits
- canvas-widgets-w10: partly written (run interrupted)
- canvas-widgets-w10: partly written (run interrupted)
- canvas-widgets-w10: partly written (run interrupted)
- canvas-widgets-w10: finished by an agent
- canvas-widgets-w10: review fixes (review-1)
2026-11-15 04:46:05 +00:00
aiongg 38d3342ad0 framework-01-w9: net change of 8 commits
- framework-01-w9: written by an agent
- framework-01-w9: finished by an agent
- Integration: desktop.rs icon_theme module lines owed by top-w2
- framework-01-w9: review fixes (review-1)
- framework-01-w9: layer containers map placement once (review-1 item 6)
- framework-01-w9: the flyout trials read the open panel's flyout, not one fading out (fw01 round 2)
- framework-01-w9: Flyout is IconicColumn's unregistered face (fw01 round 2)
- framework-01-w9: review fixes (review-tl-1.md)
2026-11-15 04:46:05 +00:00
aiongg eadac57bb8 panels-w2: net change of 1 commits
- panels-w2: a screen-mode change is a change from the mode the last pass applied, whoever wrote the binding; the reveal trial drives Tab through a root that toggles the chrome and a document canvas, and a body-only reveal shows every revealing slot (top run round)
2026-11-15 04:46:04 +00:00
aiongg db29b49895 panels-w2: written from its sheet 2026-11-14 17:56:00 +00:00
aiongg d08c97c8c5 Lints: story facts initialisers, doc links, path field last edit 2026-11-14 01:14:54 +00:00
aiongg 6924d6a1bf Rules are 1 pt wide and take a band of their own
Divider and edge rules take the thin stroke (1 pt, whole physical
pixels) instead of one physical pixel; grid rules over the document stay
one physical pixel.

The rules between a container's regions (above and under the header,
beside a ruled footer, before a ruled end region) each get a band in the
region layout, so no rule lies over a region's content at any scale.
Rules drawn along a rect's edge (footer bar, tile grid tail, timeline
graph bar, docked scroll bar, layer row toggle cells) are edge rules on
the side the rule belongs to, so the second pixel at 2x stays off the
neighbour. The split button's divider reads the divider rule's width.
2026-11-12 15:23:58 +00:00
aiongg f5110ecdb5 Dialog chrome: a section gap under the header rule, above the footer and beside a button column; no footer rule; full-window header and footer inset
The dialog shells take their regions from frame.rs (HEADER, FOOTER, SIDE_BUTTONS), spaced by one gap. FooterRegion gains an
inset tier, the counterpart of HeaderRegion::inset, so a full-window dialog keeps its title and buttons off the window edges
while its canvas and side columns reach them.
2026-11-12 14:32:51 +00:00
aiongg 47508315ef craft-ui-shell: public embed hooks for apps with their own eframe App
shell::embed holds install (runtime plus fonts), before_input, logic and
before_ui, and CloseDecision. app::run's Driver calls the same hooks.
runtime::keys::with_window_intents is public: the host's read of the
window-level keys no component took. docs/craft-framework.md 2.2
describes the recipe and what install takes over. A trial drives its
own frame loop through the hooks alone.
2026-11-12 14:32:46 +00:00
aiongg 76be23a0f7 End region rule: full-window side columns are set off from the canvas by a divider 2026-11-12 14:32:46 +00:00
aiongg 5e11bad614 A container in an embedded shell acts on no OS window; its title bar is a picture of a window
os_window reads the embedded-shell signal (ShellCx::region): inline, pane and window
mounts inside an embedded shell stand for no OS window, so they get no move band or
grips and report nothing to the window. TitleBar reads the same signal: its captions
report their clicks but send no window command, a double click acts on nothing, and
it reads no window state.
2026-11-12 14:32:44 +00:00
aiongg eef17642ba Toasts: one queue per window; each AppShell, embedded ones included, shows its own window's toasts at the end-bottom corner of its body (Anchor::Corner replaces Anchor::Viewport), so nested shells no longer each draw every card at the viewport corner; NoticeCenter posts to its window, and the NoticeCenter and ToastStack stories show three notices in their own area, as the old ones did 2026-11-12 14:32:44 +00:00
aiongg cfa87db5d1 Every region of a container spaces its children itself, in the measuring and the real run alike: header, footer and end region by the container's body gap, the header's controls box by the item gap
A region inherited the item spacing of the ui around it, which differs between the two runs (egui's default while measuring, the parent body's gap when placed), so a region of several children took more than it measured. One opener (RegionFrame::open) makes every region's ui and sets its spacing; the footer's own spacing fix goes.
2026-11-12 14:32:44 +00:00
aiongg d0bc3eb15b A footer region spaces its children by the container's body gap in the measuring and the real run alike, so its measured height is the height it takes and its last row is not clipped (ListManager's caption note)
The footer inherited the item spacing of the ui around it, which differs between the two runs: in a dialog the real run took the dialog body's gap and the measuring run egui's default.
2026-11-12 14:32:43 +00:00
aiongg 4b948bd951 A modal without a scrim takes the presses below it: every modal shows its cover, painted only for Backdrop::Scrim (K17)
An app-modal ViewportWindow with Backdrop::None, and a BlockingOverlay without a scrim, let presses through to the
window under them. The window trial presses the button under the window by position: a modal layer hides what is under
it from the accessibility tree.
2026-11-12 14:32:41 +00:00
aiongg 81c22f3469 Old modality: Tour and ViewportWindow block nothing, Preferences is app-modal, a tool window ignores Escape (K17, D10)
The tour card is a popup that blocks and dims nothing and stays on an outside press; Backdrop::ScrimWithHole and the
cover layer's hole go with it. ViewportWindow blocks nothing until app_modal(backdrop). A modeless Dialog without a
footer ignores Escape; a modal one or one with a footer closes on it. PreferencesWindow drops modeless and takes the
shared app-modal path (blocked cursor, refused close).
2026-11-12 14:32:41 +00:00
aiongg e58aabe37e Focus returns to where it came from: the drawer to Edit Toolbar, the last toast to the stop before the stack (K17)
A layer opened from a recorded opener returns focus to that opener's stop. ToolRailOutput::edit_toolbar carries the
button's response and ToolbarDrawer::opened_by takes it; the drawer still hangs from the rail. The toast layer is a
non-trapping scope (FocusPolicy::TAB_LAYER) whose opener is the stop focus entered it from, so the last card's end
returns focus there; an earlier card's end hands it to the next card.
2026-11-12 14:32:41 +00:00
aiongg a2676b8eac Framework UI crates: widgets, panels, canvas, patterns, shell and the craft-ui facade 2026-11-12 14:09:32 +00:00