- panels-w25: written by an agent
- panels-w25: the drag payload copies the document id into its closure (the payload map is 'static + Sync)
- panels-w25: review fixes (review-1)
- framework-01-w2: repair 1
- framework-01-w2: RowStyle and ShapeTokens::rows go (size.rs, lib.rs rows of the sheet)
- framework-01-w2: list rows: option rows rounded, others square; layer rules in every theme (show.rs row of the sheet)
- framework-01-w2: review fixes (review-1)
- framework-01-w2: review fixes (review-1, files the rulings name)
- framework-01-w2: the escaped-sweep trial follows the sweep rule: only the eyes it switched are restored (fw01 round 2)
- framework-01-w2: a drop past the last item in reading order lands at the end, in every layout (fwcw round 3)
The gate's design-lint test finds nothing. Env value types (pane edge, column align, row pressed, in-bar), band fill and span live in the layer that uses them; the cursor image and inside label are read back by the higher layer. Hand setters become derived props, tests assert relations, and the remaining sites are listed exceptions with reasons. The shortcut chord chip's sample is built only for screen tests.
A double click on a Smart Filter row reported its Activate on the second press and narrowed the selection on its
release, after the app had opened the filter's editor. A double click on a fill thumbnail reselected the row with no
part, which targets a fill layer's mask.
The Lock row's five buttons are small (ControlSize::Sm) and touch, as Photoshop's, so Fill and its
field stay on the row at a panel's width instead of wrapping below it. The Kind filter toggles are
small too.
LayerInfo::thumb_badge is a ThumbBadge (SmartObject, Shape) that craft-layers paints: a window glyph,
or a path with an anchor on each corner. Kind and mask badges share one badge box, a field well at
the small icon size in the thumbnail's corner.
Dividers fall between rows (RowState::last), so a list's last row no longer
draws a rule beside the footer bar's. Photoshop's Effects header shows only its
eye and label; the mock sets no icon and SubRow::icon no longer names one.
A list row paints a trailing drag handle's icon face as a mark, not an icon
button: a handle has no node of its own (the row's description names it), and a
button face would add an unnamed button.
A source marks a sub-row with its indent steps (ItemSource::sub_row). The row is
compact, its eye column empty, and its toggle cells sit in its content at that
indent (sub_row_cells): one step past the layer for the header, two for an item.
Presses flip them there and a sweep down the eye column passes them by. No divider
falls between a row and the sub-rows that continue it (RowState::continued).
The mock's Effects header carries the sparkles icon.
The samples beside the thumbnail size choices of a panel's options dialog (Layers, Channels, Paths) are larger than the
panel's own thumbnails, so the three choices read apart. They take `size.thumb.sample.{sm,md,lg}`: 36, 48 and 96 in
Compact, 36, 68 and 96 in Comfortable (twice the row thumbnails, as the old dialog drew them; PhotoCraft draws 38, 68
and 96). A Picture shows one through `PictureSize::Sample`, and the Layers options dialog's samples use it.
Component::fills defaults to the width when the caller set Sizing::FillWidth,
and the sizing stays on the component after step 1 so the layout hooks read
it. Button, TextField and Slider lose their fill_width props and Swatch and
GradientSwatch their fill flags; callers set Sizing::FillWidth. The blend
select in BlendRows takes the room before Opacity, as in PhotoCraft.
A contract trial checks that a FillWidth leaf takes the row's room and a
Content leaf does not.
BlendRows, LayerFilterBar, the scopes refresh button and the wide-angle Add
constraint button no longer fix the small size, so they show at the size
their scope gives (Md in a panel), as PhotoCraft's header controls do.
Groups::Open opens the layer's closed groups and scrolls its row into view; Groups::Keep opens
nothing and scrolls to the row of its outermost closed group, the row that stands for the layer
(PhotoCraft's Move tool pick with "expand group on click" off).
A reveal (requested, key move, page switch, type-ahead, rename) scrolled by the item layout's
extents, in which rows no pass built yet have the estimate. The rows the pass then built took
their measured heights and pushed an auto row taller than the estimate out of view. The List
now aims the reveal in the content step, before it builds the rows: it builds and measures the
auto rows that will share the view with the revealed row, up to it, that have no kept height,
and aims again until the row is placed by measured heights. The build takes those measures and
does not measure the rows again, and the frame runs once. The per-row measure is shared with the
widest-row measure.
LayersPanel no longer compares the active layer with the last pass's (Session.seen_active and
the auto-reveal go): the app calls reveal(layer) in the pass its active layer changes.
LayersPanel::document(key) keys the rows List per document, so each document keeps its scroll
position and lead.
Trials: ui-widgets List reveal past unbuilt taller rows (one pass, no row measured twice);
craft-layers panel_reveal (reveal with Open, row in view, per-document scroll, counts).
craft-ui testing part_rect_of_node reads a part's rect from the shape record by the owner's
AccessKit node, the lookup Fixture::part_rect makes by id. ThumbTarget::part and TrailingPart::part
name a row's thumbnail and trailing parts; the row declares its parts through them.
LayerInfo::thumb maps a layer part to the thumbnail that shows it, over the order the panel
reads thumbnail clicks by, and craft-layers testing thumb_rect and fx_badge_rect give a host test
the rect of a layer row's thumbnail or fx badge. The drag, menu and frame trials find thumbnails
and the badge this way.
follow_lead_source moves the lead to the row now in its place and no longer
selects that row: a row that was deleted or filtered out is not replaced by its
neighbour. LayerFilter::deselect_hidden is the one rule for a newly applied
filter (Photoshop #10879); the panel reports it as a Select on its filter bar's
edit, and an app that sets the filter itself calls it there.
A content-sized select, and any select in a bar, fits its faces: as wide as its widest entry and the chevron need,
with no field floor, and at most a field length, where a longer entry elides. Options bars sized every select to the
field length or kept a 96 pt floor, so the whole-or-nothing rule hid later members the bar had room for. The bar
selects that asked for content sizing themselves no longer need to; LayerFilterBar's type select, in a row of its own,
asks for it.
- List::edge_press(mods, test): while the modifiers are held, the band of the line between two adjacent rows the
test gives a cursor for shows that cursor and takes the click (CollectionEvent::EdgePressed), picking neither
row. The band reaches LINE_REACH from the line; a toggle cell keeps its press. Collections without it are
unchanged.
- craft-layers: LayersEvent::ClipLine { upper, release } for an Alt-click on the line between two sibling layers,
with the clip-below or clip-release cursor.
- ListRow::part_drag(RowDragSpot, payload) replaces thumb_drag: a thumbnail or a trailing part drags instead of
the row (RowEvent::PartDrag). A trailing part that drags is a handle: its click is the row's.
- TrailingFace::Strong: a text face for a trailing part.
- ListRow::thumb_cursor: the cursor over a thumbnail.
- CollectionEvent::EmptyContextMenu: a secondary click on a collection's empty space.
- craft-layers: the fx badge drags every effect of its layer onto another layer (a transfer, Alt copies) and a
click on it selects the row; MenuTarget.row is None for the empty space's menu; the load-selection cursor over
thumbnails while Cmd/Ctrl is held; LayerTree::label_colors_in_menu decides per target whether the row menu
gets the Label Color submenu.
The rows take the mask through the list's drop kind for the panel's drag payload. LayerTree::accepts_mask_drop
decides which layers take it; by default a layer takes a mask of a kind it does not have.
The mask badges and the app's thumbnail badge fill the theme's small icon size (size.icon.sm) within the thumbnail,
and the app's icon draws at the small glyph size (size.icon.glyph_sm), instead of a share of the thumbnail.
ListRow::thumb_target takes ThumbTargets, built from one ThumbTarget or an array of them; one set of brackets frames
each run of adjacent targets, so two targets side by side never cut into each other. In the Layers panel,
LayerPart::Pixels on a frame targets its shape and content together, LayerPart::FrameShape the shape alone and
LayerPart::FrameContent the content alone; a click on a frame's first thumbnail reports FrameShape. Story
composites/layers-panel/frame-selected shows it.
Story composites/layers-panel/row-kinds shows a compact artboard heading, a frame, a smart object's badge and Smart
Filter rows with their Blending Options buttons, one selected on its own. Trials: the hovered layer row, a Smart
Filter row selected on its own holding the lead, the Blending Options double click, and a frame's mask chain after
its content thumbnail.
LayerInfo.thumb_badge puts an icon in the thumbnail's corner on the scrim, in the square the mask badges use
(PhotoCraft's smart object and shape marks).
LayerKind::Frame rows show the frame's shape and, as a second thumbnail, its content (LayerPart::FrameContent,
LayerThumbKind::FrameContent). A click on the content reports that part in Select and ThumbClick, and the target
brackets frame it when the app targets the content. The masks follow the content thumbnail.
LayerSelection.sub_row is the sub-row the app keeps selected: the list highlights it beside its layer and gives it
the lead. LayerSelect.row names the sub-row a click, right-click or selection key picked. The Background's doc names
ActivateOn::Row, which a double click on its name reports.