Commit Graph
146 Commits
Author SHA1 Message Date
aiongg cc00dbd368 Clippy and test-target lints: redundant must_use, type aliases for complex types, boxed large variants, argument structs, struct-update initialisers, deprecated egui calls, unused imports and dead code; the swatch library's reorder test runs as a trial 2026-11-16 02:30:55 +00:00
aiongg b171283050 fmt 2026-11-16 01:01:56 +00:00
aiongg f1f0333a5b Merge storytold next into the framework branch 2026-11-16 01:01:38 +00:00
aiongg 9b93aacce2 tfix5-f11: number rows follow a shared Units choice (Param::number_in_units); HostedPrint::json_form; the preview is named Print preview image 2026-11-16 00:44:29 +00:00
aiongg e2acc2fc01 tfix5-f9: CustomContext::pick_color opens the picker at the colour the row shows; the context keeps no copy of the values 2026-11-16 00:17:27 +00:00
aiongg 009c18cece tfix5-f9: Reset restores the opening values with reset_to's over them; keys added since the open go 2026-11-16 00:16:34 +00:00
aiongg 1b13399c08 tfix5-f9: a ParamDialog whose preview pane centres on clicks passes a primary press on its canvas: the image is the pane's locator 2026-11-16 00:16:33 +00:00
aiongg e49acf5414 tfix5-f9: Param::resets: changing a row's value through the row, automation or a host answer removes the keys of the rows that depend on it 2026-11-16 00:15:54 +00:00
aiongg 5cabd08694 tfix4-f6d: FormDialog::opening is the host's Reset baseline in every pass; HostedAdjustDialog::seed moves it, so Reset returns to the last seed 2026-11-15 22:04:30 +00:00
aiongg 20e969d9f6 tfix4-f6d: ParamDialog::previews declares the Preview box; HostedParamDialog keeps its value, so is_previewing holds from construction 2026-11-15 22:02:17 +00:00
aiongg a4176ef04e tfix4-f6: HostedNewDocument opens its settings at construction (ctx in new); a host-opened dialog's first pass keeps them 2026-11-15 21:32:41 +00:00
aiongg 84bb213705 tfix4-f6: HostedFormatOptions opens its fields at construction (ctx in new), so they list and take sets before the first pass 2026-11-15 21:32:41 +00:00
aiongg 19cd2e1762 commands: a story's command set (#[command(story)]) loads only in an install that shows stories (the gallery, the story fixtures), so its keys never take an app's 2026-11-15 18:28:52 +00:00
aiongg 55fd41e76c tfix3-f3: one held OK (HeldAnswer) for every hosted family: HostedParamDialog and HostedWorkspace use it, HostedAdjustDialog gains held_ok/take_ok/answer_ok 2026-11-15 17:01:32 +00:00
aiongg ef51284928 tfix3-f3: a hosted param dialog is instanced by its command key; take_keyed takes results of any instance (take keeps to uninstanced ones) 2026-11-15 16:56:45 +00:00
aiongg a9e7eaf31d ui-patterns: Save for Web binds its frame; automation sets and lists it 2026-11-15 15:36:34 +00:00
aiongg 4c5aee933e ui-patterns: New Guide refuses OK while the Position text does not parse 2026-11-15 15:36:34 +00:00
aiongg 450eba6c2d ui-patterns: hosted parameter dialogs open their values at open; custom rows declare companions and an opening value 2026-11-15 15:36:34 +00:00
aiongg 2bc5fd1782 tfix-dialog: a held OK is a state the host reports (HeldOk), and confirm finishes an accepted one
StackDialog::held_state / DialogHost::held_state tell a filed OK (Waiting), an accepted one and a refused one
apart from a refused confirm. HostedParamDialog and HostedWorkspace answer confirm with the accepted held answer;
Export As and Save for Web confirm without a path ask for the save dialog as their buttons do. ui.dialog.confirm
does not report a filed held OK as a refusal.
2026-11-15 14:26:31 +00:00
aiongg 28b664b417 fwb2-fix: Export As resample list and title
(cherry picked from commit a36669c7d77d92ef4421306081582fbc56c3c522)
2026-11-15 12:06:39 +00:00
aiongg e50c665ec2 fwb2-fix: HostedParamDialog::previewed_colors
(cherry picked from commit ca7ef21f2d525946fad41a1f00496ecdce558189)
2026-11-15 12:06:39 +00:00
aiongg 533c4de857 fwb2-fix: sizing dialog keys as public consts
(cherry picked from commit a9ddf1b98cbd7f15032e0a88947b05e94129e0c3)
2026-11-15 12:06:38 +00:00
aiongg d2c962e392 fwb2-fix: SettingsDraft::remove
(cherry picked from commit 91d42261e2b702d8e31ec8d379e50b96aa22a562)
2026-11-15 12:06:38 +00:00
aiongg 14d5ec609a cargo fmt 2026-11-15 10:23:21 +00:00
aiongg e0b9e97529 panels-w14: net change of 3 commits
- panels-w14: written by an agent
- panels-w14: finished by an agent
- panels-w14: review fixes (review-1)
2026-11-15 09:18:07 +00:00
aiongg 870fca96d6 top-w6: net change of 4 commits
- top-w6: written from its sheet
- top-w6: repair 1
- top-w6: review fixes (review-1)
- top-w6: the manager's preset list caps its rows inside the scrolling dialog body (top run round)
2026-11-15 04:46:09 +00:00
aiongg 6cac93d255 top-w3: net change of 3 commits
- top-w3: written by an agent
- top-w3: review fixes (review-1)
- top-w3: remove sits beside lookup and insert in draft.rs (review-1 item 5)
2026-11-15 04:46:09 +00:00
aiongg 46bd564b75 top-w2: net change of 6 commits
- top-w2: written by an agent
- top-w2: finished by an agent
- top-w2: review fixes (review-1)
- top-w2: the menu-letter step of the shortcut trial types its letter as text, which mnemonics read (top run round)
- top-w2: typed letters in a menu go to the container of the focused row's level, with a trial for a title-click menu (top run round)
- top-w2: a menu row's pick walks out from the menu it runs in, with a trial for Cut from the Help search field's edit menu (top run round)
2026-11-15 04:46:09 +00:00
aiongg 4ff83a83e2 dialogs-w9: net change of 5 commits
- dialogs-w9: written from its sheet
- dialogs-w9: repair 1
- Integration: imaging's trial list keeps dialogs-w17's raw_develop beside color_range
- dialogs-w9: review fixes (review-1)
- dialogs-w9: the color range trial's proxy is large enough that the preview fits it to the well inside the zoom range (top run round)
2026-11-15 04:46:08 +00:00
aiongg 6e122e4c38 dialogs-w3: net change of 1 commits
- dialogs-w3: written from its sheet
2026-11-15 04:46:07 +00:00
aiongg 20e0bcf93b dialogs-w2: net change of 3 commits
- dialogs-w2: written by an agent
- Integration: ParamRows keeps dialogs-w1's preview_colors beside the patterns rows (dialogs-w1 7a195af4a)
- dialogs-w2: review fixes (review-1)
2026-11-15 04:46:07 +00:00
aiongg d3257f265a dialogs-w15: net change of 7 commits
- dialogs-w15: written from its sheet
- dialogs-w15: repair 1
- dialogs-w15: trials build the non-exhaustive SaveForWebOptions from its default (combine)
- Integration: craft-color's re-export and panels trials take SwatchTable from craft_ui::choice (panels-w7 and panels-w6 requests, done here so the area compiles)
- dialogs-w15: review fixes (review-1)
- dialogs-w15: review fixes (item 3)
- dialogs-w15: the palette trial selects the Optimized pane, whose palette the Color Table shows (dialogs run round)
2026-11-15 04:46:07 +00:00
aiongg e6e7d2183c dialogs-w14: net change of 3 commits
- dialogs-w14: written by an agent
- dialogs-w14: trials build the non-exhaustive ExportOptions from its default (combine)
- dialogs-w14: review fixes (review-1)
2026-11-15 04:46:07 +00:00
aiongg 51b41ec6df dialogs-w4: net change of 7 commits
- dialogs-w4: written by an agent
- dialogs-w4: finished by an agent
- dialogs-w4: drop the PLAN note on TextWords' export (combine)
- dialogs-w4: review fixes (review-1)
- dialogs-w4: the About tab strip takes its tabs' height in the stack header (dialogs run round)
- dialogs-w4: Integration: the dialog host ends the shown life of a dialog it removes (dialogs run round)
- dialogs-w4: ui.dialog.cancel on a prompt with Cancel answers that Cancel in the typed-dialogs trial, as dl.N2 rules (top run round)
2026-11-15 04:46:07 +00:00
aiongg 2b38e14dee dialogs-w13: net change of 5 commits
- dialogs-w13: written by an agent
- dialogs-w13: finished by an agent
- dialogs-w13: review fixes (review-1)
- Integration: draw's screen tests keep framework-01-w11's presets module beside pattern_fill
- dialogs-w13: guides trials say why a reopen is a first pass (dialogs run round)
2026-11-15 04:46:06 +00:00
aiongg 66a61366fa dialogs-w1: net change of 2 commits
- dialogs-w1: written by an agent
- dialogs-w1: review fixes (review-1)
2026-11-15 04:46:06 +00:00
aiongg 2151ca4cd4 canvas-widgets-w11: net change of 12 commits
- canvas-widgets-w11: partly written (run interrupted)
- canvas-widgets-w11: partly written (run interrupted)
- canvas-widgets-w11: partly written (run interrupted)
- canvas-widgets-w11: written by an agent
- canvas-widgets-w11: review fixes (review-1)
- canvas-widgets-w11: a root's response reports the presses on every part of its own, whatever egui widget took them; the part results say which part (fwcw round 3)
- canvas-widgets-w11: a press keeps focus only on the framework's focused stop, so a press on the canvas background focuses the canvas while a body member holds the stop (fwcw round 3)
- Integration: ui-widgets exports TextWords for Alert::range (dialogs-w4, cw.N6)
- canvas-widgets-w11: the held edit-menu selection drives the text part's keys and survives the pass focus takes to come back (top run round)
- canvas-widgets-w11: a root's own background is a hover candidate below its parts, and the root's response hovers by the framework's resolve wherever its arena is under the pointer; the press fallback to the background folds into the same shape (top run round)
- canvas-widgets-w11: an activation closes only the layers its walk out of the layer it ran in crosses, so a pick in a field's edit menu inside Help leaves Help open (top run round)
- Integration: overlay pass keeps framework-01-w9's layer spaces beside the activation's closed layers
2026-11-15 04:46:05 +00:00
aiongg db4828eaca framework-01-w1: net change of 4 commits
- framework-01-w1: written from its sheet
- framework-01-w1: review fixes (review-1)
- framework-01-w1: review fixes (review-1, files the rulings name)
- Integration: Cargo.lock line for w1's craft-settings dependency
2026-11-15 04:46:05 +00:00
aiongg 38d3342ad0 framework-01-w9: net change of 8 commits
- framework-01-w9: written by an agent
- framework-01-w9: finished by an agent
- Integration: desktop.rs icon_theme module lines owed by top-w2
- framework-01-w9: review fixes (review-1)
- framework-01-w9: layer containers map placement once (review-1 item 6)
- framework-01-w9: the flyout trials read the open panel's flyout, not one fading out (fw01 round 2)
- framework-01-w9: Flyout is IconicColumn's unregistered face (fw01 round 2)
- framework-01-w9: review fixes (review-tl-1.md)
2026-11-15 04:46:05 +00:00
aiongg bbd6f2b6af panels-w12: review fixes (review-2) 2026-11-14 17:56:01 +00:00
aiongg a3b66978e3 panels-w12: review fixes (picker.rs browser prop) 2026-11-14 17:56:01 +00:00
aiongg ead709b8d5 panels-w12: written from its sheet 2026-11-14 17:56:01 +00:00
aiongg 92cef7ac0a panels-w8: clone the row icon (compile fix) 2026-11-14 17:56:01 +00:00
aiongg 8c396b4b75 panels-w8: review fixes (review-1) 2026-11-14 17:56:00 +00:00
aiongg b3c263b6eb panels-w8: rustfmt 2026-11-14 17:56:00 +00:00
aiongg e488e459b2 panels-w8: repair 1 2026-11-14 17:56:00 +00:00
aiongg bc563b6c82 panels-w8: written from its sheet 2026-11-14 17:56:00 +00:00
aiongg ee5be1ccdd panels-w1: written from its sheet 2026-11-14 17:55:58 +00:00
aiongg 0e216b6257 Contract stubs: decision pass 2026-11-14 16:07:24 +00:00
aiongg 2b5de84828 Design lint: layer the env values, route egui access through the adapter, derive setters, token and relation checks in tests
The gate's design-lint test finds nothing. Env value types (pane edge, column align, row pressed, in-bar), band fill and span live in the layer that uses them; the cursor image and inside label are read back by the higher layer. Hand setters become derived props, tests assert relations, and the remaining sites are listed exceptions with reasons. The shortcut chord chip's sample is built only for screen tests.
2026-11-14 05:05:04 +00:00