Commit Graph
54 Commits
Author SHA1 Message Date
aiongg 014ead170f merge-fwd: item 4: FW9: ui-contract and ui-shell parse and draw icons through craft-svg (features tree-core, tree, draw, tree-render; Limits.allow_dtd); resvg 0.45 goes; trials 2026-11-16 12:40:51 +00:00
aiongg 7ca2ec0a0e Move items to the layer that owns them: pointer art and surround painting up to primitives, member_gesture_running next to the arena members, gesture_key down to runtime::edit; the font defaults test no longer needs a system emoji font 2026-11-16 04:56:54 +00:00
aiongg cc00dbd368 Clippy and test-target lints: redundant must_use, type aliases for complex types, boxed large variants, argument structs, struct-update initialisers, deprecated egui calls, unused imports and dead code; the swatch library's reorder test runs as a trial 2026-11-16 02:30:55 +00:00
aiongg f1f0333a5b Merge storytold next into the framework branch 2026-11-16 01:01:38 +00:00
aiongg c8713d756a tfix3-f5: a tool command's key release fires it in the release phase (spring-loaded tools); framework tool pickers act on the press only 2026-11-15 18:58:20 +00:00
aiongg 19cd2e1762 commands: a story's command set (#[command(story)]) loads only in an install that shows stories (the gallery, the story fixtures), so its keys never take an app's 2026-11-15 18:28:52 +00:00
aiongg 5ca05d0f44 tfix3-f3: trials: a press without a physical key fires its command once (separate passes and one pass); an app catalog's alternate key for a registry command runs it 2026-11-15 16:54:50 +00:00
aiongg 14d5ec609a cargo fmt 2026-11-15 10:23:21 +00:00
aiongg 5ae2808984 fwb1 review: Show in Folder follows CAN_REVEAL as a command state 2026-11-15 10:01:34 +00:00
aiongg 38a5547d45 hub-w1: net change of 1 commits
- hub-w1: review fixes (review-1)
2026-11-15 09:18:08 +00:00
aiongg 0b46a6d24d canvas-widgets-w29: net change of 2 commits
- canvas-widgets-w29: written by an agent
- canvas-widgets-w29: review fixes (review-1)
2026-11-15 09:18:07 +00:00
aiongg b9d2a9b266 top-w7: net change of 6 commits
- top-w7: written by an agent
- top-w7: review fixes (review-1.md)
- top-w7: menu redirect keeps the return stop's chain, with its trial (review-1.md, lead ruling on the gap)
- top-w7: a component inside a menu resolves its bound command from where focus goes once the menus close, through focus's walk (top run round)
- Integration: pick_focus trials keep top-w2's Help search-field Cut trial after this set's shortcut trial
- top-w7: a menu row's command takes its instance from the row's own chain, judged from the stop focus returns to, which gives the instance when the chain holds none (top run round)
2026-11-15 04:46:09 +00:00
aiongg e1b4567e59 top-w5: net change of 4 commits
- top-w5: written by an agent
- top-w5: review fixes (review-1.md)
- top-w5: read_last_update doc follows the updater arm (review-1 item 2)
- top-w5: the opening card's progress bar is named by the card's title (top run round)
2026-11-15 04:46:09 +00:00
aiongg c77e6d6ead top-w4: net change of 3 commits
- top-w4: written by an agent
- top-w4: review fixes (review-1)
- top-w4: edge scroll caps its step like the strips (top round)
2026-11-15 04:46:09 +00:00
aiongg b7ee7384fc canvas-widgets-w9: net change of 3 commits
- canvas-widgets-w9: written by an agent
- canvas-widgets-w9: review fixes (review-1)
- canvas-widgets-w9: the typed-zoom press trial reads the row's commit (a plain typed number proposes as typed) and shows the canvas tall enough for its pasteboard press (fwcw round 3)
2026-11-15 04:46:06 +00:00
aiongg d2d7d870c9 canvas-widgets-w12: net change of 7 commits
- canvas-widgets-w12: written by an agent
- canvas-widgets-w12: review fixes (review-1)
- canvas-widgets-w12: the pass's elapsed time (top round, review-top-1)
- canvas-widgets-w12: the strip trial reads rows wholly in view, not the first row's clipped rect (top run round)
- canvas-widgets-w12: the walk out of the menus is focus's (out_of_menus), with the menu-level container and the running menu; a body group names its container (top run round)
- canvas-widgets-w12: the walk out of the menus stops at the first return stop that is no menu row, and a menu pick returns focus by the same walk (top run round)
- canvas-widgets-w12: the walk out of a layer returns the menus it crosses; a pick walks from the menu its row runs in, and an activation closes the layer it ran in and the menus that walk crosses (top run round)
2026-11-15 04:46:06 +00:00
aiongg 1951630307 canvas-widgets-w10: net change of 5 commits
- canvas-widgets-w10: partly written (run interrupted)
- canvas-widgets-w10: partly written (run interrupted)
- canvas-widgets-w10: partly written (run interrupted)
- canvas-widgets-w10: finished by an agent
- canvas-widgets-w10: review fixes (review-1)
2026-11-15 04:46:05 +00:00
aiongg 38d3342ad0 framework-01-w9: net change of 8 commits
- framework-01-w9: written by an agent
- framework-01-w9: finished by an agent
- Integration: desktop.rs icon_theme module lines owed by top-w2
- framework-01-w9: review fixes (review-1)
- framework-01-w9: layer containers map placement once (review-1 item 6)
- framework-01-w9: the flyout trials read the open panel's flyout, not one fading out (fw01 round 2)
- framework-01-w9: Flyout is IconicColumn's unregistered face (fw01 round 2)
- framework-01-w9: review fixes (review-tl-1.md)
2026-11-15 04:46:05 +00:00
aiongg eadac57bb8 panels-w2: net change of 1 commits
- panels-w2: a screen-mode change is a change from the mode the last pass applied, whoever wrote the binding; the reveal trial drives Tab through a root that toggles the chrome and a document canvas, and a body-only reveal shows every revealing slot (top run round)
2026-11-15 04:46:04 +00:00
aiongg 80f8719cd4 panels-w2: review fixes (review-2) 2026-11-14 17:56:00 +00:00
aiongg d7ed431c5c panels-w2: review fixes (review-2) 2026-11-14 17:56:00 +00:00
aiongg db29b49895 panels-w2: written from its sheet 2026-11-14 17:56:00 +00:00
aiongg 2b5de84828 Design lint: layer the env values, route egui access through the adapter, derive setters, token and relation checks in tests
The gate's design-lint test finds nothing. Env value types (pane edge, column align, row pressed, in-bar), band fill and span live in the layer that uses them; the cursor image and inside label are read back by the higher layer. Hand setters become derived props, tests assert relations, and the remaining sites are listed exceptions with reasons. The shortcut chord chip's sample is built only for screen tests.
2026-11-14 05:05:04 +00:00
aiongg 2c8a2affd8 Contract stubs: pn.C10 and pn.C16 markers name their writer set panels-w2 2026-11-14 03:36:11 +00:00
aiongg 870c17ba97 Contract stubs: craft-ui-patterns (06.md items), cw.C46 senses_surface 2026-11-14 02:11:11 +00:00
aiongg 38ce55467c Contract stubs: craft-ui-canvas, craft-ui-shell (plus stage-4 carry) 2026-11-14 01:59:24 +00:00
aiongg d08c97c8c5 Lints: story facts initialisers, doc links, path field last edit 2026-11-14 01:14:54 +00:00
aiongg d325856d4f Lints: ui-shell, ui-canvas and ui-patterns findings 2026-11-14 00:39:12 +00:00
aiongg a17171af48 Lints: drop the workspace missing_docs lint and warn on it in the framework crates that document every public item 2026-11-14 00:15:29 +00:00
aiongg 304030b65b runtime: the root's System choices resolve from the host's SystemReader
InstallSpec::system takes the reader (ui-shell's create starts it with a
repaint wake); the input hook feeds egui's Event::SystemTheme into it, and
system_appearance(ctx) gives the reading and its generation, the one source
RootEnv::resolved uses. egui's system_theme is no longer read. The root token
cache counts its misses for tests (root_token_resolves replaces
root_token_entries).
2026-11-13 17:44:39 +00:00
aiongg 6924d6a1bf Rules are 1 pt wide and take a band of their own
Divider and edge rules take the thin stroke (1 pt, whole physical
pixels) instead of one physical pixel; grid rules over the document stay
one physical pixel.

The rules between a container's regions (above and under the header,
beside a ruled footer, before a ruled end region) each get a band in the
region layout, so no rule lies over a region's content at any scale.
Rules drawn along a rect's edge (footer bar, tile grid tail, timeline
graph bar, docked scroll bar, layer row toggle cells) are edge rules on
the side the rule belongs to, so the second pixel at 2x stays off the
neighbour. The split button's divider reads the divider rule's width.
2026-11-12 15:23:58 +00:00
aiongg a3434176e4 Dialog bodies: the content sits directly in the dialog body, which is already a stack, so fill-width children take the dialog's width; the Tabs dialog's Position column is as wide as its field and Alignment and Leader share the rest 2026-11-12 14:32:57 +00:00
aiongg f5110ecdb5 Dialog chrome: a section gap under the header rule, above the footer and beside a button column; no footer rule; full-window header and footer inset
The dialog shells take their regions from frame.rs (HEADER, FOOTER, SIDE_BUTTONS), spaced by one gap. FooterRegion gains an
inset tier, the counterpart of HeaderRegion::inset, so a full-window dialog keeps its title and buttons off the window edges
while its canvas and side columns reach them.
2026-11-12 14:32:51 +00:00
aiongg 4188d4f356 TitleBar stories keep their text placeholders: a MenuBar in the bar's leading slot shows no titles and fails the right-to-left rule, a follow-up of its own 2026-11-12 14:32:50 +00:00
aiongg 8de5a82799 TitleBar stories show the app's menu bar at the leading end and icon buttons at the trailing end 2026-11-12 14:32:50 +00:00
aiongg 0fc7bc0355 Edge rules sit on the pixels just inside their rect
Rule::edge and Draw::edge_rule draw a rule along one side of a rect, moved in by half its width, so a row's bottom rule, a cell's gridline or a strip's edge is no longer drawn on the first pixel outside, where the next row's clip or the next cell's fill hides it. List rows (layer dividers, rule), CellGrid gridlines and header edges, tab dividers, the tile grid's pinned band, font cards and ruler strips use it, as do the pane, end-region, title bar, timeline header and outline band rules that offset by hand. CellGrid draws the old's header edges toward the cells, its gridlines in the divider colour, and the selected header's accent bar inside the header.
2026-11-12 14:32:47 +00:00
aiongg 47508315ef craft-ui-shell: public embed hooks for apps with their own eframe App
shell::embed holds install (runtime plus fonts), before_input, logic and
before_ui, and CloseDecision. app::run's Driver calls the same hooks.
runtime::keys::with_window_intents is public: the host's read of the
window-level keys no component took. docs/craft-framework.md 2.2
describes the recipe and what install takes over. A trial drives its
own frame loop through the hooks alone.
2026-11-12 14:32:46 +00:00
aiongg 76be23a0f7 End region rule: full-window side columns are set off from the canvas by a divider 2026-11-12 14:32:46 +00:00
aiongg 9c78e36602 TitleBar draws its bottom hairline only with separator, as the old bar did
The old app's own bar drew none; the stories set it, as the old stories did.
2026-11-12 14:32:45 +00:00
aiongg 5e11bad614 A container in an embedded shell acts on no OS window; its title bar is a picture of a window
os_window reads the embedded-shell signal (ShellCx::region): inline, pane and window
mounts inside an embedded shell stand for no OS window, so they get no move band or
grips and report nothing to the window. TitleBar reads the same signal: its captions
report their clicks but send no window command, a double click acts on nothing, and
it reads no window state.
2026-11-12 14:32:44 +00:00
aiongg eef17642ba Toasts: one queue per window; each AppShell, embedded ones included, shows its own window's toasts at the end-bottom corner of its body (Anchor::Corner replaces Anchor::Viewport), so nested shells no longer each draw every card at the viewport corner; NoticeCenter posts to its window, and the NoticeCenter and ToastStack stories show three notices in their own area, as the old ones did 2026-11-12 14:32:44 +00:00
aiongg cfa87db5d1 Every region of a container spaces its children itself, in the measuring and the real run alike: header, footer and end region by the container's body gap, the header's controls box by the item gap
A region inherited the item spacing of the ui around it, which differs between the two runs (egui's default while measuring, the parent body's gap when placed), so a region of several children took more than it measured. One opener (RegionFrame::open) makes every region's ui and sets its spacing; the footer's own spacing fix goes.
2026-11-12 14:32:44 +00:00
aiongg d0bc3eb15b A footer region spaces its children by the container's body gap in the measuring and the real run alike, so its measured height is the height it takes and its last row is not clipped (ListManager's caption note)
The footer inherited the item spacing of the ui around it, which differs between the two runs: in a dialog the real run took the dialog body's gap and the measuring run egui's default.
2026-11-12 14:32:43 +00:00
aiongg be6d1a3332 Rules draw one physical pixel at every scale
Dividers, edges and grid lines are hairlines, as the old Divider was; the drop
mark keeps its medium width. RuleLook carries a RuleWidth that the rule painter
resolves to whole physical pixels.
2026-11-12 14:32:41 +00:00
aiongg 4b948bd951 A modal without a scrim takes the presses below it: every modal shows its cover, painted only for Backdrop::Scrim (K17)
An app-modal ViewportWindow with Backdrop::None, and a BlockingOverlay without a scrim, let presses through to the
window under them. The window trial presses the button under the window by position: a modal layer hides what is under
it from the accessibility tree.
2026-11-12 14:32:41 +00:00
aiongg 81c22f3469 Old modality: Tour and ViewportWindow block nothing, Preferences is app-modal, a tool window ignores Escape (K17, D10)
The tour card is a popup that blocks and dims nothing and stays on an outside press; Backdrop::ScrimWithHole and the
cover layer's hole go with it. ViewportWindow blocks nothing until app_modal(backdrop). A modeless Dialog without a
footer ignores Escape; a modal one or one with a footer closes on it. PreferencesWindow drops modeless and takes the
shared app-modal path (blocked cursor, refused close).
2026-11-12 14:32:41 +00:00
aiongg e58aabe37e Focus returns to where it came from: the drawer to Edit Toolbar, the last toast to the stop before the stack (K17)
A layer opened from a recorded opener returns focus to that opener's stop. ToolRailOutput::edit_toolbar carries the
button's response and ToolbarDrawer::opened_by takes it; the drawer still hangs from the rail. The toast layer is a
non-trapping scope (FocusPolicy::TAB_LAYER) whose opener is the stop focus entered it from, so the last card's end
returns focus there; an earlier card's end hands it to the next card.
2026-11-12 14:32:41 +00:00
aiongg 476602d4a3 A filling story's card is as tall as its content, and content taller than the room shares it
Along a height its parent sizes from its content, a container that fills takes its content height, at most the
room it is offered. When the content is taller, the measuring run is taken back and the container is laid out as
given the room, so its list and the bar under it share it; a record of the content height lets later runs and kept
transcripts lay it out the same. room_height only offers a finite room inside a scroll: a gallery card is as tall as
its story's content, at most the view, as the old gallery's tiles were.

layout_memory::draft runs a measuring run whose hand-forwards can be taken back once its result is seen: records,
kept transcripts, the open transcript's items, leaves and inputs, and each contribution (Contribution::undo for
column widths, label control minimums and reads). steps::id::draft takes the Auto id ordinals back with it. The
shrinking row's least probe is a draft taken back that reads nothing from outside.

A scrolling collection that fills keeps to its measured height in the real run under a body sized from its content,
so a footer under it stays below its rows. The PlacesTree story keeps the old 380 pt box.
2026-11-12 14:32:40 +00:00
aiongg e64dd901d9 Tooltips: a control that paints no label shows its own label, and the hints and names the old controls showed
A control whose own label is not painted (an icon, a glyph label, a caption-less tile, a chip, the stroke button) shows that label as its tooltip inside a field too; one named only by its field label shows none. Restores the old tooltips of the ReferencePoint points, the list disclosure, the PeopleBar avatars, the recent files, Distribute Rows Evenly, a page that failed to render, the font class mark (ListRow::trailing_named) and the Character hints (SideLabel::tooltip).
2026-11-12 14:32:39 +00:00
aiongg c19abe8663 Dock a native window by dragging its title row
A floating dock group in its own OS window now moves through a window move
gesture the app runs, which reports Begin, Update, Commit and Cancel like a
layer's move, so the dock marks the target under the pointer and docks the
whole window on release.

- macOS (Caps::OS_MOVES_TRACKED): the OS moves the window (StartMove), and the
  app follows the system pointer, button and Cmd through SystemWindows, the
  running platform's WindowSystem in craft-window. The hand-off ends when the
  system reports the button up.
- X11 and Windows: the app moves the window with SetOuterPosition so the
  pressed point stays under the pointer; Escape puts it back.
- A drag started by a container shown in its own OS window follows that
  window's pointer, not its parent's.
- The runtime's end hook sets NSWindow.movable for every window; a window
  whose move the app runs is never moved by AppKit from its band.
2026-11-12 14:32:39 +00:00