Files
craft-libs/crates/video/tests/mpeg2/hostile_dims.rs
Dylan M. Taylor 5e892217ed craft-video: MPEG-2 and MPEG-1 video decoder from FilmCraft (mpeg2) (#864)
* craft-video: MPEG-2 and MPEG-1 video decoder from FilmCraft (`mpeg2`)

FilmCraft's crates/mpeg2v at 4bec22bd moves to craft_video::mpeg2 behind the
decoder-only feature `mpeg2`: sources, README and tests (unit, synthetic
streams checked by ffmpeg, the ffmpeg oracle fixtures, hostile sweeps).

Changes in the move: craft-media-testkit instead of filmcraft-testkit, one
test target (tests/mpeg2), crate paths, rustfmt at this repo's width.

New: a memory budget (Decoder::set_memory_budget, craft_video::budget) checked
when a sequence becomes active, and a mutation test over the synthetic
field-picture, 16x8 and dual-prime streams, which ffmpeg's encoder cannot
produce and the hostile sweep therefore never reached.

* craft-video mpeg2: write the restart check without a negated conjunction (clippy nonminimal_bool)
2026-11-11 17:42:02 -05:00

191 lines
6.2 KiB
Rust

//! A 14-byte sequence header must not make the decoder size its frame buffers at 16383 x 16383
//! (gigabytes per picture). Hand-built, no ffmpeg.
use craft_video::mpeg2::Decoder;
#[derive(Default)]
struct Bits {
bytes: Vec<u8>,
n: usize,
}
impl Bits {
fn put(&mut self, value: u32, bits: usize) {
for i in (0..bits).rev() {
if self.n.is_multiple_of(8) {
self.bytes.push(0);
}
if (value >> i) & 1 == 1
&& let Some(b) = self.bytes.last_mut()
{
*b |= 0x80 >> (self.n % 8);
}
self.n += 1;
}
}
}
/// Sequence header plus sequence extension for a `w` x `h` 4:4:4 stream.
fn sequence(w: u32, h: u32, chroma_format: u32) -> Vec<u8> {
let mut s = Bits::default();
s.put(w & 0xfff, 12);
s.put(h & 0xfff, 12);
s.put(1, 4); // aspect_ratio_information
s.put(4, 4); // frame_rate_code
s.put(1000, 18); // bit_rate_value
s.put(1, 1); // marker
s.put(100, 10); // vbv_buffer_size_value
s.put(0, 3); // constrained_parameters_flag, load_intra, load_non_intra
let mut e = Bits::default();
e.put(1, 4); // sequence_extension
e.put(0x48, 8); // profile_and_level_indication
e.put(1, 1); // progressive_sequence
e.put(chroma_format, 2);
e.put(w >> 12, 2);
e.put(h >> 12, 2);
e.put(0, 12); // bit_rate_extension
e.put(1, 1); // marker
e.put(0, 8 + 1 + 2 + 5); // vbv_buffer_size_extension, low_delay, frame_rate_extension_n/d
let mut out = vec![0, 0, 1, 0xb3];
out.extend(s.bytes);
out.extend([0, 0, 1, 0xb5]);
out.extend(e.bytes);
out
}
fn accepted(w: u32, h: u32, chroma_format: u32) -> bool {
let mut dec = Decoder::new();
let _ = dec.decode(&sequence(w, h, chroma_format), 0);
dec.sequence().is_some()
}
#[test]
fn ordinary_sequences_are_accepted() {
assert!(accepted(1920, 1080, 1));
assert!(accepted(7680, 4320, 3));
}
#[test]
fn gigantic_sequences_are_refused() {
assert!(!accepted(16383, 16383, 3));
assert!(!accepted(16383, 16383, 1));
assert!(!accepted(8192, 8192, 1));
}
/// A picture of `coding_type` (1 = I, 2 = P): picture header, coding extension, one slice with a junk payload.
fn picture_of(coding_type: u32) -> Vec<u8> {
let mut h = Bits::default();
h.put(0, 10); // temporal_reference
h.put(coding_type, 3); // picture_coding_type
h.put(0xffff, 16); // vbv_delay
if coding_type == 2 {
h.put(0, 1); // full_pel_forward_vector
h.put(7, 3); // forward_f_code
}
let mut e = Bits::default();
e.put(8, 4); // picture_coding_extension
e.put(0xffff, 16); // f_codes
e.put(0, 2); // intra_dc_precision
e.put(3, 2); // picture_structure: frame
e.put(0, 10); // flags up to progressive_frame
e.put(1, 1); // progressive_frame
e.put(0, 1); // composite_display_flag
let mut out = vec![0, 0, 1, 0x00];
out.extend(h.bytes);
out.extend([0, 0, 1, 0xb5]);
out.extend(e.bytes);
out.extend([0, 0, 1, 0x01, 0x80, 0x80]);
out
}
fn picture() -> Vec<u8> {
picture_of(1)
}
#[test]
fn an_access_unit_of_many_pictures_stops_early() {
let mut data = sequence(64, 64, 1);
for _ in 0..200 {
data.extend(picture());
}
let mut dec = Decoder::new();
assert!(dec.decode(&data, 0).is_err(), "200 pictures in one access unit must be refused");
// pictures after the refusal are not decoded: the per-picture slice errors stay near the output cap
assert!(dec.errors() <= 32, "{} picture errors", dec.errors());
}
#[test]
fn a_dimension_change_does_not_hide_an_overflow() {
let mut data = sequence(64, 64, 1);
for _ in 0..20 {
data.extend(picture());
}
data.extend(sequence(128, 64, 1));
data.extend(picture());
let mut dec = Decoder::new();
assert!(dec.decode(&data, 0).is_err(), "the reset for the new dimensions must not clear the overflow");
}
#[test]
fn a_refused_access_unit_leaves_no_stale_references() {
let mut data = sequence(64, 64, 1);
for _ in 0..200 {
data.extend(picture());
}
let mut dec = Decoder::new();
assert!(dec.decode(&data, 0).is_err());
// a P picture cannot continue from the refused access unit's anchor
assert!(dec.decode(&picture_of(2), 1).unwrap().is_empty());
assert!(dec.flush().is_empty(), "a P picture after the refusal was decoded from stale references");
// an I picture restarts decoding; nothing from the refused access unit comes out before it
let two = [picture(), picture()].concat();
assert_eq!(dec.decode(&two, 2).unwrap().len(), 1, "the first I picture is shown when the second arrives");
assert_eq!(dec.flush().len(), 1);
}
/// `data` without its extension units (an MPEG-1 stream): everything from a 00 00 01 b5 start code up to the next start code.
fn mpeg1(data: &[u8]) -> Vec<u8> {
let mut out = Vec::new();
let mut i = 0;
while i < data.len() {
if data[i..].starts_with(&[0, 0, 1, 0xb5]) {
i += 4;
while i < data.len() && !data[i..].starts_with(&[0, 0, 1]) {
i += 1;
}
} else {
out.push(data[i]);
i += 1;
}
}
out
}
#[test]
fn an_mpeg1_d_picture_restarts_decoding_after_a_refused_access_unit() {
let mut data = mpeg1(&sequence(64, 64, 1));
for _ in 0..200 {
data.extend(mpeg1(&picture()));
}
let mut dec = Decoder::new();
assert!(dec.decode(&data, 0).is_err());
let two = [mpeg1(&picture_of(4)), mpeg1(&picture_of(4))].concat();
assert_eq!(dec.decode(&two, 1).unwrap().len(), 1, "the first D picture is shown when the second arrives");
}
/// 352x288 4:2:0 pads to 352x288: 152064 bytes a picture, 13 pictures held.
#[test]
fn sequence_over_the_memory_budget_is_refused() {
let need = 13 * (352 * 288 * 3 / 2);
for (budget, ok) in [(need, true), (need - 1, false)] {
let mut dec = Decoder::new();
dec.set_memory_budget(budget);
let _ = dec.decode(&sequence(352, 288, 1), 0);
assert_eq!(dec.sequence().is_some(), ok, "budget {budget}");
assert_eq!(dec.errors(), usize::from(!ok));
assert_eq!(dec.last_error().is_some(), !ok);
}
// 8K 4:4:4 (13 pictures of about 100 MB) fits the default budget.
assert!(accepted(7680, 4320, 3));
}