alehelandClaude Opus 5.5 ac8c5aae5d craft-audio: review fixes, round 8 (#443) ...

From wanikhawar's review:
- AudioSpecificConfig::parse reads backward-compatible SBR and PS signalling
  (a 0x2b7 sync extension after the config), which craft-media's Matroska
  demuxer writes for legacy HE-AAC IDs. Without lookahead those streams decoded
  as their core.
- An MP4 media edit after one empty edit is applied: its priming skip and its
  end. The empty edit's delay is not added as silence.
- A packet lost whole is concealed as long as the last one decoded, so a stream
  of multi-frame ADTS packets keeps its timing.
- ADTS-framed MP4 samples keep their sample table's timing, instead of every
  sample being read at open to look for several frames in one.
- AdtsHeader::write refuses an object type, sampling frequency index or channel
  configuration its fields cannot hold; it masked them into other values.
- AudioSpecificConfig::lc no longer panics for a sampling frequency index with no
  rate, and the decoder refuses such a config.
- AudioSpecificConfig::to_bytes refuses channel configuration 0 without a program
  config element, which would not parse back.
- Upsample2x starts each channel's history afresh when the channel count
  changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-11-07 22:26:05 +01:00

..

aac

craft-audio: review fixes, round 7 (#443)

2026-11-05 06:37:50 +01:00

main.rs

craft-audio: AAC decoder

2026-11-04 22:02:29 +01:00

routing_oracle.rs

craft-audio: review fixes, round 8 (#443)

2026-11-07 22:26:05 +01:00

testkit.rs

craft-audio: core types, WAV/AIFF read and write, peaks, symphonia (#441)

2026-11-04 10:25:57 +01:00