From f9ffd91a3b947f52a2d71b6254942d11aa06e924 Mon Sep 17 00:00:00 2001 From: "Dylan M. Taylor" Date: Fri, 13 Nov 2026 20:01:08 +0000 Subject: [PATCH 1/4] Run EffectCraft coverage tests in one shard --- .github/workflows/sonarcloud.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/sonarcloud.yml b/.github/workflows/sonarcloud.yml index 8f1aa5ad5..7d193b610 100644 --- a/.github/workflows/sonarcloud.yml +++ b/.github/workflows/sonarcloud.yml @@ -20,5 +20,8 @@ jobs: uses: storytold/craft-common-actions/.github/workflows/sonarcloud.yml@main with: timeout-minutes: 120 + # GPU tests share a process-local lock; separate coverage shards create independent + # software Vulkan devices, bypassing that lock and potentially contending on llvmpipe. + shards: 1 fonts-ref: b076417b5880bd4154bd22f00695b1d28c6bea83 secrets: inherit From dd3c6e968da0920d36f2e5bb5aa35b30076c754c Mon Sep 17 00:00:00 2001 From: "Dylan M. Taylor" Date: Sat, 14 Nov 2026 20:00:53 +0000 Subject: [PATCH 2/4] test(ui): serialize GPU picker integration --- crates/ui-egui/tests/it/ui_crypto_pick.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/crates/ui-egui/tests/it/ui_crypto_pick.rs b/crates/ui-egui/tests/it/ui_crypto_pick.rs index 03e49ca18..d863e73f7 100644 --- a/crates/ui-egui/tests/it/ui_crypto_pick.rs +++ b/crates/ui-egui/tests/it/ui_crypto_pick.rs @@ -632,6 +632,7 @@ fn clicks_wait_for_the_probe_and_edits_popups_dialogs_and_comp_switches_end_or_b /// each Resolution. Skips without a GPU adapter. #[test] fn picks_on_the_gpu_viewer() { + let _gpu = crate::gpu_test::lock(); let Some(probe) = effectcraft_gpu::Gpu::headless() else { eprintln!("no GPU adapter: skipping"); return; From 4e8cd4638b22221cfda8626e09804b9de16ffbb7 Mon Sep 17 00:00:00 2001 From: "Dylan M. Taylor" Date: Sun, 15 Nov 2026 00:34:59 +0000 Subject: [PATCH 3/4] ci: serialize one-shard Sonar coverage tests --- .github/workflows/sonarcloud.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/sonarcloud.yml b/.github/workflows/sonarcloud.yml index 7d193b610..1bc7c9f8b 100644 --- a/.github/workflows/sonarcloud.yml +++ b/.github/workflows/sonarcloud.yml @@ -17,11 +17,12 @@ concurrency: jobs: sonarcloud: # Track shared CI improvements on main. - uses: storytold/craft-common-actions/.github/workflows/sonarcloud.yml@main + uses: storytold/craft-common-actions/.github/workflows/sonarcloud.yml@72d2fbfb3dd1bf27e1bdc7107be72c70749c6876 with: timeout-minutes: 120 # GPU tests share a process-local lock; separate coverage shards create independent # software Vulkan devices, bypassing that lock and potentially contending on llvmpipe. shards: 1 + rust-test-threads: "1" fonts-ref: b076417b5880bd4154bd22f00695b1d28c6bea83 secrets: inherit From df79630f6f2e00d099c07def39b0230cb759e328 Mon Sep 17 00:00:00 2001 From: "Dylan M. Taylor" Date: Sun, 15 Nov 2026 01:36:12 +0000 Subject: [PATCH 4/4] ci: use merged test thread limit for Sonar coverage --- .github/workflows/sonarcloud.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sonarcloud.yml b/.github/workflows/sonarcloud.yml index 1bc7c9f8b..6adc57765 100644 --- a/.github/workflows/sonarcloud.yml +++ b/.github/workflows/sonarcloud.yml @@ -17,7 +17,7 @@ concurrency: jobs: sonarcloud: # Track shared CI improvements on main. - uses: storytold/craft-common-actions/.github/workflows/sonarcloud.yml@72d2fbfb3dd1bf27e1bdc7107be72c70749c6876 + uses: storytold/craft-common-actions/.github/workflows/sonarcloud.yml@main with: timeout-minutes: 120 # GPU tests share a process-local lock; separate coverage shards create independent