From dd8bb99cc429c1a68ff838f8c49009dd7ae4d20d Mon Sep 17 00:00:00 2001
From: "Dylan M. Taylor" <dylan@dylanmtaylor.com>
Date: Tue, 3 Nov 2026 12:58:58 +0000
Subject: [PATCH] address review: box blur first mean ignores an unused edge
 term (inf * 0 gave NaN)

---
 crates/effects/src/util.rs | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/crates/effects/src/util.rs b/crates/effects/src/util.rs
index 36493d65d..9c14a6c69 100644
--- a/crates/effects/src/util.rs
+++ b/crates/effects/src/util.rs
@@ -124,7 +124,11 @@ fn box_row(src: &[f32], dst: &mut [f32], r: usize) {
     // The first window, -r..=r: the edge pixels it repeats are counted, not visited, so the
     // work depends on the row length and not on the radius.
     let inside = r.min(last);
-    let mut acc = (r as f64 + 1.0) * src[0] as f64 + src[1..=inside].iter().map(|v| *v as f64).sum::<f64>() + (r - inside) as f64 * src[last] as f64;
+    let mut acc = (r as f64 + 1.0) * src[0] as f64 + src[1..=inside].iter().map(|v| *v as f64).sum::<f64>();
+    // Only when the window actually repeats the last pixel: 0 * inf would be NaN otherwise.
+    if r > inside {
+        acc += (r - inside) as f64 * src[last] as f64;
+    }
     for x in 0..n {
         dst[x] = (acc * norm) as f32;
         let xi = x as i64;
@@ -870,6 +874,10 @@ mod tests {
                 assert!((d - want).abs() < 1e-5, "r={r} x={x}: {d} vs {want}");
             }
         }
+        // An infinite last pixel inside the window still yields a finite first mean.
+        let mut inf = [0.0f32; 3];
+        box_row(&[1.0, 2.0, f32::INFINITY], &mut inf, 1);
+        assert!((inf[0] - 4.0 / 3.0).abs() < 1e-6, "{inf:?}");
         let mut one = [0.0f32];
         box_row(&[0.25], &mut one, usize::MAX);
         assert!((one[0] - 0.25).abs() < 1e-6);