* export: name the video encoder in the report, warn when hardware encoding falls back to software
* export: queued items carry their report, and the CLI prints its warnings with --queue (#3952)
* events: show a finished export's warnings after its Finished line (#3952)
* docs: queued exports and Events report the encoder fallback (#3952)
* cli: a queued export's warnings come only from the items it added (#3952)
* CI (Windows): clippy and tests of the crates with Windows-only code
A Windows leg through the shared gate and changed-paths workflows, as
LightCraft has: pull requests and pushes to main that touch the Windows
code (WASAPI audio, the graphics test start, Media Foundation / D3D11
decoding, their manifests and the lockfile), and pull requests labelled
full-ci. Nothing ran these crates' tests on Windows before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(filmcraft): accept a reset when the control server drops an expired connection
The first Windows run of the new CI leg failed unterminated_request_releases_its_slot:
Windows ended the timed-out connection with a reset (os error 10054), not a close, so
read_to_string returned ConnectionReset. Either way the client got no reply. Bytes read
before a reset stay in the string, so the no-stale-reply check still applies.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(ui-egui): let the drag-while-playing test wait for frames on a busy runner
The Windows leg (#4649) failed program_monitor_plays_on_while_a_value_is_dragged once: in 90
passes (~1.5 s) the workers finished no frame at a newer revision, so only frame 23 showed. It
passed in the run before. The test now drags until five frames have shown, for up to ~10 s, so a
picture held for the whole drag (the #1673 bug) still fails.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* ci(windows): run the Windows leg's tests under nextest
`cargo test` runs all of a binary's tests in one process, so they share
rayon's global pool and one test's work waits behind another's. The UI
binary's drag-while-playing test failed on one of two attempts at the same
commit (run 43007266199). On a Windows 11 sandbox it passed in six runs:
alone, with the whole binary, pinned to 1, 2 or 4 cores, and with a
one-thread rayon pool. The last run did fail another timing-bound test
(proxy creation, no proxies after ~8 s), which shows how tests in one
process hold each other up.
The Linux gate (`cargo xtask ci`) already uses nextest: each test in its
own process, with .config/nextest.toml's groups. The gate installs
cargo-nextest 0.9.150 on every OS, and the targets are the same
(--lib --bins --tests; no doctests on either leg's test step).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* ci(windows): fix main's first Windows-only clippy error; drop the moved h264 crate
The Windows leg's first run against current main stopped at
crates/engine/src/lib.rs: `let mut dir = DirBuilder::new()` (#4264) is
only mutated on Unix, where it sets the folder's mode, so on Windows
`-D warnings` turns the unused `mut` into an error. The builder is now
made per platform. Nothing compiled Windows code on main until this leg.
crates/h264 moved to craft-libs (504fe9fc5), so `-p filmcraft-h264` no
longer matches a package and `crates/h264/*` no longer exists: both are
removed from the leg.
On a Windows 11 sandbox at main merged into this branch (c7ef3f96) with
this change: `cargo fmt --all --check` passes, the leg's clippy command
for its six packages passes, and filmcraft-engine's lib tests pass (907).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(nextest): run the real-time play_ahead tests with nothing beside them
On the Windows leg, two play_ahead tests failed with silence where
frames were due: plays_every_frame_in_order_from_the_start at frame
27648, and a_device_with_other_channels_plays_the_channels_both_have at
frame 1024, two callbacks in, after a 30 ms head start in which the
mixer should have filled its 200 ms lead at once. The mixer thread only
sleeps when its ring is full, so it wasn't scheduled: nextest runs a
test process per core, and these tests need a thread on time against a
wall-clock device. They get the same rule as render's mixer_perf. The
other 2531 tests passed, the drag-while-playing test among them
(run 43270273462).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Containers, MP3 encoder and video decoders come from craft-libs
* Containers, MP3 encoder and video decoders come from craft-libs
The AVI, MPEG-TS/PS, MP3 encoder, H.264, HEVC, VP9, AV1, MPEG-2 and APV
crates are removed. craft-media (avi, mpegts), craft-audio (mp3-encode)
and craft-video (h264-decode, hevc-decode, vp9-decode, av1-decode, mpeg2,
apv), which were cut from them, replace them. Every craft-libs crate is
pinned at craft-libs 50f21899.
* MXF comes from craft-libs; craft-libs at df469bb2
crates/mxf is removed for craft_media::mxf. Both writer entry points name
FilmCraft (company, product, version) as the old writer did, so the bytes
and the product UID are unchanged; the export and AAF tests check it.
* docs: the VP9 and AV1 hostile_lengths WASI run points at craft-video
* Audio codecs and Ogg come from craft-libs
The AAC, AC-3, FLAC, MP1/MP2 and Opus crates and the Ogg demuxer are
removed. craft-audio and craft-media, which were cut from them and carry
their later changes, replace them.
* codecs: an Opus stream without a header packet is a decode error; craft-libs at b72cb4d6
An Ogg file whose first packet is larger than the header cap is filed as data,
so an Opus stream can arrive without its OpusHead; indexing headers[0] panicked.
The new craft-libs pin brings the Opus granule bounds from #4049 (craft-libs #859).
* tests: write artifacts into a fresh private temp folder instead of a predictable name
* address review: own the temporary folders so they are removed
* address review: create test temp dirs with mode 0700
* Leave the web smoke script's default output folder as it was (its one changed line cannot be covered by Sonar's new-code gate)
* media, engine, export, cli: read only regular files, and check before opening
* address review: open regular-file reads without blocking on a swapped-in FIFO
* address review: use the Linux MIPS and SPARC O_NONBLOCK values in open_nonblocking
* #2633: the scrub playhead no longer waits for the audio device
Opening a WASAPI output stream starts the Windows audio engine: 559 ms
measured on Realtek from a cold engine (19-23 ms while another stream is
running). A playhead drag paid that on the UI thread, twice: scrub_playhead
called app.stop() on every press, and the press path runs twice per drag, so
the first grain's stream was closed and opened again. CpalOut::config also
listed every supported configuration (191 ms) even when the device already
ran at the wanted rate.
Only stop a transport that is running, skip the rate search when the device's
default rate is the wanted one, and play the scrub grain on its own output
(ScrubOut / CpalScrubOut): its thread owns the stream (cpal's Stream is
!Send), keeps it for 5 s after the last grain and swaps in the current mixer
per grain. The UI only sends over a channel, so a press or a drag does no
blocking work.
Measured before and after in docs/performance.md.
* #2633: a ruler press also stops a stream a panicked frame left playing
A panel that panics is caught in App::ui, which clears playback.playing but does not stop the audio output: the stream keeps playing and playback.audio_clock stays true. The transport check now counts that clock, so a press on the ruler still stops it instead of scrubbing over the sound. Found by CodeRabbit on #3000.
* #2633: the scrub output follows the sequence it plays
`CpalScrubOut` took the sequence rate once, at construction, and `apply_prefs`
carried it again only when the audio hardware preferences changed. Settings ->
Sequence, opening another project and switching sequences change what the next
grain needs without touching them: a stale rate mixed grains at the wrong speed,
and an open stream (the button is down, or it lingers for a moment after the
release) kept the fill, and the mixer inside it, of the sequence that was active
when it opened.
`apply_prefs` now compares the active sequence and its sample rate with what the
output was configured for, and reconfigures the output only when the rate
changes; another sequence at the same rate just opens the stream again, so the
next grain replaces the fill in place. No event tracking: `ProjectChanged` fires
on every edit, and the comparison costs two options per frame.
* Scrub output tests: a stand-in stream instead of the real device
On Windows the audio test binary crashed (STATUS_ACCESS_VIOLATION) in the second
scrub test. cpal's WASAPI device enumerator lives in the COM apartment of the
thread that first used it, and libtest's per-test threads end with their test,
so the next test to enumerate devices read freed memory. Main's audio tests pass
on Windows because none of them touch a device.
CpalScrubOut::spawn takes the stream opener (new() passes open_scrub), so the
tests drive the scrub thread with a FakeStream that takes 600 ms to open, like a
cold WASAPI engine, and reports when it is dropped. They now check what matters:
play returns at once during a cold open, a second grain reuses the stream,
release closes an open stream before it returns, answers at once when nothing
is open, and waits at most RELEASE_WAIT for a stream still opening, which then
closes once open. The release test fails when Release leaves the stream open.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* #2553: a GPU that can't draw to the window falls back to the integrated one instead of panicking
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* #2553: a second panic saves the next mode instead of going back to the default
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* #2553: after a graphics panic, FilmCraft starts again in the next mode instead of retrying in-process
The event loop does not run again in a process it unwound out of: on the #2553 laptop the
in-process retry returned at once and no window opened until the next launch.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* #2553: a relaunch keeps the -- separator and the files after it
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: FredApps <FredApps@users.noreply.github.com>
* Graphics start: a failed fallback goes back up, and the error lists every mode tried (#2581)
A start-up error in a saved fallback mode ended the start when that mode was
the last on the ladder: a software mode saved after a one-off failure, on a
machine with no software adapter, dead-ended every later launch until the user
found `--graphics default`. The next mode is now the next one down that this
process has not tried, then any untried one from the top, so that start goes
back to the default.
When no mode works, the message lists each mode tried with its error, how to
choose a mode with `--graphics`, the version, and where the log is.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Graphics start: test the mode in a child process first, so a hanging driver moves on or reports (#1061, #2634, #1038)
A driver can hang inside wgpu's instance, adapter or device creation instead
of failing. The process then runs with no window and nothing reported, and
the start-up ladder, which counts starts that died, never moved on.
On Windows, a launch now first tests its graphics mode in a child process
(this program with `--test-graphics-start <mode>`), before this process
loads any driver. The child creates the instance, lists the adapters,
chooses one and creates the device the way eframe will, and reports each
step. A child still running after 25 s is ended, and the next mode is
tried. The window starts in the first mode that passed, with the fallback
notice; when none does, a message names each mode, the step it stopped at
and the adapter, instead of a FilmCraft that never opens.
The test runs only when the version, the mode or the display drivers
changed, or when the last start never got its window and never came back.
A start like that, older than 60 s, is taken as hung in the window itself,
and the next launch moves on from its mode.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Graphics test start: test the choice and the child's steps on every platform
SonarCloud found 65.6% of the new code covered: the choice returns early
off Windows, and nothing ran the child's own steps. The choice is now
`choose_with`, tested with a fake test start: it tests once, then starts
directly until the version, mode or drivers change; it moves on from a
start that hung in its window; and `--graphics`, no data folder, no mode
passing and `WGPU_BACKEND` each behave as described. The child's steps run
in-process with software rendering, and with DirectX 12 off Windows for
the error path.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Graphics test start: a start that ends in the message keeps an earlier hang on record
When no mode passed its test start, the message path called `finish`, which
closed the record of an earlier start that hung in this mode. The next
launch then found nothing open and started that mode without testing it,
hanging again. The message path now calls `abandon`, which ends this
attempt and leaves that record open, so the next launch moves on from the
mode as before. Found by CodeRabbit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A start-up error in a saved fallback mode ended the start when that mode was
the last on the ladder: a software mode saved after a one-off failure, on a
machine with no software adapter, dead-ended every later launch until the user
found `--graphics default`. The next mode is now the next one down that this
process has not tried, then any untried one from the top, so that start goes
back to the default.
When no mode works, the message lists each mode tried with its error, how to
choose a mode with `--graphics`, the version, and where the log is.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
request, execute, commands and screenshot move onto the shared crate (storytold/craft-libs#413): a timeout on every call, the screenshot's PNG also in data (pngBase64 stays), and uiInspect beside them. inspect, info, files, readFile, importFiles, importUrl and openProject stay FilmCraft's own, on the same object.
* render, gpu: adjustment layers composited on the GPU
An adjustment layer anywhere at a time sent the whole frame to the CPU
renderer, so GPU rendering did nothing for the frames under one. A
full-frame adjustment layer at 100 % opacity, Normal, unmasked and with
only effects the GPU stage runs is now a PlanStep::Adjust: its effects
run in the effect stage on the accumulator (the composite of the tracks
below) and the result replaces it before the tracks above are drawn.
Every other adjustment layer keeps the whole-frame CPU fallback.
The export renderer takes Composite plans without transitions; frames
with a Push still go to the CPU there, as before. perf.stats gpu gains
adjustments / cpuAdjustments.
* docs: adjustment layers on the GPU compositor in parity and performance
hardware-parity.md gains an Adjustment layers row; performance.md gains
the main-against-branch export timings with an adjustment layer.
* render, gpu: adjustment layer review fixes
- is_cpu_frame and plan_frame now ask the same adjustment_ops (evaluated
at the render scale, which is_cpu_frame takes from the RenderOptions):
a Transform that shrinks the frame no longer takes a pooled export
renderer only to be rendered on the CPU and counted as a GPU frame.
- FxOp::eval leaves a Transform with its shutter angle on (motion blur)
to the CPU; the GPU drew it sharp, on clips and adjustment layers.
- The effect stage's texture pool spans the whole composite frame, so an
adjustment step's working textures are reused instead of made again
every frame. Composite plans honour resolve = false (export).
- ExportRenderer::render hands frames with an adjustment layer back to
the CPU when the device has no effect stage, instead of compositing
them on the CPU and uploading the result to read it back.
- adjustment_covers_output checks the full-frame geometry without
building the coverage image.
- The GPU adjustment test also runs without an effect stage.
* render, gpu, export, ui: plan adjustment layers for the device's caps
plan_frame and is_cpu_frame take plan::DeviceCaps (how large a frame
the device runs adjustment layers on; none without an effect stage), so
a frame the compositing device can't adjust becomes a CPU image on the
thread that plans it, never on the UI thread or inside a renderer slot.
- Monitor: the caps are part of the frame key
(Target::SequencePlan(seq, caps)), so a plan made for another device
is never reused.
- Export: FrameRenderer::caps is required; the renderer pool plans with
the smallest caps of its renderers before it takes one.
- The compositor's own CPU fallback stays as a safety net for a plan
made for other caps; the tests check that nothing reaches it.
- Main's own-shutter Transform check replaces the duplicate guard in
gpufx.
Tests: a Push under an adjustment layer exported on the GPU against
render_sequence (forward and reversed, scales 1 and 0.5); routing
without an effect stage in the export pipeline and in the monitor's
frame server; GPU parity against render_sequence with colour and alpha
for a partly transparent canvas, stacked adjustment layers, an empty
canvas, a nested sequence below and one inside a nest, at scales 1 and
0.5; caps boundaries and is_cpu_frame agreeing with plan_frame.
* gpu: end a refused effect image's frame; count steps once drawn
effect_image began an effect stage frame and returned without ending it
when the stage refused the job, so the stage stayed mid-frame and kept
its working images. The compositor's step counters are added once the
whole frame is drawn on the GPU, so a frame that falls back half way
no longer counts the steps it threw away.
A .fcproj is read whole, and that read stops at 256 MiB. The host bridge
allowed 512 MiB and copied the bytes first, so a project in between was
stored and then failed. Refuse it before the copy. Media may still be
512 MiB, because it stays a Blob.
Co-authored-by: Cursor <cursoragent@cursor.com>
The transports, the message types and the origin checks come from the shared crate (storytold/craft-libs#420); FilmCraft keeps what is its own: project or media, the open size limit and the saveAs rule.
A path written twice in one frame went out as saveAs: false the second time
even when the first hand-over failed, because the decisions ran ahead on a
copy that advanced regardless. Each save now reads the host's document just
before it is sent, with the borrow dropped first.
A page that embeds the web build can hand it a file and get every save back instead of a browser download, and hears about unsaved changes: ?host=parent for a same-origin iframe (postMessage, the protocol the GridCraft, PdfCraft, WordCraft and CADCraft bridges use) and data-host="page" on the canvas for a page that loads the module into its own document (non-bubbling CustomEvents on the canvas). The bridge holds a Transport (Parent or Page) with one send; the pure rules are unit-tested; the hosting guide documents both modes.
* macOS: keep AppKit's Touch Bar observers when AccessKit drops (no crash on quit)
accesskit_macos 0.27.1 reset the window's view to WinitView when its adapter
dropped, discarding the key-value observation AppKit's Touch Bar finder had put
on the view's nextResponder. On quit, AppKit's removal of that observer raised
and _crashOnException: ended FilmCraft with SIGILL on Touch Bar Macs. 0.27.2
resets the class only while it is still AccessKit's own subclass.
Lockfile-only bump (accesskit 0.25.2, accesskit_consumer 0.39.2, accesskit_macos
0.27.2), with a test that fails below 0.27.2.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D5nRpBjuSq2YBDMKU2Spqs
* filmcraft: accesskit lock test in the it binary; leave tempfile's getrandom as it was
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Brandon Thomas <echelon@gmail.com>
* fix(export): an image-sequence export reports the stills it wrote
An export to `a.png` as an image sequence writes `a000.png`, `a001.png` and so on, but the
job's result, `file.exportMedia`'s `path` and the CLI's "exported" line all named `a.png`,
which does not exist.
The report now names the first still, the name `file.import` and `probe --image-sequence`
take for a sequence. `file.exportMedia` and `export.quick` name it as `path` up front, from
the frame count `export.resolve` uses, and add `lastPath`. The CLI prints both. A single
file keeps its path.
Fixes#4009
* fix(automation): a cancelled image-sequence export is cleaned up by its stills' name
Since `file.exportMedia` names an image sequence's first still as `path`, the MCP cancel
clean-up took `a000` as the stem: it left `a001.png` and every later still, and the `a.srt`
sidecar, behind. The result now also carries `basePath`, the name the stills are numbered
from, and the clean-up goes by it.
* fix(automation): an image-sequence cancel clean-up keeps the base name and finds .jpeg stills
An image-sequence export numbers every still, a single frame included, so a file under its base
name (`a.png`) is never its own: cancelling one deleted a user's `a.png` if it was saved during
the export. The stills of a `.jpeg` sequence were left behind instead, since the extension was
read as a format name, and `jpeg` names Motion-JPEG there; `file.exportMedia` keeps `.jpeg`
for a JPEG sequence.
* fix(automation): a cancelled image sequence removes only the stills it numbered
The clean-up matched any `<stem><3+ digits>.<ext>` written during the export, so cancelling an
export to `a.jpeg` could delete `a1000.jpeg`, the first still of an export to `a1.jpeg` in the
same folder. It now takes the digits and the last index from the result's `lastPath` and removes
only those names: `a000.jpeg` to `a120.jpeg` for a 121-frame export.
* cli: a missing project stops a save in place before it opens (#3944)
The save lock was taken only when --project was already a file. A project
created after that check but before Backend::open read it was opened and
saved with no lock, so a concurrent --save run could lose its edits.
A save in place on a missing project now stops at the check, with the same
error Backend::open gives. Runs that don't save over --project still leave
that error to Backend::open, and --bridge with --project stays a usage
error.
* cli: a missing project spelt two ways is still saved in place (#3944)
`--project p.fcproj --save-as ./p.fcproj` names one file, but when it
doesn't exist yet `canonicalize` fails on both spellings, so the run wasn't
seen as saving in place and skipped the missing-file check. Paths that
don't exist are now compared by their resolved folder and file name.
Existing files are compared as before. The error names `--project`, as
`Backend::open`'s does.
* cli: check that --project exists before comparing save paths (#3944)
Two findings on #3946 were the same race reached through other spellings
of a missing path: `./p.fcproj`, then `newdir/./p.fcproj` in a folder that
doesn't exist either. Each was a run that compared the paths, found no
match, and went on to open a project that wasn't there.
`saved_in_place` now checks `--project` first. A missing one stops the run
with the error `Backend::open` gave, whatever the run saves. Only existing
paths are compared after that, where `canonicalize` is exact, so the folder
fallback from the last commit goes.
* web: load only a same-origin http(s) app in the WebCodecs read-error harness
* web: keep the app URL's own query flags in the WebCodecs read-error harness
* cli: --save runs on one project take turns, so no edit is lost (#3924)
A run reads the project, edits it and writes the whole file back, so two
at once silently dropped the edits of whichever saved first. A run that
saves over the file it opened now holds an OS lock on `.<name>.lock` next
to the project from before its read until it exits. The next run says so
on stderr, waits, then edits what the first one saved.
The OS drops the lock however the process ends, so a crash leaves nothing
stale. If the lock can't be taken the run warns and saves as it did before.
The desktop app and `mcp` sessions don't take this lock.
* cli: the save lock goes by the path being saved over (#3924)
A save through a symlink replaces the link with a plain file. Resolving
the path therefore gave the runs before and after that save different
locks, and a run still waiting on the old lock could overwrite a later
run's save. The lock now uses the path as written, so replacing the link
can't change which lock a run takes.
* Apply background mask tracking in headless sessions
Fixes#3302
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: drop pending mask-tracking jobs when the project is replaced
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
* fix: drop mask-tracking jobs started on a replaced project via document epoch
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Brandon Thomas <echelon@gmail.com>
* M3: Add shared custom colors and complete marker editing
* #1435: refine native colors and range endpoint flags
Use the macOS Colors panel for custom label colors and reuse the established egui picker on other hosts. Preserve draft confirmation, exact sRGB values, native text shortcuts and project ownership. Compact the swatches and center the add control, split range glyphs across their endpoints, localize the new controls, protect newer marker edits from stale dialogs, and cover the behavior with rendered UI and hit-test regressions.
Co-authored-by: Codex <noreply@openai.com>
* #1435: preserve imported palettes and marker double-click ownership
Union saved OTIO palettes across timelines with deduplication, bounded capacity,
first-name preservation and explicit overflow warnings. Keep null authors
consistent with omitted fields, and consume marker double-clicks before the
work-area gesture so opening the editor does not alter project history.
Correct the CSV URL column and schema documentation. Add six regressions for
palette retention/capacity, author handling, and physical overlapping gestures.
Validation: full cargo xtask ci (3666 passed, 45 skipped), 42 rendered UI tests,
and strict workspace/all-target Clippy on Rust 1.99.1.
Co-authored-by: Codex <noreply@openai.com>
* #1435: retain OTIO swatch names and generator labels
Ignore orphan name entries when retaining saved palette names so input ordering
does not hide valid names after the first 64 entries. Keep names bounded by the
retained palette and preserve existing valid names.
Include generator preset labels alongside custom label colors in OTIO metadata.
Add regressions for orphan-prefixed name maps and three generator kinds with
preset/custom colors through actual export/import round trips.
Validation: both regressions failed before fixes; all 72 interchange tests and
full cargo xtask ci pass (3668 tests, 45 skipped), plus strict workspace/all-target
Clippy on Rust 1.99.1.
Co-authored-by: Codex <noreply@openai.com>
* #1435: preserve distinct OTIO generator item identity
Use exported FilmCraft item IDs for generator media identity so identical
content can retain distinct source names, labels and custom colors. Repeated
references to one source item still share a single imported media entry.
Preserve content-based fallback for missing or invalid item IDs. Cover black
video, bars and tone, and color mattes with distinct items/shared references,
plus legacy and malformed identity metadata.
Validation: distinct-generator regression failed before fix; legacy compatibility
passed. All 74 interchange tests and final full cargo xtask ci pass (3670 tests,
45 skipped); strict workspace/all-target Clippy also passes on Rust 1.99.1.
Co-authored-by: Codex <noreply@openai.com>
* #1435: align Edit Marker layout and add safe marker navigation
Give the editor a wide aligned form, larger Notes area, side action column,
and grouped palette with vertical marker types. Expand the Web Link field
with the form and keep actions accessible in small windows.
Previous/Next saves valid edits as one Undo step and stays with the original
sequence/source owner, including coincident markers. Invalid drafts stay open;
unchanged navigation and Done add no history. Keep native/shared color pickers,
Author, Notes, URL validation and immediate marker creation.
Validation: all 45 rendered sequence/marker UI tests pass, including five new
navigation/owner/validation/layout regressions. Native macOS layout, picker
Cancel and exact single-step Undo restoration verified. Full standard cargo
xtask ci passes 3675 tests (45 skipped), doctests and all remaining gates;
strict Rust 1.99.1 workspace/all-target Clippy also passes.
Co-authored-by: Codex <noreply@openai.com>
* #1435: refine Edit Marker proportions and action alignment
Narrow the dialog to 680 logical pixels and keep the core order Name,
Time/Duration, Notes, Color and marker type. Place Author after the type-specific
options as secondary metadata. Preserve our palette, custom picker and range controls.
Use consistently sized, centered rounded action buttons with a primary Done action.
Shorten Delete Marker to Delete and remove the navigation helper and unused translations.
Keep the existing navigation save/validation/Undo semantics and automation IDs.
Validation: all 45 rendered marker/sequence UI tests pass, including small-window
action accessibility. Actual macOS layout and no-op Previous/Next/Cancel verified.
Full standard cargo xtask ci passes 3675 tests (45 skipped), doctests, formatting,
Clippy, translations, layers, assets and 49 WASM crates. Strict Rust 1.99.1
workspace/all-target Clippy passes separately.
Co-authored-by: Codex <noreply@openai.com>
* #1435: tighten marker layout and validate text editing
Use a narrower aligned form with Author below Name, bounded scrolling Notes,
left-aligned colors, centered actions and an inline Web Link URL/open icon.
Remove the legacy Flash Cue choice while preserving imported marker types.
Constrain timecode typing/paste to complete numeric colon-separated fields,
validate drop-frame labels and frame bounds, and disable Done for invalid timing.
Preserve high-frame-rate timecodes and point-marker semantics when Duration is
unchecked. Route native/menu clipboard and text Undo commands to focused fields;
explicit engine commands retain project Undo and selection semantics.
Validation: standard cargo xtask ci passes 3679 tests (45 standard skips),
doctests, fmt, strict workspace/all-target Clippy, i18n, layers, 69 assets and
49 WASM crates. Also passed 48 rendered marker/sequence tests and strict Rust
1.99.1 Clippy. Actual macOS clipboard, bounded Notes, point save and exact Undo
were checked. Windows/Linux desktop interaction remains pending.
Co-authored-by: Codex <noreply@openai.com>
* M0: Wait for frame-worker recovery before asserting
Do not treat a nonempty request queue as proof of worker death in the
panic-recovery regression. Keep waiting for all injected faults and enough
post-fault completions, then drain the queue without adding more seeks.
Retain the exact fault-count, successful-recovery and empty-queue assertions
and bound the wait with a two-minute deadline.
The inherited test failed twice in independent fork CI. It did not reproduce
locally: baseline passed 20 normal and 10 delayed-report runs; the repair
passed 50 normal and 10 delayed-report runs. No product or marker UI changes.
Validation: standard cargo xtask ci passed all 4485 tests (52 standard skips),
doctests, formatting, strict workspace/all-target Clippy, i18n, layers,
69 assets and 49 WASM crates.
Assisted-by: OpenAI Codex
---------
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <codex@openai.com>
Resolve conflict in crates/ui-egui/src/i18n/tests.rs using switch_and_check
helper and add 22 new catalog entries to tr.tsv matching upstream additions.
bs.tsv: Bosnian (Latin script, Ijekavian) catalog covering every key of
FilmCraft's other catalogs, its wording shared with storytold/craft-i18n
locales/bs/ and the strings craft-i18n lacks translated new. Every bs-*
locale selects it; counts use one/few/other. Locale and plural tests,
localization docs and an attribution entry (AI-assisted, not yet
reviewed by a native speaker).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Tayw8nmxoLLmKv13jK93z
* control: say why the control server is not serving (#3436)
With --control but a missing or malformed FILMCRAFT_CONTROL_TOKEN the
server declined to start and said so only on stderr, which a desktop
launch has no reader for: the window opened, nothing listened, and the
bridge blamed the launch command.
- control server: log the disable reason and the listening state through
log::warn!/log::info! so they land in filmcraft.log; start returns a
typed Option<DisabledWhy> instead of hiding the reason
- desktop app: show the token reason in the status bar whenever it is
idle (persistent but replaceable by any real status)
- --control-input-only: exit with an error when the server cannot start
instead of parking a window that ignores all native input
- bridge: the connection-refused error names the token requirement
- i18n: status-bar string translated in the 8 active locales
Co-Authored-By: Claude <noreply@anthropic.com>
* control: drop the unused ControlNotice::Bind and its catalog rows
A bind failure is only logged until #3318; nothing constructed the variant.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Brandon Thomas <echelon@gmail.com>
UPDATE_APP (native builds; craft-update is a native-only dependency) carries our 128 px icon and accent (#8b5cf6, its colour in ArtCraft Launcher). The updater, the self-update
helper and craft-update's startup prompt all get them through crate::UPDATE_APP; the
prompt draws the icon, the accent and "by ArtCraft" (craft-update's default developer).
craft-update is pinned to storytold/craft-libs main at 1065653e7 (#434).
Clippy fixes for Rust 1.99 in untouched code (same logic):
- crates/prores/src/decode.rs
- crates/ui-egui/src/panels/file_dialogs.rs
- crates/ui-egui/src/panels/timeline/interact.rs
- crates/ui-egui/src/panels/timeline/layout.rs