With several text clips selected, the Properties panel shows the first
one, and every property it changed was sent as `graphics.set` with that
clip alone, so Font, Font Size and the other properties changed only the
first clip.
`graphics.set` can take `clips` in place of `clip`: the same props on
that layer of each listed graphic clip, in one undo step (the merge key
names every target, so a drag stays one step), and an error on any clip
changes none. The graphic editor sends the clip it shows plus every other
selected graphic clip whose layer at the same place is the same kind of
layer, leaving out clips on locked tracks. Character styles of a Type-tool
selection still go to the clip being edited.
FilmCraft's local VC-3 codec moved to craft-libs as craft-video's dnx
module (craft-libs #702-#708, with the #4101 scan-line fix ported in #833).
Turn on craft-video's dnx feature at the existing 156b491b pin and point
the MOV / MXF probes, the DnxDecoder and the DNxHR export encoder at it.
The shared decoder budgets 256 MiB of planes per coding unit by default,
which would refuse 8K DNxHR 444 with alpha. Keep FilmCraft's previous
1 GiB whole-frame ceiling: check it on the first coding-unit header
before anything is allocated, and raise the shared per-unit budget to
match. Tests cover the 16384x16384 rejection (ported from the removed
crate) and the 8K 444 + alpha admission.
Refs storytold/craft-libs#778, storytold/craft-libs#781
bs.tsv: Bosnian (Latin script, Ijekavian) catalog covering every key of FilmCraft's other catalogs, its wording shared with storytold/craft-i18n locales/bs/ and the strings craft-i18n lacks translated new. Every bs-* locale selects it; counts use one/few/other. Locale and plural tests, localization docs and an attribution entry (AI-assisted, not yet reviewed by a native speaker).
* export: name the video encoder in the report, warn when hardware encoding falls back to software
* export: queued items carry their report, and the CLI prints its warnings with --queue (#3952)
* events: show a finished export's warnings after its Finished line (#3952)
* docs: queued exports and Events report the encoder fallback (#3952)
* cli: a queued export's warnings come only from the items it added (#3952)
* Exact time and caption formats come from craft-libs
filmcraft-time is a re-export of craft_timeline::time, and the caption
format modules (SRT, WebVTT, SCC, MCC, EBU STL, TTML) are removed for
craft-captions. filmcraft-captions keeps the mapping onto caption tracks,
the burn-in and FilmCraft's program name in written MCC and STL files.
craft-libs is pinned at df469bb2.
* M3: pin timeline and caption crates to current craft-libs
Containers, MP3 encoder and video decoders come from craft-libs
* Containers, MP3 encoder and video decoders come from craft-libs
The AVI, MPEG-TS/PS, MP3 encoder, H.264, HEVC, VP9, AV1, MPEG-2 and APV
crates are removed. craft-media (avi, mpegts), craft-audio (mp3-encode)
and craft-video (h264-decode, hevc-decode, vp9-decode, av1-decode, mpeg2,
apv), which were cut from them, replace them. Every craft-libs crate is
pinned at craft-libs 50f21899.
* MXF comes from craft-libs; craft-libs at df469bb2
crates/mxf is removed for craft_media::mxf. Both writer entry points name
FilmCraft (company, product, version) as the old writer did, so the bytes
and the product UID are unchanged; the export and AAF tests check it.
* docs: the VP9 and AV1 hostile_lengths WASI run points at craft-video
* Audio codecs and Ogg come from craft-libs
The AAC, AC-3, FLAC, MP1/MP2 and Opus crates and the Ogg demuxer are
removed. craft-audio and craft-media, which were cut from them and carry
their later changes, replace them.
* codecs: an Opus stream without a header packet is a decode error; craft-libs at b72cb4d6
An Ogg file whose first packet is larger than the header cap is filed as data,
so an Opus stream can arrive without its OpusHead; indexing headers[0] panicked.
The new craft-libs pin brings the Opus granule bounds from #4049 (craft-libs #859).
* #2633: the scrub playhead no longer waits for the audio device
Opening a WASAPI output stream starts the Windows audio engine: 559 ms
measured on Realtek from a cold engine (19-23 ms while another stream is
running). A playhead drag paid that on the UI thread, twice: scrub_playhead
called app.stop() on every press, and the press path runs twice per drag, so
the first grain's stream was closed and opened again. CpalOut::config also
listed every supported configuration (191 ms) even when the device already
ran at the wanted rate.
Only stop a transport that is running, skip the rate search when the device's
default rate is the wanted one, and play the scrub grain on its own output
(ScrubOut / CpalScrubOut): its thread owns the stream (cpal's Stream is
!Send), keeps it for 5 s after the last grain and swaps in the current mixer
per grain. The UI only sends over a channel, so a press or a drag does no
blocking work.
Measured before and after in docs/performance.md.
* #2633: a ruler press also stops a stream a panicked frame left playing
A panel that panics is caught in App::ui, which clears playback.playing but does not stop the audio output: the stream keeps playing and playback.audio_clock stays true. The transport check now counts that clock, so a press on the ruler still stops it instead of scrubbing over the sound. Found by CodeRabbit on #3000.
* #2633: the scrub output follows the sequence it plays
`CpalScrubOut` took the sequence rate once, at construction, and `apply_prefs`
carried it again only when the audio hardware preferences changed. Settings ->
Sequence, opening another project and switching sequences change what the next
grain needs without touching them: a stale rate mixed grains at the wrong speed,
and an open stream (the button is down, or it lingers for a moment after the
release) kept the fill, and the mixer inside it, of the sequence that was active
when it opened.
`apply_prefs` now compares the active sequence and its sample rate with what the
output was configured for, and reconfigures the output only when the rate
changes; another sequence at the same rate just opens the stream again, so the
next grain replaces the fill in place. No event tracking: `ProjectChanged` fires
on every edit, and the comparison costs two options per frame.
* Scrub output tests: a stand-in stream instead of the real device
On Windows the audio test binary crashed (STATUS_ACCESS_VIOLATION) in the second
scrub test. cpal's WASAPI device enumerator lives in the COM apartment of the
thread that first used it, and libtest's per-test threads end with their test,
so the next test to enumerate devices read freed memory. Main's audio tests pass
on Windows because none of them touch a device.
CpalScrubOut::spawn takes the stream opener (new() passes open_scrub), so the
tests drive the scrub thread with a FakeStream that takes 600 ms to open, like a
cold WASAPI engine, and reports when it is dropped. They now check what matters:
play returns at once during a cold open, a second grain reuses the stream,
release closes an open stream before it returns, answers at once when nothing
is open, and waits at most RELEASE_WAIT for a stream still opening, which then
closes once open. The release test fails when Release leaves the stream open.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* #2553: a GPU that can't draw to the window falls back to the integrated one instead of panicking
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* #2553: a second panic saves the next mode instead of going back to the default
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* #2553: after a graphics panic, FilmCraft starts again in the next mode instead of retrying in-process
The event loop does not run again in a process it unwound out of: on the #2553 laptop the
in-process retry returned at once and no window opened until the next launch.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* #2553: a relaunch keeps the -- separator and the files after it
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Fixes#1868. Display labels only; effect ids (lumetri, ...), panel ids, automation ids, preference keys and project data are unchanged.
- Lumetri Color/Scopes/Presets -> Color Grading / Video Scopes / Color Grading Presets in the UI and all 16 catalogs; old names still resolve for panels, shortcuts, automation and Effects-panel search.
- FCP7 XML, FCPXML and EDL exports keep writing the previous Lumetri names, so interchange output is unchanged.
- Mercury Transmit -> External Video Output, shown disabled ("This preference is not available yet.") until it exists.
- Ultra Key, Warp Stabilizer and Morph Cut keep their names until RFC-0029 settles.
About > Contributors still showed an old snapshot, because nothing
regenerated contributors/contributors.json before a release. Opt in to
the shared refresh from craft-common-actions: a read-only credits job
regenerates the snapshot for the release commit, and the shared release
workflow installs it before every source build. The snapshot is not
committed back.
request, execute, commands and screenshot move onto the shared crate (storytold/craft-libs#413): a timeout on every call, the screenshot's PNG also in data (pngBase64 stays), and uiInspect beside them. inspect, info, files, readFile, importFiles, importUrl and openProject stay FilmCraft's own, on the same object.
* Projects: Open Project asks to save unsaved changes first
File ▸ Open Project opened the chosen project at once, so a project with
unsaved changes was replaced without a prompt. Close Project and Quit
(#758) already ask first.
In the desktop app, once the project to open is chosen, the same Save
Project prompt now appears when the open project has unsaved changes,
with the automation ids `openProject.save`, `openProject.dontSave` and
`openProject.cancel`. Save saves the project and then opens the chosen
one; a never-saved project goes through the Save dialog, and canceling
it returns to the prompt. On Linux, where the Save dialog does not
block, the prompt stays open after a never-saved project is saved, as
it does for Close Project and Quit, and a second Save or Don't Save
opens the chosen project. Don't Save opens the chosen project without
saving, and Cancel keeps the open project. When the chosen project
can't be opened, the open project stays open with its changes and the
error goes to the status line. `file.open` with a `path` opens without
asking, as before. The prompt reuses existing strings.
* Contributors: add dotCooCoo (Robert Lee)
* Projects: Open Recent and Home's Recent list ask to save unsaved changes first
File > Open Recent and a click in Home's Recent list sent `file.open`
with a path, so a project with unsaved changes was replaced without a
prompt. Both now call `intercept_open` and show the Save Project prompt
first, as Open Project does. After Save or Don't Save the chosen project
opens; a Recent row on Home then switches to Edit, as it does without
the prompt. `file.open` with a path from the control channel or MCP
still opens without asking.
* Projects: Open Project opens the chosen project after a later Save dialog answer
On Linux the Save dialog answers in a later frame. Save in the Open Project
prompt on a never-saved project checked whether the project was saved right
after showing the dialog, found it unsaved and showed the prompt again; the
answer then saved the project but did not open the chosen one.
Saving and then opening the chosen project now run when the dialog answers.
A canceled dialog or a failed save shows the prompt again, with the reason in
the status line. An answer that arrives after another project was opened,
created or closed to does nothing: `Session::project_generation` counts the
projects a session has held, as in #2437. The prompt offers Save whenever a
Save dialog can be shown, also through `HostHooks::run_dialog`.
* Projects: a save prompt closes when a script replaces its project
The Close Project, Open Project and Quit prompts stayed open when a
script opened, created or closed to another project while they were
shown, and Save or Don't Save then acted on the new project: Don't Save
discarded its changes and Save saved it. Each prompt now records the
project it was asked over (`Session::project_generation`) and closes
when that project has been replaced.
* Projects: a Recent row on Home switches to Edit only once its project opens
With unsaved changes, a click in Home's Recent list switched to Edit as
soon as the Save Project prompt appeared, so Cancel left Edit showing
the current project instead of Home. Home now stays while the prompt is
shown and after Cancel, and switches to Edit after Save or Don't Save
opens the chosen project, also when Save first asks where to save.
* Open Project: a failed save keeps the prompt and the chosen project
When the open project already has a file and saving it fails, the Open Project prompt now stays open with the chosen project, as it does for a project that was never saved. The error shows in the status bar.
* Open Project: only its prompt offers Save through a Save dialog that answers later
Close Project and Quit offer Save for a never-saved project only where the Save dialog answers at once, as on main. After a Save dialog that answers later, only Open Project goes on to its next step.
* Projects: a failed save keeps the Close Project and Quit prompts
When the open project already has a file and saving it fails, the Close Project and Quit prompts now stay open, as the Open Project prompt does. The error shows in the status bar.
* Projects: the Open Project prompt blocks panels in floating windows
While the Open Project prompt is shown, panels in floating windows no longer take input, as for the Close Project and Quit prompts.
* render, gpu: adjustment layers composited on the GPU
An adjustment layer anywhere at a time sent the whole frame to the CPU
renderer, so GPU rendering did nothing for the frames under one. A
full-frame adjustment layer at 100 % opacity, Normal, unmasked and with
only effects the GPU stage runs is now a PlanStep::Adjust: its effects
run in the effect stage on the accumulator (the composite of the tracks
below) and the result replaces it before the tracks above are drawn.
Every other adjustment layer keeps the whole-frame CPU fallback.
The export renderer takes Composite plans without transitions; frames
with a Push still go to the CPU there, as before. perf.stats gpu gains
adjustments / cpuAdjustments.
* docs: adjustment layers on the GPU compositor in parity and performance
hardware-parity.md gains an Adjustment layers row; performance.md gains
the main-against-branch export timings with an adjustment layer.
* render, gpu: adjustment layer review fixes
- is_cpu_frame and plan_frame now ask the same adjustment_ops (evaluated
at the render scale, which is_cpu_frame takes from the RenderOptions):
a Transform that shrinks the frame no longer takes a pooled export
renderer only to be rendered on the CPU and counted as a GPU frame.
- FxOp::eval leaves a Transform with its shutter angle on (motion blur)
to the CPU; the GPU drew it sharp, on clips and adjustment layers.
- The effect stage's texture pool spans the whole composite frame, so an
adjustment step's working textures are reused instead of made again
every frame. Composite plans honour resolve = false (export).
- ExportRenderer::render hands frames with an adjustment layer back to
the CPU when the device has no effect stage, instead of compositing
them on the CPU and uploading the result to read it back.
- adjustment_covers_output checks the full-frame geometry without
building the coverage image.
- The GPU adjustment test also runs without an effect stage.
* render, gpu, export, ui: plan adjustment layers for the device's caps
plan_frame and is_cpu_frame take plan::DeviceCaps (how large a frame
the device runs adjustment layers on; none without an effect stage), so
a frame the compositing device can't adjust becomes a CPU image on the
thread that plans it, never on the UI thread or inside a renderer slot.
- Monitor: the caps are part of the frame key
(Target::SequencePlan(seq, caps)), so a plan made for another device
is never reused.
- Export: FrameRenderer::caps is required; the renderer pool plans with
the smallest caps of its renderers before it takes one.
- The compositor's own CPU fallback stays as a safety net for a plan
made for other caps; the tests check that nothing reaches it.
- Main's own-shutter Transform check replaces the duplicate guard in
gpufx.
Tests: a Push under an adjustment layer exported on the GPU against
render_sequence (forward and reversed, scales 1 and 0.5); routing
without an effect stage in the export pipeline and in the monitor's
frame server; GPU parity against render_sequence with colour and alpha
for a partly transparent canvas, stacked adjustment layers, an empty
canvas, a nested sequence below and one inside a nest, at scales 1 and
0.5; caps boundaries and is_cpu_frame agreeing with plan_frame.
* gpu: end a refused effect image's frame; count steps once drawn
effect_image began an effect stage frame and returned without ending it
when the stage refused the job, so the stage stayed mid-frame and kept
its working images. The compositor's step counters are added once the
whole frame is drawn on the GPU, so a frame that falls back half way
no longer counts the steps it threw away.
* #1221: H.264 High 10 and High 10 Intra export in the built-in encoder
Stage 1 of #1221 (plus the intra-only option of stage 5):
- h264enc is generic over the sample type (u8 at 8 bits, u16 at 9-10 bits):
QP' = QP + QpBdOffset for quantisation and lambdas (QPY down to -12 at
10 bits), mb_qp_delta range/wrap, chroma QP mapping, deblocking alpha/beta/tC0
scaled to the bit depth, clipping in prediction, interpolation and
reconstruction. SPS bit depths, profile_idc 110, constraint_set3 for High 10
Intra, avcC high-profile fields, High 10 cpbBrVclFactor for level choice.
New YuvFrame16 / Encoder::encode16, EncoderConfig::bit_depth / intra_only.
- 8-bit output is byte-identical to main's encoder (pinned_decisions passes;
streams compared across profiles, presets, rate modes, slices, B-frames,
threads, two-pass, odd sizes).
- Oracle tests: ffmpeg decodes 10- and 9-bit streams bit-identical to the
reconstruction (presets, B-frames, slices, odd sizes, QP 22-46, CRF -12,
CBR, intra, avcC); ffprobe reports High 10 / High 10 Intra, yuv420p10le.
- Export: H264Profile::High10 (10-bit SDR via rgba_to_yuv420_10, HDR from the
float frames), h264_intra_only, MP4 / MOV / MXF OP1a (10-bit descriptor,
intra coding label), hardware encoders decline both, export dialog profile
entry ("10-bit color" on hover) and an All Intra checkbox, the bit depth in
the export summary, two Broadcast presets, flat h264Profile / h264IntraOnly
command parameters.
Rebased on main: ported into the split slice/ modules, the u32 quantisers
(exactness tests now cover QP' up to 63), main's Encoder::install and
prepare_ahead (High 10 converts in encode), export_mode/settings.rs,
tests/it/high10_oracle.rs; the new strings in every complete catalog
(es, fr, id, it, ja, ko, pt-br, zh-cn, de, ru, cs, pl, sv, tr, bs).
Not yet: High 4:2:2, High 4:4:4 Predictive, lossless, and >8-bit precision
from SDR compositing (SDR frames still arrive as RGBA8).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VECsf5SeZDHM5RDmcvRkM
* #1221: codec-parity header and revision history for High 10
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
* export: describe High 10 Master as a 10-bit master; list all APV profiles in file.exportMedia
SDR exports are rendered at 8 bits before the 10-bit conversion, so the preset
cannot promise a master without banding. Catalog keys and translations updated
in all 15 locales. Also list 4444-10, 4444-12 and 400-10, which apv_profile
already accepts.
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: FredApps <FredApps@users.noreply.github.com>
A page that embeds the web build can hand it a file and get every save back instead of a browser download, and hears about unsaved changes: ?host=parent for a same-origin iframe (postMessage, the protocol the GridCraft, PdfCraft, WordCraft and CADCraft bridges use) and data-host="page" on the canvas for a page that loads the module into its own document (non-bubbling CustomEvents on the canvas). The bridge holds a Transport (Parent or Page) with one send; the pure rules are unit-tested; the hosting guide documents both modes.
* feat(presets): native Adobe Premiere Pro .prfpset import and preset library
* Test that opening the Presets folder scans the library; open Presets last in the indent test
The Presets folder's new Import/Scan rows push the Lumetri sub-folders below the
Effects panel's visible area, so the indent test now expands Presets after them.
---------
Co-authored-by: justdxvid <178032210+justdxvid@users.noreply.github.com>
Co-authored-by: FredApps <FredApps@users.noreply.github.com>
lumetri.exportCube samples the clip's Lumetri Color on a lattice in the
sequence's output encoding and writes a 3D .cube; vignette, sharpen and the
HSL Secondary denoise and blur cannot live in a LUT and are named in the
result. The Lumetri Color panel menu gets Export .cube...
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The file.new* item commands take an optional bin, and the UI passes the bin
the Project panel shows (also through the New Sequence and Color Matte
dialogs).
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up/Down in a hot number's text field (Effect Controls, Lumetri, Properties)
did nothing useful. They now step the typed value by 1, or by the last shown
digit in a narrow range (Exposure steps 0.01); Shift is x10 and Cmd x0.1, the
drag multipliers. The new value is applied and stays selected, so typing
still replaces it.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
File > Export > Captions... always wrote the first caption track. With more
than one caption track the dialog now has a Caption Track menu, starting on
the track given by the command's `track` (the Text panel button passes the
one shown there) or else the first.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
With no colour tags, FilmCraft decodes with BT.709 transfer and
primaries and the matrix by frame size, and probe and media.colorInfo
showed those values with nothing saying they were defaults, so an
untagged file looked the same as one tagged BT.709.
VideoStreamInfo gets color_assumed (optional, left out when unknown):
which of the matrix, transfer and primaries no tag in the file gave.
MP4/MOV and Matroska take it from the same sources as the colour, APV
from its colour description, and AVI, MXF and Y4M mark all three.
probe prints it as video.color_assumed and media.colorInfo as assumed,
next to the unchanged metadata.
Co-authored-by: Brandon Thomas <echelon@gmail.com>
A moves[] entry gave its time only as integer ticks. Any other form, or
a missing clip or track, dropped the entry: alone it failed with "need
`moves`", next to other entries only those moved and the call said ok.
`time` now goes through tick_or_time_p like timeline.place's sourceIn,
and an entry without a usable clip, track or time is refused by its
index before anything moves.
* fix(export): an image-sequence export reports the stills it wrote
An export to `a.png` as an image sequence writes `a000.png`, `a001.png` and so on, but the
job's result, `file.exportMedia`'s `path` and the CLI's "exported" line all named `a.png`,
which does not exist.
The report now names the first still, the name `file.import` and `probe --image-sequence`
take for a sequence. `file.exportMedia` and `export.quick` name it as `path` up front, from
the frame count `export.resolve` uses, and add `lastPath`. The CLI prints both. A single
file keeps its path.
Fixes#4009
* fix(automation): a cancelled image-sequence export is cleaned up by its stills' name
Since `file.exportMedia` names an image sequence's first still as `path`, the MCP cancel
clean-up took `a000` as the stem: it left `a001.png` and every later still, and the `a.srt`
sidecar, behind. The result now also carries `basePath`, the name the stills are numbered
from, and the clean-up goes by it.
* fix(automation): an image-sequence cancel clean-up keeps the base name and finds .jpeg stills
An image-sequence export numbers every still, a single frame included, so a file under its base
name (`a.png`) is never its own: cancelling one deleted a user's `a.png` if it was saved during
the export. The stills of a `.jpeg` sequence were left behind instead, since the extension was
read as a format name, and `jpeg` names Motion-JPEG there; `file.exportMedia` keeps `.jpeg`
for a JPEG sequence.
* fix(automation): a cancelled image sequence removes only the stills it numbered
The clean-up matched any `<stem><3+ digits>.<ext>` written during the export, so cancelling an
export to `a.jpeg` could delete `a1000.jpeg`, the first still of an export to `a1.jpeg` in the
same folder. It now takes the digits and the last index from the result's `lastPath` and removes
only those names: `a000.jpeg` to `a120.jpeg` for a 121-frame export.
* media: name Apple Intermediate Codec and say why a clip is unreadable
Part of #3646. A MOV in Apple Intermediate Codec (fourcc icod, the
editing codec of iMovie and Final Cut) imported with its codec named
"unknown", and its frames failed with "no decoder for unknown video".
Only the log showed that error: the Project panel's badge said
"Unreadable" and nothing more.
- codecs: codec_label names icod "Apple Intermediate Codec". The
"no decoder" errors of make_video_decoder and software_video_decoder
use that label for sample entries the parser keeps as Unknown, so
the error reads "no decoder for Apple Intermediate Codec video".
Other codecs keep their short names in that error.
- ui-egui: an Unreadable badge shows on hover the error the media pool
recorded, on cards (Icon and Freeform view) and in List view, which
now registers its badge as project.item.<id>.offline as cards do.
This covers every cause the pool records, such as "H.264: field
pictures", not only this codec.
- docs: an Apple Intermediate Codec row in codec-parity.md, and the
hover in project-files.md.
FilmCraft still has no AIC decoder. Apple publishes no specification
for it, so a clean-room decoder (AGENTS.md section 2) needs a
maintainer ruling, and #3646 stays open for that.
Tests: apple_intermediate_codec_is_named_though_nothing_decodes_it in
filmcraft-codecs (the label and all three errors), and
unreadable_badge_says_why_on_hover in the ui-egui it suite (both views).
Developed with an AI assistant (Árbol, running Muse).
* ui: keep the List view's badges beside a long name (#3646)
In List view, a name that left less than 40 px of its column hid the
item's offline icon and proxy chip, and with them the Unreadable
badge's automation id and the reason it shows on hover. The badges now
keep their room at the end of the Name column, and a long name is cut
short before them. Only a column too narrow for the badges leaves them
out. Rows that showed their badges before, and rows without badges,
draw as they did.
unreadable_badge_says_why_on_hover imports a file whose name is wider
than the Name column, so its List view pass covers this case. Found by
CodeRabbit in its review of the pull request.
Developed with an AI assistant (Árbol, running Muse).
* codecs, ui: doc comments for codec_label and media_badge (#3646)
Both functions gained a role with the Apple Intermediate Codec change:
codec_label also names the codec in the no-decoder errors, and
media_badge records why an Unreadable file cannot be read. Their doc
comments say so.
Developed with an AI assistant (Árbol, running Muse).
* ui: end a List-view name cut short with "…" and show it in full on hover (#3646)
Keeping the badges' room at the end of the Name column can cut short a name
that used to fit, and the cut left no sign of it. The List view now draws the
name with the cards' elided_name, so a cut name ends in "…", and hovering it
shows the whole name, as the cards already do. Names that fit draw as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
CEA-608 has no code for some characters (the ellipsis, CJK) and the SCC
and MCC writers dropped them, or sent a close basic-set one (’ as '),
without saying so. The CEA-708 service in MCC sent ? the same way, for
instance for an em dash.
charset_warnings lists each such character once, with how often and
the first caption that has it, using the writers' own tables, and
captions.export returns the list as warnings. The list is capped at
20 characters per stream plus one summary line.
Co-authored-by: Brandon Thomas <echelon@gmail.com>
TTML and DFXP exports always wrote xml:lang="en", whatever the caption
track's language. The document now carries the language: export takes
the track's, TTML import reads xml:lang (a language tag of at most 35
characters, else a warning), and captions.import takes an optional
language that wins over both.
* interchange: EDL media relinked with Align Timecode lands on the file's own time (#3990)
An EDL's source times are timecodes, but its media items had no start
timecode, so Align Timecode had nothing to align from and a clip relinked
after an offline import kept its timecode as media time (the file's last
frame). EDL media now starts at timecode 0, and the relink shift reads each
timecode at its own file's rate, as the import-time rebase does.
* engine: EDL relink test checks the placeholder is listed missing, not its offline flag (#3990)
#4000 stops flagging EDL clips named only by clip name offline, so the setup asks media.findMissing instead, which lists the item either way.
* engine: the EDL relink test also runs with 25 fps media (#3990)
make_movie_at takes the frame rate. Under a 24 fps EDL a 25 fps file's timecode must be read at 25 fps: with the old shift (old_rate.tick_of(b - a)) the clip lands at -149 s instead of 1 s.
* cli: --save runs on one project take turns, so no edit is lost (#3924)
A run reads the project, edits it and writes the whole file back, so two
at once silently dropped the edits of whichever saved first. A run that
saves over the file it opened now holds an OS lock on `.<name>.lock` next
to the project from before its read until it exits. The next run says so
on stderr, waits, then edits what the first one saved.
The OS drops the lock however the process ends, so a crash leaves nothing
stale. If the lock can't be taken the run warns and saves as it did before.
The desktop app and `mcp` sessions don't take this lock.
* cli: the save lock goes by the path being saved over (#3924)
A save through a symlink replaces the link with a plain file. Resolving
the path therefore gave the runs before and after that save different
locks, and a run still waiting on the old lock could overwrite a later
run's save. The lock now uses the path as written, so replacing the link
can't change which lock a run takes.