From b1bd8d8b2005afbcbbba15936200f52a9dbee450 Mon Sep 17 00:00:00 2001
From: "Dylan M. Taylor" <dylan@dylanmtaylor.com>
Date: Thu, 12 Nov 2026 06:29:50 +0000
Subject: [PATCH] share legacy XLS test helpers

---
 crates/xlsx/src/tests/xls_dv_tests.rs | 17 +----------------
 crates/xlsx/src/tests/xls_tests.rs    |  6 +++---
 2 files changed, 4 insertions(+), 19 deletions(-)

diff --git a/crates/xlsx/src/tests/xls_dv_tests.rs b/crates/xlsx/src/tests/xls_dv_tests.rs
index 4f81c5084..cce7ce868 100644
--- a/crates/xlsx/src/tests/xls_dv_tests.rs
+++ b/crates/xlsx/src/tests/xls_dv_tests.rs
@@ -5,24 +5,9 @@
 use gridcraft_core::{CellRef, RangeRef};
 use gridcraft_model::{CfOperator, ErrorStyle, Validation, ValidationKind, Workbook};
 
-use super::xls_tests::compound;
+use super::xls_tests::{cat, compound, rec, u16s};
 use crate::{ReadReport, read_xls};
 
-fn rec(id: u16, payload: &[u8]) -> Vec<u8> {
-    let mut v = id.to_le_bytes().to_vec();
-    v.extend_from_slice(&(payload.len() as u16).to_le_bytes());
-    v.extend_from_slice(payload);
-    v
-}
-
-fn cat(parts: &[&[u8]]) -> Vec<u8> {
-    parts.concat()
-}
-
-fn u16s(v: &[u16]) -> Vec<u8> {
-    v.iter().flat_map(|x| x.to_le_bytes()).collect()
-}
-
 fn bof(dt: u16) -> Vec<u8> {
     rec(0x0809, &cat(&[&u16s(&[0x0600, dt, 0x0DBB, 0x07CC]), &[0; 8]]))
 }
diff --git a/crates/xlsx/src/tests/xls_tests.rs b/crates/xlsx/src/tests/xls_tests.rs
index bb2ac6e98..84189e674 100644
--- a/crates/xlsx/src/tests/xls_tests.rs
+++ b/crates/xlsx/src/tests/xls_tests.rs
@@ -133,18 +133,18 @@ pub(crate) fn compound(name: &str, data: &[u8]) -> Vec<u8> {
     out
 }
 
-fn rec(id: u16, payload: &[u8]) -> Vec<u8> {
+pub(super) fn rec(id: u16, payload: &[u8]) -> Vec<u8> {
     let mut v = id.to_le_bytes().to_vec();
     v.extend_from_slice(&(payload.len() as u16).to_le_bytes());
     v.extend_from_slice(payload);
     v
 }
 
-fn cat(parts: &[&[u8]]) -> Vec<u8> {
+pub(super) fn cat(parts: &[&[u8]]) -> Vec<u8> {
     parts.concat()
 }
 
-fn u16s(v: &[u16]) -> Vec<u8> {
+pub(super) fn u16s(v: &[u16]) -> Vec<u8> {
     v.iter().flat_map(|x| x.to_le_bytes()).collect()
 }