From cdcb05d4141124a42e26a08bf980d8e215eb50e8 Mon Sep 17 00:00:00 2001 From: "Dylan M. Taylor" Date: Wed, 4 Nov 2026 01:49:00 +0000 Subject: [PATCH] address review: report output-name exhaustion per file in create_separate --- crates/automation/src/assemble.rs | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/crates/automation/src/assemble.rs b/crates/automation/src/assemble.rs index aaccb2ac90..08dfcb516f 100644 --- a/crates/automation/src/assemble.rs +++ b/crates/automation/src/assemble.rs @@ -227,11 +227,14 @@ impl Automation { }); out.push(match converted { Ok((pdfcraft_engine::SourceKind::Pdf, ..)) => json!({ "path": p, "skipped": "already a PDF" }), - Ok((_, stem, pdf)) => { - let target = unused(&dir, &stem)?; - write_atomic(&target, &pdf)?; - json!({ "path": p, "output": target.to_string_lossy(), "bytes": pdf.len() }) - } + // every numbered name taken is this file's failure, not the whole call's + Ok((_, stem, pdf)) => match unused(&dir, &stem) { + Ok(target) => { + write_atomic(&target, &pdf)?; + json!({ "path": p, "output": target.to_string_lossy(), "bytes": pdf.len() }) + } + Err(e) => json!({ "path": p, "error": e.to_string() }), + }, Err(e) => json!({ "path": p, "error": e }), }); }