From fcd33e13165a7899695697e966df6debcddc23df Mon Sep 17 00:00:00 2001 From: mtlcl410 <2368091+mtlcl410@users.noreply.github.com> Date: Sat, 17 Oct 2026 13:13:51 +0800 Subject: [PATCH] M5: comment pop-ups follow PageCx's redaction look added since; Vietnamese for the pop-up undo labels Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01RUNQSPVXx3dDBabRZHAnjz --- crates/ui-egui/src/comments.rs | 12 +++++++++++- crates/ui-egui/src/i18n/vi.tsv | 5 +++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/crates/ui-egui/src/comments.rs b/crates/ui-egui/src/comments.rs index bced77fdc9..36da5192ee 100644 --- a/crates/ui-egui/src/comments.rs +++ b/crates/ui-egui/src/comments.rs @@ -1560,7 +1560,17 @@ pub(crate) fn popups(ctx: &egui::Context, view: &mut DocView, info: &DocInfo, hi { // The same size on the page, at the new place. let moved = Rect::from_min_size(at, placed.size()); - let cx = PageCx { page, xf: &xf, info, tool: QuickTool::Select, prefs: &CommentPrefs::default(), allowed, hidden }; + // Only converts the rectangle to user space: the redaction look is unused. + let cx = PageCx { + page, + xf: &xf, + info, + tool: QuickTool::Select, + prefs: &CommentPrefs::default(), + allowed, + hidden, + redact_mark: ([0.0; 3], 1.0), + }; let rect = cx.rect_to_user(moved); if at.distance(placed.left_top()) >= 2.0 { edits.push(Edit::SetAnnotationPopup { page, index: a.index, rect: Some(rect), open: None }); diff --git a/crates/ui-egui/src/i18n/vi.tsv b/crates/ui-egui/src/i18n/vi.tsv index 048f78f624..ffd7c73b72 100644 --- a/crates/ui-egui/src/i18n/vi.tsv +++ b/crates/ui-egui/src/i18n/vi.tsv @@ -2807,3 +2807,8 @@ key Space Space # AI-assisted additions for restoring the last view (#1767) (2026-10-16); not reviewed by a native speaker. Restore the last view (page, zoom and page display) when a document is opened again Khôi phục chế độ xem gần nhất (trang, thu phóng và hiển thị trang) khi mở lại tài liệu @plural {n} reply|{n} replies {n} câu trả lời + +# AI-assisted additions for comment pop-up windows (2026-10-16); not reviewed by a native speaker. + Open comment pop-up Mở cửa sổ bật lên của bình luận + Close comment pop-up Đóng cửa sổ bật lên của bình luận + Move comment pop-up Di chuyển cửa sổ bật lên của bình luận