mirror of
https://github.com/storytold/pdfcraft.git
synced 2026-11-15 03:37:03 +00:00
Dylan M. Taylor
606c560d24
* Use chrono for UTC/calendar conversion instead of hand-rolled copies Replaces the hand-rolled civil_from_days/days_from_civil copies and the leap-year/month math around them (log timestamp, PDF /Info dates, ASN.1 UTCTime/GeneralizedTime, FormCalc Date/Num2Date, the Combine modified-time stamp, the form date picker, and the demo-PDF timestamps) with chrono as a workspace dependency. The engine's existing chrono (clock) is lifted to the workspace. Every output format is unchanged and pinned by tests. CLAUDE.md now says time goes through chrono. Follow-up to storytold/cadcraft#1785 * Guard chrono date paths: no panic on overflow, no '+' on 5-digit years Systemic chrono follow-ups to the UTC/calendar PR: - logging::timestamp and combine_ui::utc_stamp dropped chrono's From<SystemTime> (which unwraps internally and panics on a clock past year 262143) for the fallible DateTime::from_timestamp, reading an out-of-range clock as the epoch, as the old clamping code did. - timestamp, utc_stamp, pdf_date and the xtask Stamp now write the year with {:04} instead of %Y, which prefixes a '+' before years past 9999; the old hand-rolled code wrote the plain zero-padded year. - forms_ui calendar navigation and length, and formcalc days_in, use checked_add for the December year successor so y + 1 can't overflow at i32::MAX / i64::MAX (reachable from a parsed or persisted date). Docstrings added to the chrono-touched civil_from_days and Time::from_unix for the docstring-coverage gate. Tests cover the out-of-range-epoch and 10000-01-01 cases for each. * Don't build an unrepresentable SystemTime in the far-future test UNIX_EPOCH + Duration::from_secs(u64::MAX / 2) overflows Windows' SystemTime and panicked before timestamp() ran, failing the Windows test job. Build it with checked_add and only assert where it exists. * Keep FormCalc dates exact past chrono's range MAX_DAYS accepts day numbers up to 1e8 (years past 270000), but NaiveDate stops near ±262143, so Num2Date(99000000) and Format fell back to 1900-01-01. days_from_civil, civil_from_days and days_in now have chrono convert within the date's 400-year Gregorian cycle and add whole cycles back (via i128), which gives the pre-chrono results for every year. Tests cover accepted inputs past chrono's range on both sides of the epoch, through Num2Date and Format, with values from the old formula. * Bump rustls-webpki and webpki-root-certs for RUSTSEC-2026-0382/0383 rustls-webpki 0.103.15 -> 0.103.16 and webpki-root-certs 1.0.9 -> 1.0.10 (both semver-compatible, lockfile only) drop the distrusted emSign intermediates and root. Only these two entries change; cargo deny check advisories passes. Upstream main fails the same check. * logging/cos/sign/combine/demo: keep extended-year dates, no epoch fallback For consistency with the stricter no-epoch-fallback rule now agreed across the sibling chrono PRs (wordcraft#3427, filmcraft#2662): `DateTime::from_timestamp(..).unwrap_or_default()` changes a timestamp the old code converted past chrono's year 262143 range — it collapses to 1970-01-01 instead of the real proleptic-Gregorian date. The FormCalc Num2Date path was already fixed (FredApps approved); this applies the same fix to every remaining conversion. Each site uses the 400-year Gregorian cycle (146_097 days) with chrono as the only calendar logic: chrono converts the day within one cycle, whole cycles carry in the year (i128, saturated into i64). PDF/ASN.1 format-specific year handling is kept exactly as the old code had it. Verified the cycle result equals the old formula across a wide range and at the extremes. - apps/pdfcraft/src/logging.rs `timestamp`: cycle `civil_from_days(u64)`; pre-1970 epoch clamp and ms/time-of-day format kept. Pins: +10_000_000_000_000 s -> 318857-05-20T17:46:40.000Z (was 1970); checked_add u64::MAX/2 s -> 292277026596-12-04T15:30:07.000Z (was epoch). - crates/cos/src/writer.rs `pdf_date` (i64): cycle converter, no year clamp (old code wrote `y` as-is, so a negative year keeps its sign). Pins: pdf_date(10_000_000_000_000)="D:3188570520174640Z", pdf_date(-10_000_000_000_000)="D:-3149180813061320Z". - crates/sign/src/der.rs `Time::from_unix` (i64): cycle converter; the `year` field is a u32, so the year is cast `as u32` (wrapping) exactly as the old code did — ASN.1 year width preserved byte-for-byte. Pins: from_unix(10e12).year=318857, from_unix(-10e12).year=4_294_652_378, from_unix(i64::MAX).year=219_250_468, from_unix(i64::MIN).year=4_075_720_767. - crates/ui-egui/src/combine_ui.rs `utc_stamp` (u64): cycle converter; pre-1970 epoch clamp kept. Pins: utc_stamp(10e12)="318857-05-20 17:46 UTC", u64::MAX/2 s="292277026596-12-04 15:30 UTC". - xtask/src/demo_pdf/pdf.rs `Stamp::from_unix` (i64): cycle converter, no year clamp. Pins: from_unix(10e12).iso="318857-05-20T17:46:40Z"/.pdf="D:3188570520174640Z", from_unix(-10e12).iso="-314918-08-13T06:13:20Z". cos/sign/xtask built, tested (pdf_dates_are_utc_and_byte_identical, der::tests::times, stamps_round_trip), fmt and clippy clean. pdfcraft-ui-egui and the pdfcraft app can't link here (unrelated LLVM intrinsic bug in the rten-gemm dependency, 1.98.1), so their logging and combine_ui functions + tests were copied verbatim into a scratch crate with chrono 0.4.45 and pass there; fmt --check clean on all five packages. CI builds these on all platforms. * Don't build a year-318857 SystemTime unchecked in the logging test Windows' SystemTime only reaches about year 30828, so UNIX_EPOCH + Duration::from_secs(10_000_000_000_000) panicked before timestamp() ran and failed the Windows test job. Build it with checked_add and assert where the platform can hold it. The year-10000 case fits everywhere and stays unconditional. * Name the 400-year range extension as the one exception to the time rule The rule said never to hand-roll calendar math, but the range fix (shifting by whole 400-year Gregorian cycles so dates past chrono's year range keep their old output) is cycle arithmetic, so the rule and the code disagreed. The rule now names that exception: the library still computes month, day and time, and only whole cycles are carried in the year. * Say the library computes month and day; time-of-day is plain arithmetic Narrows the range-extension wording: the date library computes the calendar fields, and splitting seconds into hours, minutes and seconds is ordinary arithmetic, which is what the code does.
74 lines
3.9 KiB
TOML
74 lines
3.9 KiB
TOML
[package]
|
|
name = "pdfcraft"
|
|
description = "PdfCraft desktop app"
|
|
version.workspace = true
|
|
edition.workspace = true
|
|
license.workspace = true
|
|
|
|
[lints]
|
|
workspace = true
|
|
|
|
[dependencies]
|
|
# Help ▸ Check for updates (issue #28): one HTTPS request to GitHub, over rustls with the OS's
|
|
# trusted roots. No bundled root list (webpki-roots and webpki-root-certs are CDLA-licensed).
|
|
ureq = { version = "3.4", default-features = false, features = ["rustls-no-provider", "_ring"] }
|
|
rustls-native-certs = "0.8"
|
|
pdfcraft-ui-egui = { workspace = true }
|
|
# `build_info`: the version and compile-time build label for `--version` and the log.
|
|
pdfcraft-engine = { workspace = true }
|
|
# wgpu draws; OpenGL (glow) is the fallback when wgpu can't start on an old or unusual GPU or
|
|
# driver (#461, #435, #392), and can be chosen with PDFCRAFT_RENDERER=gl.
|
|
eframe = { workspace = true, features = ["default_fonts", "wgpu", "glow", "accesskit", "wayland", "x11", "persistence", "links"] }
|
|
egui = { workspace = true }
|
|
serde_json = { workspace = true }
|
|
# Records from every crate go to standard error and the log file (src/logging.rs).
|
|
log = { workspace = true }
|
|
# The log timestamp goes through chrono (no hand-rolled calendar code).
|
|
chrono = { workspace = true }
|
|
|
|
[target.'cfg(target_os = "macos")'.dependencies]
|
|
# Finder double-click / Open With / Dock drops arrive as Apple events (#73); this small audited
|
|
# crate registers the handler (Objective-C interop needs unsafe, which our workspace forbids)
|
|
# behind a safe API. Same version as PhotoCraft. Pinned exactly: review the diff before bumping.
|
|
fmv-macos-events = "=0.1.0"
|
|
# ⌘Q asks about unsaved changes like the close button (#1136): an app menu whose Quit asks the
|
|
# window to close instead of winit's, which ends the process without asking.
|
|
craft-quit = { workspace = true, features = ["menu"] }
|
|
|
|
[target.'cfg(target_os = "linux")'.dependencies]
|
|
# Asks the Wayland compositor which GPU it draws with (linux-dmabuf feedback), so the window is
|
|
# drawn on that one (src/compositor_gpu.rs). Both are already in the tree through winit.
|
|
wayland-client = "0.31"
|
|
wayland-protocols = { version = "0.32", features = ["client"] }
|
|
|
|
[target.'cfg(all(unix, not(target_os = "macos")))'.dependencies]
|
|
# Whether the window is on Wayland, where it can't bring itself forward (src/single_instance.rs).
|
|
# Already in the tree through winit and eframe.
|
|
raw-window-handle = "0.6"
|
|
|
|
[dev-dependencies]
|
|
# Waits for wgpu's adapter, device and error-scope futures in tests (already in the tree through wgpu).
|
|
pollster = "1.0"
|
|
|
|
[target.'cfg(target_os = "linux")'.dev-dependencies]
|
|
# Exercise the vendored Wayland scroll policy with the actual winit event type.
|
|
winit = { version = "0.30", default-features = false, features = ["wayland"] }
|
|
|
|
[target.'cfg(target_os = "windows")'.dependencies]
|
|
# Which GPU drives which display (EnumDisplayDevices), so the window is drawn on the GPU that
|
|
# shows it (issue #378). Safe wrappers over Win32; only the `user` feature (which brings `kernel` with it),
|
|
# and `advapi` for the session id that names the single-instance socket (#3338).
|
|
winsafe = { version = "0.0.29", default-features = false, features = ["user", "advapi"] }
|
|
# Settings ▸ Accessibility ▸ Visual effects ▸ Animation effects (src/motion.rs), through WinRT's
|
|
# `UISettings`, whose bindings are safe to call (winsafe's `SystemParametersInfo` is an unsafe
|
|
# fn). Already in the tree through wgpu's DX12 backend; this adds one small namespace to it.
|
|
windows = { version = "0.62", default-features = false, features = ["std", "UI_ViewManagement"] }
|
|
# Single instance (#282): later launches hand their files to the running app over a Unix domain
|
|
# socket. `std` has no Unix sockets on Windows, and calling Winsock directly needs unsafe, which
|
|
# our workspace forbids. Already in the lockfile through zbus; pinned exactly, review before bumping.
|
|
uds_windows = "=1.2.1"
|
|
|
|
[build-dependencies]
|
|
# Icon + VERSIONINFO for pdfcraft.exe; build.rs only uses it when targeting Windows.
|
|
winresource = "0.1"
|