a3ea9a4277
* feat(ui): integrate edit-session guide drafts and interaction-check scenarios * fix(ui): repaint guide previews after automation field changes * fix(guides): retain drafts after command refusal * Restore the upstream Git-source check and keep guide replay local * Document pending source approval and shared replay workflow * Clarify that shared CI support for guide replays is pending * Vendor the guide edit dependency for source review Keep the edit-session revision and runtime behavior. Track its source, licenses, checksums and lifecycle tests in-tree in response to the source review in #9190. Apply the workspace lint policy to the standalone crate. * Move edit-session into ui-egui as a module (drop vendor/) The edit-session code now lives in crates/ui-egui/src/edit_session.rs, with its tests in edit_session/tests.rs, following the project's module layout. This removes vendor/edit-session, the path dependency, the workspace member, the NOTICE entry and the xtask layers entry. --------- Co-authored-by: Anton Pepperok <perchneko.anton@gmail.com> Co-authored-by: Perchenko Anton <perchenkoanton@iMac-Perchenko.local> Co-authored-by: FredApps <FredApps@users.noreply.github.com>
2.7 KiB
Guide editing drafts and interaction checks
Edit Selected Guides previews orientation, position and colour on the canvas without editing
the document. OK sends one view.editGuide command; Cancel and Escape discard the preview.
An unchanged OK leaves Undo/Redo intact. Invalid text keeps the last valid preview and cannot
commit. A document revision, target or ruler-unit change invalidates the draft; reopen the
dialog to start again. Undoing a concurrent edit does not revive an old draft.
If the final command is refused (for example by the automation policy), the dialog reopens
with the typed fields, error and last valid preview. Retrying uses the original target and
revision; switching documents or editing the target before retry still invalidates the draft.
The UI uses the edit_session module in ui-egui (crates/ui-egui/src/edit_session.rs) for the draft lifecycle and no-op/stale checks.
PhotoCraft retains guide selection, parsing, rendering and history ownership. Validation runs
the existing command on a temporary COW document only when parameters change. The live document
is changed only by the ordinary command after successful confirmation. Rounded ruler text that
was left untouched preserves the exact original position.
Running the scenarios
The interaction-check runner is development-only; Python is not a PhotoCraft runtime dependency. To run the scenarios locally, use the revision below. Automated execution needs a separate shared workflow and maintainer review. The adapter belongs to PhotoCraft and calls the shipped dialog handlers, control field setter, egui canvas/dialog frames, engine commands and history. Expectations are never passed to the adapter. These are semantic integration checks, not a substitute for screenshot or pointer tests.
git clone https://github.com/PerchAnton/interaction-check ../interaction-check
git -C ../interaction-check checkout --detach f8d4282d61576ffe78d18553c642d215887e2d9f
cargo build --locked -p photocraft-ui-egui --example guide_edit_scenarios
python3 ../interaction-check/interaction_check.py --timeout 30 \
--report guide-edit-report.json tests/interactions/guide-edit/*.json -- \
target/debug/examples/guide_edit_scenarios
Each scenario gets a fresh application with a 400 × 200 document at 100 ppi and vertical guides at 10 and 20 px. Reported state reads committed and preview guides, history depth, Redo, dialog validity and the real session command journal. The scenarios cover a single committed edit, Undo/Redo, cancellation, invalid input and recovery, no-ops, fractional positions, orientation and colour, document switching, deleted index reuse and an edit followed by Undo.