Merge main into fix/recolor-group-keeps-gradient-swatches

This commit is contained in:
dotCooCoo
2026-11-18 06:36:10 -08:00
94 changed files with 4691 additions and 250 deletions
+5
View File
@@ -51,6 +51,11 @@ The **Dimension Tool** is in the Modify section of the toolbar. Its strip offers
point as before. An unlinked dimension that
turns has its line where the turn puts it, or, when that would put it between the points, as
far past the outermost point as before.
With Smart Guides on, a linear dimension placed with its line within the Smart Guides snapping
tolerance of the level of a parallel line of a visible, unlocked linear dimension already drawn
anywhere in the document has its line on that level. This is VectorCraft's own rule. With
Alignment Guides on, a guide runs along the level across both lines while the dimension is
placed.
- **Angular:** hover a corner where two straight segments meet and drag outwards. Or click two
straight lines that meet (or would, extended), then click to place.
- **Radial:** hover a circle, or a segment that is a perfect arc, and drag: outwards gives its
+10 -2
View File
File diff suppressed because one or more lines are too long
+70 -20
View File
@@ -1,6 +1,6 @@
# VectorCraft MCP server
> **Last updated:** 2026-11-14 · **Change:** `text.setFormat {composer}` and paragraph styles also take `standardSingleLine` and `standardEveryLine` (#4935); existing values and responses unchanged. Previously: Pencil ignores Smart Guides and Snap to Point and shows no Smart Guides, #7252; no response-shape change. Previously: Pencil continuation, straight-line and closing cursors; scores and estimates unchanged; no response-shape change. Previously: Snap to Point with Smart Guides off draws no Smart Guides labels or lines, #7250; no response-shape change. Previously: Envelopes: a top object's side whose pieces are all one curve split at anchors follows that curve's parameter (#7097); existing response shapes retained.
> **Last updated:** 2026-11-18 · **Change:** Production Preflight command and report coverage; previously: `text.setFormat {composer}` and paragraph styles also take `standardSingleLine` and `standardEveryLine` (#4935); existing values and responses unchanged. Previously: Pencil ignores Smart Guides and Snap to Point and shows no Smart Guides, #7252; no response-shape change. Previously: Pencil continuation, straight-line and closing cursors; scores and estimates unchanged; no response-shape change. Previously: Snap to Point with Smart Guides off draws no Smart Guides labels or lines, #7250; no response-shape change. Previously: Envelopes: a top object's side whose pieces are all one curve split at anchors follows that curve's parameter (#7097); existing response shapes retained.
>
> Tech Circuit update (2026-11-14): three original procedural brushes; ten built-in brush libraries (G5).
@@ -724,7 +724,7 @@ ends the wait, so the sampler can be shown again. The BSDs and headless sessions
| `add_text` | `{text, x?, y?, width?, height?, fit?, fitMinPercent?, path?, mode?, pathEffect?, size?, font?, color?, justify?, vertical?}` | Point type at (x, y) (`justify`: `left`, `center` or `right` starts, centres or ends each line on x); area type with `width`/`height` (`fit`: `none`, `autoHeight`, `shrinkText`, as `text.areaOptions`); or `path` + `mode` (`area`/`onPath`) to flow text in or along a path, with `pathEffect` for type on a path (`rainbow`, `skew`, `3dRibbon`, `stairStep`, `gravity`; SVG export writes type on a path with any effect other than `rainbow` as outlines, with a warning). An invalid effect is rejected before editing. `justify` (also `auto`, `justifyAll`) aligns the paragraphs of every kind, as `text.setStyle` does later. `vertical: true` uses the existing vertical writing mode for every kind (default `false`, horizontal). Returns `{id}`, with `overflow: true` when the text doesn't fit its frame or path. |
| `apply_effect` | `{effect?, params?, ids?}` | Appends a live effect. Without `effect`, returns the effect catalogue with parameters and defaults. |
| `pathfinder` | `{operation, ids?}` | `unite`, `minusFront`, `intersect`, `exclude`, `divide`, `trim`, `merge`, `crop`, `outline`, `minusBack`. For a live version, apply the `pathfinder.*` effect to a group (`effect.apply` groups several loose selected objects first). In remote desktop mode, `run_command` and `invoke_menu` can both call `pathfinder.repeat` with `{}`. Successful panel operations, direct `object.pathfinder.*` commands, and `command.batch` steps (including Actions panel playback) set its history. Repeat applies it to the current selection using current Pathfinder Options. Trap, compound-shape edits, live effects and `action.batch` do not set history. With no history it returns "no Pathfinder operation applied yet". |
| `transform` | `{ids?, dx?, dy?, rotate?, scale?, scaleX?, scaleY?, reflect?, shear?, origin?, copy?}` | Runs move, rotate, scale, reflect, shear in that order. `rotate` is in degrees counter-clockwise; a positive `shear` moves the top to the right. With `copy`, the first step duplicates. A `scale`, `reflect` or `shear` that its command would refuse returns that error before any step runs; nothing changes and no undo step is recorded. |
| `transform` | `{ids?, dx?, dy?, rotate?, scale?, scaleX?, scaleY?, reflect?, shear?, origin?, copy?}` | Runs move, rotate, scale, reflect, shear in that order. `rotate` is in degrees counter-clockwise; a positive `shear` moves the top to the right. With `copy`, the first step duplicates. A `scale`, `reflect` or `shear` that its command would refuse returns that error before any step runs; nothing changes and no undo step is recorded. The same holds for a step that is not a number, a `reflect` that is not a string, a `copy` that is not true or false, and an `origin` that is not two numbers; a null `reflect`, `copy` or `origin` is left out. |
| `create_graph` | `{type?, x, y, width, height, csv? \| series?, categories?, rows?}` | The nine Illustrator graph types: column, stacked column, bar, stacked bar, line, area, scatter, pie and radar. An empty CSV cell or a `null` in `rows` is a blank value; a number in straight quotes is a label. Edit later with `graph.setData` / `graph.setType` via `run_command`. `graph.column {design, columnType: vertical\|uniform\|repeating\|sliding, each, fractions: chop\|scale}` draws the columns or bars of the series picked with Group Selection (or `seriesIndexes`, or all of them) with a graph design saved by `graph.design`; with no `design` it returns the series' current design and options. Type in the design that holds a `%` followed by two digits shows each column's value, with at least the first digit's places before the decimal point and the second digit's places after it. |
| `text_wrap` | `{ids?, offset?, invert?, release?}` | Area type below the objects (same layer) flows around them. `offset` is in points, from -1000 to 1000 (default 6). An offset outside that range or not a number, or an `invert` or `release` that is not true or false, is an error and changes nothing; `object.textWrap.make` and `object.textWrap.options` refuse the same values. |
| `undo` / `redo` | `{}` | Many calls that change nothing record no undo step, for example `object.align` with nothing to move, `object.move` by 0 without `copy` and `object.showAll` with nothing hidden. `undo` (`edit.undo`) after such a call undoes the step before it. Settings that change without an undo step stay as they are when `undo` or `redo` brings back a step that did not change them: the perspective grid's view options and active plane, the grid preferences (`gridlineEvery`, `gridSubdivisions`), the export settings (`assets.settings.set`), and the current brush and symbol. A step that changed one of them, such as a perspective grid preset that shows the grid, takes that change back. The point Automatic Plane Positioning holds comes back with the step, and is let go when the active plane kept is another one. `inspect_document` lists the undo steps as `history`. `run_command` with `edit.clearHistory` removes every undo and redo step of the active document and returns `{cleared}`, the number of steps removed; the document stays as it is, and the command records no undo step. `run_command` with `edit.newDocumentFromState` and `{index?, created?}` makes a new document holding the art as it was at that state and makes it the active document, and returns `{index, title}`. `index` is a row of the History panel, with 0 the oldest state kept, and an omitted or null `index` uses the current state. An `index` that names no state fails with `no history state N`, one that is not a whole number with `` `index` must be a whole number ``, and either changes nothing. `created` is File Info's created date in Unix seconds or null, and defaults to now. The new document takes the next `Untitled-N` name, is marked unsaved, has nothing selected and has no steps to undo or redo. It is out of symbol, opacity-mask and pattern editing, and the art drawn in a pattern's tile is stored in the pattern, as `object.pattern.done` stores it. The source document and its steps stay as they are, except that typing or a drag in progress is first kept as a step. When a command keeps a drag whose preview Real-time Drawing off had not applied yet (`edit.undo`, `edit.redo`, `edit.clearHistory`, `edit.newDocumentFromState` and the other commands that end a drag first), and applying that preview gives a warning, the command's result carries it as `previewWarning`, and as `warning` too when the command gives no warning of its own; the app's status bar shows `warning`. While the Type tool edits type, `undo` and `redo` put its caret, with no characters selected, at the end of the text the step changed: after the text it puts back or retypes, or where the text it takes out was. A step that changes no characters, such as a formatting change, leaves the caret and the selection where they are. |
@@ -5408,7 +5408,7 @@ error.
## Brush libraries
Brush libraries are read-only sets of brushes: ten generated in code (Art Ribbons, Ink and Wash, Calligraphic Nibs, Bristle
Brush libraries are read-only sets of brushes: eleven generated in code (Art Ribbons, Ink and Wash, Calligraphic Nibs, Pressure Sensitive with Flex Ribbon, Pulse Stroke, Round Flow and Chisel Flow, Bristle
Brushes with one bristle brush for each tip shape, Pattern Borders, Scatter Shapes, Game Trails, Energy Beams, and Dry Media with the Chalk Grain, Graphite Pencil, Wax Crayon and
Charcoal Dust art brushes, id `dry-media`, and Tech Circuit with Circuit Trace (art), Bus Lines and Terminal Nodes (pattern), id `tech-circuit`), the `.vectorcraft` files in the user library folder of the desktop app (User
Defined) and the brushes of any document loaded with `brush.loadLibrary` (a document without brushes of its own has
@@ -5441,7 +5441,10 @@ and several can be open at once. `window.swatchLibrary {library}`, `window.graph
`{open, panel, name, count}`; `library: null` closes every panel of that kind. The panel id is
`library:<kind>:<library id>` (`library:swatches:pastels`, `library:graphicStyles:hand-drawn`,
`library:swatches:loaded/C:/Palettes/Brand.ase`), and the panel commands take it like any other panel's:
`window.panel.float {panel, onto?, x?, y?}` groups or moves it, `window.panel.dock {panel}` docks it,
`window.panel.float {panel, onto?, x?, y?, width?, height?}` groups, moves or resizes it. Supplied
geometry also updates an existing native panel window. Positions are relative to the main window's
content origin; omitted coordinates and dimensions keep the native window's current values.
`window.panel.dock {panel}` docks it,
`window.panel.close {panel}` closes it. `window.swatchLibrary.other {path}`, `window.graphicStyleLibrary.other
{path}`, `window.symbolLibrary.other {path}` and `window.brushLibrary.other {path}` load a file and open it the same
way.
@@ -9223,6 +9226,21 @@ Screens doesn't write EPS.
{"name":"export","arguments":{"path":"/tmp/art.eps","options":{"useArtboards":true,"cmykPostScript":false}}}
```
## Production Preflight
`document.preflight {output?: "pdf"|"print"|"screen", minPpi?: 1..9600, artboards?: [index, …]}`
checks the active document without editing it or writing an export. Defaults: PDF, 300 ppi
(96 ppi for Screen), all artboards. Indices are zero based. Print uses the saved Print settings
with the requested artboards, including page scaling; PDF and Screen check visible art on them.
The result contains `checks` for `fonts`, `text`, `links` and `resolution`, each with `status`
(`passed`, `failed`, `notChecked`), finding `count` and `notChecked` count. `findings` give a
`code`, canvas `ids` and `name`; link findings also carry `sourceId`, and resolution findings
carry `effectivePpi` and `threshold`. `outputWarnings` carries the Print preview's output/settings
warnings. Resource findings point to their first visible canvas owner. Resolution inside resource
art or placed documents is explicitly not checked; a pass is not certification of an exported file.
See [Production Preflight](production-preflight.md) for the panel and coverage limits.
## Print
File → Print lays the job out as a print-ready PDF, in which each page is a sheet of the chosen paper. The desktop app
@@ -9569,7 +9587,7 @@ File → Export → Save for Web (Legacy) writes optimised web images: `document
…}` renders the artboard (`clipToArtboard`, the default; `artboard` picks one) or the visible art and the slices, at
`width`, `height` or `percent`, and encodes it with the format's settings: for GIF and PNG-8 `reduction`, `colors`,
`dither`, `ditherAmount`, `transparency`, `matte`, `interlaced`, `webSnap`, `lossy` (GIF) and `colorTable {locked,
transparent, webShift, sort, deleted, customPalette}`; for JPEG `quality`, `progressive`, `optimized`, `embedProfile` and `matte`; for PNG-24
transparent, webShift, sort, deleted, customPalette, shifted}`; for JPEG `quality`, `progressive`, `optimized`, `embedProfile` and `matte`; for PNG-24
`transparency`, `matte` and `interlaced`. `metadata` (none, copyright, contact, all) writes File Info as PNG text or a
GIF/JPEG comment; `convertToSrgb` marks PNGs as sRGB. `<stem>` is the name of `path` without its extension, or
without `path` the document's title with the characters Windows does not allow in a file name as `-` and a `-` after
@@ -9582,7 +9600,7 @@ couldn't be decoded and is missing from the image; the files are written all the
`document.exportForWeb.preview` returns what Save writes for the same settings without writing it: `bytes` (the exact
file size), `seconds` to download at `kbps` (default 56.6), the size, and for palette formats the colour table
(`colors: [{color, source, transparent, locked, webShifted, webSafe}]`). The colour table's lists name colours by
(`colors: [{color, source, transparent, locked, webShifted, shifted, webSafe}]`). The colour table's lists name colours by
`source` (the colour the reduction made), so a colour keeps its edits when it is web-shifted or snapped. `slice: n`
previews one slice; `image: true` adds the file; `warnings` holds the export's warnings.
@@ -9592,15 +9610,38 @@ file agree. A deleted color also leaves `locked`, `transparent` and `webShift`.
ignored. Deleting every opaque color is an error, and the settings, preview and files do not change; the transparent
entry of transparent pixels cannot be deleted. `colorTable.customPalette: ["#rrggbb"…]` is a fixed palette (a Custom
table) used instead of the reduction's own, at most `colors` entries with the transparent one included, so a color it
lacks is not made again; the dialog's Delete Color sets it to the table's colors on the first deletion. Both lists hold
lacks is not made again. Its colors in `transparent` all become the transparent entry and take one of the `colors`
slots together (when no pixel is transparent and no pixel takes one of them, that slot goes to its next color); its
other colors fill the remaining slots in order. The dialog's Delete Color sets it to the table's colors on the first deletion. Both lists hold
at most 256 colors, and `#rrggbbaa` is refused. A `reduction` change without `colorTable` in the same params clears
both lists. JPEG and PNG-24 have no color table and do not read them. Presets and `webExport.settings` keep them. In
the dialog a click selects one color, Shift-click selects the colors between it and the last one clicked, and
Ctrl-click (Command-click on macOS) adds or removes one (`__colors` holds the selection, `__color` the last one
clicked). The trash button and Delete Color in the table's menu delete the selection in one edit, Restore Generated
clicked). The trash button and Delete Color in the table's menu delete the selected colors the table shows in one edit,
and are off when it shows none of them (a selected color can leave the table when the reduction or the color count
changes). The Lock, Transparent and Web Shift buttons act on the last color clicked, and are off when the table no longer
shows it. Restore Generated
Table in that menu clears `deleted` and `customPalette`, and the table reads Custom while either is set. Choosing
another reduction in the dialog also clears them.
Shifting a color is `colorTable.shifted: {"#source": "#rrggbb"…}`, by `source`: every pixel of that color is
written as the color given, in the preview and the file. The color is kept when the colors are reduced, as a
locked one is: the shifted and locked colors take the palette's slots first, shifted ones before locked ones, and at
least one slot is left for the reduction, so with `colors: 2` and transparent pixels none is kept and a color left out
shifts nothing. As with a locked color, a kept source stays in the palette when the art no longer has it, and the
pixels nearest to it are written in the new color. The preview marks it `shifted` and `locked`. A shift by hand wins over `webShift`, `webSnap` and
`locked`; a color mapped to transparent stays transparent. GIF `lossy` moves no pixel into or out of a shifted color.
Two colors may be shifted to the same color. A source the
table does not hold shifts nothing, and the shift stays with the settings for when it comes back; another reduction
keeps it. The settings store the map in lowercase, drop a color shifted to itself or deleted, and drop the `webShift`
of a color shifted by hand. More than 256 entries, a key or value that is not a color such as `#ff8800` (`#rrggbbaa`
included), and two keys that name one color are errors. Presets and `webExport.settings` keep the map. In the dialog a double-click on an
opaque swatch opens the Color Picker on the color shown (on the source color for a color already shifted; an agent
sets `__editColor: "#source"`). Its OK shifts the color (picking the source color takes the shift away), and Cancel
leaves the table as it was. A shifted swatch shows the source color at its upper left and the new color at its lower
right, with the lock mark, and Lock stays on until the color is unshifted. Web Shift replaces a shift by hand, and
Unshift All Colors in the table's menu clears `shifted` and `webShift`. Only Web Colors in the picker starts off.
```json
{"name":"run_command","arguments":{"command":"document.exportForWeb.preview","params":{"format":"png8","colorTable":{"deleted":["#ff0000"],"customPalette":["#0000ff","#00ff00","#ff0000"]}}}}
```
@@ -13371,18 +13412,26 @@ Commands:
where it touches the upper one; where a straight side of a path lies along the line, the line covers the whole
side. An ellipse drawn with the Ellipse tool, then moved, turned or scaled, is measured as an exact ellipse. Any
other path must be closed, have one outline, bend the same way all around and have at most 10,000 segments; an open
path, a path that bends inward, a path without area, a group, a compound path or type is refused, and so are two
paths whose outlines are the same to within the touching tolerance given below. Two separate paths have two
external and two internal tangents. Overlapping paths have external tangents only. A path inside the other has
none. Paths that touch, from outside or from inside, share one tangent there instead: a line centered on the point
where they touch and as long as the narrower path is wide along it. Paths that meet at a corner or along a shared
stretch of outline get one such line, at the middle of the directions that touch both. Paths count as touching when
the gap between them is less than the tolerance, a billionth of the larger of their sizes and the distance between
their centers. The lines are stroked with the current stroke color and weight (black when the stroke is None), have
no fill, go directly above the upper of the two paths and are selected; one undo step. When there is no tangent of
the kind asked for, nothing changes, and the result's `warning` says why. Common Tangents…
opens a dialog (Tangents, Centerline) with Preview. → `{ids, external, internal, centerline, warning?}`
(`centerline`: the centerline's id, or null).
path, a path that bends inward, a path without area (other than a point, described below), a group, a compound
path or type is refused, and so are two paths whose outlines are the same to within the touching tolerance given
below. Two separate paths have two external and two internal tangents. Overlapping paths have external tangents
only. A path inside the other has none. Paths that touch, from outside or from inside, share one tangent there
instead: a line centered on the point where they touch and as long as the narrower path is wide along it. Paths
that meet at a corner or along a shared stretch of outline get one such line, at the middle of the directions that
touch both. Paths count as touching when the gap between them is less than the tolerance, a billionth of the larger
of their sizes and the distance between their centers. One of the two may be a point instead, a path of one
anchor: the lines then run from the point to where they touch the path, two when the point lies outside it (one
that lies along a straight side covers the whole side), one when the point lies on its outline (centered on the
point and as long as the path is wide along it, or the whole straight side the point lies on), and none when it
lies inside. The point counts as on the outline when it is less than the touching tolerance from it, with the
point's distance from the path's center in place of the distance between centers. Every `tangents` value gives
the same lines, counted in `internal` when `tangents` is `internal` and in `external` otherwise; the centerline
runs from the point to the path's center. Two points are refused with "select two closed paths". The lines are
stroked with the current stroke color and weight (black when the stroke is None), have no fill, go directly above
the upper of the two paths and are selected; one undo step. When there is no tangent of the kind asked for,
nothing changes, and the result's `warning` says why. Common Tangents… opens a dialog (Tangents, Centerline) with
Preview; with a point selected, every Tangents choice gives the same lines. → `{ids, external, internal,
centerline, warning?}` (`centerline`: the centerline's id, or null).
A parametric shape is an ordinary path. It keeps its numbers, with a fingerprint of the outline they drew, in one
entry of its object data (`vc-pathtools-shape`, as `document.node` lists `attrs.data`), which SVG export leaves out;
@@ -14360,6 +14409,7 @@ the error text. The interactive fallback applies only to ordinary File > Save, n
| Date | Change |
|---|---|
| 2026-11-18 | Production Preflight: output and artboard scope, four check summaries, clickable canvas ids, effective PPI and explicit unchecked resolution coverage. |
| 2026-11-14 | Built-in Tech Circuit brush library (id `tech-circuit`): Circuit Trace, Bus Lines and Terminal Nodes; ten built-in libraries. |
| 2026-11-13 | The Pencil ignores Smart Guides and Snap to Point and shows no Smart Guides; Snap to Grid and Snap to Pixel still move its ends (#7252). |
| 2026-11-13 | `path.freehand`: `closed`, when given, decides whether a stroke that continues a path (`extend`) closes it; the Pencil and the Paintbrush send it by Close Paths When Ends Are Within. |
+99
View File
@@ -0,0 +1,99 @@
# Production Preflight
Open **Window > Production Preflight** before delivering artwork. Choose **PDF**, **Print** or
**Screen**, set the minimum image resolution, and optionally check only the active artboard.
The default minimum is 300 ppi for PDF/Print and 96 ppi for Screen. These are editable workflow
defaults, not a guarantee of suitability for a particular printer or display.
The panel checks:
- **Fonts:** unavailable font families and styles that will use a fallback or a substitute.
- **Text Overflow:** area type or type on a path whose text extends beyond its frame.
- **Linked Files:** missing files and files that changed since they were read.
- **Image Resolution:** effective resolution along both pixel axes at the image's placed size.
Print includes the job's page transform, so enlarging the print can lower effective resolution.
Click a finding to select and zoom to the affected artwork. A font finding can select several
objects. A finding inside a symbol, pattern, brush or opacity mask locates its first visible
canvas owner. If some artwork cannot be selected, the status bar reports it; any selectable
objects are still located without unlocking artwork or artboards. **Find Font…**, **Relink…** and
**Update Link** open the existing repair workflows;
they do not apply an automatic font substitution or change artwork just by checking it.
Results refresh after document edits, Undo/Redo, document switches and changes to the panel's
options. During an interaction the panel waits for the edit to finish. External files are
checked again every two seconds while the panel is visible; **Recheck** runs immediately.
PDF and Screen inspect visible artwork intersecting the chosen artboards. Print reuses the saved
Print settings with the chosen artboards, including which layers print and what fits on the
sheet; it also shows the existing print-preview geometry/settings warnings. Locked artwork is
still checked because locking it does not prevent output. Hidden artwork is checked only if the
Print settings include hidden layers.
## Coverage limits
This is a check of the document and selected output context, not validation or certification of
an exported file. PDF export presets, colour conversion, ink coverage, bleed adequacy and
accessibility compliance are not checked by this first version.
Resolution inside symbols, patterns, brushes, opacity masks and placed documents is reported as
**Not checked**, because the resource's local transform alone does not establish its final output
resolution. A resolution check with both findings and unchecked art shows **Needs attention**
and also states that some art was not checked. A vector placed document has no single bitmap PPI.
The font and text checks share the existing output-aware walk, including its bounds/clipping
approximations for generated art and container effects. Resource findings identify a representative
visible owner, not an exhaustive list of every instance. A passed check means only that no problem
of that kind was found within the stated coverage.
The same read-only report is available through `document.preflight`; see [MCP](mcp.md#production-preflight).
## Validation (2026-11-18)
Checked on Windows with Rust 1.99.1, based on `main` at `36b5a5920c`:
- Engine integration tests: 9 passed (`cargo test -p vectorcraft-engine --test preflight`).
- Panel tests: 5 passed (`cargo test -p vectorcraft-ui-egui --lib preflight`), including pointer
selection/zoom, edits and Undo, document switching, external-file polling and explicit Recheck.
- Both test commands used `--offline --target-dir target --config profile.test.opt-level=0`.
- Existing Print Preview and Links panel engine regressions: 16 + 16 passed, run from the native
engine test binary with filters `tests::printpreview` and `tests::linkspanel`.
- The ignored `preflight_panel_preview` test was run explicitly, rendered through the offscreen GPU
harness and visually inspected. Its output remains under the ignored `target/` directory.
- Native Clippy for the engine and UI, all targets, passed with `-D warnings` (explicit
`--target x86_64-pc-windows-msvc`, using `target/wasm-check` for the validation artifacts).
- Engine/UI WebAssembly typecheck passed. Formatting, asset attribution, branding, dependency
layering and PDF dependency checks passed.
- Windows desktop build passed (`cargo build -p vectorcraft --offline --target-dir target
--config profile.dev.opt-level=0`). The running panel was visually inspected with a sample
exercising all four findings, and the contributor tried it in the desktop app.
`cargo xtask ci` was attempted with `CARGO_BUILD_TARGET=x86_64-pc-windows-msvc`: formatting and
workspace Clippy (all targets, `-D warnings`) passed. It was stopped during workspace-test
compilation after the separate `ui-commands --check` confirmed pre-existing drift between the
unchanged `menus/ui_commands.rs` and generated `mcp/src/ui_catalog.rs`. The complete workspace
test suite and remaining CI stages were not completed. An additional
WebAssembly Clippy run also encounters existing target-specific lints in unchanged `cmd/plugin.rs`
(`drop_non_drop`) and `font_menu.rs` (`unnecessary_lazy_evaluations`); the WebAssembly typecheck and
the native Clippy run above pass without source changes for those findings.
### Review follow-up on `main` at `ee60c51fd`
The exact-threshold and locked-artboard regressions were first run against the original
implementation and failed. After the fixes and merge-conflict resolution:
- All 10 engine preflight tests and 7 panel tests passed. The optional GPU preview also passed
and was visually inspected.
- The boundary regression checks several exact PPI thresholds and a real shortfall on one axis.
- Navigation regressions cover a locked artboard, retry after unlocking, and partial selection
that still zooms to the selectable artwork. Finding navigation never unlocks artwork.
- Formatting, native workspace Clippy with warnings denied, engine/UI WebAssembly typecheck,
layering and PDF dependency checks passed. The complete workspace CI suite remains incomplete; the unchanged UI command catalog
still fails its separate drift check.
## Revision history
| Date | Change |
|---|---|
| 2026-11-18 | Review follow-up: tolerate PPI rounding at the minimum, report incomplete finding selection, and retain main's symbol lookup improvements when resolving merge conflicts. |
| 2026-11-18 | Initial Production Preflight panel and command. |
+10 -5
View File
File diff suppressed because one or more lines are too long
File diff suppressed because one or more lines are too long
+11 -3
View File
File diff suppressed because one or more lines are too long