From 099ab6ea13100162c21b95a60022e14bb7b72e6c Mon Sep 17 00:00:00 2001 From: Sven Lafebre Date: Mon, 16 Nov 2026 13:11:07 +0100 Subject: [PATCH] Fix #8093: a hidden operand is an empty shape where it changes the result A selected object its clipping masks hide altogether was left out of the operation. For Intersect, Minus Front (hidden at the back), Minus Back (hidden in front) and Crop (hidden on top) that changed the result: the others' overlap or the next object down took its place. It now stays in as an empty shape for those four, which then give nothing. The other operations still leave it out, which gives the same art and keeps its style off the result. --- crates/engine/src/cmd/pathops.rs | 77 +++++++++++++--------- crates/engine/src/tests/pathfinder_clip.rs | 42 ++++++++++++ docs/target-app-parity.md | 2 +- 3 files changed, 88 insertions(+), 33 deletions(-) diff --git a/crates/engine/src/cmd/pathops.rs b/crates/engine/src/cmd/pathops.rs index 75bb06bd0e..b98e49f512 100644 --- a/crates/engine/src/cmd/pathops.rs +++ b/crates/engine/src/cmd/pathops.rs @@ -677,6 +677,10 @@ fn run_pf(s: &mut Session, p: &Value, op: PathfinderOp) -> Result { } let shape_mode = matches!(op, PathfinderOp::Unite | PathfinderOp::MinusFront | PathfinderOp::Intersect | PathfinderOp::Exclude | PathfinderOp::MinusBack); + // An operand its clipping masks hide altogether is an empty shape for the operations whose + // result it changes (Intersect gives nothing, Minus Front loses its back object, Minus Back its + // front one, Crop its cropping shape); the others leave it out, which gives the same art. + let keeps_hidden = matches!(op, PathfinderOp::Intersect | PathfinderOp::MinusFront | PathfinderOp::MinusBack | PathfinderOp::Crop); let label = pf_label(op); let options = pf_options(s, p, &format!("object.pathfinder.{}", pf_id(op)))?; let ids = s.edit(label, |d, sel| { @@ -684,39 +688,41 @@ fn run_pf(s: &mut Session, p: &Value, op: PathfinderOp) -> Result { let mut styles: Vec