Merge pull request #8003 from dotCooCoo/fix/inflate-colored-light-seam-fill

3D: colored Inflate fills each facet and its seam as one path, covering each edge pixel once
This commit is contained in:
BFlat
2026-11-16 09:31:14 +07:00
committed by GitHub
5 changed files with 179 additions and 5 deletions
+2
View File
@@ -2225,6 +2225,8 @@ Moved from the ROADMAP's "Shipped so far" on 2026-10-10. Update it when a featur
Evidence for the shared light Color: geometry tests in `tests_lighting`, effect paint tests, command/save/undo/expand and SVG/PDF checks in `three_d_light_color`, and headless picker/reset/preview tests in `tests_revolve`. Revolve keeps smooth colored vector ramps and continuous flat-lit caps. Inflate geometry tests check spherical lighting, shared vertex/edge continuity, concave cell coverage, puffed backs at perspective and legacy single-light/list equivalence; rendered command/export regressions cover smooth shading and editable expansion. Four legacy white-light PNGs matched main byte for byte when this was measured (2026-10-17); since every 3D seam took round joins (2026-11-12), white-light output is expected to differ from them at facet corners ([Seams](three-d.md#seams)); the four scenes were not exported again to measure it; [release measurements](3d-lighting-performance.md) record the colored solid-fill batch and the remaining source-gradient cost. Colored Inflate's facets lie over an underlay of themselves under one clip, so their shared edges show neither the black channel backdrop nor the background ([Seams](three-d.md#seams)); `three_d_light_color::colored_light_surfaces_match_supersampling_at_internal_facet_edges` compares 1:1 with 3x averaged down, and `colored_light_seams_stay_closed_in_svg_pdf_and_expansion` checks SVG, PDF and Expand Appearance. Colored Revolve's faces lie over an underlay of themselves the same way, run by run in a group and with mapped graphics kept after their faces; `colored_revolve_faces_leave_no_alpha_holes_at_one_to_one` checks that no pixel inside the art lets the background through at 1:1 where 3x averaged down is opaque, live, read back from SVG and PDF, and expanded.
Colored Inflate's composited facets that are simple polygons are each one filled path of the facet and its round seam, so a facet edge pixel is covered once instead of by a fill and then a same-color stroke ([Seams](three-d.md#seams)); `three_d_light_color::turned_colored_inflate_facets_and_seams_cover_their_edges_once` bounds the turned (X 50°, Y 35°) solid fill against 3x averaged down, and `lighting::tests::seamed_fill_covers_a_polygon_and_its_seam_once` checks the path's coverage and the facets that keep a fill and a stroke.
## Eyedropper character dimensions (2026-11-11)
`appearance.copyFrom` reads the source's effective character dimensions and converts them into each target's local text space, preserving target placement, rotation, shear and reflection (#6404). Point and area text, grouped text, highlighted ranges, reverse and remembered sampling, attribute opt-outs, Undo/Redo and native-file round trips are regression-tested. Picks with unrepresentable dimensions or text that would extend beyond the canvas leave the document, paint defaults and remembered sample intact. Paint-only copying remains available. Tests: `crates/engine/src/tests/eyedropper.rs` (`scaled_type_pick_*`). Scores and estimates unchanged.
+5
View File
@@ -157,6 +157,11 @@ How a facet carries its seam depends on the lights and the paint:
and from places where the light changes sharply, a pixel drawn at 1:1 is opaque where the 3x art is opaque, and
otherwise its alpha is within 3 levels. Inflate seen straight on with an opaque fill also has each color channel
within 3 levels (VectorCraft's own measure).
In the composite, a facet that is one closed polygon whose edges do not cross is drawn over the underlay as one
filled path, the facet and the outline of its round seam together, so a pixel at its edge is covered once and not
by a fill and then by a stroke of the same color. Other facets keep a fill and a seam stroke. Turned to X 50°,
Y 35° in an opaque fill, at most one color channel sample is more than 3 levels off the 3x art, and by at most 4
(VectorCraft's own measure).
- Extrude & Bevel (Classic), Rotate (Classic) and Revolve (Classic): a path and a seam for every face; gradient and
pattern faces seam only the base paint, and the shading and highlight layers cover the face alone. The Wireframe
surface draws edges only, with no seam.