From 8912679dd64d95c3012a0032595466afa8da562c Mon Sep 17 00:00:00 2001 From: bflatastic Date: Sat, 14 Nov 2026 22:53:19 +0700 Subject: [PATCH] Keyboard Shortcuts: Paintbrush stroke needs points, so it isn't listed #7592 documented brush.freehand's brush as optional, so the shortcut editor took it for a command that runs without params and listed it, and listed_commands_run_from_a_key_without_a_missing_param fails on main: a key press can't give the stroke's points. It joins NEEDS_A_PARAM with the other commands that need a point. --- crates/ui-egui/src/shortcut_editor.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/crates/ui-egui/src/shortcut_editor.rs b/crates/ui-egui/src/shortcut_editor.rs index 26606c2763..88a97206c7 100644 --- a/crates/ui-egui/src/shortcut_editor.rs +++ b/crates/ui-egui/src/shortcut_editor.rs @@ -785,9 +785,9 @@ fn listed(overrides: &Overrides, e: &Entry) -> bool { /// Options, Character, Set Bounds), the exports and saves that give the file back without a `path` /// (Save Document gives the file back when the document has no file yet; File › Save takes a key /// instead), the undo group's begin and end, and the commands that need a point, a value or a name -/// (Create Dimension, Edit Freeform Point, Select by Color, Move Brush). New Symbol is left out +/// (Create Dimension, Edit Freeform Point, Select by Color, Move Brush, Paintbrush). New Symbol is left out /// because the Symbols panel runs it through the Symbol Options dialog. -const NEEDS_A_PARAM: [&str; 74] = [ +const NEEDS_A_PARAM: [&str; 75] = [ "transparency.set", "transparency.setOpacityMask", "stroke.set", @@ -817,6 +817,7 @@ const NEEDS_A_PARAM: [&str; 74] = [ "assets.export3D", "assets.settings.set", "attributes.set", + "brush.freehand", "brush.move", "css.export", "dimension.create",