From 7cc604a003294991548b29df2aad47f3294193b9 Mon Sep 17 00:00:00 2001 From: dotCooCoo Date: Sat, 14 Nov 2026 20:46:28 -0800 Subject: [PATCH] Attributes: overprint reads the art of graph designs in series again The merge of main dropped the art from attributes.info's overprint read, so overprintFill and overprintStroke came back null with only that art selected. The edits still leave the art out. --- crates/engine/src/cmd/overprint.rs | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/crates/engine/src/cmd/overprint.rs b/crates/engine/src/cmd/overprint.rs index 0da36a3270..e8957691ec 100644 --- a/crates/engine/src/cmd/overprint.rs +++ b/crates/engine/src/cmd/overprint.rs @@ -126,8 +126,9 @@ fn kinds(p: &Value, cmd: &str, keys: [&str; 2]) -> Result> { .collect() } -/// Each kind's item target and objects: (fill?, item, ids). With `edit`, an explicit item that the graph design art left -/// out has no row of that kind for is an error, as when the edit resolves it on the other objects. +/// Each kind's item target and objects: (fill?, item, ids). With `edit`, the art of graph designs drawn in graph series +/// is left out, and an explicit item that the art left out has no row of that kind for is an error, as when the edit +/// resolves it on the other objects. Without it, the art is read with the other objects. fn aims(s: &Session, p: &Value, cmd: &str, kinds: impl IntoIterator, edit: bool) -> Result)>> { let item = item_target(s, p, cmd)?; kinds @@ -135,11 +136,7 @@ fn aims(s: &Session, p: &Value, cmd: &str, kinds: impl IntoIterator .map(|fill| { let it = item.of_kind(s, fill); let ids = it.targets(s, p)?; - let ids = if edit { - super::appearance::drop_design_art_rows(s, ids, it, fill, cmd)? - } else { - super::appearance::drop_design_art(&s.doc()?.doc, ids) - }; + let ids = if edit { super::appearance::drop_design_art_rows(s, ids, it, fill, cmd)? } else { ids }; Ok((fill, it, ids)) }) .collect()