Variables: Import Data Sets reads % columns of graph data files

dataset.import refused every header cell that starts with % unless it was
a variable's exact name, so the five-column example on the data source
set-up page did not import. A %Name header now defines the graph variable
Name, or names it when the document has it, and each cell of the column is
the path of a graph data file. The file is read as the Graph Data window's
Import Data reads one, and the data becomes the data set's graph value,
which applies as graph.setData applies it.

A relative path is taken from the new base parameter, else from the folder
of the CSV file at path. A file that is missing, can't be read or is larger
than 1 MB, a file that gives a graph value longer than 256 KB, and %
columns that hold more than 256 MB in all refuse the import with the line
and the column, and the document is left as it was. Each file is read once
per import.

Import Data's text decoding, cell splitting and sheet-to-data steps move
from the Graph Data dialog to the engine (graph/data.rs), so both imports
read a file the same way. dataset.export's warning now lists a % header
over values as refused and a %-prefixed variable of another kind as read
back with another kind.
This commit is contained in:
dotCooCoo
2026-11-14 22:07:06 -08:00
parent d094a3c449
commit 8f5aed7ea4
26 changed files with 463 additions and 119 deletions
+24 -11
View File
@@ -3329,7 +3329,7 @@ already walks Image Trace. Short agent entry points:
- Data sets: `dataset.list`, `dataset.new {name, values?}`, `dataset.set {name, newName?, values?}` (`newName` also
renames the row, in the same undo step; Edit Data Set's Name field sends it), `dataset.rename`,
`dataset.delete`, `dataset.capture`, `dataset.update`, `dataset.select {name}`, `dataset.next` /
`dataset.prev` (each `dataset.select` / next / prev is one undo step over every bound object), `dataset.import {path|data|dataBase64|csv}` /
`dataset.prev` (each `dataset.select` / next / prev is one undo step over every bound object), `dataset.import {path|data|dataBase64|csv, base?}` /
`dataset.export {path?}` (CSV: one column per variable, and no column of data set names). `dataset.import` also
reads tab-separated files. Every header cell is a variable, whatever its case (`name` and `Name` included). The
first row holds the field names, as the
@@ -3337,16 +3337,29 @@ already walks Image Trace. Short agent entry points:
describes. The rows replace every data set of the document and are named `Data Set 1`, `Data Set 2` and so on, in file order;
the document's variables and their bindings stay, and the reply's `deletedDataSets` lists the data sets that were replaced. An import error
about a row's values gives the file line the row starts on. A header cell that names no variable defines one, unbound, in the same undo step as the
rows. `#Shown` defines a visibility variable `Shown`, `@Photo` defines an image variable `Photo`, and a cell without
a prefix defines a text variable. `dataset.export` writes a visibility variable's header as `#Shown` and an image
variable's as `@Photo`, and a text or graph variable's as its name alone. Its reply's `warning` names the variables
whose header or values make an import into a document without them refuse the file (a `%` header, a `#` header
whose values aren't true or false). Otherwise it names the variables that such an import does not read back with
their kind: text variables whose names start with `#` or `@`, and graph variables. Export is refused, naming both variables, when a variable's header is
another variable's name (a visibility variable `Show` next to a text variable `#Show`). A prefixed cell whose name
is already a variable of the prefix's kind names it;
one whose name is a variable of another kind fails the import. A `%` cell that isn't a variable's exact name (graph
data files) is refused, and so are two cells that name one variable (`City` twice, or `Shown` and `#Shown`). The
rows. `#Shown` defines a visibility variable `Shown`, `@Photo` defines an image variable `Photo`, `%Sales` defines a
graph variable `Sales`, and a cell without a prefix defines a text variable. The cells of a `%` column are paths of
graph data files, as the set-up page's example shows. Each file is read as the Graph Data window's Import Data reads
one ([add graph data](https://helpx.adobe.com/illustrator/desktop/automate-visualize-data/visualize-data/add-graph-data.html)):
at most 1 MB; tab-separated when any line holds a tab, else comma-separated; the first row holds the series labels
and the first column the category labels; UTF-16 by the rule below, else UTF-8. The data becomes the data set's
graph value, which `dataset.select` applies as `graph.setData` applies it, so the graph gets the data that Import
Data and Apply give it. A relative path is taken from `dataset.import`'s `base` folder, else from the folder of the
CSV file at `path`; with neither (`csv`, `data` or `dataBase64` and no `base`), it fails the import. This is
VectorCraft's own rule. A file that is missing, can't be read or is larger than 1 MB, a file that gives a graph value
longer than 256 KB, and `%` columns whose files and graph values hold more than 256 MB in all fail the import with
the line and the column, and the document is left as it was. Each file is read once per import, however many cells
name it, and counts once toward the 256 MB; each cell's graph value counts every time. `dataset.export` writes a
visibility variable's header as `#Shown` and an image variable's as `@Photo`, and a text or graph variable's as its
name alone. Its reply's `warning` names the variables whose header or values make an import into a document without
them refuse the file (a `%` header over values, which such an import reads as file paths, and a `#` header whose
values aren't true or false). Otherwise it names the variables that such an import does not read back with their
kind: variables whose names start with `#`, `@` or `%` and aren't of that prefix's kind, and graph variables. Export
is refused, naming both variables, when a variable's header is another variable's name (a visibility variable
`Show` next to a text variable `#Show`). A prefixed cell whose name is already a variable of the prefix's kind names
it; one whose name is a variable of another kind fails the import, and so do two cells that name one variable
(`City` twice, or `Shown` and `#Shown`). A cell that is a variable's exact name, prefix included, names that
variable, so the cells under a graph variable named `%Sales` are read as graph data in CSV form. The
reply's `defined` lists the variables the import defined. While the variables are
locked, an import whose header would define a variable fails with "variables are locked".
A `dataset.import` file that isn't UTF-8 is read as Windows-1252, unless it starts with the UTF-8 byte-order mark.
+1
View File
@@ -822,6 +822,7 @@ Moved from the ROADMAP's "Shipped so far" on 2026-10-10. Update it when a featur
- Variables: Import Data Sets… (`dataset.import`) reads a UTF-16 file without a byte-order mark, instead of refusing it, when at least half of its two-byte units hold a NUL byte; it uses the byte order that reads its line breaks.
- Graphs: the Graph Data window's Import Data reads a UTF-16 text file without a byte-order mark by the same rule as Import Data Sets…, instead of filling the cells with NUL characters. It reads a file cut short by one byte, or with an unpaired surrogate, as it reads one after a byte-order mark.
- Variables: Import Data Sets… (`dataset.import`) defines the variables a file's header names that the document lacks, unbound. `#Shown` defines a visibility variable, `@Photo` defines an image variable, and a header without a prefix defines a text variable. A header that is a variable's exact name keeps naming it, and any other `%` header (graph data files) is refused.
- Variables: Import Data Sets… (`dataset.import`) reads `%` columns instead of refusing them: `%Sales` defines or names the graph variable `Sales`, and each cell is the path of a graph data file, read as the Graph Data window's Import Data reads one and kept as the data set's graph value. A relative path is taken from the CSV file's folder, or from `base`. A missing, unreadable or larger than 1 MB file fails the import with its line and column, and the document is left as it was (`crates/engine/src/tests/variables.rs`).
- Variables: Load Variable Library… in the Variables panel menu (`variable.loadLibrary`) replaces the document's variables and data sets with a variable library's, read from its XML file, in one undo step: every data set is deleted, and every variable is deleted with its bindings and values, except a variable the library also declares with the same kind, which stays bound so the library's data sets change its objects (#4136); then the library's other variables are defined, unbound: text, visibility, image (linked file) and graph variables, and variables without a known `trait` as unknown. Its data sets take text values from each value's `p` elements, one paragraph each, visibility values from `true` or `false`, image values from a file's absolute path or `file:` URL, and graph values from a `data` element of series names and rows.
- Variables: Save Variable Library… in the Variables panel menu (`variable.saveLibrary`) writes the document's variables of every kind and its data sets as a variable library's XML file, which Load Variable Library reads back with the same variables, kinds, data set names and values.
- JSON-lines control channel with real egui pointer and keyboard injection.