mirror of
https://github.com/storytold/vectorcraft.git
synced 2026-11-16 12:03:31 +00:00
3D: Revolve's colored-light faces lie over an underlay, so no alpha holes show at 1:1
Under a colored lightColor or a lights list, Revolve drew each face of a solid-color or gradient surface on its own, so where two faces' antialiased edges met, pixels inside the surface let the background through at 1:1. - The faces now lie over an underlay of themselves under one clip to their outline, as colored Inflate's facets do (lighting::sealed, split into lighting::underlay and sealed). The surface's opacity and blending mode apply once, to the sealed surface. - In a group, each run of one member's faces in the shared depth order takes its own underlay; a translucent member's run keeps its opacity, blending mode and mask on the sealed run. - A face with a part of a mapped graphic gives its face to the underlay and keeps the part right after it. - Faces in a gradient with transparent stops carry its opacity mask and are drawn as before. Revolve (Classic) is unchanged. - The paint-copy budget counts the underlay in validation and drawing. Docs: docs/three-d.md (Seams), docs/target-app-parity.md.
This commit is contained in:
@@ -2201,7 +2201,7 @@ Moved from the ROADMAP's "Shipped so far" on 2026-10-10. Update it when a featur
|
||||
|
||||
`xtask/src/pngsuite.rs` verifies each file from the pinned PngSuite mirror against `xtask/pngsuite.sha256` before it reaches the corpus. Seven synthetic regressions cover substitution, oversize, cache repair, failure cleanup, nonregular targets, stale staging and manifest limits. The opt-in corpus remains gitignored; no PNGs are committed.
|
||||
|
||||
Evidence for the shared light Color: geometry tests in `tests_lighting`, effect paint tests, command/save/undo/expand and SVG/PDF checks in `three_d_light_color`, and headless picker/reset/preview tests in `tests_revolve`. Revolve keeps smooth colored vector ramps and continuous flat-lit caps. Inflate geometry tests check spherical lighting, shared vertex/edge continuity, concave cell coverage, puffed backs at perspective and legacy single-light/list equivalence; rendered command/export regressions cover smooth shading and editable expansion. Four legacy white-light PNGs matched main byte for byte when this was measured (2026-10-17); since every 3D seam took round joins (2026-11-12), white-light output is expected to differ from them at facet corners ([Seams](three-d.md#seams)); the four scenes were not exported again to measure it; [release measurements](3d-lighting-performance.md) record the colored solid-fill batch and the remaining source-gradient cost. Colored Inflate's facets lie over an underlay of themselves under one clip, so their shared edges show neither the black channel backdrop nor the background ([Seams](three-d.md#seams)); `three_d_light_color::colored_light_surfaces_match_supersampling_at_internal_facet_edges` compares 1:1 with 3x averaged down, and `colored_light_seams_stay_closed_in_svg_pdf_and_expansion` checks SVG, PDF and Expand Appearance.
|
||||
Evidence for the shared light Color: geometry tests in `tests_lighting`, effect paint tests, command/save/undo/expand and SVG/PDF checks in `three_d_light_color`, and headless picker/reset/preview tests in `tests_revolve`. Revolve keeps smooth colored vector ramps and continuous flat-lit caps. Inflate geometry tests check spherical lighting, shared vertex/edge continuity, concave cell coverage, puffed backs at perspective and legacy single-light/list equivalence; rendered command/export regressions cover smooth shading and editable expansion. Four legacy white-light PNGs matched main byte for byte when this was measured (2026-10-17); since every 3D seam took round joins (2026-11-12), white-light output is expected to differ from them at facet corners ([Seams](three-d.md#seams)); the four scenes were not exported again to measure it; [release measurements](3d-lighting-performance.md) record the colored solid-fill batch and the remaining source-gradient cost. Colored Inflate's facets lie over an underlay of themselves under one clip, so their shared edges show neither the black channel backdrop nor the background ([Seams](three-d.md#seams)); `three_d_light_color::colored_light_surfaces_match_supersampling_at_internal_facet_edges` compares 1:1 with 3x averaged down, and `colored_light_seams_stay_closed_in_svg_pdf_and_expansion` checks SVG, PDF and Expand Appearance. Colored Revolve's faces lie over an underlay of themselves the same way, run by run in a group and with mapped graphics kept after their faces; `colored_revolve_faces_leave_no_alpha_holes_at_one_to_one` checks that no pixel inside the art lets the background through at 1:1 where 3x averaged down is opaque, live, read back from SVG and PDF, and expanded.
|
||||
|
||||
## Eyedropper character dimensions (2026-11-11)
|
||||
|
||||
|
||||
@@ -161,6 +161,12 @@ How a facet carries its seam depends on the lights and the paint:
|
||||
- Revolve, with shading on: when a `lights` list is given (even one of white lights), a solid-color or gradient face fills its light
|
||||
ramps through a clip of the face and its 0.75 pt seam, outlined with round joins. With the single legacy light,
|
||||
a face is a path and a seam; with a colored `lightColor` a gradient face fills through the same kind of clip.
|
||||
Under a colored `lightColor` or a `lights` list, the faces of a solid-color or gradient surface lie over an underlay
|
||||
of themselves under one clip, as colored Inflate's facets do; in a group, each run of one member's faces in the
|
||||
shared depth order takes its own underlay, and a face with a part of a mapped graphic keeps that part right after
|
||||
it. Faces in a gradient with transparent stops carry its opacity mask and are drawn without an underlay. At 1:1,
|
||||
away from the surface's outline, a pixel is opaque where the same art drawn at 3x and averaged down is opaque
|
||||
(VectorCraft's own measure).
|
||||
|
||||
A facet seen almost edge-on is a sliver, and a seam with mitered joins would reach past the solid as a thorn; a round
|
||||
one reaches no more than half its width past its facet. So where a facet has no neighbor (Rotate's plane, every
|
||||
|
||||
Reference in New Issue
Block a user