Scripts: an open file that is renamed is read under its new path's rules

`rename` moved the write path of open File objects but left the path they
were read from at the old name. When new code then withdrew the kept grant
for the folder, a grant the run still held for the old path let the object
go on giving the file's bytes. The read path now moves with the write path.
This commit is contained in:
dotCooCoo
2026-11-14 12:42:21 -08:00
parent cefaeefca9
commit d435ae1a27
2 changed files with 38 additions and 4 deletions
+9 -4
View File
@@ -1844,11 +1844,16 @@ fn rename(host: &Host, a: &[Data]) -> Result<Data, HostError> {
if std::fs::rename(&from, &to).is_err() {
return Ok(error(WRITE_FAILED));
}
// Open objects of the file, or of files in the folder, write to the new path.
for file in disk.open.values_mut() {
if let Some(rest) = file.target.as_deref().and_then(|t| t.strip_prefix(&from).ok()) {
file.target = Some(if rest.as_os_str().is_empty() { to.clone() } else { to.join(rest) });
// Open objects of the file, or of files in the folder, write to the new path, and the rules for
// reading apply to them there.
let moved = |p: &mut Option<std::path::PathBuf>| {
if let Some(rest) = p.as_deref().and_then(|t| t.strip_prefix(&from).ok()) {
*p = Some(if rest.as_os_str().is_empty() { to.clone() } else { to.join(rest) });
}
};
for file in disk.open.values_mut() {
moved(&mut file.target);
moved(&mut file.read_from);
}
// The old path no longer holds the file, so the report names it as well as the new one.
disk.wrote(&from);