From fe7b71b857f2e7b220428dd5e3243c94bea66120 Mon Sep 17 00:00:00 2001 From: dotCooCoo Date: Sun, 8 Nov 2026 19:26:55 -0800 Subject: [PATCH] Plug-ins: the clear-cache test installs with request grants allowed plugin.install refuses grant from a request unless the session was started to allow it, so the test from main that installs with grant turns that on. The install dialog's comment names OK's Sense::click. --- crates/engine/tests/plugin_clear_cache.rs | 1 + crates/ui-egui/src/dialogs/plugin.rs | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/crates/engine/tests/plugin_clear_cache.rs b/crates/engine/tests/plugin_clear_cache.rs index 74ba69d64..7a323390c 100644 --- a/crates/engine/tests/plugin_clear_cache.rs +++ b/crates/engine/tests/plugin_clear_cache.rs @@ -40,6 +40,7 @@ fn clearing_every_cache_empties_each_plugins_cache_and_keeps_its_settings() { std::fs::create_dir_all(&folder).unwrap(); let ids = ["test.clearcache.a", "test.clearcache.b"]; let mut s = Session::new(); + s.allow_plugin_grants_from_requests(); s.execute("file.new", &json!({"width": 400, "height": 200})).unwrap(); s.attach_plugin_store(folder.clone()); for id in ids { diff --git a/crates/ui-egui/src/dialogs/plugin.rs b/crates/ui-egui/src/dialogs/plugin.rs index 44ad09dc6..76f71f3b4 100644 --- a/crates/ui-egui/src/dialogs/plugin.rs +++ b/crates/ui-egui/src/dialogs/plugin.rs @@ -331,8 +331,8 @@ pub(crate) struct PendingInstall { pub approval: InstallApproval, } -/// No OK in the shared footer: the OK in its body is a button, which Enter clicks only when it has -/// the keyboard focus. +/// No OK in the shared footer: the OK in its body is a `Sense::click` button, which Enter clicks +/// only when it has the keyboard focus. pub(super) const INSTALL_SPEC: DialogSpec = DialogSpec { heading: |_| tl!("Install Plug-in…").trim_end_matches('…').to_string(), body_with_actions: Some(install_body),