paint.invert and paint.complement given a group whose own fill or stroke
changed, with only graph design art inside it, left the last color and
the recent colors as they were, because the remembered paint was taken
only from the objects inside the group. It now comes from the first
group whose own fill or stroke changed. A recolor that changes no
group's paint, such as the complement of a gray fill, remembers nothing.
A button beside the Help › Search Commands field opens a Recent Commands
list: the last five commands and tools picked from the palette, most
recent first. A command picked again moves to the top, so it takes one
place. Choosing a row closes the palette and runs it the way a pick of
the same result does, so dialogs, a dimmed item's reason and tool picks
work as before. With nothing picked yet, the list shows a dimmed No
recent commands row.
A command that is not available now, such as a filter of a plug-in that
is not loaded, is left out of the list but stays in the saved ids, so it
shows again when it comes back. The saved list keeps the last five
available picks and at most 20 ids in all. It is saved with the UI state
next to Recent Fonts.
While the list is open, its first row takes the keyboard, Up and Down
move through its rows and wrap at the ends, Enter runs the row, and
Escape closes the list before the palette.
Docs: docs/target-app-parity.md (command palette).
Fixes#6376
Vertically aligned area type in a frame that is not a rectangle flows its
text again until it settles, and each pass added the line-start repeat
marks to the layout's records once more, so SVG export could look up the
wrong character. Each pass now starts from empty records, and an undone
pass restores the ones before it.
The progress line said nested symbol instances leave nothing live after
Expand Appearance. It now names the 1,024-image and 256-megapixel
limits, the objects they leave with their raster effects and the
`rasterLeft` warning, and the test that covers them.
craft_image_codecs::probe_size only reads WebP, EXR and the GIF/BMP/TGA family;
for PNG, JPEG and TIFF it returns Unsupported. The cutover used it for header
sizes, so DXF export left every PNG out (cad tests), plugin objects lost PNG
pixels, and EPS image-mask and SVG import fell back to decoding whole images to
learn their size. vectorcraft_doc::header_size reads PNG's IHDR and a JPEG's
frame through craft-image-codecs and other formats through the image crate's
header readers, as main does, without decoding pixels. The SVG filter's JPEG
size comes from jpeg_info instead of a full decode.
Each line that started with a repeat mark scanned the paragraph's text from
its start for the character the mark stands for, so a paragraph with marks
at the start of many lines took quadratic time to lay out. The scan now
goes on from the line before.
The egui crate's header comment and the M14.8 line in
docs/target-app-parity.md called it "the ⌘K palette" and "a ⌘K command
palette". Cmd+K runs edit.preferences, and help.commandPalette (Help ›
Search Commands…) defaults to Cmd+Shift+/. Both now name the menu item,
and the crate comment links the palette module.
docs/mcp.md said that moving a label on its own never moves or scales a
graph's plot. A graph saved without `placedArt`, or with one that has no
width or height, is measured on `placed`, the bounds of all of its art
including the labels. Moving an outermost label of such a graph on its
own changes those bounds, and the next redraw moves and scales the plot.
The paragraph now says so.
The image made of an object's shadows and outer glows took the default
blend mode, so a Multiply shadow (Drop Shadow's default) over colored art
became a plain shadow painted over it. When the shadows and glows all use
one blend mode, the image now paints with it, for the object's own effects
and for nested symbol instances alike.
A thread of frames that hold only repeat marks or soft returns made each
frame look back through every frame before it, so opening or flowing such
a story took quadratic time, with the setting off as well. The leads are
now carried forward in one pass.
The read-root check for SVG output now looks at the same art the
writer draws:
- A placed document's art is checked, with the pixels its file holds.
A placed native file that links an image outside the read roots was
written with that path under Images: Link.
- Hidden objects inside symbols, patterns and graph designs are left
out unless hidden layers are kept, as they are in the layers.
- With profile tiny12 the file leaves out opacity masks, and their
images are not checked.
- An object whose effect SVG has no filter for is checked as the image
the file draws of it, for file output and clipboard.exportSvg alike.
The last three refused files and clipboard SVG that name no file
outside the roots.
The pieces a Warp effect cuts an image into share one <image> in the
defs. The writer counted every piece, hidden ones included, so pieces
the file leaves out (hidden, or in a hidden clip group) still put an
<image> into the defs, with the linked file's path under Images: Link.
A confined caller's read-root check looks only at the art the file
draws and did not refuse it.
Image sharing and the colorized-image counts now walk only the art the
writer draws: hidden layers and objects only with hidden layers kept,
and never a template layer's art.
- Test files whose image→craft-image-codecs rewrites didn't compile against
main's newer tests go back to main's versions (engine fileio/tests.rs,
tests_tiffbmp.rs, tests/menucmds.rs, eps tests.rs); they still use the image
crate, which keeps its format features.
- craft_jxl::encode, craft_image_codecs::encode and Image::icc at d6cd7836d.
- jp2read and pdf export pass DecodeOptions, not Limits.
- EPS DCTDecode: grey JPEGs no longer use the image after moving it, and keep
main's one-channel output.
- svg keeps its direct usvg dependency for main's image href code; pdf keeps
jpeg-encoder for CMYK JPEGs.
- clippy -D warnings and rustfmt clean.
When Noise picks the nearest color for a speck, the speck's average now
leaves out the semi-transparent pixels along a cut-out image's edge that
are the color beside them blended with the transparent background.
settle_cut_edges returns which pixels those are. A speck made only of
them merges by border. In Grayscale the speck's gray is read with luma,
the gray Grayscale traces with, and the test probe shift_probe denoises
as a trace does.
The docs now say the rule applies in Color and Grayscale (in Black and
White a region has only one neighboring color, so Black and White Logo
changes only by its Noise value), name `ea3f81d9c3` as the base of the
measurements, and say that the gradient-border test sets Noise 15
because at Noise 8 its borders stray 0.92 px against a 0.9 px limit.
`through` now takes only the ids of the group's edges, each once: a face's
id, an unknown id, another group's edge or an edge given twice is an error
and changes nothing. A hidden edge in it is still skipped by the join. For
a double-click the Bucket passes only edges of the group, each once, so an
earlier click that filled a face whose fill was the edge's stroke paint
(Paint Fills and Paint Strokes both on) no longer sends that face.
The Bucket finds the faces a fill drag crossed among those whose bounds
meet the drag's bounds only.
A canvas test covers the middle-button press and the Space-held press
between two Bucket clicks. The progress-doc line lists the new tests, and
docs/mcp.md says which edges the tool passes in `through`.
Follows #7875.
With Preserve Numbers, a non-sRGB RGB destination and RGB colors
ICC-tagged as sRGB (the `all` profiles setting, PDF/A-2b, PDF/X-3 and
PDF/X-4), a gray image that carries an ICC profile was converted to sRGB
grays and lost its profile. It now keeps its profile there, as in the
other destinations other than sRGB.
When a pasted pie's wedge links a global swatch that the document gives
another color (swatchConflict "merge", the default), the wedge takes the
document's color. Its legend label kept the contrast it had in the copy,
so a wedge that turned dark could show a black label, and one that
turned light a white label, until the pie was drawn again.
Pasting now reads which wedges show a dark fill before the copy is
linked to the document's swatches. A pie whose wedges change darkness
gets the legend label contrast a redraw sets: white on a dark wedge,
black on a light one. Pies whose legend labels have a fill of their own
keep it. This applies to every paste command, Paste without Formatting
included, and to pies inside opacity masks.
A version 6 slices resource may follow a record with a descriptor of
version 16, and the reader took any record that starts with the value
16 for one. A record whose ID is 16 then had its first bytes read as a
descriptor, and the records after it were misread or left out. When the
records read one after another, followed by nothing or by one
descriptor (the layout ag-psd writes), only the last record is checked
for a descriptor. Files that follow each record with a descriptor are
read as before.
When image resource 1050 declared more bytes than the image resources
hold, the lookup stopped as if the file stored no slices, and Open and
Place brought the artwork in without the warning that the slices were
left out. The new psdread::resource tells a cut-short resource 1050
apart from one that is absent or that follows another block cut short,
and the slices reader passes that error on, so the warning names it.
Other resource readers keep their behavior.
Paste without Formatting sets each pie legend label in a wedge to white or
black from the wedge colors before it pastes, but a wedge linked to a global
swatch that the document gives another color takes the document's color
only during the paste (swatchConflict "merge", the default). A light wedge
merged into a dark swatch kept a black label, and a later redraw turned it
white.
The copied colors linked to merged swatches now take the document's color
before the labels are set, so the labels match what a redraw sets. Graphic
style links are left for the paste to relink.
A double triangle at the right end of the tab strip of Align, Attributes,
Character, Color, Flattener Preview, Gradient, Info, Paragraph, Stroke,
Transform and Transparency steps the active panel through its display
sizes. The sizes are the states the panel menu's Show/Hide Options items
set (Transparency: thumbnails and options, thumbnails alone, neither),
largest first, and the smallest goes back to the largest.
window.panel.cycleOptions {panel} does the same and returns
{panel, size, sizes}. An unknown panel or a panel without sizes is an
error and changes nothing.
Docs: docs/mcp.md, docs/control-protocol.md, docs/ui-parity.md.
file.place.queue read each file without a password, so an encrypted
PDF, .ai or .ait file was skipped and never reached the cursor. It now
stays in the cursor at 612 x 792 pt, VectorCraft's own size, with
needsPassword: true and no thumbnail. A click or drag on it in the app
asks for its password, with the Place dialog's Show Import Options on
or off; headless, a click on it places nothing. A file that fails for
a bad option or for another reason is still refused or skipped.
File > Place of an encrypted PDF given a page and no password, with
Show Import Options on, now asks for the password too, as it does with
the option off; it used to fail for want of the password.
With the art of a graph design in a series given first and aligned: true,
effect.remove and effect.duplicate with `indices` skipped an effect of the
art that no other object has, and edited the others. With art [shadow,
roughen], a mark [shadow] and indices [0, 1], effect.remove took the
mark's shadow off and succeeded. Such an edit is now an error that leaves
the document and its undo history as they are, as the same index given
alone already was. An object that lacks one of the effects while another
object has it is still left out for that effect.
paint.invert and paint.complement given only the art of a graph design,
with no item, returned success for a target other than "object" or
"contents", because the topmost-fill path read the target only after the
early return for design art. The target is now read before that return.
Conflicts resolved in favour of main/#7664 in the 13 source files both touched
(doc/cmyk.rs, metafile/dib.rs, pdf images, svg import/files.rs, render paint and
encode tests, trace, engine load.rs), keeping main's newer TIFF/CMYK, DIB and PDF
image fixes. vectorcraft-doc stays on main's version until its CMYK reader moves
to craft-tiff. The image crate keeps its format features, and usvg, tiff,
zune-jpeg, hayro-ccitt and jpeg-encoder stay for the readers not yet moved.
Codec crates pinned to craft-libs d6cd7836d364177661b0ae17f48a0805e83a5f32.
Also fixes the compile errors CodeRabbit flagged (jp2read DecodeOptions,
filters.rs use-after-move) and the encode() arity at d6cd7836d.
A Radial Blur whose saved centerX or centerY lies outside 0 to 1 draws
at the nearest edge, and its dialog showed the center there. The dialog
kept the saved value in its fields, though, so OK without moving the
center sent that value, and effect.setParams refused it.
The Blur Center box now writes the center it shows, kept within 0 to 1,
into the dialog's fields on every frame, so OK stores the edge.
With span: "selection", paint.setStroke placed the gradient on the union of
each target's topmost stroke box, also when `item` named a lower stroke,
including an aligned row of a graph design's art. With a 40 pt lower stroke
under a 1 pt topmost one, the gradient reached 0.5 pt past the objects
instead of 20 pt. Each target's box is now that of the row it edits.
A Reset button next to Extrude & Bevel's Bevel heading, on the Object
tab of the options dialog and of the 3D and Materials panel, sets Bevel
Shape, Width, Height, Repeat, Space, Bevel Inside and Bevel both sides
back to their defaults. Depth, Twist, Taper, Cap, the rotation, the
lights and the graphics keep their values. In the panel the reset goes
to each selected Extrude & Bevel as one undo step. The button is
unavailable while every bevel setting is at its default, and a setting
the selected effects hold with different values counts as changed.
Setting the Variable field through ui.dialog.set clears Name and Kind
until a frame fills them from the chosen variable. Setting Name or Kind
alone before that frame marked the fields as filled, so the other field
stayed null and the dialog showed "null" for Name or a blank Kind. OK
already read a null field as the variable's own value, so only the
displayed field was wrong.
A frame now fills every field when the chosen variable changes, and
after that fills only a field that is still null, keeping a field that
was set.
A file dropped on a canvas that asks for import options (a layered PSD,
a PDF with several pages, a DXF drawing, a text file) kept only its
placement params in the dialog. The dialog's OK then placed the file in
whichever document was active at that moment, and placed it even when
the dropped-on document had been reverted since.
The drop now carries its target document and revert count in the place
params, as the place cursor's import options carry their token. Placing
checks them on the drop and again on the dialog's OK: the file goes to
the document it was dropped on, which becomes active again, and is not
placed when that document has been closed or reverted. The dialog then
stays open and shows the reason. The checks drop_files ran itself now
run in that one place.