Commit Graph
111 Commits
Author SHA1 Message Date
dotCooCoo 0b42788d6b Merge main into fix/graph-axis-paint-kept 2026-11-14 20:00:48 -08:00
BFlat 7c12d660af Merge pull request #7627 from dotCooCoo/feat/ai-save-graph-records
.ai save: live graphs are written as graph records
2026-11-15 09:47:28 +07:00
BFlat feaf72f2b1 Merge pull request #7692 from dotCooCoo/fix/graph-labels-embedded-newline-middle
Graphs: centered labels with a line break in their text stay centered
2026-11-15 08:25:19 +07:00
BFlat d593b41961 Merge pull request #7691 from dotCooCoo/feat/variable-library-every-kind
Variables: Load and Save Variable Library hold visibility, image and graph variables
2026-11-15 08:24:45 +07:00
dotCooCoo dba42af495 Merge main into feat/ai-save-graph-records 2026-11-14 15:21:09 -08:00
BFlat 9f6edb7239 Merge pull request #7682 from dotCooCoo/fix/graph-outline-stroke-keeps-plot
Graphs: Outline Stroke and a graph left with only labels keep the plot in place
2026-11-15 06:17:47 +07:00
BFlat 9153900b1f Merge pull request #7322 from dotCooCoo/fix/graph-series-group-opacity
Graphs: the transparency set on a series group is kept
2026-11-15 05:30:04 +07:00
dotCooCoo 1399c17c5a Graphs: centered labels with a line break in their text stay centered
A quoted CSV cell keeps its line breaks, and a category or series label
draws each one as a new line, as it does a `|`. Labels beside an axis or
in a wedge counted their lines by `|` alone, so a label with a line break
was set off center, and with kept leading or paragraph spacing it was
not moved back to its middle when the graph was drawn again. The label
now counts lines in the text it lays out.

Follow-up to #6574.
2026-11-14 14:23:42 -08:00
dotCooCoo b12c78a731 Graphs: Outline Stroke and a graph left with only labels keep the plot in place
- Outline Stroke on a graph's strokes, including Object > Expand with
  Stroke on, adjusts the bounds the graph keeps, the same way
  Create Outlines on its labels does. Before, the stroke outlines
  changed the bounds of the art without type, and the next redraw
  stretched the plot by the width the outlines added.
- A graph that keeps `placedArt` and has no art other than type left
  is no longer measured on the bounds of all its art. A label edit on
  such a graph moved and stretched the plot at the next redraw; the
  plot now stays where it is.
- A redraw no longer measures a move or scale on art that has no width
  or no height now, such as a graph left with one axis line. Before,
  the plot collapsed to no width.
- A clipping group in a graph that holds type is measured on its clip
  when the clip does not depend on type, so moving art outside the clip
  does not change the bounds. Blends, envelopes and repeats are
  measured whole, as they are drawn.
- The doc crate's helper is named `graph_art_without_type` and sits
  with the file's other free functions.
- docs/mcp.md lists Outline Stroke and states that moving an outlined
  label, a swatch, an axis or a tick mark on its own can move or scale
  the plot, and that a graph left with only labels, or with art that
  has no width or height, does not follow a move.
- Tests: a scale of the graph made before outlining a label, a move of
  a graph opened from `.ai` after its label is restyled and moved,
  Outline Stroke after a move, a graph left with only its labels or
  with one line, and clipping groups holding type.
2026-11-14 13:45:46 -08:00
dotCooCoo 69005d7b3e Graphs: Default Fill and Stroke on an axis line stores the default rows for its kind
Default Fill and Stroke on an axis line, tick mark or radar ring that already
shows the default paint now stores the default fill and stroke rows for every
line of its kind, so a stroke the kind kept from another line no longer comes
back when the graph is drawn again. The object opacity and blend mode the
kind keeps stay as they are.
2026-11-14 13:30:21 -08:00
dotCooCoo 6a5110a40c Merge main into feat/ai-save-graph-records 2026-11-14 13:27:39 -08:00
dotCooCoo c5649c7529 Merge main into feat/variable-library-every-kind 2026-11-14 13:25:37 -08:00
dotCooCoo e90c4e6fb2 Variables: Load and Save Variable Library hold visibility, image and graph variables
Load Variable Library defines each variable with the kind of its trait
(textcontent, visibility, fileref, graphdata; any other or none is the
unknown kind) and reads visibility values from true or false, image
values from a file's absolute path or file: URL, and graph values from
a data element of series names and rows. A document variable declared
with the same name and kind keeps its bindings. Save Variable Library
writes every kind in the same forms and is enabled with any variable.
Image values that aren't absolute paths and graph data past what a
graph holds are refused, so every saved file loads back.
2026-11-14 13:23:02 -08:00
BFlat 20ae675b9b Merge pull request #7622 from dotCooCoo/fix/graph-label-restyle-keeps-plot
Graphs: restyling the labels leaves the plot where it is at the next redraw
2026-11-15 04:22:27 +07:00
dotCooCoo 289fb4b770 Graphs: a pick or added style without transparency keeps the opacity a line or label kind keeps
A whole pick of every fill and stroke attribute, or an append pick, onto
a graph's axis line, tick mark or radar ring stored the line's rows in
full, object opacity and blend mode included, even when the pick did not
apply the object's transparency. On a line that still showed 100% until
the graph was drawn again, that replaced the opacity its kind kept (40%
set on another line became 100%). An append pick onto a graph label, and
graphicStyle.apply with add on a label or line, did the same.

Without Transparency applied, these picks, and a style added on top, now
store the fill and stroke rows and leave the kept object opacity and
blend mode as they were.
2026-11-14 12:48:02 -08:00
dotCooCoo c7c9e7f4db Merge main into fix/graph-series-group-opacity 2026-11-14 12:29:26 -08:00
BFlat 1a8614f00c Merge pull request #7550 from dotCooCoo/fix/graph-wedge-legend-black-kept
Graphs: a black fill set on wedge legend labels stays black on dark wedges
2026-11-15 03:22:47 +07:00
dotCooCoo cc26358b9f Graphs: an appearance moved to an axis line behind its source is kept
Move Appearance captured the cleared source and the targets together, and
graph lines are captured in paint order, so a source in front of its target
replaced the kept axis rows with its cleared ones. The targets are now
captured again after the source.
2026-11-14 12:06:53 -08:00
dotCooCoo f0c02b69ab Merge main into fix/graph-axis-paint-kept 2026-11-14 09:52:51 -08:00
dotCooCoo 7e84899786 Merge main into fix/graph-series-group-opacity 2026-11-14 09:52:39 -08:00
dotCooCoo b4eee0faca Merge main into feat/ai-save-graph-records 2026-11-14 09:42:05 -08:00
BFlat 0342616e15 Merge pull request #7459 from dotCooCoo/fix/followup-7304
Sort Objects: an opacity sort that gives marks their own opacities changes nothing
2026-11-15 00:41:36 +07:00
dotCooCoo d3789f2b0c Graphs: outlined labels and opened .ai graphs keep the plot in place at the next redraw
- A graph opened from a .ai file now saves `placedArt` too. Moving or
  restyling one of its labels before the first redraw no longer moves or
  stretches the plot.
- Type > Create Outlines on a graph's labels now adjusts the saved bounds,
  so the outlines do not read as a move at the next redraw. A move of
  the graph made before the outlining is still followed.
- A `placedArt` with no width or height falls back to the bounds of all
  of the art, as a graph saved without it does.
- `art_bounds` moves to the doc crate so the .ai reader can use it.
- docs/mcp.md describes `placedArt`, `placed` and when a redraw follows
  a move.
- Tests: a legend across the top, a legend after a right value axis and
  legend labels of several lines keep the plot in place through label
  size changes; moving a category label on its own; outlining labels
  before and after a move; a flat `placedArt`; a label moved in an
  opened .ai graph.
2026-11-14 08:47:03 -08:00
dotCooCoo 506f48daea .ai save: live graphs are written as graph records
Both .ai writers now write a graph that the .ai reader reads back as the
same graph with its records, so a saved graph opens again live, with its
table, type, axes and settings: %_Gs, the Gb, Gy, Gd, Ga/GA, Gz, Gc and
GC records, the graph's group with each series' group followed by a Go
tag, and %_GS (the published .ai file format specification, section 17
and appendix A). The records are the ones the reader in
crates/eps/src/import/ai/read/graph.rs (#7311) reads, in the form it
reads them.

The shared encoder in crates/eps/src/ai_graph.rs decides first whether
the reader keeps the graph whole: a column, stacked column, line or area
graph with a legend, settings the records carry, a table of 1 to 10,000
categories and 1 to 256 series with finite values, labels of at most 255
bytes without control characters, and art the reader attaches the graph
to. Any other graph is written as its art, with the existing warning, as
is a graph whose art the editing writer's object limit cuts short.
Tick-mark counts of 0 are written as 1, the count the reader keeps for
both.

Bar, stacked bar, scatter, pie and radar graphs, stacked column and area
graphs whose series marks carry a stroke their legend swatch lacks, and
line graphs with markers are still written as their art, with the
warning.
2026-11-14 08:20:05 -08:00
dotCooCoo 4c67b8f73c Graphs: swatch edits reach the kept black legend fill of graphs that draw it
Only a pie with Legends in Wedges picks its legend labels' fill, white on
dark wedges. Paint visits and swatch mappings now leave its default black
legend fill out only for such a pie; other graphs draw the kept fill, so
it is visited and mapped like the other label fills. A color mode change
still leaves the default black legend fill as the default, so turning on
Legends in Wedges later keeps the white labels on dark wedges.
2026-11-14 08:02:17 -08:00
dotCooCoo 5c9717474f Graphs: restyling the labels leaves the plot where it is at the next redraw
The next redraw of a graph compared the bounds of all its generated art,
labels included, with the bounds stored at the last generation, and took
any difference for a move or scale of the graph. Label edits that change
the size of the type (a new size, an indent, a legend size) changed those
bounds without a move, so the plot shifted and stretched when the graph
was drawn again.

The spec now also stores the bounds of the art without type
(`placedArt`), and moves and scales are measured on those. Graphs saved
without them are measured on the whole bounds as before. Moving one
label with Direct Selection no longer moves or stretches the plot at the
next redraw.
2026-11-14 08:00:54 -08:00
dotCooCoo d233cd8291 Merge main into fix/graph-series-group-opacity 2026-11-14 05:57:05 -08:00
BFlat 9f55dbdd46 Merge pull request #7327 from dotCooCoo/fix/graph-label-paint-recolor
Graphs: recolor, stroke and gradient edits on labels are kept for their kind
2026-11-14 20:37:50 +07:00
dotCooCoo 3597752c63 Merge main into fix/graph-wedge-legend-black-kept 2026-11-14 04:50:46 -08:00
dotCooCoo 5722d2d60d Merge main into fix/graph-axis-paint-kept 2026-11-14 04:44:27 -08:00
BFlat da9d9f8cf4 Merge pull request #7498 from dotCooCoo/fix/graph-design-art-style-redefine
Graphs: graphic styles leave a design's art in a series unlinked
2026-11-14 19:37:45 +07:00
dotCooCoo e4227d1d5b Merge main into fix/graph-axis-paint-kept 2026-11-14 03:29:24 -08:00
dotCooCoo 083180075c Graphs: a black fill set on wedge legend labels stays black on dark wedges
On a pie with Legends in Wedges, the graph draws legend labels white on
dark wedges unless they keep a fill of their own, and it read a kept black
fill as no fill of its own. A label recolored from white to black on a dark
wedge went back to white the next time the graph was drawn.

The graph now marks the legend labels' fill as set when a command sets it
(legendFillSet in the graph's label styles, kept through save and open), and
draws a marked fill on every wedge, black included. Undo clears the mark. A
size, font or stroke change does not set it, and neither does a whole-pie
recolor that gives the legend labels different fills; one that gives them
all the same fill sets it. A swatch edit or color conversion leaves the
default black legend fill as it is, and keeps a non-black legend fill from a
file saved without the mark as the labels' own when it turns black.
2026-11-14 02:54:22 -08:00
dotCooCoo f03d200c16 Merge main into fix/followup-7304 2026-11-14 02:42:19 -08:00
dotCooCoo bf3a23d031 Merge main into fix/graph-label-paint-recolor 2026-11-14 02:19:54 -08:00
dotCooCoo ded56d3d70 Merge main into fix/graph-series-group-opacity 2026-11-14 02:15:46 -08:00
dotCooCoo 5a4020a6c0 Graphs: graphic styles leave a design's art in a series unlinked
graphicStyle.new linked the object it was made from, the art of a column
or marker design in a graph series included, and graphicStyle.redefine
gave the new look to every object still linked to the style. Redefining
the style from another object then restyled that art, which the graph
draws again from the design.

- graphicStyle.new makes a style from the art without linking it.
- graphicStyle.redefine leaves the art's look as it was and unlinks it,
  as an edited object is, whether the art is a linked object (as in a
  document saved before this change) or the source.

Docs: docs/mcp.md, the params text of graphicStyle.new and
graphicStyle.redefine.
2026-11-13 22:27:58 -08:00
dotCooCoo 2a4185d6ca Merge main into fix/graph-series-gradient-per-mark 2026-11-13 22:15:43 -08:00
dotCooCoo f1a79b92cc Graphs: an edit of some attributes on an axis line keeps the rest its kind keeps
An edit that changed only some attributes of a graph line, such as a
transparency-only Eyedropper pick, a cap, or a fill, kept that line's whole
fill and stroke rows for every line of its kind. A line that still showed
the default stroke until the graph was drawn again then replaced the stroke
its kind kept from another line. Such edits now keep only the attributes they
change; Clear Appearance, Move Appearance, graphic styles, and a pick of every
attribute or with append still keep the whole rows.
2026-11-13 22:11:11 -08:00
dotCooCoo c5e2e9210a Sort Objects: an opacity sort that gives marks their own opacities changes nothing
With apply "opacity", Sort Objects compared each object's opacity with the
value it gets as a percentage, within 1e-6. An evenly stepped value can
differ from a mark's percentage by more than that while it rounds to the
same stored opacity: marks at 30%, 65% and 100% sorted by x with
distribute on keep their opacities, yet the 65% mark counted as changed.
The sort then made an undo step and replaced the opacity the graph stores
for the series (30%) with 65%.

The sort now compares each object's stored opacity with the opacity it is
given, as stored, both to skip a run that changes nothing and to pick the
marks whose opacity the graph keeps.
2026-11-13 21:16:20 -08:00
dotCooCoo f0a8c750a3 Graphs: a whole-pie recolor leaves wedge legend labels their contrast
A recolor that reached a pie's legend labels through the graph kept their
new fill as the legend's own when every label ended up with one color (a
one-series pie), so a wedge painted light again kept a white label.
Legend label fills on such a pie are now kept only when the edit named
the labels.
2026-11-13 20:44:06 -08:00
dotCooCoo 877eb84f6d Graphs: an unchanged paint write keeps a series' kept gradient
A paint write that leaves a series mark's gradient as the graph drew it
now keeps the series' stored gradient and its unit-box flag in two more
cases:

- a mark with no width or no height, such as a column for a value of 0,
  where the stored gradient was replaced by the mark's gradient in
  document coordinates and no mark took it on the next redraw;
- a gradient kept in document coordinates (a file saved before the unit
  box), which a stroke weight written as it was moved to the unit box,
  so the next redraw placed it on each mark's own box.
2026-11-13 20:09:25 -08:00
dotCooCoo 58cd62ef38 Merge main into fix/graph-axis-paint-kept 2026-11-13 19:49:27 -08:00
dotCooCoo eb9976a825 Merge main into fix/graph-label-paint-recolor 2026-11-13 19:22:11 -08:00
dotCooCoo 0b207f4e85 Graphs: axis lines, tick marks and radar rings keep the paint set on them
A graph drew its axis lines and tick marks in 0.5 pt black and a radar
graph's rings in 0.25 pt gray every time, with nothing stored for them. A
stroke, fill, weight, recolor, Appearance row, graphic style, Eyedropper
pick or opacity given to them was lost when the graph was drawn again.

- The graph now stores the rows of its axis lines and tick marks
  (axisRows) and, separately, of a radar graph's rings (ringRows): the
  paint, weight, opacity and blend mode of the topmost visible fill and
  stroke row, their order, and the line's object opacity and blend mode.
  Every line of the kind is drawn with them. Dashes, caps, joins and
  arrowheads are not stored.
- These commands store a line's rows: paint.setFill, paint.setStroke,
  the stroke, gradient and recolor commands, paint.swap, paint.default,
  Apply Fill to Stroke and Stroke to Fill, the appearance commands with
  the Eyedropper, graphic styles, transparency.set and object.setProps.
  paint.setFill, paint.setStroke and the recolor commands given a whole
  graph now also store what they give its lines.
- When one command reaches several lines of a kind, the frontmost line in
  paint order sets what the kind keeps. A gradient is stored without its
  placement.
- Lines that show their default stroke store nothing, and a global swatch
  edit or a document color conversion reaches the stored paint.

Docs: docs/mcp.md, the params text of these commands,
docs/target-app-parity.md.
2026-11-13 18:06:25 -08:00
BFlat bf3cf422e2 Merge pull request #7311 from dotCooCoo/fix/ai-graphs-keep-data
PDF/.ai import: graphs keep their data and settings when their records read whole
2026-11-14 08:39:57 +07:00
dotCooCoo 78e7227358 Merge main into fix/graph-series-gradient-per-mark 2026-11-13 17:01:05 -08:00
dotCooCoo 87b4a8053b Merge main into fix/graph-series-group-opacity 2026-11-13 16:49:51 -08:00
dotCooCoo c88da287e7 Graphs: the label gradient test places the gradient before the redraw drops its placement
The test now sets the edited label's gradient vector and aspect with paint.setGradientGeom and checks that the gradient is placed before the graph redraws, so the later check that the kept gradient has no placement fails if the redraw keeps it.
2026-11-13 16:34:27 -08:00
BFlat c79a21c8b7 Merge pull request #7320 from dotCooCoo/fix/graph-design-art-appearance
Graphs: Appearance and effect commands leave a design's art in a series out
2026-11-14 07:33:59 +07:00