Commit Graph
798 Commits
Author SHA1 Message Date
yoriswind 390203c35b 6582: resolve status documentation after the Blend fix merged 2026-11-18 05:13:11 -08:00
BFlat dce8a0c05e Merge pull request #7065 from yoriswind/codex/5179-blend-spine-redraw-bounds
Fix redraw bounds for blends following a curved spine
2026-11-18 19:58:54 +07:00
yoriswind 91898148d6 6582: preserve Eraser behavior with current upstream documentation 2026-11-18 04:55:12 -08:00
yoriswind 1d28f45f58 6582: retain fitted gradients beneath enclosing geometry effects 2026-11-18 04:39:25 -08:00
yoriswind c076b85fcf Use rendered clip paint to verify witness setup 2026-11-18 04:04:44 -08:00
yoriswind 242695b1a1 Add fixed pinning-only paint preservation witnesses 2026-11-18 03:28:38 -08:00
BFlat 91c6a702c6 Merge pull request #8535 from dotCooCoo/fix/dimension-line-level
Dimension tool: a dimension line placed beside another lands on its level
2026-11-18 18:25:01 +07:00
yoriswind 56b4fcb8c6 Fix redraw bounds for rotated Blend effects
Measure effect-bearing Align to Path content after spine placement, retaining
the conservative envelope and covering damage containment with original
software-rendered move and Undo controls.
2026-11-18 03:19:27 -08:00
yoriswind 3f09579dcd Merge upstream main to resolve PR #6601 documentation conflicts 2026-11-18 02:41:17 -08:00
dotCooCoo 18a7f7b84b Dimension tool: a dimension of the same points lines up too
The level a new dimension line lands on now comes from the dimension
lines in the document before the dimension's first preview, so its own
preview is never a level. A dimension drawn earlier between the same two
points now acts as a level as well; before, every dimension of those
points was skipped.

- Of two lines on one level, a line the pointer lies across wins over a
  line whose end is nearer the pointer.
- A dropped press while placing removes the level guide with the
  preview.
- The reach uses the Smart Guides snapping tolerance helper.
- docs/dimensions.md says the rule applies to a dimension anywhere in
  the document.
- The tests are split by behavior, with new tests for the same points,
  pointer moves in small steps, the guide after a dropped press and
  with Alignment Guides off, and the tie-break.
2026-11-18 01:40:21 -08:00
bflatastic ca187dfcbf Merge main into #8424 2026-11-18 16:25:39 +07:00
yoriswind a9b4015e40 Merge pinned current main for the confirmed #7065 bounds repair 2026-11-18 00:37:17 -08:00
BFlat abb2503bc9 Merge pull request #8536 from dotCooCoo/fix/dimension-arrow-previews
Dimension: Arrow Style shows each style's arrowhead drawn before its name
2026-11-18 15:23:50 +07:00
bflatastic 6c337442d9 Merge main into #8424 2026-11-18 14:04:27 +07:00
BFlat ada472586e Merge pull request #8135 from dotCooCoo/fix/confined-exporter-and-placed-pdf-paths
MCP: confined exporter plug-ins and unreadable linked files keep paths outside the read roots
2026-11-18 13:53:34 +07:00
dotCooCoo 285fc75c95 Dimension: test each Arrow Style's arrowhead against the expected head
The engine test now names the head each style draws (Filled a filled
triangle, Open an open triangle, Tick a slash, None no head) instead of
comparing the dimension line with ArrowStyle::arrowhead, which the
engine itself calls. It moves to crates/engine/tests/it/dimensions.rs.

The Arrow Style previews take each style from a constant list in the
order of the dropdown entries instead of parsing the entry's value
every frame, and a test checks that each entry's value matches its
style.

Part of #8049.
2026-11-17 22:17:50 -08:00
BFlat 20d8217312 Merge pull request #7950 from dotCooCoo/feat/smooth-bridge
Path Precision Tools: Smooth Bridge joins two circles with concave arcs
2026-11-18 13:12:40 +07:00
BFlat 3b25ff3945 Merge pull request #6697 from yoriswind/codex/6625-visible-fill-selection
Fix path interior selection across enabled fill rows
2026-11-18 13:01:16 +07:00
BFlat 10b2d14d1b Merge pull request #8342 from dotCooCoo/fix/issue-1954
Fix #1954: PDF/X CMYK in the output intent's profile is written as DeviceCMYK
2026-11-18 12:57:50 +07:00
BFlat c0ec570d0f Merge pull request #8371 from dotCooCoo/feat/transform-line-properties
Transform: a live line shows Line Properties with Line Length and Line Angle
2026-11-18 12:57:04 +07:00
dotCooCoo dc92781181 Part of #5590: Dimension tool lines line up with dimensions already drawn
A linear dimension placed next to another one had its line exactly where
the pointer was. Chained dimensions only lined up when the pointer hit
the other line's level exactly, which at a normal zoom it rarely does.

- With Smart Guides on, a linear dimension placed with its line within
  the Smart Guides snapping tolerance of the level of a parallel line of
  a visible, unlocked linear dimension already drawn has its line on
  that level. This applies to two clicked points and to a segment
  dragged out.
- With Alignment Guides on, a guide runs along that level across both
  lines while the dimension is placed.
- Smart Guides off, a level further off, a locked dimension or one that
  is not parallel leaves the line where the pointer puts it.

Docs: docs/dimensions.md, docs/target-app-parity.md.
2026-11-17 21:33:30 -08:00
dotCooCoo 5945e6e12a Merge main into fix/confined-exporter-and-placed-pdf-paths 2026-11-17 20:13:03 -08:00
dotCooCoo da061c6dc8 Merge main into fix/confined-exporter-and-placed-pdf-paths 2026-11-17 19:33:39 -08:00
BFlat 3dfd692304 Merge pull request #8078 from dotCooCoo/feat/text-import-character-sets
Text Import Options: Character Set offers the other documented encodings
2026-11-18 10:31:10 +07:00
BFlat 3a9bb87022 Merge pull request #7925 from dotCooCoo/feat/brush-options-of-selected-object
Brushes: Options of Selected Object changes one brushed path's brush settings without changing the brush
2026-11-18 10:18:41 +07:00
BFlat 1380e9c480 Merge pull request #7675 from dotCooCoo/feat/unit-converter
Unit Converter: one length in every unit, read from and applied to the selection
2026-11-18 10:16:26 +07:00
yoriswind 0dd87f8921 Merge main into the qualified Eraser group-stroke repair 2026-11-17 17:40:53 -08:00
dotCooCoo 38a178154b Merge main into feat/smooth-bridge 2026-11-17 17:38:12 -08:00
dotCooCoo 1ea1fd8556 Merge main into feat/transform-line-properties 2026-11-17 13:26:08 -08:00
ruchirguitar b268319320 Production Preflight: fix review issues and merge main 2026-11-18 02:48:20 +05:30
dotCooCoo 513b4aefaa Merge main into fix/issue-1954 2026-11-17 13:17:24 -08:00
BFlat 409b8ce9d1 Merge pull request #8058 from dotCooCoo/perf/selection-batch-toggle
Selection: select.toggle and select.add with many ids go through the selection once
2026-11-18 03:19:52 +07:00
ruchirguitar d6ff2f54ce Production Preflight: add output checks and repair panel 2026-11-18 01:35:12 +05:30
dotCooCoo cd4e9e9506 Transform: a live line shows Line Properties with Line Length and Line Angle
A line drawn with the Line Segment tool now shows Line Properties in the
Transform panel and the Properties panel's Transform section, with the two
properties the help page lists for a line:
https://helpx.adobe.com/illustrator/desktop/draw-shapes-and-paths/modify-live-shapes/live-shape-properties.html

- object.setLiveShape takes lineLength (pt, above 0) and lineAngle
  (degrees, brought into 0 to 360). Every selected line changes in one
  undo step; a value that changes nothing records none.
- VectorCraft's own rules: the angle runs counterclockwise from 3 o'clock,
  as the Rotate field does; a new length keeps the first end in place and
  a new angle turns the line about its midpoint; a line whose ends meet
  reads 0 degrees; the section shows only while every selected object is a
  live line; a line that would reach past the coordinate limit is an error
  that changes no line.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-17 09:57:07 -08:00
yoriswind 5f0e011379 Preserve open outlines painted by ancestor strokes 2026-11-17 07:48:02 -08:00
dotCooCoo 12977ec543 Fix #1954: PDF/X CMYK in the output intent's profile is written as DeviceCMYK
A PDF/X-3 or PDF/X-4 export tagged every CMYK color with an ICC-based
space of the same profile that the output intent embeds. In PDF/X-3 and PDF/X-4, CMYK colors in the
profile of a CMYK output intent are now DeviceCMYK, and the profile is
written once, as the output intent's DestOutputProfile (ISO 32000-1,
14.11.5:
https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/PDF32000_2008.pdf#page=641).

- With output.profiles none and a CMYK output intent, PDF/X-3 and PDF/X-4
  write every CMYK color as DeviceCMYK, unless colors are converted to a
  CMYK destination of another profile, which keeps its tag. Before, those
  standards tagged every color whatever profiles said.
- RGB and gray colors stay tagged, and so do CMYK colors and images in
  another profile.
- A CMYK image that carries the output intent's profile is DeviceCMYK,
  and so is every CMYK image when none makes CMYK colors DeviceCMYK. A
  CMYK JPEG then loses its ICC_PROFILE segments.
- Transparency groups blend in DeviceCMYK when CMYK colors are
  DeviceCMYK, also when the file has no ICC-based CMYK space.
- Files without a standard keep the tags that profiles asks for.
- The Save PDF dialog's note for PDF/X-3 and PDF/X-4 says that CMYK
  colors in the output intent's profile are written as DeviceCMYK.

Docs: docs/mcp.md, docs/target-app-parity.md and the document.exportPdf
params text.
2026-11-17 07:30:22 -08:00
yoriswind 4c764b2912 Merge main and retain qualified changes for #7065 2026-11-17 05:51:24 -08:00
yoriswind df92153483 Merge upstream main and retain independent progress documentation 2026-11-16 23:59:16 -08:00
dotCooCoo 566d5263b9 Merge main into feat/ai-editing-data-meshes 2026-11-16 23:38:43 -08:00
BFlat 6a2fa16cd1 Merge pull request #8289 from dotCooCoo/feat/ai-blends-in-editing-copy
.ai save: the editing copy keeps live blends
2026-11-17 14:32:25 +07:00
dotCooCoo ff6e3ad8b9 Merge main into feat/text-import-character-sets 2026-11-16 19:55:55 -08:00
yoriswind 443b081128 Merge upstream main and retain independent parity history 2026-11-16 19:11:21 -08:00
dotCooCoo 4b2868bd07 .ai save: the editing copy keeps live blends
The editing copy of a PDF-compatible .ai wrote every blend as its steps.
Blends the .ai reader opens live are now written live:

- The blend's key objects and, when it has a spine of its own, its
  spine are written as a group on hidden lines, each key's dictionary
  naming it a key and its id and the spine's naming it the spine. Its
  steps follow as a group, then the Path Blends record of its spacing
  (Smooth Color, Specified Steps, Specified Distance with its distance),
  orientation (Align to Page, Align to Path) and keys, then its
  dictionary (name, text wrap options, variables) and its opacity and
  blending mode as a group's after its end. A spine edited on the canvas
  is written with each key's anchor on the key. A replaced spine is
  written with an anchor where each key sits, so it opens with those
  anchors and lays out the same steps.
- Each blend is checked with the reader's own reading before it is
  written, and the blends together against the objects the reader lays
  out in one file. Written as their steps with a warning: blends with
  easing, a color shift or start points; with effects, an appearance or
  an opacity mask of their own; of objects other than paths, compound
  paths and groups, of clipping groups, of more than 62 key objects, of
  hidden keys or keys holding a blend; of keys with geometry or
  Pathfinder effects or a group's own fills and strokes, which the
  editing copy writes as their result; of keys the editing copy would
  change otherwise (empty paths or subpaths, paths and compound path
  members of several subpaths, several fills or strokes, strokes a plain
  line can't draw, dashes of more than 64 lengths, hidden fills or strokes, fills or strokes other than
  a color, in a Lab color or with transparency or effects of their own,
  effects, opacity masks); blends where one key has a fill or stroke of
  no paint or a stroke of no width and another has one that draws;
  blends whose spine has more than one part;
  blends whose step count is close to where rounding the written
  coordinates and colors changes it; blends the reader would open with
  other settings or not as drawn; blends inside objects with geometry or
  Pathfinder effects or a group's own fills and strokes; blends in
  opacity masks, pattern tiles, symbols and art cut to a clipping object
  or nested eight levels deep in art written in place of other objects;
  blends whose art would pass the most objects the reader reads; and
  every blend on a large canvas.
- The steps set their own transparency and lock and hidden state after
  the hidden lines, for readers of the printed form.

Each construct is written in the form the .ai reader reads (blend.rs,
read/document.rs blend roles, read/containers.rs end_blend, read/ops.rs
XP and transparency), and every object written counts toward the
reader's object limit as the reader counts it. The record's orientation
word and a blend with no spine part are read as #8243 reads them.

Blend Options, key objects and spines:
https://helpx.adobe.com/illustrator/desktop/manage-colors/apply-transparency-and-blending/blend-options-overview.html
https://help.adobe.com/archive/en_US/illustrator/cs5/illustrator_cs5_help.pdf#page=260

Tests: the round trip of blends of each spacing and orientation, with
no spine of their own, an edited spine and replaced curved spines,
named, at half opacity, hidden and locked, with text wrap options, of
compound paths, of groups and of 62 keys, each laying out the same steps
as the document's blend; the record's words (Align to Path's angle
included) and the dictionaries; the steps' own state after the hidden
lines; the same bytes on a second write; each case written as its
steps, with as many steps as are drawn, where they are drawn (among
them Specified Distance 0.03 pt from where its count changes, on a
spine of 200 segments, which comes back live on a spine of two); blends in
pattern tiles, opacity masks, symbols, art cut to a clipping object and
eight levels down; the object limit; the reader's blend limit; a large
canvas; fuzz cases for damaged written blends.

Docs: docs/file-format-parity.md.
2026-11-16 17:31:04 -08:00
BFlat 79d2536e8e Merge pull request #8089 from dotCooCoo/fix/issue-8063
Part of #8063: Dimension tool points snap to drawn dimensions and show anchor and path labels
2026-11-17 08:19:12 +07:00
dotCooCoo 94f4a63270 .ai save: a mesh patch folded at one corner is written as its drawn look
The writer measured which way each patch turns only at its first corner,
along the straight lines to the next corners. A patch whose point is
dragged across it, or whose handles cross at a corner, passed as a
plain patch and was written as a mesh. Each corner of each patch is now
measured along the straight lines and along its handles, and a mesh
whose corners turn different ways is written as its drawn look with the
warning.

- Tests: a patch folded at a corner by a moved point and by crossed
  handles; a reflected mesh read back draws the same points and opacity
  across each patch; an envelope in a symbol's art with its grid and
  contents in the symbol's own space opens as the art it draws, and one
  in a file without a template box is left unread.
- The fuzz case for written meshes moves next to the other editing-data
  cases in import_fuzz.rs.
- Docs: file-format-parity.md says a reflected mesh opens with each
  row's points in reverse order, and how envelopes in symbols open;
  target-app-parity.md links the help page on mesh point opacity.
2026-11-16 14:27:47 -08:00
yoriswind e9444983ef Merge main and preserve source-fitted container gradients 2026-11-16 14:16:34 -08:00
dotCooCoo de367486c0 .ai save: the editing copy keeps gradient meshes
The editing copy of a PDF-compatible .ai wrote every gradient mesh as
its drawn look. Meshes the .ai reader reads back as they are are now
written as meshes:

- Each mesh is a /Mesh record: 2 /Version, its type and grid size,
  /Data, then each patch row by row with its place, the color space
  where it changes (gray, RGB or CMYK) and its four corners: color,
  opacity, point, and the handles towards the next corner and the one
  before it. Its opacity, blending mode and knockout shape are set
  before the record, and its name and opacity mask follow it.
- A reflected mesh, whose patches all turn the other way, is written
  with its columns in reverse order, which draws the same mesh.
- In a symbol's art the corners are written about the canvas point of
  the ruler origin, y up, as an image's matrix there is. An envelope's
  grid in a symbol's art is now written in the same space, and the
  envelope's contents in its dictionary in the canvas's space, y down.
- Each mesh is checked with the reader's own reading before it is
  written. Written as their drawn look with a warning: meshes with a
  point in a Lab color, with more than 128 rows or columns, folded
  meshes (patches that turn different ways), meshes the reader would
  read with other points, handles or colors, meshes in pattern tiles
  and in art cut to a clipping object, and every mesh on a large
  canvas. A mesh's drawn look is written at any depth of nested
  symbols and live objects.

Each construct is written in the form the .ai reader at e142c5fcee
reads: /CS, /Type, /Size, /P, /N and /E in mesh.rs:180-234, corners
with or without an opacity by their count of values in read_corners
(mesh.rs:239), the patches joined into one mesh in one_mesh
(mesh.rs:298); /Mesh X!, X# and /End X! in read/ops.rs:219-232; the
transparency after the record in read/art.rs:281 (end_mesh) and
read/ops.rs:344. /Version and /Data are passed over by that reader
(mesh.rs:234). Corners in a symbol's art rest on a reader change in
this commit.

The reader changes how any .ai opens:

- Mesh records and envelope grids in a symbol's art are read in canvas
  space (read/document.rs:947 image_space), and an envelope's contents
  in its dictionary in the canvas's space, y down. In a file without a
  template box such a mesh is left unread, its symbol is not read
  whole, as with an image there (read/art.rs:634), and its instances
  open as the page draws them. Envelopes in symbols in .ai files saved
  by earlier VectorCraft builds open differently.
- A point of a patch whose corners differ in color model keeps its own
  color when the patches are joined into one mesh.

Gradient meshes, mesh points and their opacity:
https://help.adobe.com/archive/en_US/illustrator/cs5/illustrator_cs5_help.pdf#page=200
Patch meshes (corners joined by cubic edges with control points):
https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/pdfreference1.7old.pdf#page=321

Tests: the round trip of meshes with RGB, CMYK and gray points, a moved
point with handles of its own, part-transparent points, a name,
opacity, blending mode and knockout shape, hidden and locked, with an
inverted, unlinked opacity mask, in groups, opacity masks, symbols,
opacity masks in symbols, a document of two artboards and eight levels
down, compared point by point, handle by handle and channel by channel
at the 4 decimals written; reflected meshes, mirrored across and
along; the record's form, including corners in a symbol's art and an
envelope's grid and contents there; an envelope in a symbol read back
with its contents and their gradient in place; the same bytes on a
second write; each case written as its drawn look, with its paths read
back over the mesh's box; reading a mesh in a symbol's art with and
without a template box; /Version and /Data passed over; the color
model rule; fuzz cases for damaged written meshes, a symbol's
included.

Docs: docs/file-format-parity.md, docs/target-app-parity.md.
2026-11-16 13:44:56 -08:00
BFlat fb6845b07a Merge pull request #8161 from dotCooCoo/perf/cut-selection-one-pass
Cut: take the cut objects out of the selection in one pass
2026-11-17 02:50:44 +07:00
BFlat 5190f99c6c Merge pull request #8173 from dotCooCoo/fix/editing-data-fallback-says-why
.ai import: a refused PDF part's error says why the editing data couldn't be read
2026-11-17 02:50:01 +07:00
yoriswind 0774371250 #6582: preserve straight fill closure during erasure 2026-11-16 10:57:58 -08:00