When the import refuses a file's PDF part and its editing data can't be
read either, the error named only the PDF part. It now adds "its editing
data couldn't be read either (<why>)", as layers already do
(crates/eps/src/import.rs). The reasons come from the editing data
reader (a size limit, damaged compression) and from the private data
streams (larger than 256 MB, another filter or decode parameters,
damaged zlib data). A file without editing data, and an open with pages
picked, layers off or the editing data off, keep the PDF part's error.
Part of #4366.
With `pdfs: "single"` and several assets, layers or selected objects
(`selection: "each"`), document.exportForScreens wrote one PDF named
after the document holding only the first item's art, and every other
item's PDF was left out. Single file puts artboards on the pages of one
PDF; each asset, layer or object is cut out of the document with its own
art, so the export now refuses that combination before it writes any
file, and the Example line refuses it too. `pdfs: "multiple"` still
writes a PDF of each item, and `selection: "one"` writes one PDF either
way.
Docs: params text, docs/mcp.md, docs/target-app-parity.md.
The decoding File › Open, Place and the renderer share moves to
vectorcraft-doc (decode.rs: decode_image, decoded_layout), and SVG
import's images read through it: the size from the header against the
allowance first, then the pixels as stored with the profile the file
embeds (a TIFF's still read by the TIFF reader).
decoded_pixels_are_those_the_image_crate_read compares PNG, GIF, WebP,
TIFF and BMP at each depth the image crate writes with its pixels, and
JPEG within two steps.
The raster path tells formats with craft-image-codecs' detect, reads the
size from the header (vectorcraft-doc's header_size, the renderer's
decoded_layout, a Targa's own header) and decodes with the renderer's
decode_image, the pixels as stored, with the profile the file embeds.
The size notes Open, Place and the Links panel give, and Glass's Load
Texture, read the same way.
opened_rasters_are_the_pixels_the_image_crate_read compares BMP, TGA and
TIFF at 8 and 16 bits, gray and color, with and without alpha, with the
image crate's pixels, and PNG, JPEG, GIF and WebP stored as they are.
Remove Background and Color Mask check the image's size from its header
again before decoding ("an image of W × H pixels is too large to change"),
and Crop Image's trim and Remove Background read a file that can't hold
the pixels its header declares as unreadable, as on main. The test helper
reading Remove Background's output keeps 16-bit samples.
The HEIF and JPEG XL readers and their tests go back to main's (heic-rs and
jxl-oxide): the craft-heif and craft-jxl versions failed eight of their
tests (resolution axes after a quarter turn, the container's mirror and
crop, refusing a grid of cropped tiles, 16-bit samples, the decode
allowance). Moving them stays to do.
A PSD export now writes image resource 1050 in version 6 of the PSD file
format specification's slices resource format, the form that Import
Slices reads (crates/engine/src/cmd/fileio/psdslices.rs, version_6).
Flat and layered exports both carry it.
- The user and object slices that reach into the exported artboard are
written, clipped to it in its pixels, at least one pixel each way.
Auto slices are left out; opening the file lays them out again.
- An object slice is written as a user slice over its object's bounds,
and an HTML Text slice as No Image with its type's text as HTML. Name,
type, link, target, message, alternative text, cell text and
background color are kept; text alignment is written as the default.
- Slice IDs count from 1.
- More than 10000 slices or a text longer than 65536 characters is an
export error, matching the reader's limits. A slice without finite
bounds, or slices that would make the resource longer than 4 GB, is
also an export error; the size is checked before each text is added.
import_fuzz builds PSD files from scratch whose image resource 1050
holds slices in version 6 (a version 16 descriptor after the first
record) and in the version 16 descriptors of versions 7 and 8. Each
sample has one user slice, one slice that follows a layer and one
generated automatically; the first two come in as user slices.
- the_sliced_psd_samples_bring_in_their_user_slices: each sample opens
with its two user slices and no warning, document.psdInfo counts 2,
and an embedded place brings 2.
- sliced_psd_samples_with_huge_counts_or_cut_short_come_in_without_their_slices:
slice counts of 10,001, 0x7fffffff and u32::MAX, data one byte
short, and data cut inside the count bring the art in without its
slices and with a warning.
- mutated_psd_slices_never_panic: mutated slice data, kept whole, cut
short with the resource length rebuilt, or with the file cut in the
resource block, never makes document.open, document.psdInfo or an
embedded file.place report an internal error.
tests_psdslices::damaged_slices_never_panic now fails when a command
reports an internal error instead of discarding the results.
Under automation read roots, the native document that an SVG or SVGZ
carries with Preserve Editing now leaves out the Export for Screens
folder (`export_settings.folder`) when that folder is outside the read
roots, as `document.exportSettings` already does in its reply. The other
export settings and the art are kept, a folder inside the roots is kept,
and the open document is not changed.
An SVG or SVGZ of a chosen artboard left out a brushed path lying just
off the artboard even when its brush art painted onto it, as the
artboard filter measured the path without room for its brush art. The
filter now leaves the room PDF and EPS export leave
(vectorcraft_brush::reach_within): none for a brushed stroke without a
paint, only the clipping path's for a clip group, and only a compound
path's own strokes.
The PSD Options dialog gets Preserve Text Editability, and document.export
takes preserveText (with layers). Horizontal and vertical point type is
written as a type layer (a TySh block with its EngineData) that a reader
can edit, and keeps its pixels. The layer holds the text, its fonts by
PostScript name, size, leading, tracking, scaling, baseline shift, caps,
underline, strikethrough, fill color, Fractional Widths, paragraph
alignment and orientation.
Type that a type layer would draw differently stays pixels: area type,
type on a path, strokes, non-solid fills, fractional tracking, character
attributes the layer does not carry, paragraphs that set more than their
alignment or run right to left, System Layout, Optical Margin Alignment,
ruby, effects, an appearance of its own and opacity masks. A layer that
holds type becomes a group of its type layers and pixel layers of the art
between them, unless other art in it blends in a mode other than Normal.
links.relink and links.update kept a PSD or PSB file's clip group as it
was, so an image relinked to a file with another clipping path, or with
none, stayed clipped to the old file's path, and a plain image relinked
to a clipped PSD came in unclipped.
- The PNG a PSD or PSB file's merged image is kept as now carries the
clipping path the file names in a text chunk, and RasterImage.clip
holds it with its fill rule (even-odd), as it holds a DCS file's
(nonzero).
- links.relink and links.update read that path the way they read a DCS
file's: the clip group's clipping path becomes the new file's, a file
that names none leaves a plain group of the image, and a later file
that names one clips it again. A clip group whose path or fill rule
was changed in the document stays as a clipping mask around the
file's clip group.
- docs/mcp.md and the evidence line in docs/target-app-parity.md
describe the new behavior.
Opening a PDF with Crop To Trim Box put each artboard 36 pt after the
one before, while the bleed boxes round the trim boxes became the
document's bleed. With a bleed over 18 pt, one page's bleed reached
into the next artboard, and a page exported with its bleed showed part
of its neighbor. The document's bleed is now read from every picked
page first, and the artboards are 36 pt apart plus that bleed on both
sides, as linked pages on their trim boxes are laid out since #7723.
The read-root check for SVG output now looks at the same art the
writer draws:
- A placed document's art is checked, with the pixels its file holds.
A placed native file that links an image outside the read roots was
written with that path under Images: Link.
- Hidden objects inside symbols, patterns and graph designs are left
out unless hidden layers are kept, as they are in the layers.
- With profile tiny12 the file leaves out opacity masks, and their
images are not checked.
- An object whose effect SVG has no filter for is checked as the image
the file draws of it, for file output and clipboard.exportSvg alike.
The last three refused files and clipboard SVG that name no file
outside the roots.