A transform no longer leaves locked guide paths in place: a guide in a
group moves with its group again, as on main. Keeping them put made
Align, Transform Each, the pixel-grid snap and Objects on Path measure or
place art the transform did not move. Scaling::keep_guides and its
engine wiring and test are removed.
The marquee rule now covers the rest of the selection side, while guides
are locked or hidden:
- the guide rule goes down the walk as an explicit Rules value instead
of a thread-local guard;
- an Enclosing Lasso loop does not take a compound path for its guide
contours;
- an enclosing marquee measures a group without its guide paths
(Node::without_guides);
- Direct Selection's marquee takes no anchor or crossed segment of a
guide path.
Docs: the Guides area row, its evidence entry and the M1 row describe
the marquee behaviour; status lines and revision rows say a guide in a
group still moves with it.
While guides were locked, a guide path inside a group was still touched by
a selection marquee, so the marquee selected the group and moving the
group moved the guide (#8538). Clicks already skip guides (#3074).
- hit: marquee_in_view and enclosure_candidates take skip_guides; the
Selection, Direct Selection, Group Selection and Enclosing Lasso tools
pass !cx.guides, and the marquee then touches no guide path at any depth.
- doc: Scaling::keep_guides leaves the guide paths among a group's,
layer's or Intertwine group's children in place, as a ruler guide in a
transformed layer already stays.
- engine: transforms (apply_transform), Transform Each and Align and
Distribute set it while Lock Guides is on; a copy takes a copy of the
guide with the copied art and leaves the original.
Fixes#8538
The level a new dimension line lands on now comes from the dimension
lines in the document before the dimension's first preview, so its own
preview is never a level. A dimension drawn earlier between the same two
points now acts as a level as well; before, every dimension of those
points was skipped.
- Of two lines on one level, a line the pointer lies across wins over a
line whose end is nearer the pointer.
- A dropped press while placing removes the level guide with the
preview.
- The reach uses the Smart Guides snapping tolerance helper.
- docs/dimensions.md says the rule applies to a dimension anywhere in
the document.
- The tests are split by behavior, with new tests for the same points,
pointer moves in small steps, the guide after a dropped press and
with Alignment Guides off, and the tie-break.
The preview segment from an anchor with an outgoing handle was drawn as a
quadratic curve through that handle, while a click appends a corner
anchor, which makes the cubic curve that leaves along the handle and
arrives without one. The segment changed shape when the anchor went
down. The rubber band now draws that cubic curve.
Part of #8296.
Switching away from the Selection tool or a shape tool during a drag of
a corner, pie or side widget left the drag's interaction open with its
preview in the document. Both tools now cancel the drag on deactivate,
as Escape does, as the Selection tool already did for a blend widget.
A linear dimension placed next to another one had its line exactly where
the pointer was. Chained dimensions only lined up when the pointer hit
the other line's level exactly, which at a normal zoom it rarely does.
- With Smart Guides on, a linear dimension placed with its line within
the Smart Guides snapping tolerance of the level of a parallel line of
a visible, unlocked linear dimension already drawn has its line on
that level. This applies to two clicked points and to a segment
dragged out.
- With Alignment Guides on, a guide runs along that level across both
lines while the dimension is placed.
- Smart Guides off, a level further off, a locked dimension or one that
is not parallel leaves the line where the pointer puts it.
Docs: docs/dimensions.md, docs/target-app-parity.md.
A release away from the last drag point now moves the circle's points to
the release position before the circle is drawn, for a drag from the
first press, from a second press and from a press on the first point. A
release within 2 screen points of the press is still a click and keeps
the point of the press.
With a sublayer isolated, Exit Isolation Mode now isolates its parent layer
and selects the sublayer, so repeated use goes up one layer at a time and
leaves isolation mode from the top-level layer, as the help page describes:
https://helpx.adobe.com/illustrator/desktop/manage-objects/select-objects/isolate-objects.html
This applies to the Layers panel menu item, the isolation bar's back arrow,
the Control bar button, the canvas context menu, a double-click outside the
art and object.exitIsolation {}. Before, each of them left isolation mode in
one step.
- object.exitIsolation takes all (default false); all: true leaves
isolation mode from a sublayer at any depth. Any other value is an error.
- Esc and the top-level layer's crumb on the isolation bar pass all: true,
so they still leave in one step. A sublayer's crumb isolates that
sublayer.
- A hidden or locked parent layer is not isolated; the call leaves
isolation mode. A step up records no undo step. Groups keep their rule.
While a Pen drag past the drag threshold shapes a handle, the Info
panel shows the change in x and y, the distance and the angle from
the anchor to the handle's end: the outgoing handle of a new, added
or last anchor, and the incoming handle of the first anchor when the
drag closes the path. Shift gives the constrained handle and Space
moves the anchor with it. The readout clears on release, a dropped
press and a tool change.
The checks that look only at selected blends' spines (Direct Selection's
hover, press and marquee, the Anchor Point tool's press and handles, and
the Pen's click on a spine) walked the whole document and built every
blend's spine before keeping the selected ones. They now go through
direct::selected_spines, which returns an empty list when no selected
object is a blend and otherwise keeps the same order and filter. The
check that finds a point on any blend's spine is unchanged.
On 20,000 paths and 200 blends, 500 checks with one plain path selected
took 24 us instead of 336 ms; with one blend selected the time is the
same. Results are compared against the old filter in the tests.
The Circle tool, in the Ellipse tool's flyout, draws a circle with
shape.circleThroughPoints. A drag from one point to another, or a click
on each, draws the circle with the two points as the ends of a diameter.
A click on a first point, then a press on a second point dragged to a
third, draws the circle through the three. Shift keeps the second point
at 45° steps from the first. For a circle on two points, Alt rounds the
diameter to the nearest ruler tick at the current zoom in the General
unit. Each point snaps to Smart Guides. Until the release the tool shows
the circle as a dashed outline (solid once it is more than 50,000 screen
points around), a cross at its center, a line from the center to each
point and, with Measurement Labels on, the diameter by the pointer.
Three different points on one line, or a circle past the canvas, show
"Circle too large" by the pointer instead, and the release draws
nothing. Escape, a dropped press, and an edit, Undo or Redo made outside
the tool drop the first point. A second press within 3 screen points of
the first point, or one that snaps to it, places nothing when let go
there, and draws the circle on the diameter it drags out when dragged.
Each circle is one undo step. The tool's icon is new and drawn for
VectorCraft.
shape.circleThroughPoints also takes two points, or two selected anchor
points, as the ends of a diameter. Its two errors about the number of
points now say "two or three", in every catalog that translates them.
Part of #7178.
With a Type tool active, the overlays laid out every selected area type
and type on a path on each frame only to read whether its text
overflows, and the single kept layout of the edited frame was replaced
by each of them, so the edited frame was laid out again too. After
Select All in threaded text, the story's other frames were laid out on
every frame with no cache at all.
The tool now keeps each other frame's layout from the last overlays
call, keyed by the layout inputs (fonts and hyphenation exceptions) and
the text object, as the ports of the other tools already do. Each call
keeps only the frames it draws, up to 2,048, and choosing another tool
drops them. The overlays are the same.
The hatch over the region under the pointer, and over each region a drag
has touched, tested every flattened edge of the region on every hatch
line, on every repaint. The edges are now sorted by their lower end once,
and each line tests the edges that span it (plus any edge with a NaN or
infinite end height, which keeps the old test on every line). The
crossing test, the crossing formula, the sort and the pairing are
unchanged, so the hatch lines are the same coordinate for coordinate.
Tests compare every coordinate's bits against a copy of the old function
on 12 paths at three gaps, check the sweep's crossings line by line
against the old test, and count the edges tested on a 2,000-sided region.
Width points selected before their stroke took a brush show no handles,
but the Width tool still took Delete, Backspace and Escape for them. The
tool now leaves those keys to the app, as it does with no width points
selected.
- The Profile list shows its hover border whenever a click opens it,
including on a brushed stroke with a profile, where it lists Uniform.
- A test checks that the list's hover text and the Width tool's status
message are the same string, so the two share their catalog rows.
- An engine test checks that a press or a double-click on a brushed
compound path puts the message in the status bar and runs no command.
- The doc comment of Session::brushed_strokes_profiled says when type
counts, and the progress-doc line names the double-click and says that
art and pattern brushes do not follow a width profile yet.
With the Selection tool, a double-click on the side widget went on to the
art under it, or left isolation mode when no art was under it. The widget
now takes the double-click, as the blend widget does.