Commit Graph
916 Commits
Author SHA1 Message Date
BFlat 1f84febb08 Merge pull request #8169 from dotCooCoo/fix/symbol-lookup-index
Symbols: render and SVG/PDF export find each instance's symbol in one index
2026-11-18 03:23:44 +07:00
BFlat aab753f4f2 Merge pull request #7819 from dotCooCoo/feat/textures-map-art-and-shading
Export 3D Object: mapped graphics export as textures of their faces
2026-11-18 03:23:34 +07:00
BFlat a18fef053f Merge pull request #8288 from dotCooCoo/fix/metafile-loss-warnings
Metafile import: warn about images, clips and raster operations the reader leaves out
2026-11-18 03:22:29 +07:00
BFlat 36b5a5920c Merge pull request #8098 from el-j/feat/save-pdf-transparency-confirmation-8097
Fix #8097: Save PDF: show flattener rasterization resolutions in Summary warning and Advanced section
2026-11-17 22:38:24 +07:00
dotCooCoo cce26edfa0 Merge main into fix/metafile-loss-warnings
# Conflicts:
#	Cargo.toml
2026-11-17 07:25:38 -08:00
el-j 5665114718 Save PDF: include flattener resolutions in Summary warning and Advanced section 2026-11-17 15:00:11 +01:00
BFlat b506bdc525 Merge pull request #8228 from dotCooCoo/feat/webp-lossy-quality
WebP: Lossy with a Quality setting writes a lossy WebP file
2026-11-17 11:45:05 +07:00
dotCooCoo 950d54e843 Metafile import: name pattern brushes in the unread-image warning and list the new warnings
The reader also counts pattern brushes, a pen's included, whose bitmap
it could not read, so the warning now says "image or pattern brush".
The document.open and clipboard.importEmf params text, docs/mcp.md and
the crate doc list the new warnings. A WMF test covers an unreadable
pattern brush and a DSTINVERT bit block transfer.
2026-11-16 20:42:13 -08:00
BFlat 2d393d8a8a Merge pull request #8094 from el-j/fix/pdfx-transparency-reduction-6861
Fix #6861: Automated transparency reduction for PDF/X and PDF 1.3
2026-11-17 09:45:49 +07:00
dotCooCoo 6dae0b77e5 Merge main into feat/webp-lossy-quality 2026-11-16 17:39:20 -08:00
BFlat 5232789973 Merge pull request #8076 from dotCooCoo/fix/export-screens-pdf-bleed
Export for Screens: Include Bleed keeps a PDF page's TrimBox at the artboard
2026-11-17 08:20:09 +07:00
el-j 7194204871 Address review comments: reuse clear_transparency helper and run layer normalization only without transparency 2026-11-17 01:04:57 +01:00
el-j a0edcf73c4 Merge remote-tracking branch 'upstream/main' into fix/pdfx-transparency-reduction-6861 2026-11-17 00:42:30 +01:00
dotCooCoo 2f7e60dd54 WebP: Lossy with a Quality setting writes a lossy WebP file
WebP Options has a Compression menu (Lossless, Lossy) and a Quality
slider from 0 to 100 that is enabled for Lossy. document.export,
document.serialize and Export for Screens take lossless: false with
quality (default 90) and write a VP8 file, with an ALPH chunk that keeps
the alpha exactly when some pixels are not opaque. Lossless stays the
default. A WebP quality above 100, or one that is not a whole number,
is refused with an error.

The encoder is the one craft-image-codecs already provides; no
dependency changes. The note that lossy WebP isn't available, its
catalog rows and the format text that described it are removed.
2026-11-16 12:30:56 -08:00
BFlat 5190f99c6c Merge pull request #8173 from dotCooCoo/fix/editing-data-fallback-says-why
.ai import: a refused PDF part's error says why the editing data couldn't be read
2026-11-17 02:50:01 +07:00
dotCooCoo 3dedd7ca56 Merge main into fix/symbol-lookup-index 2026-11-16 10:57:10 -08:00
dotCooCoo f5f22bd6be Export for Screens: a saved PDF preset row with no bleed and one asking for the document's write one file
Under Include Bleed, a PDF row that sets no bleed now keeps the bleed values a saved PDF preset writes out and turns on useDocument, instead of replacing the whole bleed object. Its file key then matches a row of the same preset that asks for the document's bleed, so the two rows write one PDF.
2026-11-16 09:18:23 -08:00
dotCooCoo 1143546a0a Symbols: keep per-object measuring in the export walks; live walks and SVG import use the index
The export walks for type and fonts and the artboard crop shared one
SymbolBoxes for every object. A SymbolBoxes also holds measuring budgets
(effect reaches, 9-slice placements), so in a large document objects late
in a walk could be measured by estimates where main measured them exactly.
SymbolBoxes::unmeasured makes new boxes that share the name index, and each
object is measured in boxes of its own again.

- The live-object walk (render/src/live.rs) finds symbols through the
  frame's SymbolBoxes.
- SVG export's filter regions measure each object in unmeasured boxes, and
  the region boxes share the writer's index.
- SVG import keeps each imported symbol's index, so a symbol whose art
  holds instances no longer scans or indexes the list again.
- Object › Rasterize's clipping mask is left as it is on main, with
  drawn_outline_with removed.
- The symbol-read-count feature of vectorcraft-doc gives other crates'
  tests vectorcraft_doc::symbols_read. New tests check that a frame, an SVG
  export, a PDF export, the type walk and the artboard crop read the symbol
  list once among 2,000 symbols and 300 instances with drop shadows.
2026-11-16 09:07:50 -08:00
dotCooCoo 842f81d76a Merge main into fix/export-screens-pdf-bleed 2026-11-16 08:30:35 -08:00
dotCooCoo 139f881f81 .ai import: a refused PDF part's error says why the editing data couldn't be read
When the import refuses a file's PDF part and its editing data can't be
read either, the error named only the PDF part. It now adds "its editing
data couldn't be read either (<why>)", as layers already do
(crates/eps/src/import.rs). The reasons come from the editing data
reader (a size limit, damaged compression) and from the private data
streams (larger than 256 MB, another filter or decode parameters,
damaged zlib data). A file without editing data, and an open with pages
picked, layers off or the editing data off, keep the PDF part's error.

Part of #4366.
2026-11-16 07:56:57 -08:00
dotCooCoo 52b4b03920 Symbols: render and SVG/PDF export find each instance's symbol in one index
Drawing or exporting a symbol instance looked its symbol up by scanning
the document's symbol list, so a document with many instances and many
symbols spent most of a frame or an export on name comparisons. The
renderer, the SVG and PDF writers and the export walks now find symbols
through SymbolBoxes::symbol, which builds the name index once per frame,
export or walk and returns the first symbol of a name as before.

- Renderer: plain instances, inline graphics, instances with object
  effects (their art and the symbol budget) and the effect bounds.
- SVG export: instance art, symbol defs and their reuse check, and the
  paint reach of filter regions.
- PDF export: instance art, inline graphics and the brush search of
  knockout masks.
- Export warnings and artboard crops measured what each object paints
  with new symbol boxes per object, which built the name index again for
  every instance. painted_bounds_with and drawn_outline_with take the
  boxes once; Object › Rasterize's clipping mask uses them too.
2026-11-16 07:24:45 -08:00
dotCooCoo 70fdab8445 Export for Screens: Single file PDFs are refused for assets, layers and each object
With `pdfs: "single"` and several assets, layers or selected objects
(`selection: "each"`), document.exportForScreens wrote one PDF named
after the document holding only the first item's art, and every other
item's PDF was left out. Single file puts artboards on the pages of one
PDF; each asset, layer or object is cut out of the document with its own
art, so the export now refuses that combination before it writes any
file, and the Example line refuses it too. `pdfs: "multiple"` still
writes a PDF of each item, and `selection: "one"` writes one PDF either
way.

Docs: params text, docs/mcp.md, docs/target-app-parity.md.
2026-11-16 05:50:00 -08:00
el-j 3f9c5a17a3 Address review comments: recursive container check and render assertions 2026-11-16 11:20:30 +01:00
el-j 9b80bb7807 Automated transparency reduction for PDF/X and PDF 1.3 (#6861) 2026-11-16 10:58:05 +01:00
dotCooCoo b36400f236 Export for Screens: rows that take the top-level antiAlias are one file when their options match
A format row's file key was made before the top-level `antiAlias` was added to
its options, so a PDF row that sets no bleed and one that asks for the
document's bleed wrote two identical files under Include Bleed. The key is
now made again after the merge.
2026-11-16 00:54:04 -08:00
dotCooCoo 6eb973f8dd Export for Screens: Include Bleed keeps a PDF page's TrimBox at the artboard
With Include Bleed, every artboard was grown by the document's bleed and
PDF rows were written from the grown artboard. A row that used the
document's bleed then put the bleed around it a second time: a 100 pt
artboard with a 9 pt bleed wrote a 118 pt TrimBox in a 136 pt BleedBox,
and printer's marks lined up with the bleed edge instead of the trim.

PDF rows now write the artboards as they are, with the row's bleed around
each one once (PDF 32000-1:2008, 14.11.2: the TrimBox is the finished
page and the BleedBox holds it). The bleed is the row's own values, zero
included, else the document's bleed when the row sets none and its PDF
preset gives none or a bleed of 0. That gives a 100 pt TrimBox in a
118 pt BleedBox for one file per artboard, a single file and the Full
Document. Raster, SVG, EPS, AI and native rows still write the grown
artboard.

A PDF/X row that sets a bleed of 0 itself warns again that it leaves the
document's bleed out. A row without a bleed and a row that asks for the
document's bleed write one file.
2026-11-16 00:07:17 -08:00
FredApps 3e72836b00 Merge remote-tracking branch 'origin/main' into feat/cutover-remaining-codecs 2026-11-16 07:08:15 +01:00
BFlat 7180d01947 Merge pull request #7600 from dotCooCoo/fix/confined-exports-script-paths
MCP: confined exports refuse native files that name a linked JavaScript file outside the read roots
2026-11-16 12:55:43 +07:00
FredApps bfe5c253f4 Merge remote-tracking branch 'origin/main' into feat/cutover-remaining-codecs
# Conflicts:
#	crates/engine/src/cmd/menucmds.rs
2026-11-16 06:35:17 +01:00
FredApps 48d4afe4ec svg: SVG import decodes its images through craft-image-codecs
The decoding File › Open, Place and the renderer share moves to
vectorcraft-doc (decode.rs: decode_image, decoded_layout), and SVG
import's images read through it: the size from the header against the
allowance first, then the pixels as stored with the profile the file
embeds (a TIFF's still read by the TIFF reader).

decoded_pixels_are_those_the_image_crate_read compares PNG, GIF, WebP,
TIFF and BMP at each depth the image crate writes with its pixels, and
JPEG within two steps.
2026-11-16 06:06:34 +01:00
FredApps 3590f96ba9 engine: File › Open and Place read rasters through craft-image-codecs
The raster path tells formats with craft-image-codecs' detect, reads the
size from the header (vectorcraft-doc's header_size, the renderer's
decoded_layout, a Targa's own header) and decodes with the renderer's
decode_image, the pixels as stored, with the profile the file embeds.
The size notes Open, Place and the Links panel give, and Glass's Load
Texture, read the same way.

opened_rasters_are_the_pixels_the_image_crate_read compares BMP, TGA and
TIFF at 8 and 16 bits, gray and color, with and without alpha, with the
image crate's pixels, and PNG, JPEG, GIF and WebP stored as they are.
2026-11-16 05:45:22 +01:00
BFlat 2c4fcea4e3 Merge pull request #7995 from dotCooCoo/feat/psd-export-writes-slices
PSD export: slices are written, so an opened PSD's slices survive an export
2026-11-16 11:37:59 +07:00
BFlat bdf33b1114 Merge pull request #7839 from dotCooCoo/fix/expand-appearance-nested-instance-effects
Expand Appearance: raster effects on a symbol instance's fill or stroke expand to art, nested instances included
2026-11-16 10:35:50 +07:00
BFlat 59a43d3268 Merge pull request #7969 from dotCooCoo/fix/confined-export-screens-folder-checked
SVG: a confined Preserve Editing attachment leaves out an Export for Screens folder outside the read roots
2026-11-16 10:35:09 +07:00
dotCooCoo 69d3402f2a Merge main into feat/psd-export-writes-slices 2026-11-15 18:39:24 -08:00
dotCooCoo bf19766447 Merge main into fix/confined-exports-script-paths 2026-11-15 18:36:36 -08:00
FredApps be428f3fcf engine: keep the image size checks and depth of main through the cutover
Remove Background and Color Mask check the image's size from its header
again before decoding ("an image of W × H pixels is too large to change"),
and Crop Image's trim and Remove Background read a file that can't hold
the pixels its header declares as unreadable, as on main. The test helper
reading Remove Background's output keeps 16-bit samples.

The HEIF and JPEG XL readers and their tests go back to main's (heic-rs and
jxl-oxide): the craft-heif and craft-jxl versions failed eight of their
tests (resolution axes after a quarter turn, the container's mirror and
crop, refusing a grid of cropped tiles, 16-bit samples, the decode
allowance). Moving them stays to do.
2026-11-16 03:33:57 +01:00
BFlat 51ad60c5c7 Merge pull request #7985 from dotCooCoo/feat/psd-preserve-text-editability
PSD: Preserve Text Editability writes point type as editable type layers
2026-11-16 09:31:22 +07:00
dotCooCoo 66ce4de5db Merge main into feat/psd-export-writes-slices 2026-11-15 18:12:07 -08:00
dotCooCoo e0133a7938 Merge main into fix/confined-export-screens-folder-checked 2026-11-15 17:53:20 -08:00
dotCooCoo 893ed2c7e3 Merge main into fix/confined-exports-script-paths 2026-11-15 17:20:46 -08:00
BFlat f15f711280 Merge pull request #7870 from dotCooCoo/fix/pdf-preserve-numbers-tagged-images
PDF export: Preserve Numbers converts tagged images from their profile
2026-11-16 08:11:02 +07:00
BFlat d150b244d4 Merge pull request #7984 from dotCooCoo/fix/import-fuzz-sliced-psd-samples
Tests: fuzz PSD slices in versions 6, 7 and 8
2026-11-16 08:10:53 +07:00
FredApps d2b8ebfd95 Merge origin/main into feat/cutover-remaining-codecs 2026-11-16 01:57:11 +01:00
BFlat b7a1428325 Merge pull request #7935 from dotCooCoo/fix/psd-relink-clip
Links: relinking a clipped PSD follows the new file's clipping path
2026-11-16 06:54:59 +07:00
BFlat ad94d5dd7a Merge pull request #7967 from dotCooCoo/fix/svg-artboard-export-keeps-brushed-path
SVG: an artboard's SVG keeps a brushed path whose brush art reaches it
2026-11-16 06:54:29 +07:00
dotCooCoo 9597392c45 PSD export: slices are written, so an opened PSD's slices survive an export
A PSD export now writes image resource 1050 in version 6 of the PSD file
format specification's slices resource format, the form that Import
Slices reads (crates/engine/src/cmd/fileio/psdslices.rs, version_6).
Flat and layered exports both carry it.

- The user and object slices that reach into the exported artboard are
  written, clipped to it in its pixels, at least one pixel each way.
  Auto slices are left out; opening the file lays them out again.
- An object slice is written as a user slice over its object's bounds,
  and an HTML Text slice as No Image with its type's text as HTML. Name,
  type, link, target, message, alternative text, cell text and
  background color are kept; text alignment is written as the default.
- Slice IDs count from 1.
- More than 10000 slices or a text longer than 65536 characters is an
  export error, matching the reader's limits. A slice without finite
  bounds, or slices that would make the resource longer than 4 GB, is
  also an export error; the size is checked before each text is added.
2026-11-15 15:07:09 -08:00
dotCooCoo fb0a8bb52b Merge main into fix/expand-appearance-nested-instance-effects 2026-11-15 14:10:08 -08:00
dotCooCoo 846d000486 Merge main into fix/pdf-preserve-numbers-tagged-images 2026-11-15 13:58:49 -08:00
dotCooCoo 740b1e3f7e Tests: fuzz PSD slices in versions 6, 7 and 8
import_fuzz builds PSD files from scratch whose image resource 1050
holds slices in version 6 (a version 16 descriptor after the first
record) and in the version 16 descriptors of versions 7 and 8. Each
sample has one user slice, one slice that follows a layer and one
generated automatically; the first two come in as user slices.

- the_sliced_psd_samples_bring_in_their_user_slices: each sample opens
  with its two user slices and no warning, document.psdInfo counts 2,
  and an embedded place brings 2.
- sliced_psd_samples_with_huge_counts_or_cut_short_come_in_without_their_slices:
  slice counts of 10,001, 0x7fffffff and u32::MAX, data one byte
  short, and data cut inside the count bring the art in without its
  slices and with a warning.
- mutated_psd_slices_never_panic: mutated slice data, kept whole, cut
  short with the resource length rebuilt, or with the file cut in the
  resource block, never makes document.open, document.psdInfo or an
  embedded file.place report an internal error.

tests_psdslices::damaged_slices_never_panic now fails when a command
reports an internal error instead of discarding the results.
2026-11-15 13:57:26 -08:00