Commit Graph
1113 Commits
Author SHA1 Message Date
BFlat 981b2b1db3 Merge pull request #8586 from storytold/fix/type-overlay-font-race
tests: Type tool layout counts no longer race tests that add fonts
2026-11-19 01:17:56 +07:00
BFlat 16ef2053b3 Merge pull request #8562 from dotCooCoo/fix/issue-8537
Fix #8537: Dimension tool points land on preview bounds corners
2026-11-19 00:43:48 +07:00
BFlat a0bc3a7900 Merge pull request #8500 from dotCooCoo/feat/bristle-pen-cursor
Paintbrush: preview Bristle tip for rotation-capable pens
2026-11-19 00:43:00 +07:00
BFlat ca812ef78e Merge pull request #8408 from dotCooCoo/feat/type-missing-font-edit-confirm
Type: editing type set in a missing font asks to confirm first
2026-11-19 00:42:06 +07:00
BFlat b8463c946f Merge pull request #8252 from dotCooCoo/feat/polygon-side-widget
Shapes: dragging a live polygon's side widget changes its number of sides
2026-11-19 00:40:12 +07:00
bflatastic ee285c67a5 tests: Type tool layout counts no longer race tests that add fonts
The tests that count the layouts the Type tool keeps read vectorcraft_text::layout_inputs()
through its cache key. Tests in the same binary that add a font or change the hyphenation
exceptions bump it, so a count running beside one saw every frame laid out again
(type_overlays_keep_at_most_frame_layouts_max: 2051 instead of 2). Counting tests now hold a
shared test-only lock for reading and tests that change those inputs hold it for writing.
2026-11-18 23:43:02 +07:00
dotCooCoo 83bb31c9e2 Merge main into feat/type-missing-font-edit-confirm 2026-11-18 07:33:32 -08:00
dotCooCoo c609e56b87 Dimension: no preview bounds corners for guides or compound members
- A path made into a guide draws without its strokes or effects, so its
  preview bounds give no corners.
- The members of a compound path draw with the compound path's own
  appearance, so only the compound path's preview bounds give corners.
- Another path's anchor right on a preview bounds corner takes a click
  on the anchor that corner stands in for, so the point links to that
  path.
- A corner that its path cannot hold a point at, as on a stroked dot
  whose anchors all coincide, is not snapped to, so a click by the dot
  picks its anchor.
- The pointer test before measuring a path includes the right and
  bottom edges, as the 8 pixel distance test does.

Docs: docs/dimensions.md and docs/target-app-parity.md name paths made
into guides and compound path members among the art without corners.
2026-11-18 07:33:20 -08:00
dotCooCoo 5b58497e72 Merge main into fix/issue-8537 2026-11-18 07:09:23 -08:00
dotCooCoo 62c015d393 Dimension: a preview bounds corner takes only the anchor it stands for
A corner of a path's preview bounds took a Linear pick from every anchor
of its own object within 8 pixels, so the top, left, right and bottom
anchors of a small stroked circle, and the anchors of a rotated stroked
shape when zoomed out, could no longer be picked.

- The corner now takes the pick only from the holding path's anchor at
  the same corner of the object's geometric bounds. Any other anchor,
  of that object or of other art, that is nearer the pointer takes the
  point, and the nearest anchor wins a tie as the topmost.
- The path that holds a point picked on a corner is kept from the pick,
  instead of being worked out again from the point's position, so a
  point that only happens to lie on a corner links to what is under it.
  A path deleted between the clicks holds nothing.
- A corner of a compound path whose supplying member is hidden or
  locked is not snapped to.
- The hovering test checks the "anchor" label at the corner, and a new
  test covers the anchor ring right on the end of a dimension's line.

Docs: docs/dimensions.md and docs/target-app-parity.md say that only the
four corners are snapped to, by VectorCraft's own rule, not the edges of
the preview bounds, a group's own strokes or effects, or type; that a
corner point starts no construction guides; and that the dimension
measures W and H when it is drawn, since a later stroke weight change or
a scale with Scale Strokes off moves the point with the anchors.
2026-11-18 07:06:54 -08:00
dotCooCoo 153dbc89af Merge main into feat/polygon-side-widget 2026-11-18 06:13:55 -08:00
dotCooCoo a611d44b63 Merge main into feat/artboard-edge-button-tooltips 2026-11-18 05:56:53 -08:00
BFlat a9863c13af Merge pull request #8564 from Hassan1305/fix-8538-locked-guides
Lock Guides: a marquee skips guides in groups, and a group's transform leaves them in place
2026-11-18 19:33:51 +07:00
BFlat c6ced6ac64 Merge pull request #8560 from dotCooCoo/fix/pen-rubber-band-is-the-click
Pen: the rubber band after a smooth anchor is the curve a click adds
2026-11-18 18:25:13 +07:00
BFlat 91c6a702c6 Merge pull request #8535 from dotCooCoo/fix/dimension-line-level
Dimension tool: a dimension line placed beside another lands on its level
2026-11-18 18:25:01 +07:00
HassanKhan 41f7d4e06a #8538 review: drop kept guides on transform, finish the marquee rule
A transform no longer leaves locked guide paths in place: a guide in a
group moves with its group again, as on main. Keeping them put made
Align, Transform Each, the pixel-grid snap and Objects on Path measure or
place art the transform did not move. Scaling::keep_guides and its
engine wiring and test are removed.

The marquee rule now covers the rest of the selection side, while guides
are locked or hidden:
- the guide rule goes down the walk as an explicit Rules value instead
  of a thread-local guard;
- an Enclosing Lasso loop does not take a compound path for its guide
  contours;
- an enclosing marquee measures a group without its guide paths
  (Node::without_guides);
- Direct Selection's marquee takes no anchor or crossed segment of a
  guide path.

Docs: the Guides area row, its evidence entry and the M1 row describe
the marquee behaviour; status lines and revision rows say a guide in a
group still moves with it.
2026-11-18 16:15:04 +05:00
HassanKhan c6a419a097 Lock Guides: a marquee skips guides in groups, a group's transform leaves them
While guides were locked, a guide path inside a group was still touched by
a selection marquee, so the marquee selected the group and moving the
group moved the guide (#8538). Clicks already skip guides (#3074).

- hit: marquee_in_view and enclosure_candidates take skip_guides; the
  Selection, Direct Selection, Group Selection and Enclosing Lasso tools
  pass !cx.guides, and the marquee then touches no guide path at any depth.
- doc: Scaling::keep_guides leaves the guide paths among a group's,
  layer's or Intertwine group's children in place, as a ruler guide in a
  transformed layer already stays.
- engine: transforms (apply_transform), Transform Each and Align and
  Distribute set it while Lock Guides is on; a copy takes a copy of the
  guide with the copied art and leaves the original.

Fixes #8538
2026-11-18 15:24:42 +05:00
dotCooCoo 1d974067ce Fix #8537: Dimension tool points land on preview bounds corners
With Use Preview Bounds on, W and H measure a stroked path from the
outside of its stroke, while the Dimension tool's Linear points only
snapped to the path's anchors, on the stroke's centerline. A dimension
between the corners of a 12 x 6 mm rectangle with a 0.4 mm stroke then
read 11.6 x 5.6 mm.

- With Use Preview Bounds on, a Linear click within 8 pixels of a corner
  of the preview bounds of a path or compound path (strokes and effects
  included) lands on that corner instead of on that object's anchors,
  whatever the snapping options. An anchor of other art nearer the
  pointer than the corner takes the point, and a corner that is also an
  anchor takes the anchor.
- The point is held against the anchors of the path whose bounds reach
  that corner, also when the corner lies far from the path or on another
  path's segment. It moves with the path; a later change to the stroke
  weight does not move it.
- A press on such a corner picks it when the pointer moves a few pixels
  before the release, as on an anchor.
- Hovering by such a corner shows the anchor ring. The ring now also
  shows when the pointer is exactly on the point a pick lands on, which
  it did not for the end of a dimension's line.

Docs: docs/dimensions.md, docs/target-app-parity.md.
2026-11-18 01:51:42 -08:00
dotCooCoo 18a7f7b84b Dimension tool: a dimension of the same points lines up too
The level a new dimension line lands on now comes from the dimension
lines in the document before the dimension's first preview, so its own
preview is never a level. A dimension drawn earlier between the same two
points now acts as a level as well; before, every dimension of those
points was skipped.

- Of two lines on one level, a line the pointer lies across wins over a
  line whose end is nearer the pointer.
- A dropped press while placing removes the level guide with the
  preview.
- The reach uses the Smart Guides snapping tolerance helper.
- docs/dimensions.md says the rule applies to a dimension anywhere in
  the document.
- The tests are split by behavior, with new tests for the same points,
  pointer moves in small steps, the guide after a dropped press and
  with Alignment Guides off, and the tie-break.
2026-11-18 01:40:21 -08:00
dotCooCoo 405490a52a Pen: the rubber band after a smooth anchor is the curve a click adds
The preview segment from an anchor with an outgoing handle was drawn as a
quadratic curve through that handle, while a click appends a corner
anchor, which makes the cubic curve that leaves along the handle and
arrives without one. The segment changed shape when the anchor went
down. The rubber band now draws that cubic curve.

Part of #8296.
2026-11-18 01:39:59 -08:00
dotCooCoo 255cdcb6ca Shapes: switching tools during a widget drag puts the shape back
Switching away from the Selection tool or a shape tool during a drag of
a corner, pie or side widget left the drag's interaction open with its
preview in the document. Both tools now cancel the drag on deactivate,
as Escape does, as the Selection tool already did for a blend widget.
2026-11-18 01:21:57 -08:00
dotCooCoo 8c818cda86 Merge main into feat/artboard-edge-button-tooltips 2026-11-18 01:02:11 -08:00
dotCooCoo bec193c6bc Merge main into feat/polygon-side-widget 2026-11-17 22:44:14 -08:00
BFlat 7c6eb1b289 Merge pull request #8426 from dotCooCoo/perf/shape-builder-hatch-sweep
Shape Builder: the hover and drag hatch tests each line only against the edges spanning it
2026-11-18 13:14:34 +07:00
BFlat 0c7b92730b Merge pull request #8467 from dotCooCoo/perf/direct-blend-spine-guard
Direct Selection: the selected blend spine check returns at once when no blend is selected
2026-11-18 13:14:15 +07:00
dotCooCoo 8f8ac96b8f Merge main into feat/artboard-edge-button-tooltips 2026-11-17 22:11:30 -08:00
BFlat c5e2b4fbdd Merge pull request #8337 from dotCooCoo/fix/width-profile-brush-dimmed
Stroke: the Profile list is dimmed while the stroke's brush keeps its own size
2026-11-18 13:10:47 +07:00
BFlat ee989fe5a8 Merge pull request #8480 from dotCooCoo/feat/isolation-exit-one-level
Isolation: Exit Isolation Mode on a sublayer goes back one layer at a time
2026-11-18 13:10:37 +07:00
BFlat 62d9937c75 Merge pull request #8448 from dotCooCoo/feat/circle-tool
Shapes: the Circle tool draws a circle through two or three points
2026-11-18 13:09:51 +07:00
BFlat d9ad978f23 Merge pull request #8471 from dotCooCoo/feat/pen-info-handle-drag
Pen: the Info panel shows W, H, D and the angle while a drag pulls out a handle
2026-11-18 13:01:06 +07:00
BFlat aeaeef2f9c Merge pull request #8433 from dotCooCoo/perf/type-tool-ports-layout-cache
Type: Type tools keep the other frames' layouts between frames
2026-11-18 13:00:57 +07:00
BFlat e8b507aaee Merge pull request #7366 from dotCooCoo/fix/tool-set-option-errors
Tools: setting a tool option with a bad value returns an error
2026-11-18 12:58:18 +07:00
dotCooCoo dd99f72d25 Merge remote-tracking branch 'upstream/main' into feat/bristle-pen-cursor 2026-11-17 21:56:58 -08:00
BFlat 0ae342ea8d Merge pull request #8368 from dotCooCoo/fix/free-transform-shear-readout
Free Transform: a shear drag shows its angle next to the pointer
2026-11-18 12:56:31 +07:00
dotCooCoo dc92781181 Part of #5590: Dimension tool lines line up with dimensions already drawn
A linear dimension placed next to another one had its line exactly where
the pointer was. Chained dimensions only lined up when the pointer hit
the other line's level exactly, which at a normal zoom it rarely does.

- With Smart Guides on, a linear dimension placed with its line within
  the Smart Guides snapping tolerance of the level of a parallel line of
  a visible, unlocked linear dimension already drawn has its line on
  that level. This applies to two clicked points and to a segment
  dragged out.
- With Alignment Guides on, a guide runs along that level across both
  lines while the dimension is placed.
- Smart Guides off, a level further off, a locked dimension or one that
  is not parallel leaves the line where the pointer puts it.

Docs: docs/dimensions.md, docs/target-app-parity.md.
2026-11-17 21:33:30 -08:00
dotCooCoo 7973b6254c Keep precise-cursor regression meaningful 2026-11-17 20:53:26 -08:00
dotCooCoo 84a5ff6b3e Merge main into feat/artboard-edge-button-tooltips 2026-11-17 19:58:57 -08:00
dotCooCoo 7b8e9610c6 Merge main into feat/polygon-side-widget 2026-11-17 19:40:41 -08:00
BFlat 966ae74132 Merge pull request #8130 from dotCooCoo/feat/shape-builder-empty-feedback
Shape Builder: the status bar says why a click or drag built nothing
2026-11-18 10:25:20 +07:00
BFlat f09d81b8b3 Merge pull request #8250 from dotCooCoo/feat/pen-chosen-again-ends-path
Pen: choosing the Pen again while a path is being drawn ends that path, as Escape does
2026-11-18 10:11:37 +07:00
BFlat 19a220fae9 Merge pull request #8225 from dotCooCoo/feat/shape-widget-double-click-transform
Shapes: double-clicking a live shape's corner widget with a shape tool shows the Transform panel
2026-11-18 10:11:27 +07:00
dotCooCoo 18cf1d7a93 Hide Bristle tip after post-commit selection 2026-11-17 18:13:58 -08:00
dotCooCoo fbf6b4144b Merge main into feat/artboard-edge-button-tooltips 2026-11-17 18:11:36 -08:00
dotCooCoo 0637f14bfd Keep Bristle tip in sync with Alt release 2026-11-17 18:01:35 -08:00
dotCooCoo a5cc189172 Shapes: a Circle tool drag ends where it is let go
A release away from the last drag point now moves the circle's points to
the release position before the circle is drawn, for a drag from the
first press, from a second press and from a press on the first point. A
release within 2 screen points of the press is still a click and keeps
the point of the press.
2026-11-17 17:18:46 -08:00
dotCooCoo 375b2a23e1 Preview Bristle brush tip for rotation-capable pens 2026-11-17 17:14:05 -08:00
dotCooCoo 7083061f11 Merge main into perf/shape-builder-hatch-sweep 2026-11-17 16:21:48 -08:00
dotCooCoo da010c6598 Isolation: Exit Isolation Mode on a sublayer goes back one layer at a time
With a sublayer isolated, Exit Isolation Mode now isolates its parent layer
and selects the sublayer, so repeated use goes up one layer at a time and
leaves isolation mode from the top-level layer, as the help page describes:
https://helpx.adobe.com/illustrator/desktop/manage-objects/select-objects/isolate-objects.html
This applies to the Layers panel menu item, the isolation bar's back arrow,
the Control bar button, the canvas context menu, a double-click outside the
art and object.exitIsolation {}. Before, each of them left isolation mode in
one step.

- object.exitIsolation takes all (default false); all: true leaves
  isolation mode from a sublayer at any depth. Any other value is an error.
- Esc and the top-level layer's crumb on the isolation bar pass all: true,
  so they still leave in one step. A sublayer's crumb isolates that
  sublayer.
- A hidden or locked parent layer is not isolated; the call leaves
  isolation mode. A step up records no undo step. Groups keep their rule.
2026-11-17 15:35:46 -08:00
dotCooCoo a5b3a216df Pen: the Info panel shows W, H, D and the angle while a drag pulls out a handle
While a Pen drag past the drag threshold shapes a handle, the Info
panel shows the change in x and y, the distance and the angle from
the anchor to the handle's end: the outgoing handle of a new, added
or last anchor, and the incoming handle of the first anchor when the
drag closes the path. Shift gives the constrained handle and Space
moves the anchor with it. The readout clears on release, a dropped
press and a tool change.
2026-11-17 14:52:13 -08:00
dotCooCoo a411d285d4 Direct Selection: the selected blend spine check returns at once when no blend is selected
The checks that look only at selected blends' spines (Direct Selection's
hover, press and marquee, the Anchor Point tool's press and handles, and
the Pen's click on a spine) walked the whole document and built every
blend's spine before keeping the selected ones. They now go through
direct::selected_spines, which returns an empty list when no selected
object is a blend and otherwise keeps the same order and filter. The
check that finds a point on any blend's spine is unchanged.

On 20,000 paths and 200 blends, 500 checks with one plain path selected
took 24 us instead of 336 ms; with one blend selected the time is the
same. Results are compared against the old filter in the tests.
2026-11-17 14:27:34 -08:00