Answers the CodeRabbit review on #8653.
A glyph kept as an outline ends the open line, so the next mapped glyph
went through park_text's fallback arm into flush_text, which forgot the
lost glyphs in the middle of the fill pass. flush_text is now
finish_text plus forgetting them, and park_text calls finish_text:
starting a new line draws nothing else, so it is never a boundary.
Docs: the M4 roadmap row names this follow-up.
Since #8549 the glyphs of lines finished past MAX_PARKED were kept
until the next stroke and, past 4096 of them, matched every stroke.
A `2 Tr` word after a dense page of filled-only type then came in as a
filled object and a stroked one.
- flush_text forgets them: nothing is drawn between an operator's fill
pass and its stroke pass. end_text keeps them, since it also runs
mid fill pass for a glyph kept as an outline.
- LostFills keeps the first 4096 glyphs and matches only those; there
is no overflow that matches every stroke.
- replayed counts the lines its `left` check looks at toward
MAX_REPLAY_WORK.
* SVG export: preserve document unit in viewBox and width/height (#864)
When exporting SVG documents with physical units (mm, cm, in, pc), emit
the physical unit suffix on the root <svg width=... height=...>
attributes while keeping viewBox numbers and inner coordinates in 1:1 points
per SVG 1.1 coords §7.10. This avoids the 75% scaling mismatch when opening
drawings in external tools such as Inkscape or LightBurn, and preserves
the document unit setting across save/open round trips. Unitless documents
(points, pixels) continue to emit unitless dimensions.
Tested via export_physical_units_writes_unit_suffixes in vectorcraft-svg
and full round-trip svg_round_trip_preserves_document_units in vectorcraft-engine.
Ran cargo xtask ci (fmt, clippy, tests, xtask gates).
* SVG export: preserve nonzero width and viewBox on extreme small dimensions
Conflicts in docs only (status lines, changelog rows and table rows):
main's entries and this branch's are both kept, each once.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The G5 Missing entry, the Strokes, brushes, width profiles rows, the
Bundled content row, the M10 milestone and the ui-parity Brush
Libraries row now list twelve built-in brush libraries and name Stipple.
A transform no longer leaves locked guide paths in place: a guide in a
group moves with its group again, as on main. Keeping them put made
Align, Transform Each, the pixel-grid snap and Objects on Path measure or
place art the transform did not move. Scaling::keep_guides and its
engine wiring and test are removed.
The marquee rule now covers the rest of the selection side, while guides
are locked or hidden:
- the guide rule goes down the walk as an explicit Rules value instead
of a thread-local guard;
- an Enclosing Lasso loop does not take a compound path for its guide
contours;
- an enclosing marquee measures a group without its guide paths
(Node::without_guides);
- Direct Selection's marquee takes no anchor or crossed segment of a
guide path.
Docs: the Guides area row, its evidence entry and the M1 row describe
the marquee behaviour; status lines and revision rows say a guide in a
group still moves with it.
Answers the fourth CodeRabbit review on #8549.
When a fill pass finishes lines beyond MAX_PARKED, their unstroked
glyphs are recorded (bounded at 4096). The first stroke after that
which could have gone over one of them ends the stroke pass, so a TJ
over more than 65 lines that comes back to where it began stays a
filled object and a stroked one for each part, as documented. Any
other first stroke drops the record, so type after an overflowing TJ,
filled only or not, is matched as before.
MAX_HELD's doc now says that one operator filling the same run of more
than 4096 glyphs twice at the same places is matched as well as it can
be: the reader tells no operator's start.
Answers the third CodeRabbit review on #8549.
- stroke_last no longer restyles the glyph drawn last once a boundary
(end_fills) closed it: a stroke after an ActualText span no longer
strokes its replacement text. A glyph stroked again where it was just
drawn still stays one object.
- Past MAX_HELD, the held strokes go over the last run of consecutive
fills they match with room for all of them, not the first, so a long
stroke pass no longer takes the same glyphs an earlier operator
filled at the same place.
- Docs: the limit is 64 kept-back lines plus the open one, so a TJ over
up to 65 lines stays filled and stroked.
While guides were locked, a guide path inside a group was still touched by
a selection marquee, so the marquee selected the group and moving the
group moved the guide (#8538). Clicks already skip guides (#3074).
- hit: marquee_in_view and enclosure_candidates take skip_guides; the
Selection, Direct Selection, Group Selection and Enclosing Lasso tools
pass !cx.guides, and the marquee then touches no guide path at any depth.
- doc: Scaling::keep_guides leaves the guide paths among a group's,
layer's or Intertwine group's children in place, as a ruler guide in a
transformed layer already stays.
- engine: transforms (apply_transform), Transform Each and Align and
Distribute set it while Lock Guides is on; a copy takes a copy of the
guide with the copied art and leaves the original.
Fixes#8538