The Offset Path case of painted_clipping_type_survives_enclosing_geometry_effect now also checks
the clip region against the type's own outline grown by 1 pt, so a clip region that skips the
effect fails the test even when the fill and stroke art skip it too.
Free Distort and the Warp effects move a group's placed gradient from the group's bounds before the effect to its bounds after it. A clip group whose clipping type strokes is measured as that clip group, so the stroke outside the clip no longer changes how its gradient follows the effect.
On a path or compound path, a Transform effect with copies listed after
the object's own Rasterize effect now places the one image Rasterize
makes of the art before it on the original and on each copy: copy k
through the effect's map applied k times, with its pixel grid and its
room around the art, the last copy lowest and the original on top.
Before, the Transform effect copied the art and Rasterize made one image
of all the copies on a grid square to the page.
The image is made once for every placement, also when a shadow or glow
is listed between the Rasterize and Transform effects. The canvas, the
object's bounds, Expand Appearance and PDF export use the same
placements; Expand Appearance and PDF export make a group of images that
share the one image's pixels. Copies stop where the copied art stops,
and a copy scaled to nothing is left out.
Type is drawn as its outlines, so each copy that a fill's or stroke's own
Transform effect makes of type carries the raster effects listed before
it, as a path's copies do. A test checks this for the fill's first
Transform effect and for one listed after a Transform effect with
Transform Patterns on, drawn, expanded and baked.
The progress doc now lists type as covered, states when a later copying
Transform effect does not carry the raster effects before it, drops the
fill or stroke case from the older entry's limitation, and puts the
Rasterize entry back on its own line.
- A group or layer with a fill or stroke of its own and only raster effects
before its copying Transform effect now applies its members' own effects
before the copies are made, as one without a fill or stroke does.
- A layer's copies are made about the bounds of its visible members, as the
layer measures them, rather than about its hidden members as well.
- When an earlier copying Transform effect of the group or layer made copies
that carry its raster effects, each copy of a later one moves, turns,
reflects and scales those raster effects with it.
A group's or layer's own Drop Shadow, glow, blur, Feather or pixel filter
listed before its last Transform effect that makes copies now goes with each
copy, made of all the copy's members together. Its sizes scale by the copy's
mean scale, and a Drop Shadow's offset turns, reflects and scales with the
copy. Before, one shadow was drawn around all the copies at the group's own
distances. A raster effect listed after the Transform effect still paints
once around all the copies, and the members' own raster effects stay as a
copying Transform effect leaves them.
Each copy is a group holding the members. A clip group's copies each clip,
a layer's art stays a layer, and its ruler guides stay once above the
copies. Compound shapes, Shaper groups and groups with Pathfinder, 3D, Crop
Marks, Vector Halftone, a painting plug-in, a perspective or fills and
strokes with geometry effects keep the earlier behavior.
The canvas, the object's bounds, baking for export (type in such a group is
no longer kept as type under one shadow), export with raster effects as
images and Expand Appearance draw the same copies. Expand Appearance gives
the copies ids of their own, expanding a copy with a random Transform effect
before its ids change so it keeps the canvas's random values.
A Transform effect that makes copies and is listed after a fill's or
stroke's first Transform effect with Transform Patterns or Scale Strokes
& Effects on made its copies without following the raster effects listed
before it, so a Drop Shadow kept its offset on every copy. Each copy now
takes the raster effects before it turned, reflected and scaled with that
copy's map, as the first Transform effect's copies do. Without either
option of its own, it does so only when no raster effect is listed after
it.
A Drop Shadow, glow, blur, Feather or pixel filter listed before a fill's
or stroke's own Transform effect that makes copies is now drawn by each
copy from that copy's fill area or stroke outline, with its sizes scaled
by the copy's mean scale and a Drop Shadow's offset turned, reflected and
scaled with the copy. With Transform Patterns or Scale Strokes & Effects
on, the shadow is no longer scaled a second time. A raster effect listed
after the Transform effect paints once around all the copies, and with
either option on it stays on each copy as before.
Each copy of a path's own Transform effect that makes copies now carries
the raster effects of its fills and strokes the same way, for a single
fill, a single stroke, or several.
Before, one shadow was drawn around all the copies at the fill's or
stroke's own distances. The canvas, the object's bounds, export and
Expand Appearance draw the same copies, and copies that stop at the
effect budget each keep their effects. A fill or stroke whose effects
list raster effects before a Transform effect that makes copies and
another raster effect after it and before a later Transform effect that
makes copies or moves at random (for example Drop Shadow, Transform,
Drop Shadow, Transform) still paints its raster effects around all of
the copies.
A Drop Shadow, glow, blur, Feather or pixel filter listed before a
Transform effect that makes copies of type, an image or a symbol instance
was drawn once under all the copies, at the object's own distances. Each
copy now carries those raster effects, as paths' copies do: scaled by the
copy's mean scale, with a Drop Shadow's offset turned, reflected and
scaled with the copy. Raster effects listed after the Transform effect
still paint once around all the copies.
Type is copied as its outlines, an image in its frame and a symbol
instance as its symbol's art. The canvas, the object's cull bounds,
export and Expand Appearance use the same art; type whose Transform
effect only moves its copies is exported as its outlines in that case.
Type and symbol instances in perspective, objects whose fill or stroke
has geometry effects of its own, and objects with a linked opacity mask
keep one set of raster effects.
Conflicts resolved in favour of main/#7664 in the 13 source files both touched
(doc/cmyk.rs, metafile/dib.rs, pdf images, svg import/files.rs, render paint and
encode tests, trace, engine load.rs), keeping main's newer TIFF/CMYK, DIB and PDF
image fixes. vectorcraft-doc stays on main's version until its CMYK reader moves
to craft-tiff. The image crate keeps its format features, and usvg, tiff,
zune-jpeg, hayro-ccitt and jpeg-encoder stay for the readers not yet moved.
Codec crates pinned to craft-libs d6cd7836d364177661b0ae17f48a0805e83a5f32.
Also fixes the compile errors CodeRabbit flagged (jp2read DecodeOptions,
filters.rs use-after-move) and the encode() arity at d6cd7836d.
When a group with a geometry effect holds a clip group whose clipping
type paints strokes, the clip group becomes a group of a clip group and
the type's stroke art. The clipping path in it is now the region the
live clip uses, so the geometry effects of the type's fills and strokes
reshape what they paint and leave the clip as it is. The group's own
fills and strokes, their unplaced gradients and the box its geometry
effects scale around count that group as its clip group, so a stroke
moved outside the clip no longer widens them.
A fill or stroke of a painted clipping path whose Transform effect scales
strokes or moves patterns is now drawn through its art, as an export bakes
such a path, so a 2 pt stroke scaled to 200 % paints at 4 pt.
The HPGL writer closes the stroke pieces of a clipping path whose fill
paints, as it closes the outline of any filled path.
When a clip group with a geometry effect is clipped by type that paints
strokes, its own unplaced gradients are pinned to the box of the clip
group inside the result, the same node its fills and strokes paint in,
instead of the box of the group around it that also holds the strokes.
A clipping path that paints a fill or stroke kept the geometry effects of
those fills and strokes live, so a geometry effect on the clip group or on
a group around it reshaped the path first and the fill's or stroke's
effect applied after it, on the canvas and in export alike. Unpainted
clipping paths already applied them first.
The clipping path now becomes one path per fill and stroke with those
effects applied, as an unpainted one does, in a group marked as such
pieces (`NodeExtras::clip_pieces`, saved with the document). `clip_paint`
paints that group's fill pieces behind the clipped art and its stroke
pieces over it, as the path paints its fills and strokes, also after an
effect around it turns a piece into a compound path or puts it in a group.
The clip group's visual bounds take in the stroke pieces' width, and HP-GL
export draws the clipping path once, in its stroke pieces.
An export of a painted clipping path with such effects in a clip group
without effects of its own also keeps its fill and stroke now, where the
baked pieces painted nothing.
On a path or compound path, a Transform effect listed after the
object's own Rasterize effect now moves the image that Rasterize makes.
The image is made of the art before the Transform effect, at the
Rasterize effect's resolution and with its room around the art, and the
Transform effect scales, turns, reflects and moves it. Before, the
Transform effect moved the art and Rasterize made a new image of the
moved art on a grid square to the page.
- effects: rasterize_stage finds the Transform effects that move the
last Rasterize image; stage_map composes their maps about the
reference point of the art each one takes.
- render: the canvas draws the node without those Transform effects
through the map, and its drawn and painted bounds follow the map. A
map that scales the image to nothing draws nothing.
- engine: Expand Appearance places Object > Rasterize's image of the
art through the map, and PDF export makes those images before it
bakes the geometry effects.
A Transform effect that makes copies or moves at random, one followed
by another kind of effect, a fill's or stroke's own Rasterize effect,
and Rasterize on type, images, symbol instances and groups keep the
earlier behavior.
A member's light or stroke direction under groups that each have a
Transform effect is now rounded once for the turn of all of them. The
inner group's members are evaluated first, so each group rounded the
direction again: two 30-degree turns of a top light gave Left instead
of Top Left. While a group's members are evaluated, the group's own
Transform effects are counted among those the members still go through.
A clip group whose clipping type strokes becomes a group of a clip group
and the strokes when it is evaluated or exported. That group took the clip
group's Knockout Group setting, so the strokes knocked out the clipped art
under them. The inner clip group now takes the setting and the group around
it is set Off, so the clipped art knocks out as before and the strokes
paint over it, as the canvas draws the live clip group. A neutral clip
group stays neutral on both.
Create Outlines, Object > Expand and geometry effects scaled a character
stroke on unevenly scaled, sheared or flattened type by the transform's
mean scale, so a stroke scaled 300% across came out about 1.7 times as
thick everywhere, while the canvas strokes the glyphs in text space and
then transforms them.
Under such a transform each run's stroke now becomes a path filled with
the stroke's paint: the area the stroke paints around the glyphs in text
space (dashes, caps, joins and inside or outside alignment), transformed
with them. Moved, rotated, reflected and uniformly scaled type keeps a
live stroke with its weight and dashes scaled. object.expand.info reports
a gradient on such a filled stroke.
A Transform effect listed after Underpainting, Rough Pastels, Conte
Crayon, Bas Relief, Plaster or Texturizer now turns and reflects their
light direction, and after Sprayed Strokes or Graphic Pen their stroke
direction. Each is set to the nearest choice of its menu, the one
clockwise of it at a tie. Color Halftone's four screen angles turn and
reflect with the art. Stacked Transform effects, and an object's
Transform effect over a fill's own, round the direction once. A zero
scale leaves the direction as it is.
The canvas, export and Expand Appearance use the same values. Filters
with fixed stroke or pattern axes keep them.
When a geometry effect on a group outlined type used as a clipping path,
the type became a plain outline group, which paints nothing as a clipping
path, so its fill and stroke were missing from the canvas and from SVG and
PDF export.
The clip group now becomes the type's outlines as the clipping path, the
type's fills as art behind the clipped members inside the clip and, when
it strokes, its strokes as art over the clip group, outside the clip. The
group's effect reshapes all three alike. Unpainted clipping type still
gives only the clip. A clip group with fills of its own keeps painting
them inside the clip.
A clip group with a fill or stroke of its own and no geometry effect is
baked through bake_pieces, which baked the clipping path like any other
member instead of applying the geometry effects in it as the canvas clips
by it. A compound clipping path whose member has a Transform effect with
copies then baked into nested compound paths, and SVG, PDF and the other
exports dropped the moved member and its copies from the clip.
bake_pieces now applies with_clip_effects_applied to the clipping path
first, as the plain clip group route already does. Clipping type keeps
its own handling.
A path's Drop Shadow, glow, blur, Feather or pixel filter listed before a
Transform effect that makes copies was drawn once under all the copies, at
the object's own distances. Each copy now carries those raster effects,
scaled by the copy's mean scale, with a Drop Shadow's offset turned,
reflected and scaled with the copy. Raster effects listed after the
Transform effect still paint once around all the copies. Copies that stop
at the effect budget keep their effects, and a Transform effect without
copies draws as before.
The canvas, the object's bounds, export, baking and Expand Appearance use
the same art. Type, images, symbol instances, groups, a fill's or stroke's
own copying Transform effect, and paths with Rasterize or an SVG filter
before the copying effect keep one set of raster effects.
Three cases still clipped differently from what the clipping path draws:
- A clip group with an appearance of its own (a Drop Shadow, a geometry
effect) was measured for culling by its plain clipping path, so a view
showing only the part of the clip that an effect moved drew nothing.
The renderer now grows that measure by the clip region in this case
too.
- The geometry effects on the fills and strokes of an unpainted clipping
path applied after the effects of a group around it. They now apply
first, as for other members. A clipping path that paints keeps them
live, so its fill and stroke still draw.
- Export baked a compound clipping path with an effect of its own from
its raw paths, dropping the effects on those paths. It now bakes the
clipping path as the canvas clips by it, and the pieces it bakes into
get ids of their own.
A clipping path with Roughen, Transform or another effect that reshapes
a path drew its own fill and stroke reshaped, but the canvas and raster
export still clipped the art by the plain path. SVG and PDF export bake
the effect into the path before writing the clip path, so the screen
and a saved SVG showed different art.
effects::clip_outline now applies the live geometry effects in the
clipping path before taking its region: the path's or compound path's
own effects, the effects of its fills and strokes (the region is then
the union of the paths they give, as an export bakes them), the effects
of a compound path's paths, of a group's visible members and of a
nested clip group's clipping path, shown or hidden, and a group's own
effects as an export evaluates them. Raster effects such as Gaussian
Blur leave the region as it is. The renderer, the engine commands that
measure a clip region (flatten, arrowheads, cutting) and the writers use
it; the writers receive the baked document, so their output for a path
with effects does not change.
The renderer measures a clip group by the region its clipping path's
effects give it, so a view or tile that shows only the moved part of
the clip still draws the clipped art, and it drops cached clip regions
that hold a plug-in effect when plug-ins change.
Two rules change in every export as well as on the canvas:
- When the clip group, or a group around it, has a geometry effect of
its own, the clipping path's effects apply first and its gradients
move with them. #7114 left the clipping path's effects live under the
group's effect, so they applied after it.
- Type used as a clipping path keeps its own effects when a group's
effect outlines it. #2073 and #2290 outlined it without them, to
match the plain clip the canvas drew.
A 3D effect on a fill or stroke worked on copies of the object's fills
and strokes, and the copies were looked up among the object's items by
identity, so a live-effect plug-in before that 3D effect was given
`_context.item` "object" and a deferred stage there was listed with no
item. The drawn art, the 3D meshes and Expand as Wireframes now pass the
original item, so the plug-in is given `{"fill": i}` or `{"stroke": i}`
as docs/plugins.md describes. The paints of a type's first run still have
no item.
A Transform effect whose result would pass the geometry budget (2 million
anchors or 8 million lines drawn) is left out and the art stays where it
was, but the raster effects listed before it still scaled and moved with
it: before a Transform effect that scales the art 1000 times, a Drop
Shadow's offset grew 1000 times and its blur went to the 1000 pt limit
around art that had not moved, and Expand kept those values.
The geometry pass now notes each Transform effect that moves the art once
and that it leaves out, in the Carry it already returns, and
Carry::hide_skipped hides those effects in the list the raster effects
are read from. The canvas (a path's own effects and its fills' and
strokes'), its bounds, bake (SVG and PDF export), shape art, Expand,
Expand Appearance and Outline Stroke use it, and a fill's Transform
effect inside a piece no longer scales the effects before it when the
budget leaves it out. The budget itself is unchanged.
A path drawn as its own art inside a group whose geometry effects run
after its members' own read its object effects whole. The reshaping pass
now notes a Transform effect that no path in the art took past the
budget, and the member's art hides it before its raster effects are read.
The bounds skip the extra geometry pass when no raster effect could
follow a Transform effect, and painted_reach runs it once for both
measurements.
When a painted live effect on a fill or stroke returned several fills or
strokes, the next effect in that stack ran only on the first of them and
the others took its geometry. A later live-effect plug-in, and a later
geometry effect on strokes, now runs once on each of them in paint order,
given the piece's fills and strokes and its own `_context.item`. Each
run's pieces replace only that fill or stroke; a run that fails, is
refused, is deferred or would pass the effects' budget leaves only its own
fill or stroke as it was. Fills and strokes that keep the same path stay
on one path, and a deferred run is listed at the source fill's or
stroke's place.
The results that are kept share the effects' budget, and each run's
result is kept or left out whole. They are first placed with all the
room the art leaves, and placed again with room kept for the piece's path
when a fill or stroke left on that path finds no room. A result on the
path before it costs nothing and is taken whatever room is left; a
built-in effect that finds no room is built again with all the room the
art leaves, and that result is taken only when it is on the path before
it. A plug-in result is held only while it is placed: one that does not
fit, or that moves onto the path before it, is let go at once, so the
results held at one time stay within the budget however many fills and
strokes the piece has. A result kept in the first placing is reused in
the second without running the plug-in again. A painted piece's share of
the budget is counted once at each later effect.
A group's or layer's geometry effects now run after its members' own:
the geometry effects of each visible path and compound path in it and
of their fills and strokes, and a nested group's geometry and
Pathfinder effects, are applied first, at any depth, and the group's
effects reshape the result. A symbol instance's geometry effects run
after those of its symbol's members in the same way. Before, the group
reshaped the members' outlines and their own effects ran afterwards:
a 100 pt square with its own 10 pt Offset Path in a group with a 50%
Transform drew 70 pt wide, and it now draws 60 pt wide. Existing
documents with such groups draw differently.
The canvas, export (including groups that keep their type), Expand
Appearance and the art that Pathfinder operations and compound shapes
take from such a group use the same order. The reply of
effect.expandAppearance names such a group and no longer names the
members whose effects the group's art already holds.
The renderer now drops the art it keeps for a group when a plug-in is
installed or removed and a member of the group has a plug-in effect.
Docs: docs/target-app-parity.md. Not yet: the own geometry effects of
images, symbol instances, paths with a linked opacity mask or a 3D
effect, and nested groups with a 3D effect in a group still run after
the group's.